engines/dasync: add explaining comments about AES-128-CBC-HMAC-SHA1
authorDr. Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
Fri, 22 Feb 2019 12:08:54 +0000 (13:08 +0100)
committerDr. Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
Fri, 22 Feb 2019 12:31:49 +0000 (13:31 +0100)
commita4a0a1eb43cfccd128d085932a567e0482fbfe47
tree19b255f5629a6d4a976a16dbb786d174916a07ee
parentf7c5b12034f1971f30a4a73fbf3e04f0b0c0766f
engines/dasync: add explaining comments about AES-128-CBC-HMAC-SHA1

Fixes #7950

It was reported that there might be a null pointer dereference in the
implementation of the dasync_aes_128_cbc_hmac_sha1() cipher, because
EVP_aes_128_cbc_hmac_sha1() can return a null pointer if AES-NI is
not available. It took some analysis to find out that this is not
an issue in practice, and these comments explain the reason to comfort
further NPD hunters.

Detected by GitHub user @wurongxin1987 using the Sourcebrella Pinpoint
static analyzer.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/8305)
engines/e_dasync.c