Fix a race condition in ciphers handling
authorMatt Caswell <matt@openssl.org>
Fri, 14 Jun 2019 13:06:55 +0000 (14:06 +0100)
committerMatt Caswell <matt@openssl.org>
Tue, 18 Jun 2019 13:26:16 +0000 (14:26 +0100)
commit860fed97aafd30948a05ae8e90ec3fd43324866a
tree154423521592c519f1249af75016b08ec8923144
parent2813852d7111ad0a49a963bdc49d944d453e52e7
Fix a race condition in ciphers handling

Similarly to the previous commit we were storing the peer offered list
of ciphers in the session. In practice there is no need for this
information to be avilable from one resumption to the next since this
list is specific to a particular handshake. Since the session object is
supposed to be immutable we should not be updating it once we have decided
to resume. The solution is to remove the session list out of the session
object.

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from https://github.com/openssl/openssl/pull/9176)
ssl/ssl_lib.c
ssl/ssl_locl.h
ssl/ssl_sess.c
ssl/statem/statem_srvr.c