When the underlying BIO_write() fails to send a datagram, we leave the
authorLutz Jänicke <jaenicke@openssl.org>
Fri, 10 Oct 2008 10:41:35 +0000 (10:41 +0000)
committerLutz Jänicke <jaenicke@openssl.org>
Fri, 10 Oct 2008 10:41:35 +0000 (10:41 +0000)
commit7e7af0bc516fffbb28b0eb659bfd896a2c051073
tree8f366ee45cb4027f64d0df5c20654318c7c58a36
parent87d3a0cd9006f67fed0d3335d8b1c5ab94a26f8f
When the underlying BIO_write() fails to send a datagram, we leave the
offending record queued as 'pending'. The DTLS code doesn't expect this,
and we end up hitting an OPENSSL_assert() in do_dtls1_write().

The simple fix is just _not_ to leave it queued. In DTLS, dropping
packets is perfectly acceptable -- and even preferable. If we wanted a
service with retries and guaranteed delivery, we'd be using TCP.
PR: #1703
Submitted by: David Woodhouse <dwmw2@infradead.org>
ssl/s3_pkt.c