[PR3597] Advance to the next state variant when reusing messages.
authorRichard Levitte <levitte@openssl.org>
Fri, 28 Nov 2014 19:40:10 +0000 (20:40 +0100)
committerRichard Levitte <levitte@openssl.org>
Fri, 28 Nov 2014 19:47:41 +0000 (20:47 +0100)
commit7a04b854d655785798d471df25ffd5036f3cc46b
tree808035b82fdd8636b6ebc1773d9f491377d7611f
parent8123d158ab6f0a6a468748c133e33c2063ff36b5
[PR3597] Advance to the next state variant when reusing messages.

Previously, state variant was not advanced, which resulted in state
being stuck in the st1 variant (usually "_A").

This broke certificate callback retry logic when accepting connections
that were using SSLv2 ClientHello (hence reusing the message), because
their state never advanced to SSL3_ST_SR_CLNT_HELLO_C variant required
for the retry code path.

Reported by Yichun Zhang (agentzh).

Signed-off-by: Piotr Sikora <piotr@cloudflare.com>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
ssl/s3_both.c