twl4030: fix potential power supply handling issues
authorGrazvydas Ignotas <notasas@gmail.com>
Mon, 19 Mar 2012 03:37:40 +0000 (03:37 +0000)
committerAlbert ARIBAUD <albert.u.boot@aribaud.net>
Tue, 27 Mar 2012 20:05:29 +0000 (22:05 +0200)
commit61712bcad48d2874fbd9e2dc90255f0885b716b0
treed447331637e43055e5e0e5647edfacc62c1c17bd
parentf7dad8f12164d08577b42492ae8d350a002e9d99
twl4030: fix potential power supply handling issues

twl4030_pmrecv_vsel_cfg currently first sets up device group (effectively
enabling the supply), and only then sets vsel (selects voltage). This could
lead to wrong voltage for a short time, or even long time if second i2c
write fails.

Fix this by writing vsel first and device group after that. Also
introduce error checking to not enable the supply if we failed to set
the voltage, and start logging errors as power supply problems are
usually important.

Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
drivers/power/twl4030.c