Fix return code for truncated DTLS fragment.
authorAdam Langley <agl@imperialviolet.org>
Fri, 6 Jun 2014 21:44:20 +0000 (14:44 -0700)
committerMatt Caswell <matt@openssl.org>
Wed, 6 Aug 2014 20:30:39 +0000 (21:30 +0100)
commit60be11577154d7cb96b8936532112d7cf408a1a8
tree5f3d21c00ddd8c525c82f63507b5228e4de5cb81
parent5ee775a4a589419855426d91fdf68e8c880e91b8
Fix return code for truncated DTLS fragment.

Previously, a truncated DTLS fragment in
|dtls1_process_out_of_seq_message| would cause *ok to be cleared, but
the return value would still be the number of bytes read. This would
cause |dtls1_get_message| not to consider it an error and it would
continue processing as normal until the calling function noticed that
*ok was zero.

I can't see an exploit here because |dtls1_get_message| uses
|s->init_num| as the length, which will always be zero from what I can
see.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Emilia Käsper <emilia@openssl.org>
ssl/d1_both.c