Fix ssl_get_prev_session overrun
authorMatt Caswell <matt@openssl.org>
Fri, 10 Apr 2015 15:49:33 +0000 (16:49 +0100)
committerMatt Caswell <matt@openssl.org>
Tue, 14 Apr 2015 14:02:44 +0000 (15:02 +0100)
commit5d28381ae44725254e92bab9797593c6d3fa1e86
tree29dada7f44a9649209cf2b358199876fda46ea3c
parenteeda966123e96e890ad56bfcaaec82d07b36e26a
Fix ssl_get_prev_session overrun

If OpenSSL is configured with no-tlsext then ssl_get_prev_session can read
past the end of the ClientHello message if the session_id length in the
ClientHello is invalid. This should not cause any security issues since the
underlying buffer is 16k in size. It should never be possible to overrun by
that many bytes.

This is probably made redundant by the previous commit - but you can never be
too careful.

With thanks to Qinghao Tang for reporting this issue.

Reviewed-by: Rich Salz <rsalz@openssl.org>
(cherry picked from commit 5e0a80c1c9b2b06c2d203ad89778ce1b98e0b5ad)

Conflicts:
ssl/ssl_sess.c
ssl/ssl_sess.c