Add ticket length before buffering DTLS message
authorMatt Caswell <matt@openssl.org>
Thu, 5 Feb 2015 13:59:16 +0000 (13:59 +0000)
committerMatt Caswell <matt@openssl.org>
Wed, 25 Mar 2015 12:24:36 +0000 (12:24 +0000)
commit4f9fab6bd0253416eeace5a45142c7c4a83bc511
tree997ccd29bc5d53380f551c9544aa09d9368f4a88
parentd5d0a1cb1347d4a8547e78aec56c50c528186e50
Add ticket length before buffering DTLS message

In ssl3_send_new_session_ticket the message to be sent is constructed. We
skip adding the length of the session ticket initially, then call
ssl_set_handshake_header, and finally go back and add in the length of the
ticket. Unfortunately, in DTLS, ssl_set_handshake_header also has the side
effect of buffering the message for subsequent retransmission if required.
By adding the ticket length after the call to ssl_set_handshake_header the
message that is buffered is incomplete, causing an invalid message to be
sent on retransmission.

Reviewed-by: Richard Levitte <levitte@openssl.org>
ssl/s3_srvr.c