OCSP_request_add0_id() inconsistent error return
authorTodd Short <tshort@akamai.com>
Tue, 5 Jul 2016 13:59:29 +0000 (09:59 -0400)
committerRich Salz <rsalz@openssl.org>
Wed, 20 Jul 2016 05:24:57 +0000 (01:24 -0400)
commit415e7c488e09119a42be24129e38ddd43524ee06
treea3664e8a87c251ec01249fcefb692a41288d8239
parent52eede5a970fdb30c4ed6d3663e51f36bd1b1c73
OCSP_request_add0_id() inconsistent error return

There are two failure cases for OCSP_request_add_id():
1. OCSP_ONEREQ_new() failure, where |cid| is not freed
2. sk_OCSP_ONEREQ_push() failure, where |cid| is freed

This changes makes the error behavior consistent, such that |cid| is
not freed when sk_OCSP_ONEREQ_push() fails. OpenSSL only takes
ownership of |cid| when the function succeeds.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1289)
crypto/ocsp/ocsp_cl.c