Reject elliptic curve lists of odd lengths.
authorEmilia Kasper <emilia@openssl.org>
Mon, 1 Dec 2014 14:04:02 +0000 (15:04 +0100)
committerEmilia Kasper <emilia@openssl.org>
Fri, 5 Dec 2014 15:44:20 +0000 (16:44 +0100)
commit321ba85899ce7246db3791457c711ad586b6d3f8
tree2ab255f046bf4e5e02bf4adefb675b1984b0e6a1
parentfcabfc66aeade294c06259c885d4df1eab06b86c
Reject elliptic curve lists of odd lengths.

The Supported Elliptic Curves extension contains a vector of NamedCurves
of 2 bytes each, so the total length must be even. Accepting odd-length
lists was observed to lead to a non-exploitable one-byte out-of-bounds
read in the latest development branches (1.0.2 and master). Released
versions of OpenSSL are not affected.

Thanks to Felix Groebert of the Google Security Team for reporting this issue.

Reviewed-by: Matt Caswell <matt@openssl.org>
(cherry picked from commit 33d5ba862939ff8db70a9e36fc9a326fab3e8d98)
ssl/t1_lib.c