Fix many issues reported by clang-tidy (#7189)
authorLoïc Blot <nerzhul@users.noreply.github.com>
Mon, 2 Apr 2018 21:51:08 +0000 (23:51 +0200)
committerGitHub <noreply@github.com>
Mon, 2 Apr 2018 21:51:08 +0000 (23:51 +0200)
commit2481ea27ce0f423f3e6f3522539d20e1500cf572
tree73251dcbf9146d7499177f59b266d8c60b0eaae7
parente98fd934ce17a7af0b4629fc88158373303c88a0
Fix many issues reported by clang-tidy (#7189)

* Fix many issues reported by clang-tidy

We have many issues in code related to some performance to float <-> double.
Clang-tidy reported it in performance-type-promotion-in-math-fn

I fixed many of them. It's not ready for a promote to blocking

Also fix some value which should be const-ref
14 files changed:
src/chat.cpp
src/chat.h
src/mapgen/cavegen.cpp
src/mapgen/dungeongen.cpp
src/mapgen/mapgen_carpathian.cpp
src/mapgen/mapgen_fractal.cpp
src/mapgen/mapgen_v7.cpp
src/mapgen/mapgen_valleys.cpp
src/mapgen/mg_ore.cpp
src/script/lua_api/l_object.cpp
src/unittest/test_noise.cpp
src/unittest/test_random.cpp
src/unittest/test_settings.cpp
src/unittest/test_utilities.cpp