wall,crontab: use xopen_as_uid_gid()
authorRyan Mallon <rmallon@gmail.com>
Tue, 8 Oct 2013 12:53:29 +0000 (14:53 +0200)
committerDenys Vlasenko <vda.linux@googlemail.com>
Tue, 8 Oct 2013 12:53:29 +0000 (14:53 +0200)
commit1d30b3f1f66a0cd179f47082245079ef357b6a66
tree2a5eaf34ebb770e2d4d499338e6a4c82a22d3086
parent5906a5c26c392b9687d14951a6da3a5195b576be
wall,crontab: use xopen_as_uid_gid()

This fixes a narrow security race in crontab.

function                                             old     new   delta
xopen_as_uid_gid                                       -      80     +80
seteuid                                                -      64     +64
setegid                                                -      64     +64
setreuid                                               -      37     +37
xseteuid                                               -      22     +22
xsetegid                                               -      22     +22
crontab_main                                         590     577     -13
setfsuid                                              33       -     -33
setfsgid                                              33       -     -33
wall_main                                            138     102     -36
open_as_user                                         109       -    -109

   text    data     bss     dec     hex filename
 893539     497    7568  901604   dc1e4 busybox_old
 893618     497    7568  901683   dc233 busybox_unstripped

Signed-off-by: Ryan Mallon <rmallon@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
miscutils/crontab.c
miscutils/wall.c