X-Git-Url: https://git.librecmc.org/?a=blobdiff_plain;f=util-linux%2Ffdisk.c;h=8e133178de40e3c87749d04eca140bfaf29c980e;hb=765b0eed3ef29a80115708c3249d3a541509cd24;hp=980568bc8c6dab0ecee201636a5f2ccf5d836201;hpb=bf1d347964eac6bf25c1595d29fcb761e58c99c3;p=oweals%2Fbusybox.git diff --git a/util-linux/fdisk.c b/util-linux/fdisk.c index 980568bc8..8e133178d 100644 --- a/util-linux/fdisk.c +++ b/util-linux/fdisk.c @@ -21,6 +21,13 @@ #endif #include "libbb.h" +#if BB_LITTLE_ENDIAN +# define inline_if_little_endian ALWAYS_INLINE +#else +# define inline_if_little_endian /* nothing */ +#endif + + /* Looks like someone forgot to add this to config system */ #ifndef ENABLE_FEATURE_FDISK_BLKSIZE # define ENABLE_FEATURE_FDISK_BLKSIZE 0 @@ -178,10 +185,10 @@ static sector_t get_nr_sects(const struct partition *p); struct pte { struct partition *part_table; /* points into sectorbuffer */ struct partition *ext_pointer; /* points into sectorbuffer */ - sector_t offset; /* disk sector number */ + sector_t offset_from_dev_start; /* disk sector number */ char *sectorbuffer; /* disk sector contents */ #if ENABLE_FEATURE_FDISK_WRITABLE - char changed; /* boolean */ + char changed; /* boolean */ #endif }; @@ -400,8 +407,14 @@ static sector_t bb_BLKGETSIZE_sectors(int fd) return v64; } /* Needs temp of type long */ - if (ioctl(fd, BLKGETSIZE, &longsectors)) + if (ioctl(fd, BLKGETSIZE, &longsectors)) { + /* Perhaps this is a disk image */ + off_t sz = lseek(fd, 0, SEEK_END); longsectors = 0; + if (sz > 0) + longsectors = (uoff_t)sz / sector_size; + lseek(fd, 0, SEEK_SET); + } if (sizeof(long) > sizeof(sector_t) && longsectors != (sector_t)longsectors ) { @@ -428,16 +441,6 @@ static sector_t bb_BLKGETSIZE_sectors(int fd) #define hsc2sector(h,s,c) \ (sector(s) - 1 + sectors * ((h) + heads * cylinder(s,c))) -#define set_hsc(h,s,c,sector) \ - do { \ - s = sector % g_sectors + 1; \ - sector /= g_sectors; \ - h = sector % g_heads; \ - sector /= g_heads; \ - c = sector & 0xff; \ - s |= (sector >> 2) & 0xc0; \ - } while (0) - static void close_dev_fd(void) { @@ -445,27 +448,6 @@ close_dev_fd(void) xmove_fd(xopen(bb_dev_null, O_RDONLY), dev_fd); } -#if ENABLE_FEATURE_FDISK_WRITABLE -/* Read line; return 0 or first printable char */ -static int -read_line(const char *prompt) -{ - int sz; - - sz = read_line_input(prompt, line_buffer, sizeof(line_buffer), NULL); - if (sz <= 0) - exit(EXIT_SUCCESS); /* Ctrl-D or Ctrl-C */ - - if (line_buffer[sz-1] == '\n') - line_buffer[--sz] = '\0'; - - line_ptr = line_buffer; - while (*line_ptr != '\0' && (unsigned char)*line_ptr <= ' ') - line_ptr++; - return *line_ptr; -} -#endif - /* * Return partition name - uses static storage */ @@ -497,30 +479,13 @@ partname(const char *dev, int pno, int lth) if (lth) { snprintf(bufp, bufsiz, "%*.*s%s%-2u", - lth-wp-2, w, dev, p, pno); + lth-wp-2, w, dev, p, pno); } else { snprintf(bufp, bufsiz, "%.*s%s%-2u", w, dev, p, pno); } return bufp; } -#if ENABLE_FEATURE_FDISK_WRITABLE -static void -set_all_unchanged(void) -{ - int i; - - for (i = 0; i < MAXIMUM_PARTS; i++) - ptes[i].changed = 0; -} - -static ALWAYS_INLINE void -set_changed(int i) -{ - ptes[i].changed = 1; -} -#endif /* FEATURE_FDISK_WRITABLE */ - static ALWAYS_INLINE struct partition * get_part_table(int i) { @@ -541,7 +506,67 @@ valid_part_table_flag(const char *mbuffer) return (mbuffer[510] == 0x55 && (uint8_t)mbuffer[511] == 0xaa); } +static void fdisk_fatal(const char *why) +{ + if (listing) { + close_dev_fd(); + longjmp(listingbuf, 1); + } + bb_error_msg_and_die(why, disk_device); +} + +static void +seek_sector(sector_t secno) +{ +#if ENABLE_FDISK_SUPPORT_LARGE_DISKS + off64_t off = (off64_t)secno * sector_size; + if (lseek64(dev_fd, off, SEEK_SET) == (off64_t) -1) + fdisk_fatal(unable_to_seek); +#else + uint64_t off = (uint64_t)secno * sector_size; + if (off > MAXINT(off_t) + || lseek(dev_fd, (off_t)off, SEEK_SET) == (off_t) -1 + ) { + fdisk_fatal(unable_to_seek); + } +#endif +} + #if ENABLE_FEATURE_FDISK_WRITABLE +/* Read line; return 0 or first printable char */ +static int +read_line(const char *prompt) +{ + int sz; + + sz = read_line_input(prompt, line_buffer, sizeof(line_buffer), NULL); + if (sz <= 0) + exit(EXIT_SUCCESS); /* Ctrl-D or Ctrl-C */ + + if (line_buffer[sz-1] == '\n') + line_buffer[--sz] = '\0'; + + line_ptr = line_buffer; + while (*line_ptr != '\0' && (unsigned char)*line_ptr <= ' ') + line_ptr++; + return *line_ptr; +} + +static void +set_all_unchanged(void) +{ + int i; + + for (i = 0; i < MAXIMUM_PARTS; i++) + ptes[i].changed = 0; +} + +static ALWAYS_INLINE void +set_changed(int i) +{ + ptes[i].changed = 1; +} + static ALWAYS_INLINE void write_part_table_flag(char *b) { @@ -574,53 +599,23 @@ read_hex(const char *const *sys) unsigned long v; while (1) { read_nonempty("Hex code (type L to list codes): "); - if (*line_ptr == 'l' || *line_ptr == 'L') { + if ((line_ptr[0] | 0x20) == 'l') { list_types(sys); continue; } v = bb_strtoul(line_ptr, NULL, 16); - if (v > 0xff) - /* Bad input also triggers this */ - continue; - return v; + if (v <= 0xff) + return v; } } -#endif /* FEATURE_FDISK_WRITABLE */ - -static void fdisk_fatal(const char *why) -{ - if (listing) { - close_dev_fd(); - longjmp(listingbuf, 1); - } - bb_error_msg_and_die(why, disk_device); -} -static void -seek_sector(sector_t secno) -{ -#if ENABLE_FDISK_SUPPORT_LARGE_DISKS - off64_t off = (off64_t)secno * sector_size; - if (lseek64(dev_fd, off, SEEK_SET) == (off64_t) -1) - fdisk_fatal(unable_to_seek); -#else - uint64_t off = (uint64_t)secno * sector_size; - if (off > MAXINT(off_t) - || lseek(dev_fd, (off_t)off, SEEK_SET) == (off_t) -1 - ) { - fdisk_fatal(unable_to_seek); - } -#endif -} - -#if ENABLE_FEATURE_FDISK_WRITABLE static void write_sector(sector_t secno, const void *buf) { seek_sector(secno); xwrite(dev_fd, buf, sector_size); } -#endif +#endif /* FEATURE_FDISK_WRITABLE */ #include "fdisk_aix.c" @@ -713,40 +708,42 @@ STATIC_SUN void sun_write_table(void); #include "fdisk_sun.c" -#if ENABLE_FEATURE_FDISK_WRITABLE -/* start_sect and nr_sects are stored little endian on all machines */ -/* moreover, they are not aligned correctly */ -static void -store4_little_endian(unsigned char *cp, unsigned val) +static inline_if_little_endian unsigned +read4_little_endian(const unsigned char *cp) { - cp[0] = val; - cp[1] = val >> 8; - cp[2] = val >> 16; - cp[3] = val >> 24; + uint32_t v; + move_from_unaligned32(v, cp); + return SWAP_LE32(v); } -#endif /* FEATURE_FDISK_WRITABLE */ -static unsigned -read4_little_endian(const unsigned char *cp) +static sector_t +get_start_sect(const struct partition *p) { - return cp[0] + (cp[1] << 8) + (cp[2] << 16) + (cp[3] << 24); + return read4_little_endian(p->start4); +} + +static sector_t +get_nr_sects(const struct partition *p) +{ + return read4_little_endian(p->size4); } #if ENABLE_FEATURE_FDISK_WRITABLE -static void -set_start_sect(struct partition *p, unsigned start_sect) +/* start_sect and nr_sects are stored little endian on all machines */ +/* moreover, they are not aligned correctly */ +static inline_if_little_endian void +store4_little_endian(unsigned char *cp, unsigned val) { - store4_little_endian(p->start4, start_sect); + uint32_t v = SWAP_LE32(val); + move_to_unaligned32(cp, v); } -#endif -static sector_t -get_start_sect(const struct partition *p) +static void +set_start_sect(struct partition *p, unsigned start_sect) { - return read4_little_endian(p->start4); + store4_little_endian(p->start4, start_sect); } -#if ENABLE_FEATURE_FDISK_WRITABLE static void set_nr_sects(struct partition *p, unsigned nr_sects) { @@ -754,17 +751,11 @@ set_nr_sects(struct partition *p, unsigned nr_sects) } #endif -static sector_t -get_nr_sects(const struct partition *p) -{ - return read4_little_endian(p->size4); -} - /* Allocate a buffer and read a partition table sector */ static void read_pte(struct pte *pe, sector_t offset) { - pe->offset = offset; + pe->offset_from_dev_start = offset; pe->sectorbuffer = xzalloc(sector_size); seek_sector(offset); /* xread would make us abort - bad for fdisk -l */ @@ -777,9 +768,9 @@ read_pte(struct pte *pe, sector_t offset) } static sector_t -get_partition_start(const struct pte *pe) +get_partition_start_from_dev_start(const struct pte *pe) { - return pe->offset + get_start_sect(pe->part_table); + return pe->offset_from_dev_start + get_start_sect(pe->part_table); } #if ENABLE_FEATURE_FDISK_WRITABLE @@ -942,7 +933,7 @@ get_sys_types(void) } #else #define get_sys_types() i386_sys_types -#endif /* FEATURE_FDISK_WRITABLE */ +#endif static const char * partition_type(unsigned char type) @@ -957,6 +948,24 @@ partition_type(unsigned char type) return "Unknown"; } +static int +is_cleared_partition(const struct partition *p) +{ + /* We consider partition "cleared" only if it has only zeros */ + const char *cp = (const char *)p; + int cnt = sizeof(*p); + char bits = 0; + while (--cnt >= 0) + bits |= *cp++; + return (bits == 0); +} + +static void +clear_partition(struct partition *p) +{ + if (p) + memset(p, 0, sizeof(*p)); +} #if ENABLE_FEATURE_FDISK_WRITABLE static int @@ -998,25 +1007,28 @@ list_types(const char *const *sys) } while (done < last[0]); bb_putchar('\n'); } -#endif /* FEATURE_FDISK_WRITABLE */ -static int -is_cleared_partition(const struct partition *p) -{ - return !(!p || p->boot_ind || p->head || p->sector || p->cyl || - p->sys_ind || p->end_head || p->end_sector || p->end_cyl || - get_start_sect(p) || get_nr_sects(p)); -} +#define set_hsc(h, s, c, sector) do \ +{ \ + s = sector % g_sectors + 1; \ + sector /= g_sectors; \ + h = sector % g_heads; \ + sector /= g_heads; \ + c = sector & 0xff; \ + s |= (sector >> 2) & 0xc0; \ +} while (0) -static void -clear_partition(struct partition *p) +static void set_hsc_start_end(struct partition *p, sector_t start, sector_t stop) { - if (!p) - return; - memset(p, 0, sizeof(struct partition)); + if (dos_compatible_flag && (start / (g_sectors * g_heads) > 1023)) + start = g_heads * g_sectors * 1024 - 1; + set_hsc(p->head, p->sector, p->cyl, start); + + if (dos_compatible_flag && (stop / (g_sectors * g_heads) > 1023)) + stop = g_heads * g_sectors * 1024 - 1; + set_hsc(p->end_head, p->end_sector, p->end_cyl, stop); } -#if ENABLE_FEATURE_FDISK_WRITABLE static void set_partition(int i, int doext, sector_t start, sector_t stop, int sysid) { @@ -1028,18 +1040,13 @@ set_partition(int i, int doext, sector_t start, sector_t stop, int sysid) offset = extended_offset; } else { p = ptes[i].part_table; - offset = ptes[i].offset; + offset = ptes[i].offset_from_dev_start; } p->boot_ind = 0; p->sys_ind = sysid; set_start_sect(p, start - offset); set_nr_sects(p, stop - start + 1); - if (dos_compatible_flag && (start / (g_sectors * g_heads) > 1023)) - start = g_heads * g_sectors * 1024 - 1; - set_hsc(p->head, p->sector, p->cyl, start); - if (dos_compatible_flag && (stop / (g_sectors * g_heads) > 1023)) - stop = g_heads * g_sectors * 1024 - 1; - set_hsc(p->end_head, p->end_sector, p->end_cyl, stop); + set_hsc_start_end(p, start, stop); ptes[i].changed = 1; } #endif @@ -1189,26 +1196,22 @@ read_extended(int ext) static void create_doslabel(void) { - int i; - printf(msg_building_new_label, "DOS disklabel"); current_label_type = LABEL_DOS; - #if ENABLE_FEATURE_OSF_LABEL possibly_osf_label = 0; #endif g_partitions = 4; - for (i = 510-64; i < 510; i++) - MBRbuffer[i] = 0; + memset(&MBRbuffer[510 - 4*16], 0, 4*16); write_part_table_flag(MBRbuffer); extended_offset = 0; set_all_unchanged(); set_changed(0); get_boot(CREATE_EMPTY_DOS); } -#endif /* FEATURE_FDISK_WRITABLE */ +#endif static void get_sectorsize(void) @@ -1325,7 +1328,7 @@ static int get_boot(void) struct pte *pe = &ptes[i]; pe->part_table = pt_offset(MBRbuffer, i); pe->ext_pointer = NULL; - pe->offset = 0; + pe->offset_from_dev_start = 0; pe->sectorbuffer = MBRbuffer; #if ENABLE_FEATURE_FDISK_WRITABLE pe->changed = (what == CREATE_EMPTY_DOS); @@ -1709,9 +1712,9 @@ delete_partition(int i) if (pe->part_table) /* prevent SEGFAULT */ set_start_sect(pe->part_table, - get_partition_start(pe) - + get_partition_start_from_dev_start(pe) - extended_offset); - pe->offset = extended_offset; + pe->offset_from_dev_start = extended_offset; pe->changed = 1; } @@ -1721,9 +1724,10 @@ delete_partition(int i) ptes[i] = ptes[i+1]; i++; } - } else + } else { /* the only logical: clear only */ clear_partition(ptes[i].part_table); + } } } @@ -1922,7 +1926,7 @@ wrong_p_order(int *prev) pe = &ptes[i]; p = pe->part_table; if (p->sys_ind) { - p_start_pos = get_partition_start(pe); + p_start_pos = get_partition_start_from_dev_start(pe); if (last_p_start_pos > p_start_pos) { if (prev) @@ -1961,11 +1965,11 @@ fix_chain_of_logicals(void) /* (Its sector is the global extended_offset.) */ stage1: for (j = 5; j < g_partitions - 1; j++) { - oj = ptes[j].offset; - ojj = ptes[j+1].offset; + oj = ptes[j].offset_from_dev_start; + ojj = ptes[j+1].offset_from_dev_start; if (oj > ojj) { - ptes[j].offset = ojj; - ptes[j+1].offset = oj; + ptes[j].offset_from_dev_start = ojj; + ptes[j+1].offset_from_dev_start = oj; pj = ptes[j].part_table; set_start_sect(pj, get_start_sect(pj)+oj-ojj); pjj = ptes[j+1].part_table; @@ -1985,8 +1989,8 @@ fix_chain_of_logicals(void) pjj = ptes[j+1].part_table; sj = get_start_sect(pj); sjj = get_start_sect(pjj); - oj = ptes[j].offset; - ojj = ptes[j+1].offset; + oj = ptes[j].offset_from_dev_start; + ojj = ptes[j+1].offset_from_dev_start; if (oj+sj > ojj+sjj) { tmp = *pj; *pj = *pjj; @@ -2103,8 +2107,8 @@ list_table(int xtra) partname(disk_device, i+1, w+2), !p->boot_ind ? ' ' : p->boot_ind == ACTIVE_FLAG /* boot flag */ ? '*' : '?', - cround(get_partition_start(pe)), /* start */ - cround(get_partition_start(pe) + psects /* end */ + cround(get_partition_start_from_dev_start(pe)), /* start */ + cround(get_partition_start_from_dev_start(pe) + psects /* end */ - (psects ? 1 : 0)), pblocks, podd ? '+' : ' ', /* odd flag on end */ p->sys_ind, /* type id */ @@ -2166,7 +2170,7 @@ fill_bounds(sector_t *first, sector_t *last) first[i] = 0xffffffff; last[i] = 0; } else { - first[i] = get_partition_start(pe); + first[i] = get_partition_start_from_dev_start(pe); last[i] = first[i] + get_nr_sects(p) - 1; } } @@ -2223,7 +2227,7 @@ verify(void) p = pe->part_table; if (p->sys_ind && !IS_EXTENDED(p->sys_ind)) { check_consistency(p, i); - if (get_partition_start(pe) < first[i]) + if (get_partition_start_from_dev_start(pe) < first[i]) printf("Warning: bad start-of-data in " "partition %u\n", i + 1); check(i + 1, p->end_head, p->end_sector, p->end_cyl, @@ -2313,7 +2317,7 @@ add_partition(int n, int sys) for (i = 0; i < g_partitions; i++) { int lastplusoff; - if (start == ptes[i].offset) + if (start == ptes[i].offset_from_dev_start) start += sector_offset; lastplusoff = last[i] + ((n < 4) ? 0 : sector_offset); if (start >= first[i] && start <= lastplusoff) @@ -2330,8 +2334,7 @@ add_partition(int n, int sys) sector_t saved_start; saved_start = start; - start = read_int(cround(saved_start), cround(saved_start), cround(limit), - 0, mesg); + start = read_int(cround(saved_start), cround(saved_start), cround(limit), 0, mesg); if (display_in_cyl_units) { start = (start - 1) * units_per_sector; if (start < saved_start) @@ -2343,9 +2346,9 @@ add_partition(int n, int sys) if (n > 4) { /* NOT for fifth partition */ struct pte *pe = &ptes[n]; - pe->offset = start - sector_offset; - if (pe->offset == extended_offset) { /* must be corrected */ - pe->offset++; + pe->offset_from_dev_start = start - sector_offset; + if (pe->offset_from_dev_start == extended_offset) { /* must be corrected */ + pe->offset_from_dev_start++; if (sector_offset == 1) start++; } @@ -2354,8 +2357,8 @@ add_partition(int n, int sys) for (i = 0; i < g_partitions; i++) { struct pte *pe = &ptes[i]; - if (start < pe->offset && limit >= pe->offset) - limit = pe->offset - 1; + if (start < pe->offset_from_dev_start && limit >= pe->offset_from_dev_start) + limit = pe->offset_from_dev_start - 1; if (start < first[i] && limit >= first[i]) limit = first[i] - 1; } @@ -2371,8 +2374,7 @@ add_partition(int n, int sys) snprintf(mesg, sizeof(mesg), "Last %s or +size or +sizeM or +sizeK", str_units(SINGULAR)); - stop = read_int(cround(start), cround(limit), cround(limit), - cround(start), mesg); + stop = read_int(cround(start), cround(limit), cround(limit), cround(start), mesg); if (display_in_cyl_units) { stop = stop * units_per_sector - 1; if (stop >limit) @@ -2382,7 +2384,7 @@ add_partition(int n, int sys) set_partition(n, 0, start, stop, sys); if (n > 4) - set_partition(n - 1, 1, ptes[n].offset, stop, EXTENDED); + set_partition(n - 1, 1, ptes[n].offset_from_dev_start, stop, EXTENDED); if (IS_EXTENDED(sys)) { struct pte *pe4 = &ptes[4]; @@ -2390,7 +2392,7 @@ add_partition(int n, int sys) ext_index = n; pen->ext_pointer = p; - pe4->offset = extended_offset = start; + pe4->offset_from_dev_start = extended_offset = start; pe4->sectorbuffer = xzalloc(sector_size); pe4->part_table = pt_offset(pe4->sectorbuffer, 0); pe4->ext_pointer = pe4->part_table + 1; @@ -2408,7 +2410,7 @@ add_logical(void) pe->sectorbuffer = xzalloc(sector_size); pe->part_table = pt_offset(pe->sectorbuffer, 0); pe->ext_pointer = pe->part_table + 1; - pe->offset = 0; + pe->offset_from_dev_start = 0; pe->changed = 1; g_partitions++; } @@ -2462,7 +2464,7 @@ new_partition(void) "l logical (5 or over)" : "e extended")); while (1) { c = read_nonempty(line); - if (c == 'p' || c == 'P') { + if ((c | 0x20) == 'p') { i = get_nonexisting_partition(0, 4); if (i >= 0) add_partition(i, LINUX_NATIVE); @@ -2498,7 +2500,7 @@ write_table(void) if (pe->changed) { write_part_table_flag(pe->sectorbuffer); - write_sector(pe->offset, pe->sectorbuffer); + write_sector(pe->offset_from_dev_start, pe->sectorbuffer); } } } @@ -2587,22 +2589,25 @@ move_begin(unsigned i) { struct pte *pe = &ptes[i]; struct partition *p = pe->part_table; - sector_t new, first; + sector_t new, first, nr_sects; if (warn_geometry()) return; - if (!p->sys_ind || !get_nr_sects(p) || IS_EXTENDED(p->sys_ind)) { + nr_sects = get_nr_sects(p); + if (!p->sys_ind || !nr_sects || IS_EXTENDED(p->sys_ind)) { printf("Partition %u has no data area\n", i + 1); return; } - first = get_partition_start(pe); - new = read_int(first, first, first + get_nr_sects(p) - 1, first, - "New beginning of data") - pe->offset; - - if (new != get_nr_sects(p)) { - first = get_nr_sects(p) + get_start_sect(p) - new; - set_nr_sects(p, first); - set_start_sect(p, new); + first = get_partition_start_from_dev_start(pe); /* == pe->offset_from_dev_start + get_start_sect(p) */ + new = read_int(0 /*was:first*/, first, first + nr_sects - 1, first, "New beginning of data"); + if (new != first) { + sector_t new_relative = new - pe->offset_from_dev_start; + nr_sects += (get_start_sect(p) - new_relative); + set_start_sect(p, new_relative); + set_nr_sects(p, nr_sects); + read_nonempty("Recalculate C/H/S values? (Y/N): "); + if ((line_ptr[0] | 0x20) == 'y') + set_hsc_start_end(p, new, new + nr_sects - 1); pe->changed = 1; } } @@ -2614,7 +2619,7 @@ xselect(void) while (1) { bb_putchar('\n'); - c = tolower(read_nonempty("Expert command (m for help): ")); + c = 0x20 | read_nonempty("Expert command (m for help): "); switch (c) { case 'a': if (LABEL_IS_SUN) @@ -2654,8 +2659,7 @@ xselect(void) #endif break; case 'h': - user_heads = g_heads = read_int(1, g_heads, 256, 0, - "Number of heads"); + user_heads = g_heads = read_int(1, g_heads, 256, 0, "Number of heads"); update_units(); break; case 'i': @@ -2680,8 +2684,7 @@ xselect(void) case 'r': return; case 's': - user_sectors = g_sectors = read_int(1, g_sectors, 63, 0, - "Number of sectors"); + user_sectors = g_sectors = read_int(1, g_sectors, 63, 0, "Number of sectors"); if (dos_compatible_flag) { sector_offset = g_sectors; printf("Warning: setting sector offset for DOS " @@ -2842,14 +2845,17 @@ int fdisk_main(int argc UNUSED_PARAM, char **argv) opt = getopt32(argv, "b:C:H:lS:u" IF_FEATURE_FDISK_BLKSIZE("s"), §or_size, &user_cylinders, &user_heads, &user_sectors); argv += optind; - if (opt & OPT_b) { // -b + if (opt & OPT_b) { /* Ugly: this sector size is really per device, - so cannot be combined with multiple disks, - and the same goes for the C/H/S options. - */ - if (sector_size != 512 && sector_size != 1024 - && sector_size != 2048) + * so cannot be combined with multiple disks, + * and the same goes for the C/H/S options. + */ + if (sector_size < 512 + || sector_size > 0x10000 + || (sector_size & (sector_size-1)) /* not power of 2 */ + ) { bb_show_usage(); + } sector_offset = 2; user_set_sector_size = 1; } @@ -2920,7 +2926,7 @@ int fdisk_main(int argc UNUSED_PARAM, char **argv) while (1) { int c; bb_putchar('\n'); - c = tolower(read_nonempty("Command (m for help): ")); + c = 0x20 | read_nonempty("Command (m for help): "); switch (c) { case 'a': if (LABEL_IS_DOS)