X-Git-Url: https://git.librecmc.org/?a=blobdiff_plain;f=sysklogd%2Flogger.c;h=c5e17c2e5c9b224073c538a608082a252bc06c96;hb=62a6983a818ce701b924f84bf23716c4fbff170a;hp=a78cf77b9441c02110da55f1f406a766e445a4e1;hpb=cb1ba865077720087d47895d4125474ccbf366cc;p=oweals%2Fbusybox.git

diff --git a/sysklogd/logger.c b/sysklogd/logger.c
index a78cf77b9..c5e17c2e5 100644
--- a/sysklogd/logger.c
+++ b/sysklogd/logger.c
@@ -8,13 +8,6 @@
  */
 
 #include "busybox.h"
-#include <stdio.h>
-#include <unistd.h>
-#include <sys/types.h>
-#include <fcntl.h>
-#include <ctype.h>
-#include <string.h>
-#include <stdlib.h>
 
 #if !defined CONFIG_SYSLOGD
 
@@ -48,14 +41,14 @@ static int decode(char *name, CODE * codetab)
 	CODE *c;
 
 	if (isdigit(*name))
-		return (atoi(name));
+		return atoi(name);
 	for (c = codetab; c->c_name; c++) {
 		if (!strcasecmp(name, c->c_name)) {
-			return (c->c_val);
+			return c->c_val;
 		}
 	}
 
-	return (-1);
+	return -1;
 }
 
 /* Decode a symbolic name to a numeric value
@@ -70,72 +63,69 @@ static int pencode(char *s)
 	char *save;
 	int lev, fac = LOG_USER;
 
-	for (save = s; *s && *s != '.'; ++s);
+	for (save = s; *s && *s != '.'; ++s)
+		;
 	if (*s) {
 		*s = '\0';
 		fac = decode(save, facilitynames);
 		if (fac < 0)
-			bb_error_msg_and_die("unknown facility name: %s", save);
+			bb_error_msg_and_die("unknown %s name: %s", "facility", save);
 		*s++ = '.';
 	} else {
 		s = save;
 	}
 	lev = decode(s, prioritynames);
 	if (lev < 0)
-		bb_error_msg_and_die("unknown priority name: %s", save);
+		bb_error_msg_and_die("unknown %s name: %s", "priority", save);
 	return ((lev & LOG_PRIMASK) | (fac & LOG_FACMASK));
 }
 
 
 int logger_main(int argc, char **argv)
 {
-	unsigned long opt;
 	char *opt_p, *opt_t;
-	int pri = LOG_USER | LOG_NOTICE;
-	int option = 0;
-	int c, i;
-	char buf[1024], name[128];
+	int i = 0;
+	RESERVE_CONFIG_BUFFER(name, 80);
 
 	/* Fill out the name string early (may be overwritten later) */
 	bb_getpwuid(name, geteuid(), sizeof(name));
 
 	/* Parse any options */
-	opt = bb_getopt_ulflags(argc, argv, "p:st:", &opt_p, &opt_t);
-	if (opt & 0x1) pri = pencode(opt_p); // -p
-	if (opt & 0x2) option |= LOG_PERROR; // -s
-	if (opt & 0x4) safe_strncpy(name, opt_t, sizeof(name)); // -t
-
-	openlog(name, option, 0);
-	if (optind == argc) {
-		do {
-			/* read from stdin */
-			i = 0;
-			while ((c = getc(stdin)) != EOF && c != '\n' &&
-					i < (sizeof(buf)-1)) {
-				buf[i++] = c;
-			}
-			if (i > 0) {
-				buf[i++] = '\0';
-				syslog(pri, "%s", buf);
+	getopt32(argc, argv, "p:st:", &opt_p, &opt_t);
+
+	if (option_mask32 & 0x2) /* -s */
+		i |= LOG_PERROR;
+	if (option_mask32 & 0x4) /* -t */
+		safe_strncpy(name, opt_t, sizeof(name));
+	openlog(name, i, 0);
+	if (ENABLE_FEATURE_CLEAN_UP)
+		RELEASE_CONFIG_BUFFER(name);
+	i = LOG_USER | LOG_NOTICE;
+	if (option_mask32 & 0x1) /* -p */
+		i = pencode(opt_p);
+
+	argc -= optind;
+	argv += optind;
+	if (!argc) {
+		while (fgets(bb_common_bufsiz1, BUFSIZ, stdin)) {
+			if (bb_common_bufsiz1[0]
+			 && NOT_LONE_CHAR(bb_common_bufsiz1, '\n')
+			) {
+				/* Neither "" nor "\n" */
+				syslog(i, "%s", bb_common_bufsiz1);
 			}
-		} while (c != EOF);
+		}
 	} else {
 		char *message = NULL;
-		int len = argc - optind; /* for the space between the args
-					    and  '\0' */
-		opt = len;
-		argv += optind;
-		for (i = 0; i < opt; i++) {
-			len += strlen(*argv);
+		int len = 1; /* for NUL */
+		int pos = 0;
+		do {
+			len += strlen(*argv) + 1;
 			message = xrealloc(message, len);
-			if(!i)
-				message[0] = '\0';
-			else
-				strcat(message, " ");
-			strcat(message, *argv);
-			argv++;
-		}
-		syslog(pri, "%s", message);
+			sprintf(message + pos, " %s", *argv),
+			pos = len;
+		} while (*++argv);
+		syslog(i, "%s", message + 1); /* skip leading " " */
 	}
 
 	closelog();
@@ -177,6 +167,3 @@ int logger_main(int argc, char **argv)
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  */
-
-
-