X-Git-Url: https://git.librecmc.org/?a=blobdiff_plain;f=src%2Futil%2Fcommon_logging.c;h=f5688f42c620495d8d237396139548a8d217c0c3;hb=2587d268f7c92b09bfc1b0130105b378d6055329;hp=8f1c8e876296edfe5d7cbc108a773293dc230579;hpb=3d7fefedc9ba60bd8e8448efe8b628446d958536;p=oweals%2Fgnunet.git diff --git a/src/util/common_logging.c b/src/util/common_logging.c index 8f1c8e876..f5688f42c 100644 --- a/src/util/common_logging.c +++ b/src/util/common_logging.c @@ -1,6 +1,6 @@ /* This file is part of GNUnet. - (C) 2006-2013 Christian Grothoff (and other contributing authors) + Copyright (C) 2006-2013 Christian Grothoff (and other contributing authors) GNUnet is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published @@ -14,19 +14,18 @@ You should have received a copy of the GNU General Public License along with GNUnet; see the file COPYING. If not, write to the - Free Software Foundation, Inc., 59 Temple Place - Suite 330, - Boston, MA 02111-1307, USA. + Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, + Boston, MA 02110-1301, USA. */ /** * @file util/common_logging.c * @brief error handling API - * * @author Christian Grothoff */ #include "platform.h" -#include "gnunet_common.h" -#include "gnunet_util_lib.h" +#include "gnunet_crypto_lib.h" +#include "gnunet_strings_lib.h" #include @@ -283,7 +282,7 @@ resize_logdefs () * Abort the process, generate a core dump if possible. */ void -GNUNET_abort () +GNUNET_abort_ () { #if WINDOWS DebugBreak (); @@ -296,7 +295,7 @@ GNUNET_abort () * Rotate logs, deleting the oldest log. * * @param new_name new name to add to the rotation - */ + */ static void log_rotate (const char *new_name) { @@ -315,7 +314,7 @@ log_rotate (const char *new_name) GNUNET_free (discard); } rotation[rotation_off % ROTATION_KEEP] = GNUNET_strdup (new_name); - rotation_off++; + rotation_off++; } @@ -323,19 +322,18 @@ log_rotate (const char *new_name) * Setup the log file. * * @param tm timestamp for which we should setup logging - * @return GNUNET_OK on success, GNUNET_SYSERR on error + * @return #GNUNET_OK on success, #GNUNET_SYSERR on error */ static int setup_log_file (const struct tm *tm) { - static char last_fn[PATH_MAX + 1]; + static char last_fn[PATH_MAX + 1]; char fn[PATH_MAX + 1]; - int dirwarn; int altlog_fd; int dup_return; FILE *altlog; char *leftsquare; - + if (NULL == log_file_name) return GNUNET_SYSERR; if (0 == strftime (fn, sizeof (fn), log_file_name, tm)) @@ -354,7 +352,6 @@ setup_log_file (const struct tm *tm) return GNUNET_OK; /* no change */ log_rotate (last_fn); strcpy (last_fn, fn); - dirwarn = (GNUNET_OK != GNUNET_DISK_directory_create_for_file (fn)); #if WINDOWS altlog_fd = OPEN (fn, O_APPEND | O_BINARY | @@ -388,16 +385,13 @@ setup_log_file (const struct tm *tm) if (-1 == altlog_fd) { GNUNET_log_strerror_file (GNUNET_ERROR_TYPE_ERROR, "open", fn); - if (dirwarn) - GNUNET_log (GNUNET_ERROR_TYPE_WARNING, - _("Failed to create or access directory for log file `%s'\n"), - fn); return GNUNET_SYSERR; } - GNUNET_stderr = altlog; + GNUNET_stderr = altlog; return GNUNET_OK; } + /** * Utility function - adds a parsed definition to logdefs array. * @@ -663,10 +657,12 @@ parse_all_definitions () * @param comp default component to use * @param loglevel what types of messages should be logged * @param logfile which file to write log messages to (can be NULL) - * @return GNUNET_OK on success + * @return #GNUNET_OK on success */ int -GNUNET_log_setup (const char *comp, const char *loglevel, const char *logfile) +GNUNET_log_setup (const char *comp, + const char *loglevel, + const char *logfile) { const char *env_logfile; const struct tm *tm; @@ -703,14 +699,14 @@ GNUNET_log_setup (const char *comp, const char *loglevel, const char *logfile) * Add a custom logger. * * @param logger log function - * @param logger_cls closure for logger + * @param logger_cls closure for @a logger */ void GNUNET_logger_add (GNUNET_Logger logger, void *logger_cls) { struct CustomLogger *entry; - entry = GNUNET_malloc (sizeof (struct CustomLogger)); + entry = GNUNET_new (struct CustomLogger); entry->logger = logger; entry->logger_cls = logger_cls; entry->next = loggers; @@ -722,7 +718,7 @@ GNUNET_logger_add (GNUNET_Logger logger, void *logger_cls) * Remove a custom logger. * * @param logger log function - * @param logger_cls closure for logger + * @param logger_cls closure for @a logger */ void GNUNET_logger_remove (GNUNET_Logger logger, void *logger_cls) @@ -732,14 +728,14 @@ GNUNET_logger_remove (GNUNET_Logger logger, void *logger_cls) prev = NULL; pos = loggers; - while ((pos != NULL) && + while ((NULL != pos) && ((pos->logger != logger) || (pos->logger_cls != logger_cls))) { prev = pos; pos = pos->next; } - GNUNET_assert (pos != NULL); - if (prev == NULL) + GNUNET_assert (NULL != pos); + if (NULL == prev) loggers = pos->next; else prev->next = pos->next; @@ -828,10 +824,11 @@ flush_bulk (const char *datestr) * Ignore the next n calls to the log function. * * @param n number of log calls to ignore (could be negative) - * @param check_reset GNUNET_YES to assert that the log skip counter is currently zero + * @param check_reset #GNUNET_YES to assert that the log skip counter is currently zero */ void -GNUNET_log_skip (int n, int check_reset) +GNUNET_log_skip (int n, + int check_reset) { int ok; @@ -848,6 +845,7 @@ GNUNET_log_skip (int n, int check_reset) } } + /** * Get the number of log calls that are going to be skipped * @@ -859,6 +857,7 @@ GNUNET_get_log_skip () return skip_log; } + /** * Output a log message using the default mechanism. * @@ -868,7 +867,9 @@ GNUNET_get_log_skip () * @param va arguments to the format string "message" */ static void -mylog (enum GNUNET_ErrorType kind, const char *comp, const char *message, +mylog (enum GNUNET_ErrorType kind, + const char *comp, + const char *message, va_list va) { char date[DATE_STR_SIZE]; @@ -944,7 +945,7 @@ mylog (enum GNUNET_ErrorType kind, const char *comp, const char *message, strftime (date2, DATE_STR_SIZE, "%b %d %H:%M:%S-%%06u", tmptr); snprintf (date, sizeof (date), date2, timeofday.tv_usec); } -#endif +#endif VSNPRINTF (buf, size, message, va); if (NULL != tmptr) (void) setup_log_file (tmptr); @@ -954,7 +955,7 @@ mylog (enum GNUNET_ErrorType kind, const char *comp, const char *message, { last_bulk_repeat++; if ( (GNUNET_TIME_absolute_get_duration (last_bulk_time).rel_value_us > - BULK_DELAY_THRESHOLD) || + BULK_DELAY_THRESHOLD) || (last_bulk_repeat > BULK_REPEAT_THRESHOLD) ) flush_bulk (date); return; @@ -978,7 +979,8 @@ mylog (enum GNUNET_ErrorType kind, const char *comp, const char *message, * @param ... arguments for format string */ void -GNUNET_log_nocheck (enum GNUNET_ErrorType kind, const char *message, ...) +GNUNET_log_nocheck (enum GNUNET_ErrorType kind, + const char *message, ...) { va_list va; @@ -1037,43 +1039,6 @@ GNUNET_error_type_to_string (enum GNUNET_ErrorType kind) } -/** - * Convert a short hash to a string (for printing debug messages). - * This is one of the very few calls in the entire API that is - * NOT reentrant! - * - * @param hc the short hash code - * @return string form; will be overwritten by next call to GNUNET_h2s. - */ -const char * -GNUNET_short_h2s (const struct GNUNET_CRYPTO_ShortHashCode * hc) -{ - static struct GNUNET_CRYPTO_ShortHashAsciiEncoded ret; - - GNUNET_CRYPTO_short_hash_to_enc (hc, &ret); - ret.short_encoding[8] = '\0'; - return (const char *) ret.short_encoding; -} - - -/** - * Convert a short hash to a string (for printing debug messages). - * This is one of the very few calls in the entire API that is - * NOT reentrant! - * - * @param hc the short hash code - * @return string form; will be overwritten by next call to GNUNET_h2s_full. - */ -const char * -GNUNET_short_h2s_full (const struct GNUNET_CRYPTO_ShortHashCode * hc) -{ - static struct GNUNET_CRYPTO_ShortHashAsciiEncoded ret; - - GNUNET_CRYPTO_short_hash_to_enc (hc, &ret); - ret.short_encoding[sizeof (ret) - 1] = '\0'; - return (const char *) ret.short_encoding; -} - /** * Convert a hash to a string (for printing debug messages). * This is one of the very few calls in the entire API that is @@ -1119,16 +1084,19 @@ GNUNET_h2s_full (const struct GNUNET_HashCode * hc) * * @param pid the peer identity * @return string form of the pid; will be overwritten by next - * call to GNUNET_i2s. + * call to #GNUNET_i2s. */ const char * GNUNET_i2s (const struct GNUNET_PeerIdentity *pid) { - static struct GNUNET_CRYPTO_HashAsciiEncoded ret; - - GNUNET_CRYPTO_hash_to_enc (&pid->hashPubKey, &ret); - ret.encoding[4] = '\0'; - return (const char *) ret.encoding; + static char buf[256]; + char *ret; + + ret = GNUNET_CRYPTO_eddsa_public_key_to_string (&pid->public_key); + strcpy (buf, ret); + GNUNET_free (ret); + buf[4] = '\0'; + return buf; } @@ -1139,15 +1107,18 @@ GNUNET_i2s (const struct GNUNET_PeerIdentity *pid) * * @param pid the peer identity * @return string form of the pid; will be overwritten by next - * call to GNUNET_i2s. + * call to #GNUNET_i2s_full. */ const char * GNUNET_i2s_full (const struct GNUNET_PeerIdentity *pid) { - static struct GNUNET_CRYPTO_HashAsciiEncoded ret; + static char buf[256]; + char *ret; - GNUNET_CRYPTO_hash_to_enc (&pid->hashPubKey, &ret); - return (const char *) ret.encoding; + ret = GNUNET_CRYPTO_eddsa_public_key_to_string (&pid->public_key); + strcpy (buf, ret); + GNUNET_free (ret); + return buf; } @@ -1157,14 +1128,22 @@ GNUNET_i2s_full (const struct GNUNET_PeerIdentity *pid) * in the entire API that is NOT reentrant! * * @param addr the address - * @param addrlen the length of the address + * @param addrlen the length of the address in @a addr * @return nicely formatted string for the address - * will be overwritten by next call to GNUNET_a2s. + * will be overwritten by next call to #GNUNET_a2s. */ const char * -GNUNET_a2s (const struct sockaddr *addr, socklen_t addrlen) +GNUNET_a2s (const struct sockaddr *addr, + socklen_t addrlen) { - static char buf[INET6_ADDRSTRLEN + 8]; +#ifndef WINDOWS +#define LEN GNUNET_MAX ((INET6_ADDRSTRLEN + 8), \ + (1 + sizeof (struct sockaddr_un) - sizeof (sa_family_t))) +#else +#define LEN (INET6_ADDRSTRLEN + 8) +#endif + static char buf[LEN]; +#undef LEN static char b2[6]; const struct sockaddr_in *v4; const struct sockaddr_un *un; @@ -1203,12 +1182,15 @@ GNUNET_a2s (const struct sockaddr *addr, socklen_t addrlen) return ""; un = (const struct sockaddr_un *) addr; off = 0; - if (un->sun_path[0] == '\0') + if ('\0' == un->sun_path[0]) off++; memset (buf, 0, sizeof (buf)); - snprintf (buf, sizeof (buf) - 1, "%s%.*s", (off == 1) ? "@" : "", - (int) (addrlen - sizeof (sa_family_t) - 1 - off), - &un->sun_path[off]); + GNUNET_snprintf (buf, + sizeof (buf), + "%s%.*s", + (1 == off) ? "@" : "", + (int) (addrlen - sizeof (sa_family_t) - off), + &un->sun_path[off]); return buf; default: return _("invalid address"); @@ -1224,7 +1206,7 @@ GNUNET_a2s (const struct sockaddr *addr, socklen_t addrlen) * @param option name of missing option */ void -GNUNET_log_config_missing (enum GNUNET_ErrorType kind, +GNUNET_log_config_missing (enum GNUNET_ErrorType kind, const char *section, const char *option) { @@ -1244,7 +1226,7 @@ GNUNET_log_config_missing (enum GNUNET_ErrorType kind, * @param required what is required that is invalid about the option */ void -GNUNET_log_config_invalid (enum GNUNET_ErrorType kind, +GNUNET_log_config_invalid (enum GNUNET_ErrorType kind, const char *section, const char *option, const char *required) @@ -1258,15 +1240,16 @@ GNUNET_log_config_invalid (enum GNUNET_ErrorType kind, /** * Initializer */ -void __attribute__ ((constructor)) GNUNET_util_cl_init () +void __attribute__ ((constructor)) +GNUNET_util_cl_init () { GNUNET_stderr = stderr; #ifdef MINGW GNInitWinEnv (NULL); #endif #if WINDOWS - if (!InitializeCriticalSectionAndSpinCount (&output_message_cs, 0x00000400)) - GNUNET_abort (); + if (!InitializeCriticalSectionAndSpinCount (&output_message_cs, 0x00000400)) + GNUNET_abort_ (); #endif } @@ -1274,7 +1257,8 @@ void __attribute__ ((constructor)) GNUNET_util_cl_init () /** * Destructor */ -void __attribute__ ((destructor)) GNUNET_util_cl_fini () +void __attribute__ ((destructor)) +GNUNET_util_cl_fini () { #if WINDOWS DeleteCriticalSection (&output_message_cs);