X-Git-Url: https://git.librecmc.org/?a=blobdiff_plain;f=src%2Ftransport%2Ftransport-testing.c;h=32331d9d9fce4d1373acd06c91eb0eb4b84a5f0b;hb=66963559294951161370c50f2430a31d54448f86;hp=fb7535750f47cd3885e059d4a92476d23989de0c;hpb=18bc4a4c2993dc9962bf62b6b375921282246b86;p=oweals%2Fgnunet.git

diff --git a/src/transport/transport-testing.c b/src/transport/transport-testing.c
index fb7535750..32331d9d9 100644
--- a/src/transport/transport-testing.c
+++ b/src/transport/transport-testing.c
@@ -27,8 +27,6 @@
 
 #include "transport-testing.h"
 
-#define VERBOSE GNUNET_EXTRA_LOGGING
-
 
 static struct PeerContext *
 find_peer_context (struct GNUNET_TRANSPORT_TESTING_handle *tth,
@@ -47,7 +45,8 @@ find_peer_context (struct GNUNET_TRANSPORT_TESTING_handle *tth,
   return t;
 }
 
-struct ConnectingContext *
+
+static struct ConnectingContext *
 find_connecting_context (struct GNUNET_TRANSPORT_TESTING_handle *tth,
                          struct PeerContext *p1, struct PeerContext *p2)
 {
@@ -66,25 +65,21 @@ find_connecting_context (struct GNUNET_TRANSPORT_TESTING_handle *tth,
   return cc;
 }
 
+
 static void
 notify_connect (void *cls, const struct GNUNET_PeerIdentity *peer,
                 const struct GNUNET_ATS_Information *ats, uint32_t ats_count)
 {
   struct PeerContext *p = cls;
+  char *p2_s;
+  struct PeerContext *p2;
 
-  /* Find PeerContext */
-  GNUNET_assert (p != 0);
-  GNUNET_assert (p->tth != NULL);
-  struct PeerContext *p2 = find_peer_context (p->tth, peer);
-
-  if (p == NULL)
-    return;
+  GNUNET_assert (NULL != p);
+  GNUNET_assert (NULL != p->tth);
+  p2 = find_peer_context (p->tth, peer);
   if (p->nc != NULL)
     p->nc (p->cb_cls, peer, ats, ats_count);
 
-#if VERBOSE
-  char *p2_s;
-
   if (p2 != NULL)
     GNUNET_asprintf (&p2_s, "%u (`%s')", p2->no, GNUNET_i2s (&p2->id));
   else
@@ -93,8 +88,6 @@ notify_connect (void *cls, const struct GNUNET_PeerIdentity *peer,
                    "Peers %s connected to peer %u (`%s')\n", p2_s, p->no,
                    GNUNET_i2s (&p->id));
   GNUNET_free (p2_s);
-#endif
-
 
   /* Find ConnectingContext */
   struct ConnectingContext *cc = find_connecting_context (p->tth, p, p2);
@@ -115,6 +108,7 @@ notify_connect (void *cls, const struct GNUNET_PeerIdentity *peer,
   }
 }
 
+
 static void
 notify_disconnect (void *cls, const struct GNUNET_PeerIdentity *peer)
 {
@@ -148,6 +142,7 @@ notify_disconnect (void *cls, const struct GNUNET_PeerIdentity *peer)
     p->nd (p->cb_cls, peer);
 }
 
+
 static void
 notify_receive (void *cls, const struct GNUNET_PeerIdentity *peer,
                 const struct GNUNET_MessageHeader *message,
@@ -161,35 +156,26 @@ notify_receive (void *cls, const struct GNUNET_PeerIdentity *peer,
     p->rec (p->cb_cls, peer, message, ats, ats_count);
 }
 
+
 static void
 get_hello (void *cb_cls, const struct GNUNET_MessageHeader *message)
 {
   struct PeerContext *p = cb_cls;
+  struct GNUNET_PeerIdentity hello_id;
 
   GNUNET_assert (message != NULL);
   GNUNET_assert (GNUNET_OK ==
                  GNUNET_HELLO_get_id ((const struct GNUNET_HELLO_Message *)
-                                      message, &p->id));
-#if VERBOSE
-  size_t size =
-      GNUNET_HELLO_size ((const struct GNUNET_HELLO_Message *) message);
-#endif
+                                      message, &hello_id));
+  GNUNET_assert (0 == memcmp (&hello_id, &p->id, sizeof (hello_id)));
   GNUNET_free_non_null (p->hello);
   p->hello = (struct GNUNET_HELLO_Message *) GNUNET_copy_message (message);
 
-#if VERBOSE
-  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "transport-testing",
-                   "New HELLO for peer %u (`%s') with size %u\n", p->no,
-                   GNUNET_i2s (&p->id), size);
-#endif
-
-  if (p->start_cb != NULL)
+  if (NULL != p->start_cb)
   {
-#if VERBOSE
     GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "transport-testing",
                      "Peer %u (`%s') successfully started\n", p->no,
                      GNUNET_i2s (&p->id));
-#endif
     p->start_cb (p, p->cb_cls);
     p->start_cb = NULL;
   }
@@ -222,7 +208,7 @@ try_connect (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   GNUNET_TRANSPORT_offer_hello (cc->th_p1,
                                 (const struct GNUNET_MessageHeader *) cc->
                                 p2->hello, NULL, NULL);
-  GNUNET_TRANSPORT_try_connect (cc->th_p1, &p2->id);
+  GNUNET_TRANSPORT_try_connect (cc->th_p1, &p2->id, NULL, NULL); /*FIXME TRY_CONNECT change */
 
   cc->tct =
       GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_SECONDS, &try_connect, cc);
@@ -231,22 +217,31 @@ try_connect (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
 
 /**
  * Start a peer with the given configuration
+ * @param tth the testing handle
+ * @param cfgname configuration file
+ * @param peer_id a unique number to identify the peer
  * @param rec receive callback
  * @param nc connect callback
  * @param nd disconnect callback
+ * @param start_cb start callback
  * @param cb_cls closure for callback
  * @return the peer context
  */
 struct PeerContext *
-GNUNET_TRANSPORT_TESTING_start_peer (struct GNUNET_TRANSPORT_TESTING_handle
-                                     *tth, const char *cfgname, int peer_id,
+GNUNET_TRANSPORT_TESTING_start_peer (struct GNUNET_TRANSPORT_TESTING_handle *tth,
+                                     const char *cfgname, int peer_id,
                                      GNUNET_TRANSPORT_ReceiveCallback rec,
                                      GNUNET_TRANSPORT_NotifyConnect nc,
                                      GNUNET_TRANSPORT_NotifyDisconnect nd,
                                      GNUNET_TRANSPORT_TESTING_start_cb start_cb,
                                      void *cb_cls)
 {
-  GNUNET_assert (tth != NULL);
+  char *emsg = NULL;
+  struct GNUNET_PeerIdentity *dummy;
+
+  GNUNET_assert (NULL != tth);
+  GNUNET_assert (NULL != tth->tl_system);
+
   if (GNUNET_DISK_file_test (cfgname) == GNUNET_NO)
   {
     GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "transport-testing",
@@ -255,28 +250,61 @@ GNUNET_TRANSPORT_TESTING_start_peer (struct GNUNET_TRANSPORT_TESTING_handle
   }
 
   struct PeerContext *p = GNUNET_malloc (sizeof (struct PeerContext));
+  GNUNET_CONTAINER_DLL_insert (tth->p_head, tth->p_tail, p);
 
+  /* Create configuration and call testing lib to modify it */
   p->cfg = GNUNET_CONFIGURATION_create ();
-
   GNUNET_assert (GNUNET_OK == GNUNET_CONFIGURATION_load (p->cfg, cfgname));
-  if (GNUNET_CONFIGURATION_have_value (p->cfg, "PATHS", "SERVICEHOME"))
-    GNUNET_assert (GNUNET_OK ==
-                   GNUNET_CONFIGURATION_get_value_string (p->cfg, "PATHS",
-                                                          "SERVICEHOME",
-                                                          &p->servicehome));
-  if (NULL != p->servicehome)
-    GNUNET_DISK_directory_remove (p->servicehome);
-  p->arm_proc =
-      GNUNET_OS_start_process (NULL, NULL, "gnunet-service-arm",
-                               "gnunet-service-arm", "-c", cfgname,
-#if VERBOSE_PEERS
-                               "-L", "DEBUG",
-#else
-                               "-L", "ERROR",
-#endif
-                               NULL);
+
+  if (GNUNET_SYSERR == GNUNET_TESTING_configuration_create (tth->tl_system, p->cfg))
+  {
+    GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "transport-testing",
+                     "Testing library failed to create unique configuration based on `%s'\n",
+                     cfgname);
+    GNUNET_free (p);
+    return NULL;
+  }
 
   p->no = peer_id;
+  /* Configure peer with configuration */
+  p->peer = GNUNET_TESTING_peer_configure (tth->tl_system, p->cfg, p->no, NULL, &emsg);
+  if (NULL == p->peer)
+  {
+    GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "transport-testing",
+                     "Testing library failed to create unique configuration based on `%s': `%s'\n",
+                     cfgname, emsg);
+    GNUNET_TRANSPORT_TESTING_stop_peer (tth, p);
+    GNUNET_free_non_null (emsg);
+    return NULL;
+  }
+  GNUNET_free_non_null (emsg);
+  if (GNUNET_OK != GNUNET_TESTING_peer_start (p->peer))
+  {
+    GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "transport-testing",
+                     "Testing library failed to create unique configuration based on `%s'\n",
+                     cfgname);
+    GNUNET_TRANSPORT_TESTING_stop_peer (tth, p);
+    return NULL;
+  }
+
+  memset(&dummy, '\0', sizeof (dummy));
+  GNUNET_TESTING_peer_get_identity (p->peer, &p->id);
+  if (0 == memcmp (&dummy, &p->id, sizeof (struct GNUNET_PeerIdentity)))
+  {
+    GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "transport-testing",
+                     "Testing library failed to obtain peer identity for peer %u\n",
+                     p->no);
+    GNUNET_TRANSPORT_TESTING_stop_peer (tth, p);
+    return NULL;
+  }
+  else
+  {
+    GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "transport-testing",
+                     "Peer %u configured with identity `%s'\n",
+                     p->no,
+                     GNUNET_i2s (&p->id));
+  }
+
   p->tth = tth;
   p->nc = nc;
   p->nd = nd;
@@ -287,21 +315,95 @@ GNUNET_TRANSPORT_TESTING_start_peer (struct GNUNET_TRANSPORT_TESTING_handle
   else
     p->cb_cls = p;
 
-  p->th =
-      GNUNET_TRANSPORT_connect (p->cfg, NULL, p, &notify_receive,
-                                &notify_connect, &notify_disconnect);
-  GNUNET_assert (p->th != NULL);
+  p->th = GNUNET_TRANSPORT_connect (p->cfg, NULL, p,
+                                    &notify_receive,
+                                    &notify_connect, &notify_disconnect);
+  if (NULL == p->th)
+  {
+    GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "transport-testing",
+                     "Failed to connect to transport service for peer  `%s': `%s'\n",
+                     cfgname, emsg);
+    GNUNET_TRANSPORT_TESTING_stop_peer (tth, p);
+    return NULL;
+  }
 
   p->ghh = GNUNET_TRANSPORT_get_hello (p->th, &get_hello, p);
   GNUNET_assert (p->ghh != NULL);
 
-  GNUNET_CONTAINER_DLL_insert (tth->p_head, tth->p_tail, p);
-
   return p;
 }
 
+/**
+* Restart the given peer
+* @param tth testing handle
+* @param p the peer
+* @param cfgname the cfg file used to restart
+* @param restart_cb callback to call when restarted
+* @param cb_cls callback closure
+* @return GNUNET_OK in success otherwise GNUNET_SYSERR
+*/
+int
+GNUNET_TRANSPORT_TESTING_restart_peer (struct GNUNET_TRANSPORT_TESTING_handle
+                                       *tth, struct PeerContext *p,
+                                       const char *cfgname,
+                                       GNUNET_TRANSPORT_TESTING_start_cb
+                                       restart_cb, void *cb_cls)
+{
+  GNUNET_assert (tth != NULL);
+  GNUNET_assert (p != NULL);
+  GNUNET_assert (NULL != p->peer);
+
+  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "transport-testing",
+                   "Restarting peer %u (`%s')\n", p->no, GNUNET_i2s (&p->id));
+
+  /* shutdown */
+  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "transport-testing",
+                   "Stopping peer %u (`%s')\n", p->no, GNUNET_i2s (&p->id));
+  if (NULL != p->ghh)
+    GNUNET_TRANSPORT_get_hello_cancel (p->ghh);
+  p->ghh = NULL;
+
+  if (NULL != p->th)
+    GNUNET_TRANSPORT_disconnect (p->th);
+
+  if (GNUNET_SYSERR == GNUNET_TESTING_peer_stop(p->peer))
+  {
+    GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "transport-testing",
+                     "Failed to stop peer %u (`%s')\n", p->no, GNUNET_i2s (&p->id));
+    return GNUNET_SYSERR;
+  }
+
+  sleep (5);
+
+  /* restart */
+  if (GNUNET_SYSERR == GNUNET_TESTING_peer_start(p->peer))
+  {
+    GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "transport-testing",
+                     "Failed to restart peer %u (`%s')\n",
+                     p->no, GNUNET_i2s (&p->id));
+    return GNUNET_SYSERR;
+  }
+
+  GNUNET_assert (p->th != NULL);
+  GNUNET_assert (p->start_cb == NULL);
+  p->start_cb = restart_cb;
+  p->cb_cls = cb_cls;
+
+  p->th = GNUNET_TRANSPORT_connect (p->cfg, NULL, p,
+                                    &notify_receive,
+                                    &notify_connect,
+                                    &notify_disconnect);
+  GNUNET_assert (NULL != p->th);
+
+  p->ghh = GNUNET_TRANSPORT_get_hello (p->th, &get_hello, p);
+  GNUNET_assert (p->ghh != NULL);
+  return GNUNET_OK;
+}
+
+
 /**
  * shutdown the given peer
+ * @param tth testing handle
  * @param p the peer
  */
 void
@@ -309,58 +411,65 @@ GNUNET_TRANSPORT_TESTING_stop_peer (struct GNUNET_TRANSPORT_TESTING_handle *tth,
                                     struct PeerContext *p)
 {
   GNUNET_assert (p != NULL);
-
   if (p->ghh != NULL)
+  {
     GNUNET_TRANSPORT_get_hello_cancel (p->ghh);
-  p->ghh = NULL;
-
+    p->ghh = NULL;
+  }
   if (p->th != NULL)
-    GNUNET_TRANSPORT_disconnect (p->th);
-
-  if (NULL != p->arm_proc)
   {
-    if (0 != GNUNET_OS_process_kill (p->arm_proc, SIGTERM))
-      GNUNET_log_strerror (GNUNET_ERROR_TYPE_WARNING, "kill");
-    GNUNET_OS_process_wait (p->arm_proc);
-    GNUNET_OS_process_close (p->arm_proc);
-    p->arm_proc = NULL;
+    GNUNET_TRANSPORT_disconnect (p->th);
+    p->th = NULL;
   }
 
-  if (p->servicehome != NULL)
+  if (p->peer != NULL)
   {
-    GNUNET_DISK_directory_remove (p->servicehome);
-    GNUNET_free (p->servicehome);
+    if (GNUNET_OK != GNUNET_TESTING_peer_stop (p->peer))
+    {
+      GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "transport-testing",
+                       "Testing lib failed to stop peer %u (`%s') \n", p->no,
+                       GNUNET_i2s (&p->id));
+    }
+    GNUNET_TESTING_peer_destroy (p->peer);
+    p->peer = NULL;
   }
 
   if (p->hello != NULL)
+  {
     GNUNET_free (p->hello);
-
+    p->hello = NULL;
+  }
   if (p->cfg != NULL)
+  {
     GNUNET_CONFIGURATION_destroy (p->cfg);
-
+    p->cfg = NULL;
+  }
   GNUNET_CONTAINER_DLL_remove (tth->p_head, tth->p_tail, p);
-
+  GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "transport-testing",
+                   "Peer %u (`%s') stopped \n", p->no,
+                   GNUNET_i2s (&p->id));
   GNUNET_free (p);
-  p = NULL;
 }
 
+
 /**
- * Initiate peer p1 to connect to peer p2
- * Get peer p2's HELLO and offer it to p1
- * p1 then tries to connect to p2
+ * Initiate a connection from p1 to p2 by offering p1 p2's HELLO message
+ *
+ * Remarks: start_peer's notify_connect callback can be called before.
+ *
+ * @param tth transport testing handle
  * @param p1 peer 1
  * @param p2 peer 2
  * @param cb the callback to call when both peers notified that they are connected
- * @param cb_cls callback cls (or a pointer to the
- *        GNUNET_TRANSPORT_TESTING_ConnectRequest itself if null)
- * @return connect context
+ * @param cls callback cls
+ * @return a connect request handle
  */
 GNUNET_TRANSPORT_TESTING_ConnectRequest
-GNUNET_TRANSPORT_TESTING_connect_peers (struct GNUNET_TRANSPORT_TESTING_handle
-                                        *tth, struct PeerContext *p1,
+GNUNET_TRANSPORT_TESTING_connect_peers (struct GNUNET_TRANSPORT_TESTING_handle *tth,
+                                        struct PeerContext *p1,
                                         struct PeerContext *p2,
                                         GNUNET_TRANSPORT_TESTING_connect_cb cb,
-                                        void *cb_cls)
+                                        void *cls)
 {
   GNUNET_assert (tth != NULL);
 
@@ -369,35 +478,32 @@ GNUNET_TRANSPORT_TESTING_connect_peers (struct GNUNET_TRANSPORT_TESTING_handle
 
   GNUNET_assert (p1 != NULL);
   GNUNET_assert (p2 != NULL);
-
   cc->p1 = p1;
   cc->p2 = p2;
-
   cc->cb = cb;
-  if (cb_cls != NULL)
-    cc->cb_cls = cb_cls;
+  if (cls != NULL)
+    cc->cb_cls = cls;
   else
     cc->cb_cls = cc;
-
   cc->th_p1 = p1->th;
   cc->th_p2 = p2->th;
-
   GNUNET_assert (cc->th_p1 != NULL);
   GNUNET_assert (cc->th_p2 != NULL);
-
   GNUNET_CONTAINER_DLL_insert (tth->cc_head, tth->cc_tail, cc);
-
   cc->tct = GNUNET_SCHEDULER_add_now (&try_connect, cc);
   GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "transport-testing",
-                   "New connect request %X\n", cc);
+                   "New connect request %p\n", cc);
 
   return cc;
 }
 
+
 /**
  * Cancel the request to connect two peers
  * Tou MUST cancel the request if you stop the peers before the peers connected succesfully
- * @param cc a connect request handle
+ *
+ * @param tth transport testing handle
+ * @param ccr a connect request handle
  */
 void
 GNUNET_TRANSPORT_TESTING_connect_peers_cancel (struct
@@ -411,7 +517,7 @@ GNUNET_TRANSPORT_TESTING_connect_peers_cancel (struct
   GNUNET_assert (tth != NULL);
 
   GNUNET_log_from (GNUNET_ERROR_TYPE_DEBUG, "transport-testing",
-                   "Canceling connect request %X!\n", cc);
+                   "Canceling connect request %p!\n", cc);
 
   if (cc->tct != GNUNET_SCHEDULER_NO_TASK)
     GNUNET_SCHEDULER_cancel (cc->tct);
@@ -440,7 +546,7 @@ GNUNET_TRANSPORT_TESTING_done (struct GNUNET_TRANSPORT_TESTING_handle *tth)
   {
     ct = cc->next;
     GNUNET_log_from (GNUNET_ERROR_TYPE_ERROR, "transport-testing",
-                     "Developer forgot to cancel connect request %X!\n", cc);
+                     "Developer forgot to cancel connect request %p!\n", cc);
     GNUNET_TRANSPORT_TESTING_connect_peers_cancel (tth, cc);
     cc = ct;
   }
@@ -454,10 +560,13 @@ GNUNET_TRANSPORT_TESTING_done (struct GNUNET_TRANSPORT_TESTING_handle *tth)
     p = t;
   }
 
+  GNUNET_TESTING_system_destroy (tth->tl_system, GNUNET_YES);
+
   GNUNET_free (tth);
   tth = NULL;
 }
 
+
 /**
  * Initialize the transport testing
  * @return transport testing handle
@@ -465,8 +574,19 @@ GNUNET_TRANSPORT_TESTING_done (struct GNUNET_TRANSPORT_TESTING_handle *tth)
 struct GNUNET_TRANSPORT_TESTING_handle *
 GNUNET_TRANSPORT_TESTING_init ()
 {
-  struct GNUNET_TRANSPORT_TESTING_handle *tth =
-      GNUNET_malloc (sizeof (struct GNUNET_TRANSPORT_TESTING_handle));
+  struct GNUNET_TRANSPORT_TESTING_handle *tth;
+
+  /* prepare hostkeys */
+  tth = GNUNET_malloc (sizeof (struct GNUNET_TRANSPORT_TESTING_handle));
+
+  /* Init testing the testing lib */
+  tth->tl_system = GNUNET_TESTING_system_create ("transport-testing", NULL, NULL);
+  if (NULL == tth->tl_system)
+  {
+    GNUNET_log (GNUNET_ERROR_TYPE_ERROR, _("Failed to initialize testing library!\n"));
+    GNUNET_free (tth);
+    return NULL;
+  }
 
   return tth;
 }
@@ -488,7 +608,25 @@ extract_filename (const char *file)
   char *backup = pch;
   char *filename = NULL;
   char *res;
-
+#if WINDOWS
+  if ((strlen (pch) >= 3) && pch[1] == ':')
+  {
+    if (NULL != strstr (pch, "\\"))
+    {
+      pch = strtok (pch, "\\");
+      while (pch != NULL)
+      {
+        pch = strtok (NULL, "\\");
+        if (pch != NULL)
+          filename = pch;
+      }
+    }
+  }
+  if (filename != NULL)
+    pch = filename; /* If we miss the next condition, filename = pch will
+                     * not harm us.
+                     */
+#endif
   if (NULL != strstr (pch, "/"))
   {
     pch = strtok (pch, "/");
@@ -509,6 +647,7 @@ extract_filename (const char *file)
   return res;
 }
 
+
 /**
  * Extracts the test filename from an absolute file name and removes the extension
  * @param file absolute file name
@@ -568,7 +707,8 @@ GNUNET_TRANSPORT_TESTING_get_test_source_name (const char *file, char **dest)
 
 
 /**
- * Extracts the plugin anme from an absolute file name and the test name
+ * Extracts the plugin name from an absolute file name and the test name
+ *
  * @param file absolute file name
  * @param test test name
  * @param dest where to store result
@@ -577,48 +717,45 @@ void
 GNUNET_TRANSPORT_TESTING_get_test_plugin_name (const char *file,
                                                const char *test, char **dest)
 {
+  char *filename;
+  char *dotexe;
   char *e = extract_filename (file);
   char *t = extract_filename (test);
 
-  char *filename = NULL;
-  char *dotexe;
-
-  if (e == NULL)
+  if (NULL == e)
     goto fail;
-
   /* remove "lt-" */
   filename = strstr (e, "tes");
-  if (filename == NULL)
+  if (NULL == filename)
     goto fail;
-
   /* remove ".exe" */
   if (NULL != (dotexe = strstr (filename, ".exe")))
     dotexe[0] = '\0';
 
   /* find last _ */
   filename = strstr (filename, t);
-  if (filename == NULL)
+  if (NULL == filename)
     goto fail;
-
   /* copy plugin */
   filename += strlen (t);
-  filename++;
+  if ('\0' != *filename)
+    filename++;
   GNUNET_asprintf (dest, "%s", filename);
   goto suc;
-
 fail:
   (*dest) = NULL;
 suc:
   GNUNET_free (t);
   GNUNET_free (e);
-
 }
 
+
 /**
  * This function takes the filename (e.g. argv[0), removes a "lt-"-prefix and
  * if existing ".exe"-prefix and adds the peer-number
+ *
  * @param file filename of the test, e.g. argv[0]
- * @param cfgname where to write the result
+ * @param dest where to write the filename
  * @param count peer number
  */
 void
@@ -629,30 +766,22 @@ GNUNET_TRANSPORT_TESTING_get_config_name (const char *file, char **dest,
   char *backup = filename;
   char *dotexe;
 
-  if (filename == NULL)
+  if (NULL == filename)
     goto fail;
-
   /* remove "lt-" */
   filename = strstr (filename, "tes");
-  if (filename == NULL)
+  if (NULL == filename)
     goto fail;
-
   /* remove ".exe" */
   if (NULL != (dotexe = strstr (filename, ".exe")))
     dotexe[0] = '\0';
-
-  goto suc;
-
+  GNUNET_asprintf (dest, "%s_peer%u.conf", filename, count);
+  GNUNET_free (backup);
+  return;
 fail:
   (*dest) = NULL;
-  return;
-
-suc:
-  /* create cfg filename */
-  GNUNET_asprintf (dest, "%s_peer%u.conf", filename, count);
   GNUNET_free (backup);
 }
 
 
-
-/* end of transport_testing.h */
+/* end of transport-testing.c */