X-Git-Url: https://git.librecmc.org/?a=blobdiff_plain;f=src%2Ftransport%2Fgnunet-transport.c;h=4feb773986f7cd55c9b91dc7c08eb123c16fa97b;hb=f0a8d26b26cda04518e3555373172f6b4940e489;hp=646b8087b7c7efbcf62ac33d0e9d982ecec42f39;hpb=7e60f24441ae84fe5aa965a09805e25996423886;p=oweals%2Fgnunet.git diff --git a/src/transport/gnunet-transport.c b/src/transport/gnunet-transport.c index 646b8087b..4feb77398 100644 --- a/src/transport/gnunet-transport.c +++ b/src/transport/gnunet-transport.c @@ -1,6 +1,6 @@ /* This file is part of GNUnet. - (C) 2011-2014 Christian Grothoff (and other contributing authors) + Copyright (C) 2011-2014 Christian Grothoff (and other contributing authors) GNUnet is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published @@ -14,8 +14,8 @@ You should have received a copy of the GNU General Public License along with GNUnet; see the file COPYING. If not, write to the - Free Software Foundation, Inc., 59 Temple Place - Suite 330, - Boston, MA 02111-1307, USA. + Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, + Boston, MA 02110-1301, USA. */ /** @@ -66,11 +66,6 @@ struct ValidationResolutionContext */ struct ValidationResolutionContext *prev; - /** - * Peer identity - */ - struct GNUNET_PeerIdentity id; - /** * Address to resolve */ @@ -148,11 +143,6 @@ struct PeerResolutionContext */ struct PeerResolutionContext *prev; - /** - * The peer id - */ - struct GNUNET_PeerIdentity id; - /** * address to resolve */ @@ -208,7 +198,7 @@ struct TestContext /** * Task identifier for the timeout. */ - GNUNET_SCHEDULER_TaskIdentifier tsk; + struct GNUNET_SCHEDULER_Task * tsk; /** * Name of plugin under test. @@ -281,10 +271,15 @@ static struct GNUNET_TRANSPORT_Handle *handle; static struct GNUNET_CONFIGURATION_Handle *cfg; /** - * Try_connect handle + * Try connect handle */ struct GNUNET_TRANSPORT_TryConnectHandle *tc_handle; +/** + * Try disconnect handle + */ +struct GNUNET_TRANSPORT_TryDisconnectHandle *td_handle; + /** * Option -s. */ @@ -419,12 +414,12 @@ static struct GNUNET_PeerIdentity pid; /** * Task scheduled for cleanup / termination of the process. */ -static GNUNET_SCHEDULER_TaskIdentifier end; +static struct GNUNET_SCHEDULER_Task * end; /** * Task for operation timeout */ -static GNUNET_SCHEDULER_TaskIdentifier op_timeout; +static struct GNUNET_SCHEDULER_Task * op_timeout; /** * Selected level of verbosity. @@ -516,12 +511,13 @@ shutdown_task (void *cls, struct GNUNET_TIME_Relative duration; struct ValidationResolutionContext *cur; struct ValidationResolutionContext *next; + struct PeerResolutionContext *rc; - end = GNUNET_SCHEDULER_NO_TASK; - if (GNUNET_SCHEDULER_NO_TASK != op_timeout) + end = NULL; + if (NULL != op_timeout) { GNUNET_SCHEDULER_cancel (op_timeout); - op_timeout = GNUNET_SCHEDULER_NO_TASK; + op_timeout = NULL; } if (NULL != tc_handle) { @@ -550,12 +546,23 @@ shutdown_task (void *cls, next = cur->next; GNUNET_TRANSPORT_address_to_string_cancel (cur->asc); - GNUNET_CONTAINER_DLL_remove (vc_head, vc_tail, cur); + GNUNET_CONTAINER_DLL_remove (vc_head, + vc_tail, + cur); GNUNET_free (cur->transport); GNUNET_HELLO_address_free (cur->addrcp); GNUNET_free (cur); } - + while (NULL != (rc = rc_head)) + { + GNUNET_CONTAINER_DLL_remove (rc_head, + rc_tail, + rc); + GNUNET_TRANSPORT_address_to_string_cancel (rc->asc); + GNUNET_free (rc->transport); + GNUNET_free (rc->addrcp); + GNUNET_free (rc); + } if (NULL != th) { GNUNET_TRANSPORT_notify_transmit_ready_cancel (th); @@ -607,13 +614,13 @@ operation_timeout (void *cls, { struct PeerResolutionContext *cur; struct PeerResolutionContext *next; - op_timeout = GNUNET_SCHEDULER_NO_TASK; + op_timeout = NULL; if ((try_connect) || (benchmark_send) || (benchmark_receive)) { FPRINTF (stdout, _("Failed to connect to `%s'\n"), GNUNET_i2s_full (&pid)); - if (GNUNET_SCHEDULER_NO_TASK != end) + if (NULL != end) GNUNET_SCHEDULER_cancel (end); end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL); ret = 1; @@ -639,7 +646,7 @@ operation_timeout (void *cls, FPRINTF (stdout, "%s", _("Failed to list connections, timeout occured\n")); - if (GNUNET_SCHEDULER_NO_TASK != end) + if (NULL != end) GNUNET_SCHEDULER_cancel (end); end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL); ret = 1; @@ -649,7 +656,7 @@ operation_timeout (void *cls, static void -run_nat_test (); +run_nat_test (void); /** @@ -689,25 +696,15 @@ display_test_result (struct TestContext *tc, tc->name); break; default: + FPRINTF (stderr, + _("Configuration for plugin `%s' did not work!\n"), + tc->name); break; } - - if (GNUNET_YES != result) - { - FPRINTF (stderr, - _("Configuration for plugin `%s' did not work!\n"), - tc->name); - } - else - { - FPRINTF (stderr, - _("Configuration for plugin `%s' is working!\n"), - tc->name); - } - if (GNUNET_SCHEDULER_NO_TASK != tc->tsk) + if (NULL != tc->tsk) { GNUNET_SCHEDULER_cancel (tc->tsk); - tc->tsk = GNUNET_SCHEDULER_NO_TASK; + tc->tsk = NULL; } if (NULL != tc->tst) { @@ -730,6 +727,7 @@ display_test_result (struct TestContext *tc, run_nat_test (); } + /** * Function called by NAT to report the outcome of the nat-test. * Clean up and update GUI. @@ -743,14 +741,14 @@ result_callback (void *cls, { struct TestContext *tc = cls; - display_test_result (tc, result); + display_test_result (tc, + result); } /** * Resolve address we got a validation state for to a string. * - * @param id peer identity the address is for * @param address the address itself * @param numeric #GNUNET_YES to disable DNS, #GNUNET_NO to try reverse lookup * @param last_validation when was the address validated last @@ -759,8 +757,7 @@ result_callback (void *cls, * @param state where are we in the validation state machine */ static void -resolve_validation_address (const struct GNUNET_PeerIdentity *id, - const struct GNUNET_HELLO_Address *address, +resolve_validation_address (const struct GNUNET_HELLO_Address *address, int numeric, struct GNUNET_TIME_Absolute last_validation, struct GNUNET_TIME_Absolute valid_until, @@ -799,10 +796,10 @@ process_validation_string (void *cls, if (GNUNET_SYSERR == res) { FPRINTF (stderr, - "Failed to convert address for peer `%s' plugin `%s' length %lu to string \n", - GNUNET_i2s (&vc->id), + "Failed to convert address for peer `%s' plugin `%s' length %u to string \n", + GNUNET_i2s (&vc->addrcp->peer), vc->addrcp->transport_name, - vc->addrcp->address_length); + (unsigned int) vc->addrcp->address_length); } if (GNUNET_TIME_UNIT_ZERO_ABS.abs_value_us == vc->valid_until.abs_value_us) s_valid = GNUNET_strdup ("never"); @@ -821,7 +818,7 @@ process_validation_string (void *cls, FPRINTF (stdout, _("Peer `%s' %s %s\n\t%s%s\n\t%s%s\n\t%s%s\n"), - GNUNET_i2s (&vc->id), + GNUNET_i2s (&vc->addrcp->peer), (GNUNET_OK == res) ? address : "", (monitor_validation) ? GNUNET_TRANSPORT_vs2s (vc->state) : "", "Valid until : ", s_valid, @@ -845,8 +842,7 @@ process_validation_string (void *cls, (note: this should be unnecessary, as transport should fallback to numeric lookup internally if DNS takes too long anyway) */ - resolve_validation_address (&vc->id, - vc->addrcp, + resolve_validation_address (vc->addrcp, GNUNET_NO, vc->last_validation, vc->valid_until, @@ -857,7 +853,7 @@ process_validation_string (void *cls, { FPRINTF (stdout, _("Peer `%s' %s `%s' \n"), - GNUNET_i2s (&vc->id), + GNUNET_i2s (&vc->addrcp->peer), "", GNUNET_TRANSPORT_vs2s (vc->state)); } @@ -868,15 +864,15 @@ process_validation_string (void *cls, GNUNET_free (vc); if ((0 == address_resolutions) && (iterate_validation)) { - if (GNUNET_SCHEDULER_NO_TASK != end) + if (NULL != end) { GNUNET_SCHEDULER_cancel (end); - end = GNUNET_SCHEDULER_NO_TASK; + end = NULL; } - if (GNUNET_SCHEDULER_NO_TASK != op_timeout) + if (NULL != op_timeout) { GNUNET_SCHEDULER_cancel (op_timeout); - op_timeout = GNUNET_SCHEDULER_NO_TASK; + op_timeout = NULL; } ret = 0; end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL); @@ -887,7 +883,6 @@ process_validation_string (void *cls, /** * Resolve address we got a validation state for to a string. * - * @param id peer identity the address is for * @param address the address itself * @param numeric #GNUNET_YES to disable DNS, #GNUNET_NO to try reverse lookup * @param last_validation when was the address validated last @@ -896,8 +891,7 @@ process_validation_string (void *cls, * @param state where are we in the validation state machine */ static void -resolve_validation_address (const struct GNUNET_PeerIdentity *id, - const struct GNUNET_HELLO_Address *address, +resolve_validation_address (const struct GNUNET_HELLO_Address *address, int numeric, struct GNUNET_TIME_Absolute last_validation, struct GNUNET_TIME_Absolute valid_until, @@ -911,7 +905,6 @@ resolve_validation_address (const struct GNUNET_PeerIdentity *id, GNUNET_CONTAINER_DLL_insert(vc_head, vc_tail, vc); address_resolutions++; - vc->id = (*id); vc->transport = GNUNET_strdup(address->transport_name); vc->addrcp = GNUNET_HELLO_address_copy (address); vc->printed = GNUNET_NO; @@ -933,7 +926,6 @@ resolve_validation_address (const struct GNUNET_PeerIdentity *id, * Resolve address we got a validation state for to a string. * * @param cls NULL - * @param peer peer identity the address is for * @param address the address itself * @param last_validation when was the address validated last * @param valid_until until when is the address valid @@ -942,14 +934,13 @@ resolve_validation_address (const struct GNUNET_PeerIdentity *id, */ static void process_validation_cb (void *cls, - const struct GNUNET_PeerIdentity *peer, const struct GNUNET_HELLO_Address *address, struct GNUNET_TIME_Absolute last_validation, struct GNUNET_TIME_Absolute valid_until, struct GNUNET_TIME_Absolute next_validation, enum GNUNET_TRANSPORT_ValidationState state) { - if ((NULL == peer) && (NULL == address)) + if (NULL == address) { if (monitor_validation) { @@ -958,25 +949,13 @@ process_validation_cb (void *cls, _("Monitor disconnected from transport service. Reconnecting.\n")); return; } - - /* done */ - vic = NULL; - if (GNUNET_SCHEDULER_NO_TASK != end) - GNUNET_SCHEDULER_cancel (end); - end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL); - return; - } - if ((NULL == peer) || (NULL == address)) - { - /* invalid response */ vic = NULL; - if (GNUNET_SCHEDULER_NO_TASK != end) + if (NULL != end) GNUNET_SCHEDULER_cancel (end); end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL); return; } - resolve_validation_address (peer, - address, + resolve_validation_address (address, numeric, last_validation, valid_until, @@ -995,11 +974,12 @@ run_nat_test () (uint16_t) head->adv_port); head->tst = GNUNET_NAT_test_start (cfg, - (0 == strcasecmp (head->name, "udp")) ? GNUNET_NO : GNUNET_YES, - (uint16_t) head->bnd_port, - (uint16_t) head->adv_port, - TIMEOUT, - &result_callback, head); + (0 == strcasecmp (head->name, "udp")) + ? GNUNET_NO : GNUNET_YES, + (uint16_t) head->bnd_port, + (uint16_t) head->adv_port, + TIMEOUT, + &result_callback, head); } @@ -1135,23 +1115,23 @@ notify_connect (void *cls, GNUNET_i2s_full (peer)); ret = 0; - if (GNUNET_SCHEDULER_NO_TASK != op_timeout) + if (NULL != op_timeout) { GNUNET_SCHEDULER_cancel (op_timeout); - op_timeout = GNUNET_SCHEDULER_NO_TASK; + op_timeout = NULL; } - if (GNUNET_SCHEDULER_NO_TASK != end) + if (NULL != end) GNUNET_SCHEDULER_cancel (end); end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL); return; } if (benchmark_send) { - if (GNUNET_SCHEDULER_NO_TASK != op_timeout) + if (NULL != op_timeout) { GNUNET_SCHEDULER_cancel (op_timeout); - op_timeout = GNUNET_SCHEDULER_NO_TASK; + op_timeout = NULL; } if (verbosity > 0) FPRINTF (stdout, @@ -1192,13 +1172,13 @@ notify_disconnect (void *cls, GNUNET_i2s_full (peer)); ret = 0; - if (GNUNET_SCHEDULER_NO_TASK != op_timeout) + if (NULL != op_timeout) { GNUNET_SCHEDULER_cancel (op_timeout); - op_timeout = GNUNET_SCHEDULER_NO_TASK; + op_timeout = NULL; } - if (GNUNET_SCHEDULER_NO_TASK != end) + if (NULL != end) GNUNET_SCHEDULER_cancel (end); end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL); return; @@ -1213,7 +1193,7 @@ notify_disconnect (void *cls, { FPRINTF (stdout, _("Disconnected from peer `%s' while benchmarking\n"), GNUNET_i2s (&pid)); - if (GNUNET_SCHEDULER_NO_TASK != end) + if (NULL != end) GNUNET_SCHEDULER_cancel (end); return; } @@ -1300,9 +1280,17 @@ notify_receive (void *cls, } +/** + * Convert address to a printable format. + * + * @param address the address + * @param numeric #GNUNET_YES to convert to numeric format, #GNUNET_NO + * to try to use reverse DNS + * @param state state the peer is in + * @param state_timeout when will the peer's state expire + */ static void -resolve_peer_address (const struct GNUNET_PeerIdentity *id, - const struct GNUNET_HELLO_Address *address, +resolve_peer_address (const struct GNUNET_HELLO_Address *address, int numeric, enum GNUNET_TRANSPORT_PeerState state, struct GNUNET_TIME_Absolute state_timeout); @@ -1368,11 +1356,11 @@ process_peer_string (void *cls, if (GNUNET_SYSERR == res) { FPRINTF (stderr, - "Failed to convert address for peer `%s' plugin `%s' length %lu to string \n", - GNUNET_i2s (&rc->id), + "Failed to convert address for peer `%s' plugin `%s' length %u to string \n", + GNUNET_i2s (&rc->addrcp->peer), rc->addrcp->transport_name, - rc->addrcp->address_length); - print_info (&rc->id, + (unsigned int) rc->addrcp->address_length); + print_info (&rc->addrcp->peer, rc->transport, NULL, rc->state, @@ -1382,7 +1370,7 @@ process_peer_string (void *cls, } if (GNUNET_OK == res) { - print_info (&rc->id, + print_info (&rc->addrcp->peer, rc->transport, address, rc->state, @@ -1395,6 +1383,7 @@ process_peer_string (void *cls, } /* NULL == address, last call, we are done */ + rc->asc = NULL; GNUNET_assert (address_resolutions > 0); address_resolutions--; if (GNUNET_NO == rc->printed) @@ -1405,15 +1394,14 @@ process_peer_string (void *cls, (note: this should not be needed, as transport should fallback to numeric conversion if DNS takes too long) */ - resolve_peer_address (&rc->id, - rc->addrcp, + resolve_peer_address (rc->addrcp, GNUNET_YES, rc->state, rc->state_timeout); } else { - print_info (&rc->id, + print_info (&rc->addrcp->peer, rc->transport, NULL, rc->state, @@ -1426,25 +1414,35 @@ process_peer_string (void *cls, GNUNET_free (rc); if ((0 == address_resolutions) && (iterate_connections)) { - if (GNUNET_SCHEDULER_NO_TASK != end) + if (NULL != end) { GNUNET_SCHEDULER_cancel (end); - end = GNUNET_SCHEDULER_NO_TASK; + end = NULL; } - if (GNUNET_SCHEDULER_NO_TASK != op_timeout) + if (NULL != op_timeout) { GNUNET_SCHEDULER_cancel (op_timeout); - op_timeout = GNUNET_SCHEDULER_NO_TASK; + op_timeout = NULL; } ret = 0; - end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL); + end = GNUNET_SCHEDULER_add_now (&shutdown_task, + NULL); } } +/** + * Convert address to a printable format and print it + * together with the given state data. + * + * @param address the address + * @param numeric #GNUNET_YES to convert to numeric format, #GNUNET_NO + * to try to use reverse DNS + * @param state state the peer is in + * @param state_timeout when will the peer's state expire + */ static void -resolve_peer_address (const struct GNUNET_PeerIdentity *id, - const struct GNUNET_HELLO_Address *address, +resolve_peer_address (const struct GNUNET_HELLO_Address *address, int numeric, enum GNUNET_TRANSPORT_PeerState state, struct GNUNET_TIME_Absolute state_timeout) @@ -1452,12 +1450,11 @@ resolve_peer_address (const struct GNUNET_PeerIdentity *id, struct PeerResolutionContext *rc; rc = GNUNET_new (struct PeerResolutionContext); - GNUNET_assert(NULL != rc); - GNUNET_CONTAINER_DLL_insert(rc_head, rc_tail, rc); + GNUNET_CONTAINER_DLL_insert (rc_head, + rc_tail, + rc); address_resolutions++; - - rc->id = (*id); - rc->transport = GNUNET_strdup(address->transport_name); + rc->transport = GNUNET_strdup (address->transport_name); rc->addrcp = GNUNET_HELLO_address_copy (address); rc->printed = GNUNET_NO; rc->state = state; @@ -1493,7 +1490,7 @@ process_peer_iteration_cb (void *cls, /* done */ address_resolution_in_progress = GNUNET_NO; pic = NULL; - if (GNUNET_SCHEDULER_NO_TASK != end) + if (NULL != end) GNUNET_SCHEDULER_cancel (end); end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL); return; @@ -1503,7 +1500,7 @@ process_peer_iteration_cb (void *cls, (GNUNET_NO == GNUNET_TRANSPORT_is_connected(state))) return; /* Display only connected peers */ - if (GNUNET_SCHEDULER_NO_TASK != op_timeout) + if (NULL != op_timeout) GNUNET_SCHEDULER_cancel (op_timeout); op_timeout = GNUNET_SCHEDULER_add_delayed (OP_TIMEOUT, &operation_timeout, @@ -1515,9 +1512,16 @@ process_peer_iteration_cb (void *cls, address->transport_name); if (NULL != address) - resolve_peer_address (peer, address, numeric, state, state_timeout); + resolve_peer_address (address, + numeric, + state, + state_timeout); else - print_info (peer, NULL, NULL, state, state_timeout); + print_info (peer, + NULL, + NULL, + state, + state_timeout); } @@ -1536,9 +1540,69 @@ struct PluginMonitorAddress * Resolved address as string. */ char *str; + + /** + * Last event we got and did not yet print because + * @e str was NULL (address not yet resolved). + */ + struct GNUNET_TRANSPORT_SessionInfo si; }; +/** + * Print information about a plugin monitoring event. + * + * @param addr out internal context + * @param info the monitoring information + */ +static void +print_plugin_event_info (struct PluginMonitorAddress *addr, + const struct GNUNET_TRANSPORT_SessionInfo *info) +{ + const char *state; + + switch (info->state) + { + case GNUNET_TRANSPORT_SS_INIT: + state = "INIT"; + break; + case GNUNET_TRANSPORT_SS_HANDSHAKE: + state = "HANDSHAKE"; + break; + case GNUNET_TRANSPORT_SS_UP: + state = "UP"; + break; + case GNUNET_TRANSPORT_SS_UPDATE: + state = "UPDATE"; + break; + case GNUNET_TRANSPORT_SS_DONE: + state = "DONE"; + break; + default: + state = "UNKNOWN"; + break; + } + fprintf (stdout, + "%s: state %s timeout in %s @ %s%s\n", + GNUNET_i2s (&info->address->peer), + state, + GNUNET_STRINGS_relative_time_to_string (GNUNET_TIME_absolute_get_remaining (info->session_timeout), + GNUNET_YES), + addr->str, + (info->is_inbound == GNUNET_YES) ? " (INBOUND)" : ""); + fprintf (stdout, + "%s: queue has %3u messages and %6u bytes\n", + GNUNET_i2s (&info->address->peer), + info->num_msg_pending, + info->num_bytes_pending); + if (0 != GNUNET_TIME_absolute_get_remaining (info->receive_delay).rel_value_us) + fprintf (stdout, + "%s: receiving blocked until %s\n", + GNUNET_i2s (&info->address->peer), + GNUNET_STRINGS_absolute_time_to_string (info->receive_delay)); +} + + /** * Function called with a textual representation of an address. This * function will be called several times with different possible @@ -1570,6 +1634,8 @@ address_cb (void *cls, if (NULL != addr->str) return; addr->str = GNUNET_strdup (address); + print_plugin_event_info (addr, + &addr->si); } @@ -1596,7 +1662,6 @@ plugin_monitoring_cb (void *cls, void **session_ctx, const struct GNUNET_TRANSPORT_SessionInfo *info) { - const char *state; struct PluginMonitorAddress *addr; if ( (NULL == info) && @@ -1628,44 +1693,17 @@ plugin_monitoring_cb (void *cls, addr = GNUNET_new (struct PluginMonitorAddress); addr->asc = GNUNET_TRANSPORT_address_to_string (cfg, info->address, - GNUNET_NO, + numeric, GNUNET_TIME_UNIT_FOREVER_REL, &address_cb, addr); *session_ctx = addr; } - switch (info->state) - { - case GNUNET_TRANSPORT_SS_INIT: - state = "INIT"; - break; - case GNUNET_TRANSPORT_SS_HANDSHAKE: - state = "HANDSHAKE"; - break; - case GNUNET_TRANSPORT_SS_UP: - state = "UP"; - break; - case GNUNET_TRANSPORT_SS_UPDATE: - state = "UPDATE"; - break; - case GNUNET_TRANSPORT_SS_DONE: - state = "DONE"; - break; - default: - state = "UNKNOWN"; - break; - } - fprintf (stdout, - "%s: %s %s (# %u/%u b) blocked until %s timeout in %s [%s]\n", - GNUNET_i2s (&info->address->peer), - addr->str, - (info->is_inbound == GNUNET_YES) ? "<-" : ((info->is_inbound == GNUNET_NO) ? "->" : "<>"), - info->num_msg_pending, - info->num_bytes_pending, - GNUNET_STRINGS_absolute_time_to_string (info->receive_delay), - GNUNET_STRINGS_relative_time_to_string (GNUNET_TIME_absolute_get_remaining (info->session_timeout), - GNUNET_YES), - state); + if (NULL == addr->str) + addr->si = *info; + else + print_plugin_event_info (addr, + info); if (GNUNET_TRANSPORT_SS_DONE == info->state) { if (NULL != addr->asc) @@ -1683,13 +1721,12 @@ plugin_monitoring_cb (void *cls, /** * Function called with information about a peers * - * @param cls closure + * @param cls closure, NULL * @param peer identity of the peer, NULL for final callback when operation done * @param address binary address used to communicate with this peer, * NULL on disconnect or when done * @param state current state this peer is in * @param state_timeout time out for the current state - * */ static void process_peer_monitoring_cb (void *cls, @@ -1708,28 +1745,34 @@ process_peer_monitoring_cb (void *cls, return; } - if (GNUNET_SCHEDULER_NO_TASK != op_timeout) + if (NULL != op_timeout) GNUNET_SCHEDULER_cancel (op_timeout); op_timeout = GNUNET_SCHEDULER_add_delayed (OP_TIMEOUT, &operation_timeout, NULL); - if (NULL == (m = GNUNET_CONTAINER_multipeermap_get (monitored_peers, peer))) + if (NULL == (m = GNUNET_CONTAINER_multipeermap_get (monitored_peers, + peer))) { m = GNUNET_new (struct MonitoredPeer); - GNUNET_CONTAINER_multipeermap_put (monitored_peers, peer, - m, GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_FAST); + GNUNET_CONTAINER_multipeermap_put (monitored_peers, + peer, + m, + GNUNET_CONTAINER_MULTIHASHMAPOPTION_UNIQUE_FAST); } else { if ( (m->state == state) && - (m->state_timeout.abs_value_us == state_timeout.abs_value_us) && - ((NULL == address) && (NULL == m->address))) + (m->state_timeout.abs_value_us == state_timeout.abs_value_us) && + (NULL == address) && + (NULL == m->address) ) { return; /* No real change */ } - if ( (m->state == state) && ((NULL != address) && (NULL != m->address)) && - (0 == GNUNET_HELLO_address_cmp(m->address, address))) + if ( (m->state == state) && + (NULL != address) && + (NULL != m->address) && + (0 == GNUNET_HELLO_address_cmp(m->address, address)) ) return; /* No real change */ } @@ -1744,8 +1787,7 @@ process_peer_monitoring_cb (void *cls, m->state_timeout = state_timeout; if (NULL != address) - resolve_peer_address (peer, - m->address, + resolve_peer_address (m->address, numeric, m->state, m->state_timeout); @@ -1772,11 +1814,9 @@ try_connect_cb (void *cls, { static int retries = 0; + tc_handle = NULL; if (GNUNET_OK == result) - { - tc_handle = NULL; return; - } retries++; if (retries < 10) { @@ -1784,18 +1824,15 @@ try_connect_cb (void *cls, &pid, &try_connect_cb, NULL); - } - else - { - FPRINTF (stderr, - "%s", - _("Failed to send connect request to transport service\n")); - if (GNUNET_SCHEDULER_NO_TASK != end) - GNUNET_SCHEDULER_cancel (end); - ret = 1; - end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL); return; } + FPRINTF (stderr, + "%s", + _("Failed to send connect request to transport service\n")); + if (NULL != end) + GNUNET_SCHEDULER_cancel (end); + ret = 1; + end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL); } @@ -1812,27 +1849,25 @@ try_disconnect_cb (void *cls, const int result) { static int retries = 0; + + td_handle = NULL; if (GNUNET_OK == result) - { - tc_handle = NULL; return; - } retries++; if (retries < 10) - tc_handle = GNUNET_TRANSPORT_try_disconnect (handle, + { + td_handle = GNUNET_TRANSPORT_try_disconnect (handle, &pid, &try_disconnect_cb, NULL); - else - { - FPRINTF (stderr, "%s", - _("Failed to send disconnect request to transport service\n")); - if (GNUNET_SCHEDULER_NO_TASK != end) - GNUNET_SCHEDULER_cancel (end); - ret = 1; - end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL); return; } + FPRINTF (stderr, "%s", + _("Failed to send disconnect request to transport service\n")); + if (NULL != end) + GNUNET_SCHEDULER_cancel (end); + ret = 1; + end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL); } @@ -1933,9 +1968,10 @@ testservice_task (void *cls, ret = 1; return; } - tc_handle = GNUNET_TRANSPORT_try_disconnect (handle, &pid, try_disconnect_cb, - NULL); - if (NULL == tc_handle) + td_handle = GNUNET_TRANSPORT_try_disconnect (handle, &pid, + &try_disconnect_cb, + NULL); + if (NULL == td_handle) { FPRINTF (stderr, "%s", _("Failed to send request to transport service\n")); @@ -2006,11 +2042,14 @@ testservice_task (void *cls, } else if (monitor_connections) /* -m: List information about peers continuously */ { - monitored_peers = GNUNET_CONTAINER_multipeermap_create (10, GNUNET_NO); + monitored_peers = GNUNET_CONTAINER_multipeermap_create (10, + GNUNET_NO); address_resolution_in_progress = GNUNET_YES; - pic = GNUNET_TRANSPORT_monitor_peers (cfg, (NULL == cpid) ? NULL : &pid, - GNUNET_NO, TIMEOUT, - &process_peer_monitoring_cb, (void *) cfg); + pic = GNUNET_TRANSPORT_monitor_peers (cfg, + (NULL == cpid) ? NULL : &pid, + GNUNET_NO, + TIMEOUT, + &process_peer_monitoring_cb, NULL); } else if (monitor_plugins) /* -P: List information about plugins continuously */ {