X-Git-Url: https://git.librecmc.org/?a=blobdiff_plain;f=shell%2Fbbsh.c;h=897c0227cce785504a9dc6076eabab41d3356fad;hb=33f85eeac5a7babc996cacce4485326d46b6e54d;hp=fe27f441839e7e3426e437b0beb3801c5b51fe7d;hpb=06af2165288cd6516b89001ec9e24992619230e0;p=oweals%2Fbusybox.git diff --git a/shell/bbsh.c b/shell/bbsh.c index fe27f4418..897c0227c 100644 --- a/shell/bbsh.c +++ b/shell/bbsh.c @@ -36,7 +36,7 @@ echo `echo hello#comment " woot` and more */ -#include "busybox.h" +#include "libbb.h" // A single executable, its arguments, and other information we know about it. #define BBSH_FLAG_EXIT 1 @@ -68,7 +68,7 @@ struct pipeline { static void free_list(void *list, void (*freeit)(void *data)) { - while(list) { + while (list) { void **next = (void **)list; void *list_next = *next; freeit(list); @@ -90,7 +90,7 @@ static char *parse_word(char *start, struct command **cmd) // Grab next word. (Add dequote and envvar logic here) end = start; - while (*end && !isspace(*end)) end++; + end = skip_non_whitespace(end); (*cmd)->argv[(*cmd)->argc++] = xstrndup(start, end-start); // Allocate more space if there's no room for NULL terminator. @@ -159,16 +159,16 @@ static int run_pipeline(struct pipeline *line) // Handle local commands. This is totally fake and plastic. if (cmd->argc==2 && !strcmp(cmd->argv[0],"cd")) chdir(cmd->argv[1]); - else if(!strcmp(cmd->argv[0],"exit")) + else if (!strcmp(cmd->argv[0],"exit")) exit(cmd->argc>1 ? atoi(cmd->argv[1]) : 0); else { int status; pid_t pid=fork(); - if(!pid) { - run_applet_by_name(cmd->argv[0],cmd->argc,cmd->argv); + if (!pid) { + run_applet_and_exit(cmd->argv[0],cmd->argc,cmd->argv); execvp(cmd->argv[0],cmd->argv); - printf("No %s",cmd->argv[0]); - exit(1); + printf("No %s", cmd->argv[0]); + exit(EXIT_FAILURE); } else waitpid(pid, &status, 0); } @@ -179,7 +179,7 @@ static void free_cmd(void *data) { struct command *cmd=(struct command *)data; - while(cmd->argc) free(cmd->argv[--cmd->argc]); + while (cmd->argc) free(cmd->argv[--cmd->argc]); } @@ -198,21 +198,21 @@ static void handle(char *command) } } -int bbsh_main(int argc, char *argv[]); -int bbsh_main(int argc, char *argv[]) +int bbsh_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; +int bbsh_main(int argc, char **argv) { char *command=NULL; FILE *f; - getopt32(argc, argv, "c:", &command); + getopt32(argv, "c:", &command); - f = argv[optind] ? xfopen(argv[optind],"r") : NULL; + f = argv[optind] ? xfopen_for_read(argv[optind]) : NULL; if (command) handle(command); else { unsigned cmdlen=0; for (;;) { - if(!f) putchar('$'); - if(1 > getline(&command, &cmdlen,f ? : stdin)) break; + if (!f) putchar('$'); + if (1 > getline(&command, &cmdlen,f ? : stdin)) break; handle(command); }