X-Git-Url: https://git.librecmc.org/?a=blobdiff_plain;f=libopkg%2Fopkg.c;h=35ddb89bcebee341774dc75aac8cce4e67e409cc;hb=733d8409723a397b4ced39ea7aaab8bc8b4af5d9;hp=4320ab985dffaaef28a26069994a5a2b13211cb9;hpb=15893c2a54d2101b02533113c7b137170bea5810;p=oweals%2Fopkg-lede.git

diff --git a/libopkg/opkg.c b/libopkg/opkg.c
index 4320ab9..35ddb89 100644
--- a/libopkg/opkg.c
+++ b/libopkg/opkg.c
@@ -27,12 +27,15 @@
 #include "opkg_download.h"
 #include "opkg_remove.h"
 #include "opkg_upgrade.h"
+#include "opkg_error.h"
 
 #include "sprintf_alloc.h"
 #include "file_util.h"
 
 #include <libbb/libbb.h>
 
+struct errlist* error_list;
+
 struct _opkg_t
 {
   args_t *args;
@@ -160,8 +163,7 @@ opkg_package_new ()
 
   opkg_package_t *p;
 
-  p = malloc (sizeof (opkg_package_t));
-  memset (p, 0, sizeof (opkg_package_t));
+  p = calloc (1, sizeof (opkg_package_t));
 
   return p;
 }
@@ -175,6 +177,7 @@ opkg_package_free (opkg_package_t *p)
   free (p->description);
   free (p->tags);
   free (p->url);
+  free (p->repository);
 
   free (p);
 }
@@ -183,13 +186,28 @@ opkg_t *
 opkg_new ()
 {
   opkg_t *opkg;
-  opkg = malloc (sizeof (opkg_t));
+  int err;
 
-  opkg->args = malloc (sizeof (args_t));
-  args_init (opkg->args);
+  opkg = calloc (1, sizeof (opkg_t));
 
-  opkg->conf = malloc (sizeof (opkg_conf_t));
-  opkg_conf_init (opkg->conf, opkg->args);
+  opkg->args = calloc (1, sizeof (args_t));
+  err = args_init (opkg->args);
+  if (err)
+  {
+    free (opkg->args);
+    free (opkg);
+    return NULL;
+  }
+
+  opkg->conf = calloc (1, sizeof (opkg_conf_t));
+  err = opkg_conf_init (opkg->conf, opkg->args);
+  if (err)
+  {
+    free (opkg->conf);
+    free (opkg->args);
+    free (opkg);
+    return NULL;
+  }
 
   opkg_init_options_array (opkg->conf, &opkg->options);
   return opkg;
@@ -202,6 +220,10 @@ opkg_free (opkg_t *opkg)
 
   opkg_conf_deinit (opkg->conf);
   args_deinit (opkg->args);
+  free (opkg->options);
+  free (opkg->args);
+  free (opkg->conf);
+  free (opkg);
 }
 
 int
@@ -230,7 +252,6 @@ opkg_re_read_config_files (opkg_t *opkg)
   a->nodeps = c->nodeps;
   a->noaction = c->noaction;
   a->query_all = c->query_all;
-  a->multiple_providers = c->multiple_providers;
   a->verbosity = c->verbosity;
 
   if (c->offline_root)
@@ -251,6 +272,12 @@ opkg_re_read_config_files (opkg_t *opkg)
     a->offline_root_post_script_cmd = strdup (c->offline_root_post_script_cmd);
   }
 
+  if (c->cache) {
+    if (a->cache)
+	free (a->cache);
+    a->cache = strdup(c->cache);
+  }
+
   /* throw away old opkg_conf and start again */
   opkg_conf_deinit (opkg->conf);
   opkg_conf_init (opkg->conf, opkg->args);
@@ -359,9 +386,12 @@ int
 opkg_install_package (opkg_t *opkg, const char *package_name, opkg_progress_callback_t progress_callback, void *user_data)
 {
   int err;
-  char *package_id = NULL;
+  char *stripped_filename;
   opkg_progress_data_t pdata;
-  pkg_t *new;
+  pkg_t *old, *new;
+  pkg_vec_t *deps, *all;
+  int i, ndepends;
+  char **unresolved = NULL;
 
   opkg_assert (opkg != NULL);
   opkg_assert (package_name != NULL);
@@ -369,45 +399,139 @@ opkg_install_package (opkg_t *opkg, const char *package_name, opkg_progress_call
   /* ... */
   pkg_info_preinstall_check (opkg->conf);
 
-  new = pkg_hash_fetch_best_installation_candidate_by_name (opkg->conf, package_name);
 
+  /* check to ensure package is not already installed */
+  old = pkg_hash_fetch_installed_by_name(&opkg->conf->pkg_hash, package_name);
+  if (old)
+  {
+    /* XXX: Error: Package is already installed. */
+    return OPKG_PACKAGE_ALREADY_INSTALLED;
+  }
+
+  new = pkg_hash_fetch_best_installation_candidate_by_name(opkg->conf, package_name, NULL);
   if (!new)
   {
     /* XXX: Error: Could not find package to install */
-    return 1;
+    return OPKG_PACKAGE_NOT_FOUND;
   }
+
+  new->state_flag |= SF_USER;
+
   pdata.action = OPKG_INSTALL;
   pdata.package = old_pkg_to_new (new);
 
   progress (pdata, 0);
 
-  /* download the package */
-  opkg_prepare_url_for_install (opkg->conf, package_name, &package_id);
-
-  progress (pdata, 50);
+  /* find dependancies and download them */
+  deps = pkg_vec_alloc ();
+  /* this function does not return the original package, so we insert it later */
+  ndepends = pkg_hash_fetch_unsatisfied_dependencies (opkg->conf, new, deps, &unresolved);
+  if (unresolved)
+  {
+    /* XXX: Error: Could not satisfy dependencies */
+    pkg_vec_free (deps);
+    return OPKG_DEPENDENCIES_FAILED;
+  }
 
-  if (!package_id)
-    package_id = strdup (package_name);
+  /* insert the package we are installing so that we download it */
+  pkg_vec_insert (deps, new);
 
-  /* unpack the package */
-  if (opkg->conf->multiple_providers)
+  /* download package and dependancies */
+  for (i = 0; i < deps->len; i++)
   {
-    err = opkg_install_multi_by_name (opkg->conf, package_id);
+    pkg_t *pkg;
+    struct _curl_cb_data cb_data;
+    char *url;
+
+    pkg = deps->pkgs[i];
+    if (pkg->local_filename)
+      continue;
+
+    opkg_package_free (pdata.package);
+    pdata.package = old_pkg_to_new (pkg);
+    pdata.action = OPKG_DOWNLOAD;
+
+    if (pkg->src == NULL)
+    {
+      /* XXX: Error: Package not available from any configured src */
+      return OPKG_PACKAGE_NOT_AVAILABLE;
+    }
+
+    sprintf_alloc(&url, "%s/%s", pkg->src->value, pkg->filename);
+
+    /* Get the filename part, without any directory */
+    stripped_filename = strrchr(pkg->filename, '/');
+    if ( ! stripped_filename )
+        stripped_filename = pkg->filename;
+
+    sprintf_alloc(&pkg->local_filename, "%s/%s", opkg->conf->tmp_dir, stripped_filename);
+
+    cb_data.cb = progress_callback;
+    cb_data.progress_data = &pdata;
+    cb_data.opkg = opkg;
+    cb_data.user_data = user_data;
+    /* 75% of "install" progress is for downloading */
+    cb_data.start_range = 75 * i / deps->len;
+    cb_data.finish_range = 75 * (i + 1) / deps->len;
+
+    err = opkg_download(opkg->conf, url, pkg->local_filename,
+              (curl_progress_func) curl_progress_cb, &cb_data);
+    free(url);
+
+    if (err)
+    {
+      pkg_vec_free (deps);
+      opkg_package_free (pdata.package);
+      return OPKG_DOWNLOAD_FAILED;
+    }
+
   }
-  else
+  pkg_vec_free (deps);
+
+  /* clear depenacy checked marks, left by pkg_hash_fetch_unsatisfied_dependencies */
+  all = pkg_vec_alloc ();
+  pkg_hash_fetch_available (&opkg->conf->pkg_hash, all);
+  for (i = 0; i < all->len; i++)
   {
-    err = opkg_install_by_name (opkg->conf, package_id);
+    all->pkgs[i]->parent->dependencies_checked = 0;
   }
+  pkg_vec_free (all);
+
+
+  /* 75% of "install" progress is for downloading */
+  opkg_package_free (pdata.package);
+  pdata.package = old_pkg_to_new (new);
+  pdata.action = OPKG_INSTALL;
+  progress (pdata, 75);
+
+  /* unpack the package */
+  err = opkg_install_pkg(opkg->conf, new, 0);
 
   if (err)
-    return err;
+  {
+    opkg_package_free (pdata.package);
+    switch (err)
+    {
+      case OPKG_INSTALL_ERR_NOT_TRUSTED: return OPKG_GPG_ERROR;
+      case OPKG_INSTALL_ERR_DOWNLOAD: return OPKG_DOWNLOAD_FAILED;
+      case OPKG_INSTALL_ERR_DEPENDENCIES:
+      case OPKG_INSTALL_ERR_CONFLICTS: return OPKG_DEPENDENCIES_FAILED;
+      case OPKG_INSTALL_ERR_ALREADY_INSTALLED: return OPKG_PACKAGE_ALREADY_INSTALLED;
+      case OPKG_INSTALL_ERR_SIGNATURE: return OPKG_GPG_ERROR;
+      case OPKG_INSTALL_ERR_MD5: return OPKG_MD5_ERROR;
+      default: return OPKG_UNKNOWN_ERROR;
+    }
+  }
 
   progress (pdata, 75);
 
   /* run configure scripts, etc. */
   err = opkg_configure_packages (opkg->conf, NULL);
   if (err)
-    return err;
+  {
+    opkg_package_free (pdata.package);
+    return OPKG_UNKNOWN_ERROR;
+  }
 
   /* write out status files and file lists */
   opkg_conf_write_status_files (opkg->conf);
@@ -421,6 +545,7 @@ opkg_install_package (opkg_t *opkg, const char *package_name, opkg_progress_call
 int
 opkg_remove_package (opkg_t *opkg, const char *package_name, opkg_progress_callback_t progress_callback, void *user_data)
 {
+  int err;
   pkg_t *pkg = NULL;
   pkg_t *pkg_to_remove;
   opkg_progress_data_t pdata;
@@ -428,17 +553,14 @@ opkg_remove_package (opkg_t *opkg, const char *package_name, opkg_progress_callb
   opkg_assert (opkg != NULL);
   opkg_assert (package_name != NULL);
 
-
-
   pkg_info_preinstall_check (opkg->conf);
 
-
   pkg = pkg_hash_fetch_installed_by_name (&opkg->conf->pkg_hash, package_name);
 
   if (pkg == NULL)
   {
     /* XXX: Error: Package not installed. */
-    return 1;
+    return OPKG_PACKAGE_NOT_INSTALLED;
   }
 
   pdata.action = OPKG_REMOVE;
@@ -449,7 +571,8 @@ opkg_remove_package (opkg_t *opkg, const char *package_name, opkg_progress_callb
   if (pkg->state_status == SS_NOT_INSTALLED)
   {
     /* XXX:  Error: Package seems to be not installed (STATUS = NOT_INSTALLED). */
-    return 1;
+    opkg_package_free (pdata.package);
+    return OPKG_PACKAGE_NOT_INSTALLED;
   }
   progress (pdata, 25);
 
@@ -467,7 +590,7 @@ opkg_remove_package (opkg_t *opkg, const char *package_name, opkg_progress_callb
 
   progress (pdata, 75);
 
-  opkg_remove_pkg (opkg->conf, pkg_to_remove, 0);
+  err = opkg_remove_pkg (opkg->conf, pkg_to_remove, 0);
 
   /* write out status files and file lists */
   opkg_conf_write_status_files (opkg->conf);
@@ -476,12 +599,13 @@ opkg_remove_package (opkg_t *opkg, const char *package_name, opkg_progress_callb
 
   progress (pdata, 100);
   opkg_package_free (pdata.package);
-  return 0;
+  return (err) ? OPKG_UNKNOWN_ERROR : OPKG_NO_ERROR;
 }
 
 int
 opkg_upgrade_package (opkg_t *opkg, const char *package_name, opkg_progress_callback_t progress_callback, void *user_data)
 {
+  int err;
   pkg_t *pkg;
   opkg_progress_data_t pdata;
 
@@ -500,7 +624,7 @@ opkg_upgrade_package (opkg_t *opkg, const char *package_name, opkg_progress_call
     if (pkg == NULL)
     {
       /* XXX: Error: Package not installed in default_dest */
-      return 1;
+      return OPKG_PACKAGE_NOT_INSTALLED;
     }
   }
   else
@@ -512,17 +636,43 @@ opkg_upgrade_package (opkg_t *opkg, const char *package_name, opkg_progress_call
   if (!pkg)
   {
     /* XXX: Error: Package not installed */
-    return 1;
+    return OPKG_PACKAGE_NOT_INSTALLED;
   }
 
   pdata.action = OPKG_INSTALL;
   pdata.package = old_pkg_to_new (pkg);
   progress (pdata, 0);
 
-  opkg_upgrade_pkg (opkg->conf, pkg);
+  err = opkg_upgrade_pkg (opkg->conf, pkg);
+  /* opkg_upgrade_pkg returns the error codes of opkg_install_pkg */
+  if (err)
+  {
+
+    opkg_package_free (pdata.package);
+    switch (err)
+    {
+      case OPKG_INSTALL_ERR_NOT_TRUSTED: return OPKG_GPG_ERROR;
+      case OPKG_INSTALL_ERR_DOWNLOAD: return OPKG_DOWNLOAD_FAILED;
+      case OPKG_INSTALL_ERR_DEPENDENCIES:
+      case OPKG_INSTALL_ERR_CONFLICTS: return OPKG_DEPENDENCIES_FAILED;
+      case OPKG_INSTALL_ERR_ALREADY_INSTALLED: return OPKG_PACKAGE_ALREADY_INSTALLED;
+      case OPKG_INSTALL_ERR_SIGNATURE: return OPKG_GPG_ERROR;
+      case OPKG_INSTALL_ERR_MD5: return OPKG_MD5_ERROR;
+      default: return OPKG_UNKNOWN_ERROR;
+    }
+  }
   progress (pdata, 75);
 
-  opkg_configure_packages (opkg->conf, NULL);
+  err = opkg_configure_packages (opkg->conf, NULL);
+  if (err) {
+    opkg_package_free (pdata.package);  
+    return OPKG_UNKNOWN_ERROR;
+  }
+
+  /* write out status files and file lists */
+  opkg_conf_write_status_files (opkg->conf);
+  pkg_write_changed_filelists (opkg->conf);
+
   progress (pdata, 100);
   opkg_package_free (pdata.package);
   return 0;
@@ -575,7 +725,7 @@ int
 opkg_update_package_lists (opkg_t *opkg, opkg_progress_callback_t progress_callback, void *user_data)
 {
   char *tmp;
-  int err;
+  int err, result = 0;
   char *lists_dir;
   pkg_src_list_elt_t *iter;
   pkg_src_t *src;
@@ -621,7 +771,7 @@ opkg_update_package_lists (opkg_t *opkg, opkg_progress_callback_t progress_callb
     return 1;
   }
 
-  /* cout the number of sources so we can give some progress updates */
+  /* count the number of sources so we can give some progress updates */
   sources_list_count = 0;
   sources_done = 0;
   iter = opkg->conf->pkg_src_list.head;
@@ -633,7 +783,7 @@ opkg_update_package_lists (opkg_t *opkg, opkg_progress_callback_t progress_callb
 
   for (iter = opkg->conf->pkg_src_list.head; iter; iter = iter->next)
   {
-    char *url, *list_file_name;
+    char *url, *list_file_name = NULL;
 
     src = iter->data;
 
@@ -646,9 +796,9 @@ opkg_update_package_lists (opkg_t *opkg, opkg_progress_callback_t progress_callb
     sprintf_alloc (&list_file_name, "%s/%s", lists_dir, src->name);
     if (src->gzip)
     {
-      char *tmp_file_name;
       FILE *in, *out;
       struct _curl_cb_data cb_data;
+      char *tmp_file_name = NULL;
 
       sprintf_alloc (&tmp_file_name, "%s/%s.gz", tmp, src->name);
 
@@ -678,6 +828,7 @@ opkg_update_package_lists (opkg_t *opkg, opkg_progress_callback_t progress_callb
           fclose (out);
         unlink (tmp_file_name);
       }
+      free (tmp_file_name);
     }
     else
       err = opkg_download (opkg->conf, url, list_file_name, NULL, NULL);
@@ -685,10 +836,12 @@ opkg_update_package_lists (opkg_t *opkg, opkg_progress_callback_t progress_callb
     if (err)
     {
       /* XXX: Error: download error */
+      result = OPKG_DOWNLOAD_FAILED;
     }
     free (url);
 
 #ifdef HAVE_GPGME
+    char *sig_file_name;
     /* download detached signitures to verify the package lists */
     /* get the url for the sig file */
     if (src->extra_data)  /* debian style? */
@@ -697,12 +850,13 @@ opkg_update_package_lists (opkg_t *opkg, opkg_progress_callback_t progress_callb
     else
       sprintf_alloc (&url, "%s/%s", src->value, "Packages.sig");
 
-    /* create temporary file for it */
-    char *tmp_file_name;
+    /* create filename for signature */
+    sprintf_alloc (&sig_file_name, "%s/%s.sig", lists_dir, src->name);
 
-    sprintf_alloc (&tmp_file_name, "%s/%s", tmp, "Packages.sig");
+    /* make sure there is no existing signature file */
+    unlink (sig_file_name);
 
-    err = opkg_download (opkg->conf, url, tmp_file_name, NULL, NULL);
+    err = opkg_download (opkg->conf, url, sig_file_name, NULL, NULL);
     if (err)
     {
       /* XXX: Warning: Download failed */
@@ -710,7 +864,7 @@ opkg_update_package_lists (opkg_t *opkg, opkg_progress_callback_t progress_callb
     else
     {
       int err;
-      err = opkg_verify_file (opkg->conf, list_file_name, tmp_file_name);
+      err = opkg_verify_file (opkg->conf, list_file_name, sig_file_name);
       if (err == 0)
       {
         /* XXX: Notice: Signature check passed */
@@ -720,15 +874,14 @@ opkg_update_package_lists (opkg_t *opkg, opkg_progress_callback_t progress_callb
         /* XXX: Warning: Signature check failed */
       }
     }
-    unlink (tmp_file_name);
-    free (tmp_file_name);
+    free (sig_file_name);
+    free (list_file_name);
     free (url);
 #else
-    /* XXX: Note: Signiture check for %s skipped because GPG support was not
+    /* XXX: Note: Signature check for %s skipped because GPG support was not
      * enabled in this build
      */
 #endif
-    free (list_file_name);
 
     sources_done++;
     progress (pdata, 100 * sources_done / sources_list_count);
@@ -738,7 +891,10 @@ opkg_update_package_lists (opkg_t *opkg, opkg_progress_callback_t progress_callb
   free (tmp);
   free (lists_dir);
 
-  return 0;
+  /* Now re-read the package lists to update package hash tables. */
+  opkg_re_read_config_files (opkg);
+
+  return result;
 }
 
 
@@ -762,6 +918,7 @@ opkg_list_packages (opkg_t *opkg, opkg_package_callback_t callback, void *user_d
 
     package = old_pkg_to_new (pkg);
     callback (opkg, package, user_data);
+    opkg_package_free (package);
   }
 
   pkg_vec_free (all);
@@ -778,6 +935,9 @@ opkg_list_upgradable_packages (opkg_t *opkg, opkg_package_callback_t callback, v
   opkg_assert (opkg);
   opkg_assert (callback);
 
+  /* ensure all data is valid */
+  pkg_info_preinstall_check (opkg->conf);
+
   all = pkg_vec_alloc ();
   pkg_hash_fetch_available (&opkg->conf->pkg_hash, all);
   for (i = 0; i < all->len; i++)
@@ -791,7 +951,7 @@ opkg_list_upgradable_packages (opkg_t *opkg, opkg_package_callback_t callback, v
     if (old->state_status != SS_INSTALLED)
       continue;
 
-    new = pkg_hash_fetch_best_installation_candidate_by_name(opkg->conf, old->name);
+    new = pkg_hash_fetch_best_installation_candidate_by_name(opkg->conf, old->name, NULL);
     if (new == NULL) {
       /* XXX: Notice: Assuming locally install package is up to date */
       continue;
@@ -803,6 +963,7 @@ opkg_list_upgradable_packages (opkg_t *opkg, opkg_package_callback_t callback, v
     {
       package = old_pkg_to_new (new);
       callback (opkg, package, user_data);
+      opkg_package_free (package);
     }
   }
 
@@ -866,3 +1027,68 @@ opkg_find_package (opkg_t *opkg, const char *name, const char *ver, const char *
 
   return package;
 }
+
+#include <curl/curl.h>
+/**
+ * @brief Check the accessibility of repositories. It will try to access the repository to check if the respository is accessible throught current network status. 
+ * @param opkg The opkg_t
+ * @return return how many repositories cannot access. 0 means all okay. 
+ */ 
+int opkg_repository_accessibility_check(opkg_t *opkg) 
+{
+  pkg_src_list_elt_t *iter;
+  str_list_elt_t *iter1;
+  str_list_t *src;
+  int repositories=0;
+  int ret=0;
+  int err;
+  char *repo_ptr;
+  char *stmp;
+  opkg_assert(opkg != NULL);
+
+  src = str_list_alloc();
+
+  for (iter = opkg->conf->pkg_src_list.head; iter; iter = iter->next) 
+  {
+    if (strstr(iter->data->value, "://") && 
+		    index(strstr(iter->data->value, "://") + 3, '/')) 
+      stmp = strndup(iter->data->value, 
+		      (index(strstr(iter->data->value, "://") + 3, '/') - iter->data->value)*sizeof(char));
+
+    else
+      stmp = strdup(iter->data->value);
+
+    for (iter1 = src->head; iter1; iter1 = iter1->next)
+    {
+      if (strstr(iter1->data, stmp)) 
+        break;
+    }
+    if (iter1)
+      continue;
+
+    sprintf_alloc(&repo_ptr, "%s/index.html",stmp);
+    free(stmp);
+
+    str_list_append(src, repo_ptr);
+    repositories++;
+  }
+  while (repositories > 0) 
+  {
+    iter1 = str_list_pop(src);
+    repositories--;
+
+    err = opkg_download(opkg->conf, iter1->data, "/dev/null", NULL, NULL);
+    if (!(err == CURLE_OK || 
+		err == CURLE_HTTP_RETURNED_ERROR || 
+		err == CURLE_FILE_COULDNT_READ_FILE ||
+		err == CURLE_REMOTE_FILE_NOT_FOUND || 
+		err == CURLE_TFTP_NOTFOUND
+		)) {
+	    ret++;
+    }
+    str_list_elt_deinit(iter1);
+    free(iter1);
+  }
+  free(src);
+  return ret;
+}