X-Git-Url: https://git.librecmc.org/?a=blobdiff_plain;f=drivers%2Fusb%2Fgadget%2Fatmel_usba_udc.c;h=c9d483318fe8aade5429ac9560697fcc7cf597a4;hb=f68c8e827c26d2911224f5abaa68a94faed07d3e;hp=c99208d10200d17a5729d2f16ce39c6be76bab1b;hpb=3be2bdf5dc69b3142c1162a59bc67191c9077567;p=oweals%2Fu-boot.git diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c index c99208d102..c9d483318f 100644 --- a/drivers/usb/gadget/atmel_usba_udc.c +++ b/drivers/usb/gadget/atmel_usba_udc.c @@ -1,15 +1,14 @@ +// SPDX-License-Identifier: GPL-2.0+ /* * Driver for the Atmel USBA high speed USB device controller * [Original from Linux kernel: drivers/usb/gadget/atmel_usba_udc.c] * * Copyright (C) 2005-2013 Atmel Corporation * Bo Shen - * - * SPDX-License-Identifier: GPL-2.0+ */ #include -#include +#include #include #include #include @@ -171,7 +170,7 @@ usba_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc) { struct usba_ep *ep = to_usba_ep(_ep); struct usba_udc *udc = ep->udc; - unsigned long flags, ept_cfg, maxpacket; + unsigned long flags = 0, ept_cfg, maxpacket; unsigned int nr_trans; DBG(DBG_GADGET, "%s: ep_enable: desc=%p\n", ep->ep.name, desc); @@ -274,7 +273,7 @@ static int usba_ep_disable(struct usb_ep *_ep) struct usba_ep *ep = to_usba_ep(_ep); struct usba_udc *udc = ep->udc; LIST_HEAD(req_list); - unsigned long flags; + unsigned long flags = 0; DBG(DBG_GADGET, "ep_disable: %s\n", ep->ep.name); @@ -314,7 +313,7 @@ usba_ep_alloc_request(struct usb_ep *_ep, gfp_t gfp_flags) DBG(DBG_GADGET, "ep_alloc_request: %p, 0x%x\n", _ep, gfp_flags); - req = malloc(sizeof(struct usba_request)); + req = calloc(1, sizeof(struct usba_request)); if (!req) return NULL; @@ -339,7 +338,7 @@ usba_ep_queue(struct usb_ep *_ep, struct usb_request *_req, gfp_t gfp_flags) struct usba_request *req = to_usba_req(_req); struct usba_ep *ep = to_usba_ep(_ep); struct usba_udc *udc = ep->udc; - unsigned long flags; + unsigned long flags = 0; int ret; DBG(DBG_GADGET | DBG_QUEUE | DBG_REQ, "%s: queue req %p, len %u\n", @@ -401,7 +400,7 @@ static int usba_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req) static int usba_ep_set_halt(struct usb_ep *_ep, int value) { struct usba_ep *ep = to_usba_ep(_ep); - unsigned long flags; + unsigned long flags = 0; int ret = 0; DBG(DBG_GADGET, "endpoint %s: %s HALT\n", ep->ep.name, @@ -480,7 +479,7 @@ static int usba_udc_get_frame(struct usb_gadget *gadget) static int usba_udc_wakeup(struct usb_gadget *gadget) { struct usba_udc *udc = to_usba_udc(gadget); - unsigned long flags; + unsigned long flags = 0; u32 ctrl; int ret = -EINVAL; @@ -499,7 +498,7 @@ static int usba_udc_set_selfpowered(struct usb_gadget *gadget, int is_selfpowered) { struct usba_udc *udc = to_usba_udc(gadget); - unsigned long flags; + unsigned long flags = 0; spin_lock_irqsave(&udc->lock, flags); if (is_selfpowered) @@ -1062,7 +1061,6 @@ static void usba_ep_irq(struct usba_udc *udc, struct usba_ep *ep) if ((epstatus & epctrl) & USBA_RX_BK_RDY) { DBG(DBG_BUS, "%s: RX data ready\n", ep->ep.name); receive_data(ep); - usba_ep_writel(ep, CLR_STA, USBA_RX_BK_RDY); } } @@ -1200,7 +1198,7 @@ static struct usba_udc controller = { }, }; -int usb_gadget_handle_interrupts(void) +int usb_gadget_handle_interrupts(int index) { struct usba_udc *udc = &controller; @@ -1229,7 +1227,7 @@ int usb_gadget_register_driver(struct usb_gadget_driver *driver) ret = driver->bind(&udc->gadget); if (ret) { - error("driver->bind() returned %d\n", ret); + pr_err("driver->bind() returned %d\n", ret); udc->driver = NULL; } @@ -1241,7 +1239,7 @@ int usb_gadget_unregister_driver(struct usb_gadget_driver *driver) struct usba_udc *udc = &controller; if (!driver || !driver->unbind || !driver->disconnect) { - error("bad paramter\n"); + pr_err("bad paramter\n"); return -EINVAL; } @@ -1262,7 +1260,7 @@ static struct usba_ep *usba_udc_pdata(struct usba_platform_data *pdata, eps = malloc(sizeof(struct usba_ep) * pdata->num_ep); if (!eps) { - error("failed to alloc eps\n"); + pr_err("failed to alloc eps\n"); return NULL; }