X-Git-Url: https://git.librecmc.org/?a=blobdiff_plain;f=crypto%2Fhmac%2Fhmactest.c;h=5a573950a453827826988a0e733bcf4925cbc507;hb=e4c2e4cb69224051fda663e52e48c00b2ca8f60f;hp=f9c84a725ac99a0a61d2a6013e2ee5e3b87f1490;hpb=b7279ed55c8bc11f78123f987e46f7772bd2047c;p=oweals%2Fopenssl.git

diff --git a/crypto/hmac/hmactest.c b/crypto/hmac/hmactest.c
index f9c84a725a..5a573950a4 100644
--- a/crypto/hmac/hmactest.c
+++ b/crypto/hmac/hmactest.c
@@ -173,50 +173,56 @@ int main(int argc, char *argv[])
 
 /* test4 */
     HMAC_CTX_init(&ctx);
-    if(HMAC_Init_ex(&ctx, NULL, 0, NULL, NULL)) {
+    if (HMAC_Init_ex(&ctx, NULL, 0, NULL, NULL)) {
         printf("Should fail to initialise HMAC with empty MD and key (test 4)\n");
         err++;
         goto test5;
     }
-    if(HMAC_Update(&ctx, test[4].data, test[4].data_len)) {
+    if (HMAC_Update(&ctx, test[4].data, test[4].data_len)) {
         printf("Should fail HMAC_Update with ctx not set up (test 4)\n");
         err++;
         goto test5;
     }
-    if(HMAC_Init_ex(&ctx, NULL, 0, EVP_sha1(), NULL)) {
+    if (HMAC_Init_ex(&ctx, NULL, 0, EVP_sha1(), NULL)) {
         printf("Should fail to initialise HMAC with empty key (test 4)\n");
         err++;
         goto test5;
     }
-    if(HMAC_Update(&ctx, test[4].data, test[4].data_len)) {
+    if (HMAC_Update(&ctx, test[4].data, test[4].data_len)) {
         printf("Should fail HMAC_Update with ctx not set up (test 4)\n");
         err++;
         goto test5;
     }
     printf("test 4 ok\n");
 test5:
+    HMAC_CTX_cleanup(&ctx);
     HMAC_CTX_init(&ctx);
-    if(HMAC_Init_ex(&ctx, test[4].key, test[4].key_len, NULL, NULL)) {
+    if (HMAC_Init_ex(&ctx, test[4].key, test[4].key_len, NULL, NULL)) {
         printf("Should fail to initialise HMAC with empty MD (test 5)\n");
         err++;
         goto test6;
     }
-    if(HMAC_Update(&ctx, test[4].data, test[4].data_len)) {
+    if (HMAC_Update(&ctx, test[4].data, test[4].data_len)) {
         printf("Should fail HMAC_Update with ctx not set up (test 5)\n");
         err++;
         goto test6;
     }
-    if(!HMAC_Init_ex(&ctx, test[4].key, test[4].key_len, EVP_sha1(), NULL)) {
+    if (HMAC_Init_ex(&ctx, test[4].key, -1, EVP_sha1(), NULL)) {
+        printf("Should fail to initialise HMAC with invalid key len(test 5)\n");
+        err++;
+        goto test6;
+    }
+    if (!HMAC_Init_ex(&ctx, test[4].key, test[4].key_len, EVP_sha1(), NULL)) {
         printf("Failed to initialise HMAC (test 5)\n");
         err++;
         goto test6;
     }
-    if(!HMAC_Update(&ctx, test[4].data, test[4].data_len)) {
+    if (!HMAC_Update(&ctx, test[4].data, test[4].data_len)) {
         printf("Error updating HMAC with data (test 5)\n");
         err++;
         goto test6;
     }
-    if(!HMAC_Final(&ctx, buf, &len)) {
+    if (!HMAC_Final(&ctx, buf, &len)) {
         printf("Error finalising data (test 5)\n");
         err++;
         goto test6;
@@ -228,17 +234,22 @@ test5:
         err++;
         goto test6;
     }
-    if(!HMAC_Init_ex(&ctx, NULL, 0, EVP_sha256(), NULL)) {
+    if (HMAC_Init_ex(&ctx, NULL, 0, EVP_sha256(), NULL)) {
+        printf("Should disallow changing MD without a new key (test 5)\n");
+        err++;
+        goto test6;
+    }
+    if (!HMAC_Init_ex(&ctx, test[4].key, test[4].key_len, EVP_sha256(), NULL)) {
         printf("Failed to reinitialise HMAC (test 5)\n");
         err++;
         goto test6;
     }
-    if(!HMAC_Update(&ctx, test[5].data, test[5].data_len)) {
+    if (!HMAC_Update(&ctx, test[5].data, test[5].data_len)) {
         printf("Error updating HMAC with data (sha256) (test 5)\n");
         err++;
         goto test6;
     }
-    if(!HMAC_Final(&ctx, buf, &len)) {
+    if (!HMAC_Final(&ctx, buf, &len)) {
         printf("Error finalising data (sha256) (test 5)\n");
         err++;
         goto test6;
@@ -250,17 +261,17 @@ test5:
         err++;
         goto test6;
     }
-    if(!HMAC_Init_ex(&ctx, test[6].key, test[6].key_len, NULL, NULL)) {
+    if (!HMAC_Init_ex(&ctx, test[6].key, test[6].key_len, NULL, NULL)) {
         printf("Failed to reinitialise HMAC with key (test 5)\n");
         err++;
         goto test6;
     }
-    if(!HMAC_Update(&ctx, test[6].data, test[6].data_len)) {
+    if (!HMAC_Update(&ctx, test[6].data, test[6].data_len)) {
         printf("Error updating HMAC with data (new key) (test 5)\n");
         err++;
         goto test6;
     }
-    if(!HMAC_Final(&ctx, buf, &len)) {
+    if (!HMAC_Final(&ctx, buf, &len)) {
         printf("Error finalising data (new key) (test 5)\n");
         err++;
         goto test6;
@@ -274,23 +285,24 @@ test5:
         printf("test 5 ok\n");
     }
 test6:
+    HMAC_CTX_cleanup(&ctx);
     HMAC_CTX_init(&ctx);
-    if(!HMAC_Init_ex(&ctx, test[7].key, test[7].key_len, EVP_sha1(), NULL)) {
+    if (!HMAC_Init_ex(&ctx, test[7].key, test[7].key_len, EVP_sha1(), NULL)) {
         printf("Failed to initialise HMAC (test 6)\n");
         err++;
         goto end;
     }
-    if(!HMAC_Update(&ctx, test[7].data, test[7].data_len)) {
+    if (!HMAC_Update(&ctx, test[7].data, test[7].data_len)) {
         printf("Error updating HMAC with data (test 6)\n");
         err++;
         goto end;
     }
-    if(!HMAC_CTX_copy(&ctx2, &ctx)) {
+    if (!HMAC_CTX_copy(&ctx2, &ctx)) {
         printf("Failed to copy HMAC_CTX (test 6)\n");
         err++;
         goto end;
     }
-    if(!HMAC_Final(&ctx2, buf, &len)) {
+    if (!HMAC_Final(&ctx2, buf, &len)) {
         printf("Error finalising data (test 6)\n");
         err++;
         goto end;
@@ -304,6 +316,7 @@ test6:
         printf("test 6 ok\n");
     }
 end:
+    HMAC_CTX_cleanup(&ctx);
     EXIT(err);
     return (0);
 }