X-Git-Url: https://git.librecmc.org/?a=blobdiff_plain;f=coreutils%2Flogname.c;h=ca5eb41cfa9b212f145c93b847317cf148b7bb39;hb=0fb397e6176bebd31d27f8b2105b808091207366;hp=a1887aaf9f595370e9fda3c35a7f8cc8cd447357;hpb=67991cf824f8df27e74c92d754fb507681c69ce6;p=oweals%2Fbusybox.git

diff --git a/coreutils/logname.c b/coreutils/logname.c
index a1887aaf9..ca5eb41cf 100644
--- a/coreutils/logname.c
+++ b/coreutils/logname.c
@@ -20,22 +20,36 @@
  *
  */
 
-#include "busybox.h"
+/* BB_AUDIT SUSv3 compliant */
+/* http://www.opengroup.org/onlinepubs/007904975/utilities/logname.html */
+
+/* Mar 16, 2003      Manuel Novoa III   (mjn3@codepoet.org)
+ *
+ * SUSv3 specifies the string used is that returned from getlogin().
+ * The previous implementation used getpwuid() for geteuid(), which
+ * is _not_ the same.  Erik apparently made this change almost 3 years
+ * ago to avoid failing when no utmp was available.  However, the
+ * correct course of action wrt SUSv3 for a failing getlogin() is
+ * a diagnostic message and an error return.
+ */
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
+#include "busybox.h"
 
 extern int logname_main(int argc, char **argv)
 {
-	char user[9];
+	const char *p;
 
-	if (argc > 1)
-		show_usage();
+	if (argc > 1) {
+		bb_show_usage();
+	}
 
-	my_getpwuid(user, geteuid());
-	if (*user) {
-		puts(user);
-		return EXIT_SUCCESS;
+	if ((p = getlogin()) != NULL) {
+		puts(p);
+		bb_fflush_stdout_and_exit(EXIT_SUCCESS);
 	}
-	error_msg_and_die("no login name");
+
+	bb_perror_msg_and_die("getlogin");
 }