X-Git-Url: https://git.librecmc.org/?a=blobdiff_plain;f=coreutils%2Finstall.c;h=73f9c70d573e30dec4690245e28d406a12b42e19;hb=68c048fb23bd8b0831bbd02ec66900b12390cf19;hp=1f65407b12b809e80b49d89654a83c5ae1b7f99b;hpb=1203c9bf2f63938f7766a3022a9659b25712824f;p=oweals%2Fbusybox.git diff --git a/coreutils/install.c b/coreutils/install.c index 1f65407b1..73f9c70d5 100644 --- a/coreutils/install.c +++ b/coreutils/install.c @@ -1,47 +1,64 @@ /* vi: set sw=4 ts=4: */ /* - * Copyright (C) 2003 by Glenn McGrath + * Copyright (C) 2003 by Glenn McGrath * SELinux support: by Yuichi Nakamura * - * Licensed under GPLv2 or later, see file LICENSE in this tarball for details. - * - * TODO: -d option, need a way of recursively making directories and changing - * owner/group, will probably modify bb_make_directory(...) + * Licensed under GPLv2 or later, see file LICENSE in this source tree. */ -#include "busybox.h" +/* -v, -b, -c are ignored */ +//usage:#define install_trivial_usage +//usage: "[-cdDsp] [-o USER] [-g GRP] [-m MODE] [-t DIR] [SOURCE]... DEST" +//usage:#define install_full_usage "\n\n" +//usage: "Copy files and set attributes\n" +//usage: "\n -c Just copy (default)" +//usage: "\n -d Create directories" +//usage: "\n -D Create leading target directories" +//usage: "\n -s Strip symbol table" +//usage: "\n -p Preserve date" +//usage: "\n -o USER Set ownership" +//usage: "\n -g GRP Set group ownership" +//usage: "\n -m MODE Set permissions" +//usage: "\n -t DIR Install to DIR" +//usage: IF_SELINUX( +//usage: "\n -Z Set security context" +//usage: ) + +#include "libbb.h" #include "libcoreutils/coreutils.h" -#include -#include /* struct option */ #if ENABLE_FEATURE_INSTALL_LONG_OPTIONS -static const struct option install_long_options[] = { - { "directory", 0, NULL, 'd' }, - { "preserve-timestamps", 0, NULL, 'p' }, - { "strip", 0, NULL, 's' }, - { "group", 0, NULL, 'g' }, - { "mode", 0, NULL, 'm' }, - { "owner", 0, NULL, 'o' }, +static const char install_longopts[] ALIGN1 = + IF_FEATURE_VERBOSE( + "verbose\0" No_argument "v" + ) + "directory\0" No_argument "d" + "preserve-timestamps\0" No_argument "p" + "strip\0" No_argument "s" + "group\0" Required_argument "g" + "mode\0" Required_argument "m" + "owner\0" Required_argument "o" + "target-directory\0" Required_argument "t" +/* autofs build insists of using -b --suffix=.orig */ +/* TODO? (short option for --suffix is -S) */ #if ENABLE_SELINUX - { "context", 1, NULL, 'Z' }, - { "preserve_context", 0, NULL, 0xff }, - { "preserve-context", 0, NULL, 0xff }, + "context\0" Required_argument "Z" + "preserve_context\0" No_argument "\xff" + "preserve-context\0" No_argument "\xff" #endif - { 0, 0, 0, 0 } -}; + ; #endif #if ENABLE_SELINUX -static bool use_default_selinux_context = 1; - -static void setdefaultfilecon(const char *path) { +static void setdefaultfilecon(const char *path) +{ struct stat s; security_context_t scontext = NULL; if (!is_selinux_enabled()) { return; - } + } if (lstat(path, &s) != 0) { return; } @@ -55,7 +72,8 @@ static void setdefaultfilecon(const char *path) { if (lsetfilecon(path, scontext) < 0) { if (errno != ENOTSUP) { - bb_perror_msg("warning: failed to change context of %s to %s", path, scontext); + bb_perror_msg("warning: can't change context" + " of %s to %s", path, scontext); } } @@ -65,119 +83,145 @@ static void setdefaultfilecon(const char *path) { #endif -int install_main(int argc, char **argv); +int install_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE; int install_main(int argc, char **argv) { struct stat statbuf; mode_t mode; uid_t uid; gid_t gid; + char *arg, *last; const char *gid_str; const char *uid_str; const char *mode_str; + int mkdir_flags = FILEUTILS_RECUR; int copy_flags = FILEUTILS_DEREFERENCE | FILEUTILS_FORCE; - int ret = EXIT_SUCCESS, flags, i, isdir; + int opts; + int ret = EXIT_SUCCESS; + int isdir; #if ENABLE_SELINUX security_context_t scontext; + bool use_default_selinux_context = 1; #endif enum { - OPT_CMD = 0x1, - OPT_DIRECTORY = 0x2, - OPT_PRESERVE_TIME = 0x4, - OPT_STRIP = 0x8, - OPT_GROUP = 0x10, - OPT_MODE = 0x20, - OPT_OWNER = 0x40, + OPT_c = 1 << 0, + OPT_v = 1 << 1, + OPT_b = 1 << 2, + OPT_MKDIR_LEADING = 1 << 3, + OPT_DIRECTORY = 1 << 4, + OPT_PRESERVE_TIME = 1 << 5, + OPT_STRIP = 1 << 6, + OPT_GROUP = 1 << 7, + OPT_MODE = 1 << 8, + OPT_OWNER = 1 << 9, + OPT_TARGET = 1 << 10, #if ENABLE_SELINUX - OPT_SET_SECURITY_CONTEXT = 0x80, - OPT_PRESERVE_SECURITY_CONTEXT = 0x100, + OPT_SET_SECURITY_CONTEXT = 1 << 11, + OPT_PRESERVE_SECURITY_CONTEXT = 1 << 12, #endif }; #if ENABLE_FEATURE_INSTALL_LONG_OPTIONS - applet_long_options = install_long_options; + applet_long_options = install_longopts; #endif - opt_complementary = "?:s--d:d--s" USE_SELINUX(":Z--\xff:\xff--Z"); + opt_complementary = "t--d:d--t:s--d:d--s" IF_FEATURE_INSTALL_LONG_OPTIONS(IF_SELINUX(":Z--\xff:\xff--Z")); /* -c exists for backwards compatibility, it's needed */ + /* -b is ignored ("make a backup of each existing destination file") */ + opts = getopt32(argv, "cvb" "Ddpsg:m:o:t:" IF_SELINUX("Z:"), + &gid_str, &mode_str, &uid_str, &last + IF_SELINUX(, &scontext)); + argc -= optind; + argv += optind; - flags = getopt32(argc, argv, "cdpsg:m:o:" USE_SELINUX("Z:"), &gid_str, &mode_str, &uid_str USE_SELINUX(, &scontext)); - #if ENABLE_SELINUX - if (flags & OPT_PRESERVE_SECURITY_CONTEXT) { - use_default_selinux_context = 0; - copy_flags |= FILEUTILS_PRESERVE_SECURITY_CONTEXT; - selinux_or_die(); - } - if (flags & OPT_SET_SECURITY_CONTEXT) { + if (opts & (OPT_PRESERVE_SECURITY_CONTEXT|OPT_SET_SECURITY_CONTEXT)) { selinux_or_die(); - if (setfscreatecon(scontext) < 0) { - bb_error_msg_and_die("setfscreatecon(%s)", scontext); // perror? - } use_default_selinux_context = 0; - copy_flags |= FILEUTILS_SET_SECURITY_CONTEXT; + if (opts & OPT_PRESERVE_SECURITY_CONTEXT) { + copy_flags |= FILEUTILS_PRESERVE_SECURITY_CONTEXT; + } + if (opts & OPT_SET_SECURITY_CONTEXT) { + setfscreatecon_or_die(scontext); + copy_flags |= FILEUTILS_SET_SECURITY_CONTEXT; + } } #endif - /* preserve access and modification time, this is GNU behaviour, BSD only preserves modification time */ - if (flags & OPT_PRESERVE_TIME) { + if ((opts & OPT_v) && FILEUTILS_VERBOSE) { + mkdir_flags |= FILEUTILS_VERBOSE; + copy_flags |= FILEUTILS_VERBOSE; + } + + /* preserve access and modification time, this is GNU behaviour, + * BSD only preserves modification time */ + if (opts & OPT_PRESERVE_TIME) { copy_flags |= FILEUTILS_PRESERVE_STATUS; } - mode = 0666; - if (flags & OPT_MODE) bb_parse_mode(mode_str, &mode); - uid = (flags & OPT_OWNER) ? get_ug_id(uid_str, xuname2uid) : getuid(); - gid = (flags & OPT_GROUP) ? get_ug_id(gid_str, xgroup2gid) : getgid(); - if (flags & (OPT_OWNER|OPT_GROUP)) umask(0); - - /* Create directories - * don't use bb_make_directory() as it can't change uid or gid - * perhaps bb_make_directory() should be improved. - */ - if (flags & OPT_DIRECTORY) { - for (argv += optind; *argv; argv++) { - char *old_argv_ptr = *argv + 1; - char *argv_ptr; - do { - argv_ptr = strchr(old_argv_ptr, '/'); - old_argv_ptr = argv_ptr; - if (argv_ptr) { - *argv_ptr = '\0'; - old_argv_ptr++; - } - if (mkdir(*argv, mode | 0111) == -1) { - if (errno != EEXIST) { - bb_perror_msg("cannot create %s", *argv); - ret = EXIT_FAILURE; - break; - } - } - if ((flags & (OPT_OWNER|OPT_GROUP)) - && lchown(*argv, uid, gid) == -1 - ) { - bb_perror_msg("cannot change ownership of %s", *argv); - ret = EXIT_FAILURE; - break; - } - if (argv_ptr) { - *argv_ptr = '/'; - } - } while (old_argv_ptr); - } - return ret; + mode = 0755; /* GNU coreutils 6.10 compat */ + if (opts & OPT_MODE) + bb_parse_mode(mode_str, &mode); + uid = (opts & OPT_OWNER) ? get_ug_id(uid_str, xuname2uid) : getuid(); + gid = (opts & OPT_GROUP) ? get_ug_id(gid_str, xgroup2gid) : getgid(); + + /* If -t DIR is in use, then isdir=true, last="DIR" */ + isdir = (opts & OPT_TARGET); + if (!(opts & (OPT_TARGET|OPT_DIRECTORY))) { + /* Neither -t DIR nor -d is in use */ + argc--; + last = argv[argc]; + argv[argc] = NULL; + /* coreutils install resolves link in this case, don't use lstat */ + isdir = stat(last, &statbuf) < 0 ? 0 : S_ISDIR(statbuf.st_mode); } - isdir = lstat(argv[argc - 1], &statbuf) < 0 ? 0 : S_ISDIR(statbuf.st_mode); + if (argc < 1) + bb_show_usage(); - for (i = optind; i < argc - 1; i++) { + while ((arg = *argv++) != NULL) { char *dest; - dest = argv[argc - 1]; - if (isdir) - dest = concat_path_file(argv[argc - 1], basename(argv[i])); - ret |= copy_file(argv[i], dest, copy_flags); + if (opts & OPT_DIRECTORY) { + dest = arg; + /* GNU coreutils 6.9 does not set uid:gid + * on intermediate created directories + * (only on last one) */ + if (bb_make_directory(dest, 0755, mkdir_flags)) { + ret = EXIT_FAILURE; + goto next; + } + } else { + dest = last; + if (opts & OPT_MKDIR_LEADING) { + char *ddir = xstrdup(dest); + bb_make_directory(dirname(ddir), 0755, mkdir_flags); + /* errors are not checked. copy_file + * will fail if dir is not created. */ + free(ddir); + } + if (isdir) + dest = concat_path_file(last, bb_basename(arg)); + if (copy_file(arg, dest, copy_flags) != 0) { + /* copy is not made */ + ret = EXIT_FAILURE; + goto next; + } + if (opts & OPT_STRIP) { + char *args[4]; + args[0] = (char*)"strip"; + args[1] = (char*)"-p"; /* -p --preserve-dates */ + args[2] = dest; + args[3] = NULL; + if (spawn_and_wait(args)) { + bb_perror_msg("strip"); + ret = EXIT_FAILURE; + } + } + } - /* Set the file mode */ - if ((flags & OPT_MODE) && chmod(dest, mode) == -1) { - bb_perror_msg("cannot change permissions of %s", dest); + /* Set the file mode (always, not only with -m). + * GNU coreutils 6.10 is not affected by umask. */ + if (chmod(dest, mode) == -1) { + bb_perror_msg("can't change %s of %s", "permissions", dest); ret = EXIT_FAILURE; } #if ENABLE_SELINUX @@ -185,19 +229,15 @@ int install_main(int argc, char **argv) setdefaultfilecon(dest); #endif /* Set the user and group id */ - if ((flags & (OPT_OWNER|OPT_GROUP)) + if ((opts & (OPT_OWNER|OPT_GROUP)) && lchown(dest, uid, gid) == -1 ) { - bb_perror_msg("cannot change ownership of %s", dest); + bb_perror_msg("can't change %s of %s", "ownership", dest); ret = EXIT_FAILURE; } - if (flags & OPT_STRIP) { - if (BB_EXECLP("strip", "strip", dest, NULL) == -1) { - bb_perror_msg("strip"); - ret = EXIT_FAILURE; - } - } - if (ENABLE_FEATURE_CLEAN_UP && isdir) free(dest); + next: + if (ENABLE_FEATURE_CLEAN_UP && isdir) + free(dest); } return ret;