bc: convert to "G trick" - this returns bc to zero bss increase

[oweals/busybox.git] / util-linux / renice.c

diff --git a/util-linux/renice.c b/util-linux/renice.c
index 23cbca88d2054eb0d52f42fd00a3ee777b71d86f..ee0fb3c8eae0a445e40ab793ed9b4b834dd1dfd6 100644 (file)
--- a/util-linux/renice.c
+++ b/util-linux/renice.c
@@ -6,7 +6,6 @@
  *
  * Licensed under GPLv2 or later, see file LICENSE in this source tree.
  */
-
 /* Notes:
  *   Setting an absolute priority was obsoleted in SUSv2 and removed
  *   in SUSv3.  However, the common linux version of renice does
@@ -25,7 +24,7 @@
 //config:      Renice alters the scheduling priority of one or more running
 //config:      processes.
 
-//applet:IF_RENICE(APPLET(renice, BB_DIR_USR_BIN, BB_SUID_DROP))
+//applet:IF_RENICE(APPLET_NOEXEC(renice, renice, BB_DIR_USR_BIN, BB_SUID_DROP, renice))
 
 //kbuild:lib-$(CONFIG_RENICE) += renice.o
 
@@ -40,11 +39,6 @@
 //usage:     "\n       -u      Process user names"
 
 #include "libbb.h"
-#include <sys/resource.h>
-
-void BUG_bad_PRIO_PROCESS(void);
-void BUG_bad_PRIO_PGRP(void);
-void BUG_bad_PRIO_USER(void);
 
 int renice_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
 int renice_main(int argc UNUSED_PARAM, char **argv)
@@ -59,12 +53,9 @@ int renice_main(int argc UNUSED_PARAM, char **argv)
        char *arg;
 
        /* Yes, they are not #defines in glibc 2.4! #if won't work */
-       if (PRIO_PROCESS < CHAR_MIN || PRIO_PROCESS > CHAR_MAX)
-               BUG_bad_PRIO_PROCESS();
-       if (PRIO_PGRP < CHAR_MIN || PRIO_PGRP > CHAR_MAX)
-               BUG_bad_PRIO_PGRP();
-       if (PRIO_USER < CHAR_MIN || PRIO_USER > CHAR_MAX)
-               BUG_bad_PRIO_USER();
+       BUILD_BUG_ON(PRIO_PROCESS < CHAR_MIN || PRIO_PROCESS > CHAR_MAX);
+       BUILD_BUG_ON(PRIO_PGRP < CHAR_MIN || PRIO_PGRP > CHAR_MAX);
+       BUILD_BUG_ON(PRIO_USER < CHAR_MIN || PRIO_USER > CHAR_MAX);
 
        arg = *++argv;
 
@@ -102,6 +93,7 @@ int renice_main(int argc UNUSED_PARAM, char **argv)
                /* Process an ID arg. */
                if (which == PRIO_USER) {
                        struct passwd *p;
+                       /* NB: use of getpwnam makes it risky to be NOFORK, switch to getpwnam_r? */
                        p = getpwnam(arg);
                        if (!p) {
                                bb_error_msg("unknown user %s", arg);