bc: fix for() to not leave data on stack
[oweals/busybox.git] / testsuite / runtest
index fc8392ac537dacf9527e59f03d1fddf870be3c33..44f9cd1a1f15ccbd28c9db24ef1ebc68a7807393 100755 (executable)
@@ -1,33 +1,39 @@
 #!/bin/sh
-
 # Usage:
 # runtest [applet1] [applet2...]
 
+. ./testing.sh
+
+total_failed=0
+
 # Run one old-style test.
 # Tests are stored in applet/testcase shell scripts.
 # They are run using "sh -x -e applet/testcase".
 # Option -e will make testcase stop on the first failed command.
 run_applet_testcase()
 {
-       local applet=$1
-       local testcase=$2
+       applet="$1"
+       testcase="$2"
 
-       local status
-       local uc_applet=$(echo $applet | tr a-z A-Z)
-       local testname=$(basename $testcase)
+       status=0
+       uc_applet=$(echo "$applet" | tr a-z A-Z)
+       testname="$testcase"
 
-       if grep -q "^# CONFIG_${uc_applet} is not set$" $bindir/.config; then
+       testname="${testname##*/}" # take basename
+       if grep "^# CONFIG_$uc_applet is not set$" "$bindir/.config" >/dev/null; then
                echo "UNTESTED: $testname"
                return 0
        fi
 
-       if grep -q "^# FEATURE: " $testcase; then
-               local feature=`sed -ne 's/^# FEATURE: //p' $testcase`
+       if grep "^# FEATURE: " "$testcase" >/dev/null; then
+               local feature=$(sed -ne 's/^# FEATURE: //p' "$testcase")
 
-               if grep -q "^# ${feature} is not set$" $bindir/.config; then
-                       echo "UNTESTED: $testname"
-                       return 0
-               fi
+               for f in $feature; do
+                       if grep "^# $f is not set$" "$bindir/.config" >/dev/null; then
+                               echo "UNTESTED: $testname"
+                               return 0
+                       fi
+               done
        fi
 
        rm -rf ".tmpdir.$applet"
@@ -35,9 +41,9 @@ run_applet_testcase()
        cd ".tmpdir.$applet" || return 1
 
 #      echo "Running testcase $testcase"
-       d="$tsdir" sh -x -e "$testcase" >"$testname.stdout.txt" 2>&1
-       status=$?
-       if [ $status != 0 ]; then
+       d="$tsdir" \
+               sh -x -e "$testcase" >"$testname.stdout.txt" 2>&1 || status=$?
+       if [ $status -ne 0 ]; then
                echo "FAIL: $testname"
                if [ x"$VERBOSE" != x ]; then
                        cat "$testname.stdout.txt"
@@ -53,25 +59,36 @@ run_applet_testcase()
 }
 
 # Run all old-style tests for given applet
-run_applet_tests()
+run_oldstyle_applet_tests()
 {
-       local applet=$1
+       local applet="$1"
        local status=0
-       for testcase in $tsdir/$applet/*; do
-               if [ "$testcase" = "$tsdir/$applet/CVS" ]; then
-                       continue
-               fi
-               run_applet_testcase $applet $testcase
-               test $? = 0 || status=1
+
+       for testcase in "$tsdir/$applet"/*; do
+               # switch on basename of $testcase
+               case "${testcase##*/}" in
+                       .*)     continue ;;    # .svn, .git etc
+                       *~)     continue ;;    # backup files
+                       "CVS")  continue ;;
+                       \#*)    continue ;;    # CVS merge residues
+                       *.mine) continue ;;    # svn-produced junk
+                       *.r[0-9]*) continue ;; # svn-produced junk
+               esac
+               run_applet_testcase "$applet" "$testcase" || {
+                       status=1
+                       total_failed=$((total_failed + 1))
+               }
        done
        return $status
 }
 
 
 
-[ -n "$tsdir" ] || tsdir=$(pwd)
-[ -n "$bindir" ] || bindir=$(dirname $(pwd))
+lcwd=$(pwd)
+[ x"$tsdir" != x"" ] || tsdir="$lcwd"
+[ x"$bindir" != x"" ] || bindir="${lcwd%/*}" # one directory up from $lcwd
 PATH="$bindir:$PATH"
+export bindir   # some tests need to look at $bindir/.config
 
 if [ x"$VERBOSE" = x ]; then
        export VERBOSE=
@@ -83,7 +100,8 @@ if [ x"$1" = x"-v" ]; then
 fi
 
 implemented=$(
-       $bindir/busybox 2>&1 |
+       printf "busybox " # always implemented
+       "$bindir/busybox" 2>&1 |
        while read line; do
                if [ x"$line" = x"Currently defined functions:" ]; then
                        xargs | sed 's/,//g'
@@ -100,41 +118,54 @@ fi
 # Populate a directory with links to all busybox applets
 
 LINKSDIR="$bindir/runtest-tempdir-links"
+
+# Comment this line out if you have put a different binary in $LINKSDIR
+# (say, a "standard" tool's binary) in order to run tests against it:
 rm -rf "$LINKSDIR" 2>/dev/null
-mkdir "$LINKSDIR"
+
+mkdir "$LINKSDIR" 2>/dev/null
 for i in $implemented; do
-       ln -s $bindir/busybox "$LINKSDIR"/$i
+       # Note: if $LINKSDIR/applet exists, we do not overwrite it.
+       # Useful if one wants to run tests against a standard utility,
+       # not an applet.
+       ln -s "$bindir/busybox" "$LINKSDIR/$i" 2>/dev/null
 done
 
 # Set up option flags so tests can be selective.
-export OPTIONFLAGS=:$(sed -nr 's/^CONFIG_//p' $bindir/.config | sed 's/=.*//' | xargs | sed 's/ /:/g')
+export OPTIONFLAGS=:$(
+       sed -nr 's/^CONFIG_//p' "$bindir/.config" |
+       sed 's/=.*//' | xargs | sed 's/ /:/g'
+       ):
 
 status=0
 for applet in $applets; do
-       if [ "$applet" = "links" ]; then continue; fi
-
        # Any old-style tests for this applet?
-       if [ "$applet" != "CVS" -a -d "$tsdir/$applet" ]; then
-               run_applet_tests "$applet"
-               test $? = 0 || status=1
+       if [ -d "$tsdir/$applet" ]; then
+               run_oldstyle_applet_tests "$applet" || status=1
        fi
 
        # Is this a new-style test?
-       if [ -f "${applet}.tests" ]; then
-               if [ ! -h "$LINKSDIR/$applet" ] && [ "${applet:0:4}" != "all_" ]; then
-                       echo "SKIPPED: $applet (not built)"
-                       continue
+       if [ -f "$applet.tests" ]; then
+               if [ ! -e "$LINKSDIR/$applet" ]; then
+                       # (avoiding bash'ism "${applet:0:4}")
+                       if ! echo "$applet" | grep "^all_" >/dev/null; then
+                               echo "SKIPPED: $applet (not built)"
+                               continue
+                       fi
                fi
-#              echo "Running test ${tsdir:-.}/${applet}.tests"
-               PATH="$LINKSDIR:$tsdir:$bindir:$PATH" "${tsdir:-.}/${applet}.tests"
-               test $? = 0 || status=1
+#              echo "Running test $tsdir/$applet.tests"
+               PATH="$LINKSDIR:$tsdir:$bindir:$PATH" \
+                       "$tsdir/$applet.tests"
+               rc=$?
+               total_failed=$((total_failed + rc))
+               test $rc -ne 0 && status=1
        fi
 done
 
 # Leaving the dir makes it somewhat easier to run failed test by hand
 #rm -rf "$LINKSDIR"
 
-if [ $status != 0 -a x"$VERBOSE" = x ]; then
-       echo "Failures detected, running with -v (verbose) will give more info"
+if [ $status -ne 0 ] && [ x"$VERBOSE" = x ]; then
+       echo "$total_failed failure(s) detected; running with -v (verbose) will give more info"
 fi
 exit $status