#define -> static const int. Also got rid of some big static buffers.
[oweals/busybox.git] / tar.c
diff --git a/tar.c b/tar.c
index c6a2a6627fe29555403503d20b8bc92cda93603f..51a857d719680a0d8367e0738a898c1c70a93373 100644 (file)
--- a/tar.c
+++ b/tar.c
@@ -51,6 +51,7 @@
 #include <sys/types.h>
 #include <sys/sysmacros.h>
 #include <getopt.h>
+#include <fnmatch.h>
 
 #ifdef BB_FEATURE_TAR_GZIP
 extern int unzip(int in, int out);
@@ -63,7 +64,7 @@ extern int gunzip_init();
 #define MINOR(dev) ((dev)&0xff)
 #endif
 
-#define NAME_SIZE      100
+enum { NAME_SIZE = 100 }; /* because gcc won't let me use 'static const int' */
 
 /* POSIX tar Header Block, from POSIX 1003.1-1990  */
 struct TarHeader
@@ -93,9 +94,9 @@ typedef struct TarHeader TarHeader;
 /* A few useful constants */
 #define TAR_MAGIC          "ustar"        /* ustar and a null */
 #define TAR_VERSION        "  "           /* Be compatable with GNU tar format */
-#define TAR_MAGIC_LEN       6
-#define TAR_VERSION_LEN     2
-#define TAR_BLOCK_SIZE      512
+static const int TAR_MAGIC_LEN = 6;
+static const int TAR_VERSION_LEN = 2;
+static const int TAR_BLOCK_SIZE = 512;
 
 /* A nice enum with all the possible tar file content types */
 enum TarFileType 
@@ -134,7 +135,7 @@ struct TarInfo
 typedef struct TarInfo TarInfo;
 
 /* Local procedures to restore files from a tar file.  */
-static int readTarFile(int tarFd, int extractFlag, int listFlag, 
+extern int readTarFile(int tarFd, int extractFlag, int listFlag, 
                int tostdoutFlag, int verboseFlag, char** extractList,
                char** excludeList);
 
@@ -153,7 +154,7 @@ void child_died()
        exit(EXIT_FAILURE);
 }
 
-static int tar_unzip_init(int tarFd)
+extern int tar_unzip_init(int tarFd)
 {
        int child_pid;
        static int unzip_pipe[2];
@@ -162,22 +163,32 @@ static int tar_unzip_init(int tarFd)
 
        if (pipe(unzip_pipe)!=0)
                error_msg_and_die("pipe error\n");
-                       
+
        if ( (child_pid = fork()) == -1)
                error_msg_and_die("fork failure\n");
 
        if (child_pid==0) {
                /* child process */
+               close(unzip_pipe[0]);
                gunzip_init();
                unzip(tarFd, unzip_pipe[1]);
                exit(EXIT_SUCCESS);
        }
-       else
+       else {
                /* return fd of uncompressed data to parent process */
+               close(unzip_pipe[1]);
                return(unzip_pipe[0]);
+       }
 }
 #endif
 
+#if defined BB_FEATURE_TAR_EXCLUDE
+struct option longopts[] = {
+       { "exclude", 1, NULL, 'e' },
+       { NULL, 0, NULL, 0 }
+};
+#endif
+
 extern int tar_main(int argc, char **argv)
 {
        char** excludeList=NULL;
@@ -185,7 +196,6 @@ extern int tar_main(int argc, char **argv)
        const char *tarName="-";
 #if defined BB_FEATURE_TAR_EXCLUDE
        int excludeListSize=0;
-       char *excludeFileName ="-";
        FILE *fileList;
        char file[256];
 #endif
@@ -198,101 +208,84 @@ extern int tar_main(int argc, char **argv)
        int verboseFlag  = FALSE;
        int tostdoutFlag = FALSE;
        int status       = FALSE;
-       int firstOpt     = TRUE;
-       int stopIt;
+       int opt;
 
        if (argc <= 1)
                usage(tar_usage);
 
-       while (*(++argv) && (**argv == '-' || firstOpt == TRUE)) {
-               firstOpt=FALSE;
-               stopIt=FALSE;
-               while (stopIt==FALSE && **argv) {
-                       switch (*((*argv)++)) {
-                               case 'c':
-                                       if (extractFlag == TRUE || listFlag == TRUE)
-                                               goto flagError;
-                                       createFlag = TRUE;
-                                       break;
-                               case 'x':
-                                       if (listFlag == TRUE || createFlag == TRUE)
-                                               goto flagError;
-                                       extractFlag = TRUE;
-                                       break;
-                               case 't':
-                                       if (extractFlag == TRUE || createFlag == TRUE)
-                                               goto flagError;
-                                       listFlag = TRUE;
-                                       break;
+       if (argv[1][0] != '-') {
+               char *tmp = xmalloc(strlen(argv[1]) + 2);
+               tmp[0] = '-';
+               strcpy(tmp + 1, argv[1]);
+               argv[1] = tmp;
+       }
+
+       while (
+#ifndef BB_FEATURE_TAR_EXCLUDE
+                       (opt = getopt(argc, argv, "cxtzvOf:"))
+#else
+                       (opt = getopt_long(argc, argv, "cxtzvOf:X:", longopts, NULL))
+#endif
+                       > 0) {
+               switch (opt) {
+                       case 'c':
+                               if (extractFlag == TRUE || listFlag == TRUE)
+                                       goto flagError;
+                               createFlag = TRUE;
+                               break;
+                       case 'x':
+                               if (listFlag == TRUE || createFlag == TRUE)
+                                       goto flagError;
+                               extractFlag = TRUE;
+                               break;
+                       case 't':
+                               if (extractFlag == TRUE || createFlag == TRUE)
+                                       goto flagError;
+                               listFlag = TRUE;
+                               break;
 #ifdef BB_FEATURE_TAR_GZIP
-                               case 'z':
-                                       unzipFlag = TRUE;
-                                       break;
+                       case 'z':
+                               unzipFlag = TRUE;
+                               break;
 #endif
-                               case 'v':
-                                       verboseFlag = TRUE;
-                                       break;
-                               case 'O':
-                                       tostdoutFlag = TRUE;
-                                       break;                                  
-                               case 'f':
-                                       if (*tarName != '-')
-                                               error_msg_and_die( "Only one 'f' option allowed\n");
-                                       tarName = *(++argv);
-                                       if (tarName == NULL)
-                                               error_msg_and_die( "Option requires an argument: No file specified\n");
-                                       stopIt=TRUE;
-                                       break;
+                       case 'v':
+                               verboseFlag = TRUE;
+                               break;
+                       case 'O':
+                               tostdoutFlag = TRUE;
+                               break;
+                       case 'f':
+                               if (*tarName != '-')
+                                       error_msg_and_die( "Only one 'f' option allowed\n");
+                               tarName = optarg;
+                               break;
 #if defined BB_FEATURE_TAR_EXCLUDE
-                               case 'e':
-                                       if (strcmp(*argv, "xclude")==0) {
-                                               excludeList=xrealloc( excludeList,
-                                                               sizeof(char *) * (excludeListSize+2));
-                                               excludeList[excludeListSize] = *(++argv);
-                                               if (excludeList[excludeListSize] == NULL)
-                                                       error_msg_and_die( "Option requires an argument: No file specified\n");
-                                               /* Remove leading "/"s */
-                                               if (*excludeList[excludeListSize] =='/')
-                                                       excludeList[excludeListSize] = (excludeList[excludeListSize])+1;
-                                               /* Tack a NULL onto the end of the list */
-                                               excludeList[++excludeListSize] = NULL;
-                                               stopIt=TRUE;
-                                               break;
-                                       }
-                               case 'X':
-                                       if (*excludeFileName != '-')
-                                               error_msg_and_die("Only one 'X' option allowed\n");
-                                       excludeFileName = *(++argv);
-                                       if (excludeFileName == NULL)
-                                               error_msg_and_die("Option requires an argument: No file specified\n");
-                                       fileList = fopen (excludeFileName, "r");
-                                       if (! fileList)
-                                               error_msg_and_die("Exclude file: file not found\n");
-                                       while (fgets(file, sizeof(file), fileList) != NULL) {
-                                               excludeList = xrealloc(excludeList,
-                                                               sizeof(char *) * (excludeListSize+2));
-                                               if (file[strlen(file)-1] == '\n')
-                                                       file[strlen(file)-1] = '\0';
-                                               excludeList[excludeListSize] = xstrdup(file);
-                                               /* Remove leading "/"s */
-                                               while (*excludeList[excludeListSize] == '/')
-                                                       excludeList[excludeListSize]++;
-                                               /* Tack a NULL onto the end of the list */
-                                               excludeList[++excludeListSize] = NULL;
-                                       }
-                                       fclose(fileList);
-                                       stopIt=TRUE;
-                                       break;
+                       case 'e':
+                               excludeList=xrealloc( excludeList,
+                                               sizeof(char *) * (excludeListSize+2));
+                               excludeList[excludeListSize] = optarg;
+                               /* Tack a NULL onto the end of the list */
+                               excludeList[++excludeListSize] = NULL;
+                       case 'X':
+                               fileList = xfopen(optarg, "r");
+                               while (fgets(file, sizeof(file), fileList) != NULL) {
+                                       excludeList = xrealloc(excludeList,
+                                                       sizeof(char *) * (excludeListSize+2));
+                                       if (file[strlen(file)-1] == '\n')
+                                               file[strlen(file)-1] = '\0';
+                                       excludeList[excludeListSize] = xstrdup(file);
+                                       /* Tack a NULL onto the end of the list */
+                                       excludeList[++excludeListSize] = NULL;
+                               }
+                               fclose(fileList);
+                               break;
 #endif
-                               case '-':
-                                               break;
                                default:
                                        usage(tar_usage);
-                       }
                }
        }
 
-       /* 
+       /*
         * Do the correct type of action supplying the rest of the
         * command line arguments as the list of files to process.
         */
@@ -304,13 +297,13 @@ extern int tar_main(int argc, char **argv)
                if (unzipFlag==TRUE)
                        error_msg_and_die("Creation of compressed not internally support by tar, pipe to busybox gunzip\n");
 #endif
-               status = writeTarFile(tarName, verboseFlag, argv, excludeList);
+               status = writeTarFile(tarName, verboseFlag, argv + optind, excludeList);
 #endif
        }
        if (listFlag == TRUE || extractFlag == TRUE) {
                int tarFd;
-               if (*argv)
-                       extractList = argv;
+               if (argv[optind])
+                       extractList = argv + optind;
                /* Open the tar file for reading.  */
                if (!strcmp(tarName, "-"))
                        tarFd = fileno(stdin);
@@ -431,9 +424,12 @@ tarExtractDirectory(TarInfo *header, int extractFlag, int tostdoutFlag)
        /* make the final component, just in case it was
         * omitted by create_path() (which will skip the
         * directory if it doesn't have a terminating '/') */
-       if (mkdir(header->name, header->mode) == 0) {
-               fixUpPermissions(header);
+       if (mkdir(header->name, header->mode) < 0 && errno != EEXIST) {
+               perror_msg("%s", header->name);
+               return FALSE;
        }
+
+       fixUpPermissions(header);
        return( TRUE);
 }
 
@@ -576,6 +572,47 @@ readTarHeader(struct TarHeader *rawHeader, struct TarInfo *header)
        return( FALSE);
 }
 
+int exclude_file(char **excluded_files, const char *file)
+{
+       int i;
+
+       if (excluded_files == NULL)
+               return 0;
+
+       for (i = 0; excluded_files[i] != NULL; i++) {
+               if (excluded_files[i][0] == '/') {
+                       if (fnmatch(excluded_files[i], file,
+                                               FNM_PATHNAME | FNM_LEADING_DIR) == 0)
+                               return 1;
+               } else {
+                       const char *p;
+
+                       for (p = file; p[0] != '\0'; p++) {
+                               if ((p == file || p[-1] == '/') && p[0] != '/' &&
+                                               fnmatch(excluded_files[i], p,
+                                                       FNM_PATHNAME | FNM_LEADING_DIR) == 0)
+                                       return 1;
+                       }
+               }
+       }
+
+       return 0;
+}
+
+int extract_file(char **extract_files, const char *file)
+{
+       int i;
+
+       if (extract_files == NULL)
+               return 1;
+
+       for (i = 0; extract_files[i] != NULL; i++) {
+               if (fnmatch(extract_files[i], file, FNM_LEADING_DIR) == 0)
+                       return 1;
+       }
+
+       return 0;
+}
 
 /*
  * Read a tar file and extract or list the specified files within it.
@@ -590,7 +627,6 @@ extern int readTarFile(int tarFd, int extractFlag, int listFlag,
        int skipNextHeaderFlag=FALSE;
        TarHeader rawHeader;
        TarInfo header;
-       char** tmpList;
 
        /* Set the umask for this process so it doesn't 
         * screw up permission setting for us later. */
@@ -629,56 +665,29 @@ extern int readTarFile(int tarFd, int extractFlag, int listFlag,
                }
 
 #if defined BB_FEATURE_TAR_EXCLUDE
-               {
-                       int skipFlag=FALSE;
-                       /* Check for excluded files....  */
-                       for (tmpList=excludeList; tmpList && *tmpList; tmpList++) {
-                               /* Do some extra hoop jumping for when directory names
-                                * end in '/' but the entry in tmpList doesn't */
-                               if (strncmp( *tmpList, header.name, strlen(*tmpList))==0 || (
-                                                       header.name[strlen(header.name)-1]=='/'
-                                                       && strncmp( *tmpList, header.name, 
-                                                               MIN(strlen(header.name)-1, strlen(*tmpList)))==0)) {
-                                       /* If it is a regular file, pretend to extract it with
-                                        * the extractFlag set to FALSE, so the junk in the tarball
-                                        * is properly skipped over */
-                                       if ( header.type==REGTYPE || header.type==REGTYPE0 ) {
-                                               if (tarExtractRegularFile(&header, FALSE, FALSE) == FALSE)
-                                                       errorFlag = TRUE;
-                                       }
-                                       skipFlag=TRUE;
-                                       break;
-                               }
-                       }
+               if (exclude_file(excludeList, header.name)) {
                        /* There are not the droids you're looking for, move along */
-                       if (skipFlag==TRUE)
-                               continue;
+                       /* If it is a regular file, pretend to extract it with
+                        * the extractFlag set to FALSE, so the junk in the tarball
+                        * is properly skipped over */
+                       if ( header.type==REGTYPE || header.type==REGTYPE0 ) {
+                               if (tarExtractRegularFile(&header, FALSE, FALSE) == FALSE)
+                                       errorFlag = TRUE;
+                       }
+                       continue;
                }
 #endif
-               if (extractList != NULL) {
-                       int skipFlag = TRUE;
-                       for (tmpList = extractList; *tmpList != NULL; tmpList++) {
-                               if (strncmp( *tmpList, header.name, strlen(*tmpList))==0 || (
-                                                       header.name[strlen(header.name)-1]=='/'
-                                                       && strncmp( *tmpList, header.name, 
-                                                               MIN(strlen(header.name)-1, strlen(*tmpList)))==0)) {
-                                       /* If it is a regular file, pretend to extract it with
-                                        * the extractFlag set to FALSE, so the junk in the tarball
-                                        * is properly skipped over */
-                                       skipFlag = FALSE;
-                                       memmove(extractList+1, extractList,
-                                                               sizeof(*extractList)*(tmpList-extractList));
-                                       extractList++;
-                                       break;
-                               }
-                       }
+
+               if (!extract_file(extractList, header.name)) {
                        /* There are not the droids you're looking for, move along */
-                       if (skipFlag == TRUE) {
-                               if ( header.type==REGTYPE || header.type==REGTYPE0 )
-                                       if (tarExtractRegularFile(&header, FALSE, FALSE) == FALSE)
-                                               errorFlag = TRUE;
-                               continue;
+                       /* If it is a regular file, pretend to extract it with
+                        * the extractFlag set to FALSE, so the junk in the tarball
+                        * is properly skipped over */
+                       if ( header.type==REGTYPE || header.type==REGTYPE0 ) {
+                               if (tarExtractRegularFile(&header, FALSE, FALSE) == FALSE)
+                                       errorFlag = TRUE;
                        }
+                       continue;
                }
 
                if (listFlag == TRUE) {
@@ -799,12 +808,6 @@ extern int readTarFile(int tarFd, int extractFlag, int listFlag,
        /* Stuff to do when we are done */
 endgame:
        close( tarFd);
-       if (extractList != NULL) {
-               for (; *extractList != NULL; extractList++) {
-                       error_msg("%s: Not found in archive\n", *extractList);
-                       errorFlag = TRUE;
-               }
-       }
        if ( *(header.name) == '\0' ) {
                if (errorFlag==TRUE)
                        error_msg( "Error exit delayed from previous errors\n");
@@ -936,47 +939,17 @@ static int putOctal (char *cp, int len, long value)
 
 /* Write out a tar header for the specified file/directory/whatever */
 static int
-writeTarHeader(struct TarBallInfo *tbInfo, const char *fileName, struct stat *statbuf)
+writeTarHeader(struct TarBallInfo *tbInfo, const char *header_name,
+               const char *real_name, struct stat *statbuf)
 {
        long chksum=0;
        struct TarHeader header;
-#if defined BB_FEATURE_TAR_EXCLUDE
-       char** tmpList;
-#endif
        const unsigned char *cp = (const unsigned char *) &header;
        ssize_t size = sizeof(struct TarHeader);
                
        memset( &header, 0, size);
 
-       if (*fileName=='/') {
-               static int alreadyWarned=FALSE;
-               if (alreadyWarned==FALSE) {
-                       error_msg("Removing leading '/' from member names\n");
-                       alreadyWarned=TRUE;
-               }
-               strncpy(header.name, fileName+1, sizeof(header.name)); 
-       }
-       else {
-               strncpy(header.name, fileName, sizeof(header.name)); 
-       }
-
-#if defined BB_FEATURE_TAR_EXCLUDE
-       /* Check for excluded files....  */
-       for (tmpList=tbInfo->excludeList; tmpList && *tmpList; tmpList++) {
-               /* Do some extra hoop jumping for when directory names
-                * end in '/' but the entry in tmpList doesn't */
-               if (strncmp( *tmpList, header.name, strlen(*tmpList))==0 || (
-                                       header.name[strlen(header.name)-1]=='/'
-                                       && strncmp( *tmpList, header.name, 
-                                               MIN(strlen(header.name)-1, strlen(*tmpList)))==0)) {
-                       /* Set the mode to something that is not a regular file, thereby
-                        * faking out writeTarFile into thinking that nothing further need
-                        * be done for this file.  Yes, I know this is ugly, but it works. */
-                       statbuf->st_mode = 0;
-                       return( TRUE);
-               }
-       }
-#endif
+       strncpy(header.name, header_name, sizeof(header.name)); 
 
        putOctal(header.mode, sizeof(header.mode), statbuf->st_mode);
        putOctal(header.uid, sizeof(header.uid), statbuf->st_uid);
@@ -1002,7 +975,7 @@ writeTarHeader(struct TarBallInfo *tbInfo, const char *fileName, struct stat *st
                int link_size=0;
                char buffer[BUFSIZ];
                header.typeflag  = SYMTYPE;
-               link_size = readlink(fileName, buffer, sizeof(buffer) - 1);
+               link_size = readlink(real_name, buffer, sizeof(buffer) - 1);
                if ( link_size < 0) {
                        perror_msg("Error reading symlink '%s'", header.name);
                        return ( FALSE);
@@ -1026,7 +999,7 @@ writeTarHeader(struct TarBallInfo *tbInfo, const char *fileName, struct stat *st
                header.typeflag  = REGTYPE;
                putOctal(header.size, sizeof(header.size), statbuf->st_size);
        } else {
-               error_msg("%s: Unknown file type\n", fileName);
+               error_msg("%s: Unknown file type\n", real_name);
                return ( FALSE);
        }
 
@@ -1043,7 +1016,7 @@ writeTarHeader(struct TarBallInfo *tbInfo, const char *fileName, struct stat *st
        
        /* Now write the header out to disk */
        if ((size=full_write(tbInfo->tarFd, (char*)&header, sizeof(struct TarHeader))) < 0) {
-               error_msg(io_error, fileName, strerror(errno)); 
+               error_msg(io_error, real_name, strerror(errno)); 
                return ( FALSE);
        }
        /* Pad the header up to the tar block size */
@@ -1065,6 +1038,7 @@ writeTarHeader(struct TarBallInfo *tbInfo, const char *fileName, struct stat *st
 static int writeFileToTarball(const char *fileName, struct stat *statbuf, void* userData)
 {
        struct TarBallInfo *tbInfo = (struct TarBallInfo *)userData;
+       const char *header_name;
 
        /*
        ** Check to see if we are dealing with a hard link.
@@ -1097,12 +1071,31 @@ static int writeFileToTarball(const char *fileName, struct stat *statbuf, void*
                return( TRUE);
        }
 
+       header_name = fileName;
+       while (header_name[0] == '/') {
+               static int alreadyWarned=FALSE;
+               if (alreadyWarned==FALSE) {
+                       error_msg("Removing leading '/' from member names\n");
+                       alreadyWarned=TRUE;
+               }
+               header_name++;
+       }
+
        if (strlen(fileName) >= NAME_SIZE) {
                error_msg(name_longer_than_foo, NAME_SIZE);
                return ( TRUE);
        }
 
-       if (writeTarHeader(tbInfo, fileName, statbuf)==FALSE) {
+       if (header_name[0] == '\0')
+               return TRUE;
+
+#if defined BB_FEATURE_TAR_EXCLUDE
+       if (exclude_file(tbInfo->excludeList, header_name)) {
+               return SKIP;
+       }
+#endif
+
+       if (writeTarHeader(tbInfo, header_name, fileName, statbuf)==FALSE) {
                return( FALSE);
        }