Changed bb_regcomp to xregcomp and #if 0'ed out destroy_cmd_strs in sed.c
[oweals/busybox.git] / tar.c
diff --git a/tar.c b/tar.c
index 02fde0a64cba06a2fe5f10da5dd34d7c3f7cc8df..353694f3327f6af7ca2e7f8132b00ebda27737be 100644 (file)
--- a/tar.c
+++ b/tar.c
@@ -2,9 +2,9 @@
 /*
  * Mini tar implementation for busybox 
  *
- * Note, that as of BusyBox 0.43 tar has been completely rewritten from the
- * ground up.  It still has remnents of the old code lying about, but it pretty
- * different (i.e. cleaner, less global variables, etc)
+ * Note, that as of BusyBox-0.43, tar has been completely rewritten from the
+ * ground up.  It still has remnents of the old code lying about, but it is
+ * very different now (i.e. cleaner, less global variables, etc)
  *
  * Copyright (C) 2000 by Lineo, inc.
  * Written by Erik Andersen <andersen@lineo.com>, <andersee@debian.org>
 #include <utime.h>
 #include <sys/types.h>
 #include <sys/sysmacros.h>
-#include <sys/param.h>                 /* for PATH_MAX */
 
 
-#ifdef BB_FEATURE_TAR_CREATE
-
 static const char tar_usage[] =
-       "tar -[cxtvOf] [tarFile] [-X excludeFile] [FILE] ...\n\n"
-       "Create, extract, or list files from a tar file.  Note that\n"
-       "this version of tar packs hard links as separate files.\n\n"
-       "Options:\n"
-
-       "\tc=create, x=extract, t=list contents, v=verbose,\n"
-       "\tO=extract to stdout, f=tarfile or \"-\" for stdin\n"
-       "\tX=exclude file\n";
-
+#ifdef BB_FEATURE_TAR_CREATE
+       "tar -[cxtvO] "
 #else
-
-static const char tar_usage[] =
-       "tar -[xtvO] [-f tarFile] [-X excludeFile] [FILE] ...\n\n"
-       "Extract, or list files stored in a tar file.  This\n"
-       "version of tar does not support creation of tar files.\n\n"
-       "Options:\n"
-
-       "\tx=extract, t=list contents, v=verbose,\n"
-       "\tO=extract to stdout, f=tarfile or \"-\" for stdin\n"
-       "\tX=exclude file\n";
-
-
+       "tar -[xtvO] "
 #endif
-
+#if defined BB_FEATURE_TAR_EXCLUDE
+       "[--exclude File] "
+#endif
+       "[-f tarFile] [FILE] ...\n"
+#ifndef BB_FEATURE_TRIVIAL_HELP
+       "\nCreate, extract, or list files from a tar file.  Note that\n"
+       "this version of tar treats hard links as separate files.\n\n"
+       "Main operation mode:\n"
+#ifdef BB_FEATURE_TAR_CREATE
+       "\tc\t\tcreate\n"
+#endif
+       "\tx\t\textract\n"
+       "\tt\t\tlist\n"
+       "\nFile selection:\n"
+       "\tf\t\tname of tarfile or \"-\" for stdin\n"
+       "\tO\t\textract to stdout\n"
+#if defined BB_FEATURE_TAR_EXCLUDE
+       "\t--exclude\tfile to exclude\n"
+#endif
+       "\nInformative output:\n"
+       "\tv\t\tverbosely list files processed\n"
+#endif
+       ;
 
 /* Tar file constants  */
 #ifndef MAJOR
@@ -91,31 +92,30 @@ static const char tar_usage[] =
 struct TarHeader
 {
                                 /* byte offset */
-       char name[100];               /*   0 */
-       char mode[8];                 /* 100 */
-       char uid[8];                  /* 108 */
-       char gid[8];                  /* 116 */
-       char size[12];                /* 124 */
-       char mtime[12];               /* 136 */
-       char chksum[8];               /* 148 */
-       char typeflag;                /* 156 */
-       char linkname[100];           /* 157 */
-       char magic[6];                /* 257 */
-       char version[2];              /* 263 */
-       char uname[32];               /* 265 */
-       char gname[32];               /* 297 */
-       char devmajor[8];             /* 329 */
-       char devminor[8];             /* 337 */
-       char prefix[155];             /* 345 */
-       /* padding                       500 */
+       char name[100];               /*   0-99 */
+       char mode[8];                 /* 100-107 */
+       char uid[8];                  /* 108-115 */
+       char gid[8];                  /* 116-123 */
+       char size[12];                /* 124-135 */
+       char mtime[12];               /* 136-147 */
+       char chksum[8];               /* 148-155 */
+       char typeflag;                /* 156-156 */
+       char linkname[100];           /* 157-256 */
+       char magic[6];                /* 257-262 */
+       char version[2];              /* 263-264 */
+       char uname[32];               /* 265-296 */
+       char gname[32];               /* 297-328 */
+       char devmajor[8];             /* 329-336 */
+       char devminor[8];             /* 337-344 */
+       char prefix[155];             /* 345-499 */
+       char padding[12];             /* 500-512 (pad to exactly the TAR_BLOCK_SIZE) */
 };
 typedef struct TarHeader TarHeader;
 
 
 /* A few useful constants */
 #define TAR_MAGIC          "ustar"        /* ustar and a null */
-//#define TAR_VERSION      "00"           /* 00 and no null */
-#define TAR_VERSION        "  "           /* Be compatable with old GNU format */
+#define TAR_VERSION        "  "           /* Be compatable with GNU tar format */
 #define TAR_MAGIC_LEN       6
 #define TAR_VERSION_LEN     2
 #define TAR_BLOCK_SIZE      512
@@ -170,8 +170,10 @@ static int writeTarFile(const char* tarName, int tostdoutFlag,
 extern int tar_main(int argc, char **argv)
 {
        char** excludeList=NULL;
+#if defined BB_FEATURE_TAR_EXCLUDE
        int excludeListSize=0;
-       const char *tarName=NULL;
+#endif
+       const char *tarName="-";
        int listFlag     = FALSE;
        int extractFlag  = FALSE;
        int createFlag   = FALSE;
@@ -183,19 +185,21 @@ extern int tar_main(int argc, char **argv)
                usage(tar_usage);
 
        /* Parse any options */
-       while (--argc > 0 && **(++argv) == '-') {
+       while (--argc > 0 && strspn(*(++argv), "-cxt") >0 ) {
                stopIt=FALSE;
-               while (stopIt==FALSE && *(++(*argv))) {
+               while (stopIt==FALSE && *argv && **argv) {
                        switch (**argv) {
                                case 'f':
                                        if (--argc == 0) {
                                                fatalError( "Option requires an argument: No file specified\n");
                                        }
-                                       if (tarName != NULL)
+                                       if (*tarName != '-')
                                                fatalError( "Only one 'f' option allowed\n");
                                        tarName = *(++argv);
                                        if (tarName == NULL)
                                                fatalError( "Option requires an argument: No file specified\n");
+                                       if (!strcmp(tarName, "-"))
+                                               tostdoutFlag = TRUE;
                                        stopIt=TRUE;
                                        break;
 
@@ -224,38 +228,38 @@ extern int tar_main(int argc, char **argv)
                                        tostdoutFlag = TRUE;
                                        tarName = "-";
                                        break;
-                               case 'X':
-                                       if (--argc == 0) {
-                                               fatalError( "Option requires an argument: No file specified\n");
+                               case '-':
+#if defined BB_FEATURE_TAR_EXCLUDE
+                                       if (strcmp(*argv, "-exclude")==0) {
+                                               if (--argc == 0) {
+                                                       fatalError( "Option requires an argument: No file specified\n");
+                                               }
+                                               excludeList=realloc( excludeList, sizeof(char**) * (excludeListSize+2));
+                                               excludeList[excludeListSize] = *(++argv);
+                                               /* Remove leading "/"s */
+                                               if (*excludeList[excludeListSize] =='/') {
+                                                       excludeList[excludeListSize] = (excludeList[excludeListSize])+1;
+                                               }
+                                               if (excludeList[excludeListSize++] == NULL)
+                                                       fatalError( "Option requires an argument: No file specified\n");
+                                               /* Tack a NULL onto the end of the list */
+                                               excludeList[excludeListSize] = NULL;
+                                               stopIt=TRUE;
+                                               break;
                                        }
-                                       excludeList=realloc( excludeList, sizeof(char**) * (excludeListSize+1));
-                                       excludeList[excludeListSize] = *(++argv);
-                                       /* Remove leading "/"s */
-                                       if (*excludeList[excludeListSize] =='/') {
-                                               excludeList[excludeListSize] = (excludeList[excludeListSize])+1;
+#endif
+                                       if (strcmp(*argv, "-help")==0) {
+                                               usage(tar_usage);
                                        }
-                                       if (excludeList[excludeListSize++] == NULL)
-                                               fatalError( "Option requires an argument: No file specified\n");
-                                       stopIt=TRUE;
-                                       break;
-
-                               case '-':
-                                       usage(tar_usage);
                                        break;
 
                                default:
                                        fatalError( "Unknown tar flag '%c'\n" 
                                                        "Try `tar --help' for more information\n", **argv);
                        }
+                       ++(*argv);
                }
        }
-#if 0
-       for (i=0; i<excludeListSize; i++) {
-               printf( "%s\n", excludeList[i]);
-               fflush(stdout);
-       }
-#endif
-
 
        /* 
         * Do the correct type of action supplying the rest of the
@@ -267,7 +271,8 @@ extern int tar_main(int argc, char **argv)
 #else
                exit(writeTarFile(tarName, tostdoutFlag, verboseFlag, argc, argv, excludeList));
 #endif
-       } else {
+       }
+       if (listFlag == TRUE || extractFlag == TRUE) {
                exit(readTarFile(tarName, extractFlag, listFlag, tostdoutFlag, verboseFlag, excludeList));
        }
 
@@ -300,11 +305,14 @@ tarExtractRegularFile(TarInfo *header, int extractFlag, int tostdoutFlag)
 
        /* Open the file to be written, if a file is supposed to be written */
        if (extractFlag==TRUE && tostdoutFlag==FALSE) {
-               if ((outFd=open(header->name, O_CREAT|O_TRUNC|O_WRONLY, header->mode & ~S_IFMT)) < 0)
-                       errorMsg(io_error, header->name, strerror(errno)); 
                /* Create the path to the file, just in case it isn't there...
                 * This should not screw up path permissions or anything. */
                createPath(header->name, 0777);
+               if ((outFd=open(header->name, O_CREAT|O_TRUNC|O_WRONLY, 
+                                               header->mode & ~S_IFMT)) < 0) {
+                       errorMsg(io_error, header->name, strerror(errno)); 
+                       return( FALSE);
+               }
        }
 
        /* Write out the file, if we are supposed to be doing that */
@@ -322,7 +330,7 @@ tarExtractRegularFile(TarInfo *header, int extractFlag, int tostdoutFlag)
                }
                if ( (readSize = fullRead(header->tarFd, buffer, readSize)) <= 0 ) {
                        /* Tarball seems to have a problem */
-                       errorMsg("tar: Unexpected EOF in archive\n"); 
+                       errorMsg("Unexpected EOF in archive\n"); 
                        return( FALSE);
                }
                if ( readSize < writeSize )
@@ -336,6 +344,8 @@ tarExtractRegularFile(TarInfo *header, int extractFlag, int tostdoutFlag)
                                errorMsg(io_error, header->name, strerror(errno)); 
                                return( FALSE);
                        }
+               } else {
+                       actualWriteSz=writeSize;
                }
 
                size -= actualWriteSz;
@@ -358,7 +368,7 @@ tarExtractDirectory(TarInfo *header, int extractFlag, int tostdoutFlag)
                return( TRUE);
 
        if (createPath(header->name, header->mode) != TRUE) {
-               errorMsg("tar: %s: Cannot mkdir: %s\n", 
+               errorMsg("%s: Cannot mkdir: %s\n", 
                                header->name, strerror(errno)); 
                return( FALSE);
        }
@@ -378,7 +388,7 @@ tarExtractHardLink(TarInfo *header, int extractFlag, int tostdoutFlag)
                return( TRUE);
 
        if (link(header->linkname, header->name) < 0) {
-               errorMsg("tar: %s: Cannot create hard link to '%s': %s\n", 
+               errorMsg("%s: Cannot create hard link to '%s': %s\n", 
                                header->name, header->linkname, strerror(errno)); 
                return( FALSE);
        }
@@ -396,7 +406,7 @@ tarExtractSymLink(TarInfo *header, int extractFlag, int tostdoutFlag)
 
 #ifdef S_ISLNK
        if (symlink(header->linkname, header->name) < 0) {
-               errorMsg("tar: %s: Cannot create symlink to '%s': %s\n", 
+               errorMsg("%s: Cannot create symlink to '%s': %s\n", 
                                header->name, header->linkname, strerror(errno)); 
                return( FALSE);
        }
@@ -411,7 +421,7 @@ tarExtractSymLink(TarInfo *header, int extractFlag, int tostdoutFlag)
        /* Do not change permissions or date on symlink,
         * since it changes the pointed to file instead.  duh. */
 #else
-       errorMsg("tar: %s: Cannot create symlink to '%s': %s\n", 
+       errorMsg("%s: Cannot create symlink to '%s': %s\n", 
                        header->name, header->linkname, 
                        "symlinks not supported"); 
 #endif
@@ -426,13 +436,13 @@ tarExtractSpecial(TarInfo *header, int extractFlag, int tostdoutFlag)
 
        if (S_ISCHR(header->mode) || S_ISBLK(header->mode) || S_ISSOCK(header->mode)) {
                if (mknod(header->name, header->mode, makedev(header->devmajor, header->devminor)) < 0) {
-                       errorMsg("tar: %s: Cannot mknod: %s\n",
+                       errorMsg("%s: Cannot mknod: %s\n",
                                header->name, strerror(errno)); 
                        return( FALSE);
                }
        } else if (S_ISFIFO(header->mode)) {
                if (mkfifo(header->name, header->mode) < 0) {
-                       errorMsg("tar: %s: Cannot mkfifo: %s\n",
+                       errorMsg("%s: Cannot mkfifo: %s\n",
                                header->name, strerror(errno)); 
                        return( FALSE);
                }
@@ -480,7 +490,7 @@ readTarHeader(struct TarHeader *rawHeader, struct TarInfo *header)
                        ++*(header->name);
 
                if (alreadyWarned == FALSE) {
-                       errorMsg("tar: Removing leading '/' from member names\n");
+                       errorMsg("Removing leading '/' from member names\n");
                        alreadyWarned = TRUE;
                }
        }
@@ -493,18 +503,6 @@ readTarHeader(struct TarHeader *rawHeader, struct TarInfo *header)
        chksum = getOctal(rawHeader->chksum, sizeof(rawHeader->chksum));
        header->type  = rawHeader->typeflag;
        header->linkname  = rawHeader->linkname;
-       /* Check for and relativify any absolute paths */
-       if ( *(header->linkname) == '/' ) {
-               static int alreadyWarned=FALSE;
-
-               while (*(header->linkname) == '/')
-                       ++*(header->linkname);
-
-               if (alreadyWarned == FALSE) {
-                       errorMsg("tar: Removing leading '/' from link names\n");
-                       alreadyWarned = TRUE;
-               }
-       }
        header->devmajor  = getOctal(rawHeader->devmajor, sizeof(rawHeader->devmajor));
        header->devminor  = getOctal(rawHeader->devminor, sizeof(rawHeader->devminor));
 
@@ -532,11 +530,13 @@ readTarHeader(struct TarHeader *rawHeader, struct TarInfo *header)
 static int readTarFile(const char* tarName, int extractFlag, int listFlag, 
                int tostdoutFlag, int verboseFlag, char** excludeList)
 {
-       int status, tarFd=0;
+       int status, tarFd=-1;
        int errorFlag=FALSE;
        TarHeader rawHeader;
        TarInfo header;
-       //int skipFileFlag=FALSE;
+#if defined BB_FEATURE_TAR_EXCLUDE
+       char** tmpList;
+#endif
 
        /* Open the tar file for reading.  */
        if (!strcmp(tarName, "-"))
@@ -557,7 +557,6 @@ static int readTarFile(const char* tarName, int extractFlag, int listFlag,
 
                /* First, try to read the header */
                if ( readTarHeader(&rawHeader, &header) == FALSE ) {
-                       close( tarFd);
                        if ( *(header.name) == '\0' ) {
                                goto endgame;
                        } else {
@@ -568,7 +567,34 @@ static int readTarFile(const char* tarName, int extractFlag, int listFlag,
                }
                if ( *(header.name) == '\0' )
                                goto endgame;
-
+               header.tarFd = tarFd;
+
+#if defined BB_FEATURE_TAR_EXCLUDE
+               {
+                       int skipFlag=FALSE;
+                       /* Check for excluded files....  */
+                       for (tmpList=excludeList; tmpList && *tmpList; tmpList++) {
+                               /* Do some extra hoop jumping for when directory names
+                                * end in '/' but the entry in tmpList doesn't */
+                               if (strncmp( *tmpList, header.name, strlen(*tmpList))==0 || (
+                                                       header.name[strlen(header.name)-1]=='/'
+                                                       && strncmp( *tmpList, header.name, 
+                                                               MIN(strlen(header.name)-1, strlen(*tmpList)))==0)) {
+                                       /* If it is a regular file, pretend to extract it with
+                                        * the extractFlag set to FALSE, so the junk in the tarball
+                                        * is properly skipped over */
+                                       if ( header.type==REGTYPE || header.type==REGTYPE0 ) {
+                                                       tarExtractRegularFile(&header, FALSE, FALSE);
+                                       }
+                                       skipFlag=TRUE;
+                                       break;
+                               }
+                       }
+                       /* There are not the droids you're looking for, move along */
+                       if (skipFlag==TRUE)
+                               continue;
+               }
+#endif
                /* Special treatment if the list (-t) flag is on */
                if (verboseFlag == TRUE && extractFlag == FALSE) {
                        int len, len1;
@@ -593,7 +619,7 @@ static int readTarFile(const char* tarName, int extractFlag, int listFlag,
                                len1=snprintf(buf, sizeof(buf), "%ld,%-ld ", 
                                                header.devmajor, header.devminor);
                        } else {
-                               len1=snprintf(buf, sizeof(buf), "%d ", header.size);
+                               len1=snprintf(buf, sizeof(buf), "%lu ", (long)header.size);
                        }
                        /* Jump through some hoops to make the columns match up */
                        for(;(len+len1)<31;len++)
@@ -623,15 +649,9 @@ static int readTarFile(const char* tarName, int extractFlag, int listFlag,
                        printf("\n");
                }
 
-#if 0
-               /* See if we want to restore this file or not */
-               skipFileFlag=FALSE;
-               if (wantFileName(outName) == FALSE) {
-                       skipFileFlag = TRUE;
-               }
-#endif
                /* Remove any clutter lying in our way */
-               unlink( header.name);
+               if (extractFlag == TRUE)        /* .. but only if we are extracting (as */
+                       unlink( header.name);   /* opposed to listing) (rob@sysgo.de)   */
 
                /* If we got here, we can be certain we have a legitimate 
                 * header to work with.  So work with it.  */
@@ -675,7 +695,7 @@ static int readTarFile(const char* tarName, int extractFlag, int listFlag,
                return ( FALSE);
        }
        else if (errorFlag==TRUE) {
-               errorMsg( "tar: Error exit delayed from previous errors\n");
+               errorMsg( "Error exit delayed from previous errors\n");
                return( FALSE);
        } else 
                return( status);
@@ -685,7 +705,7 @@ endgame:
        close( tarFd);
        if ( *(header.name) == '\0' ) {
                if (errorFlag==TRUE)
-                       errorMsg( "tar: Error exit delayed from previous errors\n");
+                       errorMsg( "Error exit delayed from previous errors\n");
                else
                        return( TRUE);
        } 
@@ -751,7 +771,9 @@ writeTarHeader(struct TarBallInfo *tbInfo, const char *fileName, struct stat *st
 {
        long chksum=0;
        struct TarHeader header;
+#if defined BB_FEATURE_TAR_EXCLUDE
        char** tmpList;
+#endif
        const unsigned char *cp = (const unsigned char *) &header;
        ssize_t size = sizeof(struct TarHeader);
 
@@ -760,7 +782,7 @@ writeTarHeader(struct TarBallInfo *tbInfo, const char *fileName, struct stat *st
        if (*fileName=='/') {
                static int alreadyWarned=FALSE;
                if (alreadyWarned==FALSE) {
-                       errorMsg("tar: Removing leading '/' from member names\n");
+                       errorMsg("Removing leading '/' from member names\n");
                        alreadyWarned=TRUE;
                }
                strncpy(header.name, fileName+1, sizeof(header.name)); 
@@ -769,15 +791,23 @@ writeTarHeader(struct TarBallInfo *tbInfo, const char *fileName, struct stat *st
                strncpy(header.name, fileName, sizeof(header.name)); 
        }
 
-       /* Now that leading '/''s have been removed, 
-        * check for excluded files....  */
+#if defined BB_FEATURE_TAR_EXCLUDE
+       /* Check for excluded files....  */
        for (tmpList=tbInfo->excludeList; tmpList && *tmpList; tmpList++) {
-               printf( "comparing '%s' and '%s'", *tmpList, header.name);
-               if (strcmp( *tmpList, header.name)==0)
-                       printf( ": match\n");
-               else
-                       printf( "\n");
+               /* Do some extra hoop jumping for when directory names
+                * end in '/' but the entry in tmpList doesn't */
+               if (strncmp( *tmpList, header.name, strlen(*tmpList))==0 || (
+                                       header.name[strlen(header.name)-1]=='/'
+                                       && strncmp( *tmpList, header.name, 
+                                               MIN(strlen(header.name)-1, strlen(*tmpList)))==0)) {
+                       /* Set the mode to something that is not a regular file, thereby
+                        * faking out writeTarFile into thinking that nothing further need
+                        * be done for this file.  Yes, I know this is ugly, but it works. */
+                       statbuf->st_mode = 0;
+                       return( TRUE);
+               }
        }
+#endif
 
        putOctal(header.mode, sizeof(header.mode), statbuf->st_mode);
        putOctal(header.uid, sizeof(header.uid), statbuf->st_uid);
@@ -795,25 +825,18 @@ writeTarHeader(struct TarBallInfo *tbInfo, const char *fileName, struct stat *st
        if (! *header.uname)
                strcpy(header.uname, "root");
 
-       // FIXME (or most likely not): I break Hard Links
+       /* WARNING/NOTICE: I break Hard Links */
        if (S_ISLNK(statbuf->st_mode)) {
+               int link_size=0;
                char buffer[BUFSIZ];
                header.typeflag  = SYMTYPE;
-               if ( readlink(fileName, buffer, sizeof(buffer) - 1) < 0) {
+               link_size = readlink(fileName, buffer, sizeof(buffer) - 1);
+               if ( link_size < 0) {
                        errorMsg("Error reading symlink '%s': %s\n", header.name, strerror(errno));
                        return ( FALSE);
                }
-               if (*buffer=='/') {
-                       static int alreadyWarned=FALSE;
-                       if (alreadyWarned==FALSE) {
-                               errorMsg("tar: Removing leading '/' from link names\n");
-                               alreadyWarned=TRUE;
-                       }
-                       strncpy(header.linkname, buffer+1, sizeof(header.linkname)); 
-               }
-               else {
-                       strncpy(header.linkname, buffer, sizeof(header.linkname)); 
-               }
+               buffer[link_size] = '\0';
+               strncpy(header.linkname, buffer, sizeof(header.linkname)); 
        } else if (S_ISDIR(statbuf->st_mode)) {
                header.typeflag  = DIRTYPE;
                strncat(header.name, "/", sizeof(header.name)); 
@@ -831,7 +854,7 @@ writeTarHeader(struct TarBallInfo *tbInfo, const char *fileName, struct stat *st
                header.typeflag  = REGTYPE;
                putOctal(header.size, sizeof(header.size), statbuf->st_size);
        } else {
-               errorMsg("tar: %s: Unknown file type\n", fileName);
+               errorMsg("%s: Unknown file type\n", fileName);
                return ( FALSE);
        }
 
@@ -869,7 +892,7 @@ static int writeFileToTarball(const char *fileName, struct stat *statbuf, void*
 
        /* It is against the rules to archive a socket */
        if (S_ISSOCK(statbuf->st_mode)) {
-               errorMsg("tar: %s: socket ignored\n", fileName);
+               errorMsg("%s: socket ignored\n", fileName);
                return( TRUE);
        }
 
@@ -878,7 +901,7 @@ static int writeFileToTarball(const char *fileName, struct stat *statbuf, void*
         * the new tarball */
        if (tbInfo->statBuf.st_dev == statbuf->st_dev &&
                        tbInfo->statBuf.st_ino == statbuf->st_ino) {
-               errorMsg("tar: %s: file is the archive; skipping\n", fileName);
+               errorMsg("%s: file is the archive; skipping\n", fileName);
                return( TRUE);
        }
 
@@ -894,7 +917,7 @@ static int writeFileToTarball(const char *fileName, struct stat *statbuf, void*
 
                /* open the file we want to archive, and make sure all is well */
                if ((inputFileFd = open(fileName, O_RDONLY)) < 0) {
-                       errorMsg("tar: %s: Cannot open: %s\n", fileName, strerror(errno));
+                       errorMsg("%s: Cannot open: %s\n", fileName, strerror(errno));
                        return( FALSE);
                }
                
@@ -932,7 +955,7 @@ static int writeTarFile(const char* tarName, int tostdoutFlag,
 
        /* Make sure there is at least one file to tar up.  */
        if (argc <= 0)
-               fatalError("tar: Cowardly refusing to create an empty archive\n");
+               fatalError("Cowardly refusing to create an empty archive\n");
 
        /* Open the tar file for writing.  */
        if (tostdoutFlag == TRUE)
@@ -940,7 +963,7 @@ static int writeTarFile(const char* tarName, int tostdoutFlag,
        else
                tbInfo.tarFd = open (tarName, O_WRONLY | O_CREAT | O_TRUNC, 0644);
        if (tbInfo.tarFd < 0) {
-               errorMsg( "tar: Error opening '%s': %s\n", tarName, strerror(errno));
+               errorMsg( "Error opening '%s': %s\n", tarName, strerror(errno));
                return ( FALSE);
        }
        tbInfo.excludeList=excludeList;
@@ -965,10 +988,16 @@ static int writeTarFile(const char* tarName, int tostdoutFlag,
        for (size=0; size<(2*TAR_BLOCK_SIZE); size++) {
                write(tbInfo.tarFd, "\0", 1);
        }
+
+       /* To be pedantically correct, we would check if the tarball
+        * is smaller then 20 tar blocks, and pad it if it was smaller,
+        * but that isn't necessary for GNU tar interoperability, and
+        * so is considered a waste of space */
+
        /* Hang up the tools, close up shop, head home */
        close(tarFd);
        if (errorFlag == TRUE) {
-               errorMsg("tar: Error exit delayed from previous errors\n");
+               errorMsg("Error exit delayed from previous errors\n");
                return(FALSE);
        }
        return( TRUE);