static int
tarExtractDirectory(TarInfo *header, int extractFlag, int tostdoutFlag)
{
+ int result;
if (extractFlag==FALSE || tostdoutFlag==TRUE)
return( TRUE);
/* make the final component, just in case it was
* omitted by create_path() (which will skip the
* directory if it doesn't have a terminating '/') */
- if (mkdir(header->name, header->mode) < 0 && errno != EEXIST) {
+ result = mkdir(header->name, header->mode);
+ /* Don't fix permissions on pre-existing directories */
+ if (result == 0) {
+ fixUpPermissions(header);
+ } else if (result < 0 && errno != EEXIST) {
perror_msg("%s", header->name);
return FALSE;
}
- fixUpPermissions(header);
return( TRUE);
}
static int alreadyWarned=FALSE;
while (*(header->name) == '/')
- ++*(header->name);
+ header->name++;
if (alreadyWarned == FALSE) {
error_msg("Removing leading '/' from member names");
}
}
if ( *(header.name) == '\0' )
- goto endgame;
+ continue;
header.tarFd = tarFd;
/* Skip funky extra GNU headers that precede long files */
header.typeflag = LNKTYPE;
strncpy(header.linkname, tbInfo->hlInfo->name, sizeof(header.linkname));
} else if (S_ISLNK(statbuf->st_mode)) {
- int link_size=0;
- char buffer[BUFSIZ];
- header.typeflag = SYMTYPE;
- link_size = readlink(real_name, buffer, sizeof(buffer) - 1);
- if ( link_size < 0) {
- perror_msg("Error reading symlink '%s'", header.name);
+ char *lpath = xreadlink(real_name);
+ if (!lpath) /* Already printed err msg inside xreadlink() */
return ( FALSE);
- }
- buffer[link_size] = '\0';
- strncpy(header.linkname, buffer, sizeof(header.linkname));
+ header.typeflag = SYMTYPE;
+ strncpy(header.linkname, lpath, sizeof(header.linkname));
+ free(lpath);
} else if (S_ISDIR(statbuf->st_mode)) {
header.typeflag = DIRTYPE;
strncat(header.name, "/", sizeof(header.name));