Closing bug 730. libbb run_parts is using scandir (a GNUism),
[oweals/busybox.git] / sysklogd / syslogd.c
index 8f9d75cc6378bb94c7ab41713b71053299586498..9e030bd63dd957a66acdbae4ef57e1bf6d1aa51a 100644 (file)
  *
  * Maintainer: Gennady Feldman <gfeldman@gena01.com> as of Mar 12, 2001
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
- *
+ * Licensed under the GPL v2 or later, see the file LICENSE in this tarball.
  */
 
-#include <stdio.h>
-#include <stdlib.h>
-#include <ctype.h>
-#include <errno.h>
-#include <fcntl.h>
-#include <getopt.h>
-#include <netdb.h>
+#include "busybox.h"
 #include <paths.h>
-#include <signal.h>
-#include <stdarg.h>
 #include <stdbool.h>
-#include <time.h>
-#include <string.h>
-#include <unistd.h>
-#include <sys/socket.h>
-#include <sys/types.h>
 #include <sys/un.h>
-#include <sys/param.h>
-
-#include "busybox.h"
 
 /* SYSLOG_NAMES defined to pull some extra junk from syslog.h */
 #define SYSLOG_NAMES
 #include <sys/syslog.h>
 #include <sys/uio.h>
 
-/* Path for the file where all log messages are written */
-#define __LOG_FILE "/var/log/messages"
-
 /* Path to the unix socket */
 static char lfile[MAXPATHLEN];
 
-static const char *logFilePath = __LOG_FILE;
+/* Path for the file where all log messages are written */
+static const char *logFilePath = "/var/log/messages";
 
 #ifdef CONFIG_FEATURE_ROTATE_LOGFILE
 /* max size of message file before being rotated */
@@ -71,6 +40,9 @@ static int logFileRotate = 1;
 /* interval between marks in seconds */
 static int MarkInterval = 20 * 60;
 
+/* level of messages to be locally logged */
+static int logLevel = 8;
+
 /* localhost's name */
 static char LocalHostName[64];
 
@@ -80,24 +52,52 @@ static char LocalHostName[64];
 static int remotefd = -1;
 static struct sockaddr_in remoteaddr;
 
-/* where do we log? */
-static char *RemoteHost;
-
-/* what port to log to? */
-static int RemotePort = 514;
-
-/* To remote log or not to remote log, that is the question. */
-static int doRemoteLog = FALSE;
-static int local_logging = FALSE;
 #endif
 
-/* Make loging output smaller. */
-static bool small = false;
-
+/* options */
+/* Correct regardless of combination of CONFIG_xxx */
+enum {
+       OPTBIT_mark = 0, // -m
+       OPTBIT_nofork, // -n
+       OPTBIT_outfile, // -O
+       OPTBIT_loglevel, // -l
+       OPTBIT_small, // -S
+       USE_FEATURE_ROTATE_LOGFILE(OPTBIT_filesize   ,) // -s
+       USE_FEATURE_ROTATE_LOGFILE(OPTBIT_rotatecnt  ,) // -b
+       USE_FEATURE_REMOTE_LOG(    OPTBIT_remote     ,) // -R
+       USE_FEATURE_REMOTE_LOG(    OPTBIT_localtoo   ,) // -L
+       USE_FEATURE_IPC_SYSLOG(    OPTBIT_circularlog,) // -C
+
+       OPT_mark        = 1 << OPTBIT_mark    ,
+       OPT_nofork      = 1 << OPTBIT_nofork  ,
+       OPT_outfile     = 1 << OPTBIT_outfile ,
+       OPT_loglevel    = 1 << OPTBIT_loglevel,
+       OPT_small       = 1 << OPTBIT_small   ,
+       OPT_filesize    = USE_FEATURE_ROTATE_LOGFILE((1 << OPTBIT_filesize   )) + 0,
+       OPT_rotatecnt   = USE_FEATURE_ROTATE_LOGFILE((1 << OPTBIT_rotatecnt  )) + 0,
+       OPT_remotelog   = USE_FEATURE_REMOTE_LOG(    (1 << OPTBIT_remote     )) + 0,
+       OPT_locallog    = USE_FEATURE_REMOTE_LOG(    (1 << OPTBIT_localtoo   )) + 0,
+       OPT_circularlog = USE_FEATURE_IPC_SYSLOG(    (1 << OPTBIT_circularlog)) + 0,
+};
+#define OPTION_STR "m:nO:l:S" \
+       USE_FEATURE_ROTATE_LOGFILE("s:" ) \
+       USE_FEATURE_ROTATE_LOGFILE("b:" ) \
+       USE_FEATURE_REMOTE_LOG(    "R:" ) \
+       USE_FEATURE_REMOTE_LOG(    "L"  ) \
+       USE_FEATURE_IPC_SYSLOG(    "C::")
+#define OPTION_DECL *opt_m, *opt_l \
+       USE_FEATURE_ROTATE_LOGFILE(,*opt_s) \
+       USE_FEATURE_ROTATE_LOGFILE(,*opt_b) \
+       USE_FEATURE_REMOTE_LOG(    ,*opt_R) \
+       USE_FEATURE_IPC_SYSLOG(    ,*opt_C = NULL)
+#define OPTION_PARAM &opt_m, &logFilePath, &opt_l \
+       USE_FEATURE_ROTATE_LOGFILE(,&opt_s) \
+       USE_FEATURE_ROTATE_LOGFILE(,&opt_b) \
+       USE_FEATURE_REMOTE_LOG(    ,&opt_R) \
+       USE_FEATURE_IPC_SYSLOG(    ,&opt_C)
 
 #define MAXLINE         1024   /* maximum line length */
 
-
 /* circular buffer variables/structures */
 #ifdef CONFIG_FEATURE_IPC_SYSLOG
 
@@ -111,50 +111,28 @@ static bool small = false;
 #include <sys/shm.h>
 
 /* our shared key */
-static const long KEY_ID = 0x414e4547; /*"GENA" */
+#define KEY_ID ((long)0x414e4547) /* "GENA" */
 
 // Semaphore operation structures
 static struct shbuf_ds {
-       int size;                       // size of data written
-       int head;                       // start of message list
-       int tail;                       // end of message list
-       char data[1];           // data/messages
-} *buf = NULL;                 // shared memory pointer
+       int size;       // size of data written
+       int head;       // start of message list
+       int tail;       // end of message list
+       char data[1];   // data/messages
+} *shbuf = NULL;        // shared memory pointer
 
 static struct sembuf SMwup[1] = { {1, -1, IPC_NOWAIT} };       // set SMwup
 static struct sembuf SMwdn[3] = { {0, 0}, {1, 0}, {1, +1} };   // set SMwdn
 
-static int shmid = -1; // ipc shared memory id
-static int s_semid = -1;       // ipc semaphore id
+static int shmid = -1;   // ipc shared memory id
+static int s_semid = -1; // ipc semaphore id
 static int shm_size = ((CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE)*1024);  // default shm size
-static int circular_logging = FALSE;
 
-/*
- * sem_up - up()'s a semaphore.
- */
-static inline void sem_up(int semid)
+static void ipcsyslog_cleanup(void)
 {
-       if (semop(semid, SMwup, 1) == -1) {
-               bb_perror_msg_and_die("semop[SMwup]");
-       }
-}
-
-/*
- * sem_down - down()'s a semaphore
- */
-static inline void sem_down(int semid)
-{
-       if (semop(semid, SMwdn, 3) == -1) {
-               bb_perror_msg_and_die("semop[SMwdn]");
-       }
-}
-
-
-void ipcsyslog_cleanup(void)
-{
-       printf("Exiting Syslogd!\n");
+       puts("Exiting syslogd!");
        if (shmid != -1) {
-               shmdt(buf);
+               shmdt(shbuf);
        }
 
        if (shmid != -1) {
@@ -165,24 +143,28 @@ void ipcsyslog_cleanup(void)
        }
 }
 
-void ipcsyslog_init(void)
+static void ipcsyslog_init(void)
 {
-       if (buf == NULL) {
-               if ((shmid = shmget(KEY_ID, shm_size, IPC_CREAT | 1023)) == -1) {
+       if (shbuf == NULL) {
+               shmid = shmget(KEY_ID, shm_size, IPC_CREAT | 1023);
+               if (shmid == -1) {
                        bb_perror_msg_and_die("shmget");
                }
 
-               if ((buf = shmat(shmid, NULL, 0)) == NULL) {
+               shbuf = shmat(shmid, NULL, 0);
+               if (!shbuf) {
                        bb_perror_msg_and_die("shmat");
                }
 
-               buf->size = shm_size - sizeof(*buf);
-               buf->head = buf->tail = 0;
+               shbuf->size = shm_size - sizeof(*shbuf);
+               shbuf->head = shbuf->tail = 0;
 
                // we'll trust the OS to set initial semval to 0 (let's hope)
-               if ((s_semid = semget(KEY_ID, 2, IPC_CREAT | IPC_EXCL | 1023)) == -1) {
+               s_semid = semget(KEY_ID, 2, IPC_CREAT | IPC_EXCL | 1023);
+               if (s_semid == -1) {
                        if (errno == EEXIST) {
-                               if ((s_semid = semget(KEY_ID, 2, 0)) == -1) {
+                               s_semid = semget(KEY_ID, 2, 0);
+                               if (s_semid == -1) {
                                        bb_perror_msg_and_die("semget");
                                }
                        } else {
@@ -195,11 +177,14 @@ void ipcsyslog_init(void)
 }
 
 /* write message to buffer */
-void circ_message(const char *msg)
+static void circ_message(const char *msg)
 {
        int l = strlen(msg) + 1;        /* count the whole message w/ '\0' included */
+       const char * const fail_msg = "Can't find the terminator token%s?\n";
 
-       sem_down(s_semid);
+       if (semop(s_semid, SMwdn, 3) == -1) {
+               bb_perror_msg_and_die("SMwdn");
+       }
 
        /*
         * Circular Buffer Algorithm:
@@ -222,77 +207,80 @@ void circ_message(const char *msg)
         *      "tail" are actually offsets from the beginning of the buffer.
         *
         * Note: This algorithm uses Linux IPC mechanism w/ shared memory and semaphores to provide
-        *       a threasafe way of handling shared memory operations.
+        *       a threadsafe way of handling shared memory operations.
         */
-       if ((buf->tail + l) < buf->size) {
+       if ((shbuf->tail + l) < shbuf->size) {
                /* before we append the message we need to check the HEAD so that we won't
                   overwrite any of the message that we still need and adjust HEAD to point
                   to the next message! */
-               if (buf->tail < buf->head) {
-                       if ((buf->tail + l) >= buf->head) {
+               if (shbuf->tail < shbuf->head) {
+                       if ((shbuf->tail + l) >= shbuf->head) {
                                /* we need to move the HEAD to point to the next message
                                 * Theoretically we have enough room to add the whole message to the
                                 * buffer, because of the first outer IF statement, so we don't have
                                 * to worry about overflows here!
                                 */
-                               int k = buf->tail + l - buf->head;      /* we need to know how many bytes
-                                                                                                          we are overwriting to make
-                                                                                                          enough room */
+                               /* we need to know how many bytes we are overwriting to make enough room */
+                               int k = shbuf->tail + l - shbuf->head;
                                char *c =
-                                       memchr(buf->data + buf->head + k, '\0',
-                                                  buf->size - (buf->head + k));
-                               if (c != NULL) {        /* do a sanity check just in case! */
-                                       buf->head = c - buf->data + 1;  /* we need to convert pointer to
-                                                                                                          offset + skip the '\0' since
-                                                                                                          we need to point to the beginning
-                                                                                                          of the next message */
+                                       memchr(shbuf->data + shbuf->head + k, '\0',
+                                                  shbuf->size - (shbuf->head + k));
+                               if (c != NULL) { /* do a sanity check just in case! */
+                                       /* we need to convert pointer to offset + skip the '\0'
+                                          since we need to point to the beginning of the next message */
+                                       shbuf->head = c - shbuf->data + 1;
                                        /* Note: HEAD is only used to "retrieve" messages, it's not used
                                           when writing messages into our buffer */
-                               } else {        /* show an error message to know we messed up? */
-                                       printf("Weird! Can't find the terminator token??? \n");
-                                       buf->head = 0;
+                               } else { /* show an error message to know we messed up? */
+                                       printf(fail_msg,"");
+                                       shbuf->head = 0;
                                }
                        }
                }
 
                /* in other cases no overflows have been done yet, so we don't care! */
                /* we should be ok to append the message now */
-               strncpy(buf->data + buf->tail, msg, l); /* append our message */
-               buf->tail += l; /* count full message w/ '\0' terminating char */
+               strncpy(shbuf->data + shbuf->tail, msg, l);     /* append our message */
+               shbuf->tail += l;       /* count full message w/ '\0' terminating char */
        } else {
                /* we need to break up the message and "circle" it around */
                char *c;
-               int k = buf->tail + l - buf->size;      /* count # of bytes we don't fit */
+               int k = shbuf->tail + l - shbuf->size;  /* count # of bytes we don't fit */
 
                /* We need to move HEAD! This is always the case since we are going
-                * to "circle" the message.
-                */
-               c = memchr(buf->data + k, '\0', buf->size - k);
+                * to "circle" the message. */
+               c = memchr(shbuf->data + k, '\0', shbuf->size - k);
 
                if (c != NULL) {        /* if we don't have '\0'??? weird!!! */
                        /* move head pointer */
-                       buf->head = c - buf->data + 1;
+                       shbuf->head = c - shbuf->data + 1;
 
                        /* now write the first part of the message */
-                       strncpy(buf->data + buf->tail, msg, l - k - 1);
+                       strncpy(shbuf->data + shbuf->tail, msg, l - k - 1);
 
                        /* ALWAYS terminate end of buffer w/ '\0' */
-                       buf->data[buf->size - 1] = '\0';
+                       shbuf->data[shbuf->size - 1] = '\0';
 
                        /* now write out the rest of the string to the beginning of the buffer */
-                       strcpy(buf->data, &msg[l - k - 1]);
+                       strcpy(shbuf->data, &msg[l - k - 1]);
 
                        /* we need to place the TAIL at the end of the message */
-                       buf->tail = k + 1;
+                       shbuf->tail = k + 1;
                } else {
-                       printf
-                               ("Weird! Can't find the terminator token from the beginning??? \n");
-                       buf->head = buf->tail = 0;      /* reset buffer, since it's probably corrupted */
+                       printf(fail_msg, " from the beginning");
+                       shbuf->head = shbuf->tail = 0;  /* reset buffer, since it's probably corrupted */
                }
 
        }
-       sem_up(s_semid);
+       if (semop(s_semid, SMwup, 1) == -1) {
+               bb_perror_msg_and_die("SMwup");
+       }
+
 }
+#else
+void ipcsyslog_cleanup(void);
+void ipcsyslog_init(void);
+void circ_message(const char *msg);
 #endif                                                 /* CONFIG_FEATURE_IPC_SYSLOG */
 
 /* Note: There is also a function called "message()" in init.c */
@@ -300,7 +288,7 @@ void circ_message(const char *msg)
 static void message(char *fmt, ...) __attribute__ ((format(printf, 1, 2)));
 static void message(char *fmt, ...)
 {
-       int fd;
+       int fd = -1;
        struct flock fl;
        va_list arguments;
 
@@ -309,7 +297,7 @@ static void message(char *fmt, ...)
        fl.l_len = 1;
 
 #ifdef CONFIG_FEATURE_IPC_SYSLOG
-       if ((circular_logging == TRUE) && (buf != NULL)) {
+       if ((option_mask32 & OPT_circularlog) && shbuf) {
                char b[1024];
 
                va_start(arguments, fmt);
@@ -319,38 +307,39 @@ static void message(char *fmt, ...)
 
        } else
 #endif
-       if ((fd =
-                        device_open(logFilePath,
-                                                        O_WRONLY | O_CREAT | O_NOCTTY | O_APPEND |
-                                                        O_NONBLOCK)) >= 0) {
+       fd = device_open(logFilePath, O_WRONLY | O_CREAT
+                                       | O_NOCTTY | O_APPEND | O_NONBLOCK);
+       if (fd >= 0) {
                fl.l_type = F_WRLCK;
                fcntl(fd, F_SETLKW, &fl);
+
 #ifdef CONFIG_FEATURE_ROTATE_LOGFILE
-               if ( logFileSize > 0 ) {
+               if (ENABLE_FEATURE_ROTATE_LOGFILE && logFileSize > 0 ) {
                        struct stat statf;
                        int r = fstat(fd, &statf);
-                       if( !r && (statf.st_mode & S_IFREG)
-                               && (lseek(fd,0,SEEK_END) > logFileSize) ) {
-                               if(logFileRotate > 0) {
-                                       int i;
-                                       char oldFile[(strlen(logFilePath)+4)], newFile[(strlen(logFilePath)+4)];
-                                       for(i=logFileRotate-1;i>0;i--) {
+                       if (!r && (statf.st_mode & S_IFREG)
+                                       && (lseek(fd,0,SEEK_END) > logFileSize)) {
+                               if (logFileRotate > 0) {
+                                       int i = strlen(logFilePath) + 4;
+                                       char oldFile[i];
+                                       char newFile[i];
+                                       for (i=logFileRotate-1; i>0; i--) {
                                                sprintf(oldFile, "%s.%d", logFilePath, i-1);
                                                sprintf(newFile, "%s.%d", logFilePath, i);
                                                rename(oldFile, newFile);
                                        }
                                        sprintf(newFile, "%s.%d", logFilePath, 0);
                                        fl.l_type = F_UNLCK;
-                                       fcntl (fd, F_SETLKW, &fl);
+                                       fcntl(fd, F_SETLKW, &fl);
                                        close(fd);
                                        rename(logFilePath, newFile);
-                                       fd = device_open (logFilePath,
+                                       fd = device_open(logFilePath,
                                                   O_WRONLY | O_CREAT | O_NOCTTY | O_APPEND |
                                                   O_NONBLOCK);
                                        fl.l_type = F_WRLCK;
-                                       fcntl (fd, F_SETLKW, &fl);
+                                       fcntl(fd, F_SETLKW, &fl);
                                } else {
-                                       ftruncate( fd, 0 );
+                                       ftruncate(fd, 0);
                                }
                        }
                }
@@ -363,9 +352,8 @@ static void message(char *fmt, ...)
                close(fd);
        } else {
                /* Always send console messages to /dev/console so people will see them. */
-               if ((fd =
-                        device_open(_PATH_CONSOLE,
-                                                O_WRONLY | O_NOCTTY | O_NONBLOCK)) >= 0) {
+               fd = device_open(_PATH_CONSOLE, O_WRONLY | O_NOCTTY | O_NONBLOCK);
+               if (fd >= 0) {
                        va_start(arguments, fmt);
                        vdprintf(fd, fmt, arguments);
                        va_end(arguments);
@@ -380,37 +368,20 @@ static void message(char *fmt, ...)
        }
 }
 
-#ifdef CONFIG_FEATURE_REMOTE_LOG
-static void init_RemoteLog(void)
-{
-       memset(&remoteaddr, 0, sizeof(remoteaddr));
-       remotefd = socket(AF_INET, SOCK_DGRAM, 0);
-
-       if (remotefd < 0) {
-               bb_error_msg("cannot create socket");
-       }
-
-       remoteaddr.sin_family = AF_INET;
-       remoteaddr.sin_addr = *(struct in_addr *) *(xgethostbyname(RemoteHost))->h_addr_list;
-       remoteaddr.sin_port = htons(RemotePort);
-}
-#endif
-
 static void logMessage(int pri, char *msg)
 {
        time_t now;
        char *timestamp;
-       static char res[20] = "";
-#ifdef CONFIG_FEATURE_REMOTE_LOG       
-       static char line[MAXLINE + 1];
-#endif
+       char res[20];
        CODE *c_pri, *c_fac;
 
        if (pri != 0) {
-               for (c_fac = facilitynames;
-                        c_fac->c_name && !(c_fac->c_val == LOG_FAC(pri) << 3); c_fac++);
-               for (c_pri = prioritynames;
-                        c_pri->c_name && !(c_pri->c_val == LOG_PRI(pri)); c_pri++);
+               c_fac = facilitynames;
+               while (c_fac->c_name && !(c_fac->c_val == LOG_FAC(pri) << 3))
+                       c_fac++;
+               c_pri = prioritynames;
+               while (c_pri->c_name && !(c_pri->c_val == LOG_PRI(pri)))
+                       c_pri++;
                if (c_fac->c_name == NULL || c_pri->c_name == NULL) {
                        snprintf(res, sizeof(res), "<%d>", pri);
                } else {
@@ -432,38 +403,31 @@ static void logMessage(int pri, char *msg)
        /* todo: supress duplicates */
 
 #ifdef CONFIG_FEATURE_REMOTE_LOG
-       if (doRemoteLog == TRUE) {
+       if (option_mask32 & OPT_remotelog) {
+               char line[MAXLINE + 1];
                /* trying connect the socket */
                if (-1 == remotefd) {
-                       init_RemoteLog();
+                       remotefd = socket(AF_INET, SOCK_DGRAM, 0);
                }
-
                /* if we have a valid socket, send the message */
                if (-1 != remotefd) {
-                       now = 1;
                        snprintf(line, sizeof(line), "<%d>%s", pri, msg);
-
-               retry:
-                       /* send message to remote logger */
-                       if(( -1 == sendto(remotefd, line, strlen(line), 0,
-                                                       (struct sockaddr *) &remoteaddr,
-                                                       sizeof(remoteaddr))) && (errno == EINTR)) {
-                               /* sleep now seconds and retry (with now * 2) */
-                               sleep(now);
-                               now *= 2;
-                               goto retry;
-                       }
+                       /* send message to remote logger, ignore possible error */
+                       sendto(remotefd, line, strlen(line), 0,
+                                       (struct sockaddr *) &remoteaddr, sizeof(remoteaddr));
                }
        }
 
-       if (local_logging == TRUE)
+       if (option_mask32 & OPT_locallog)
 #endif
        {
                /* now spew out the message to wherever it is supposed to go */
-               if (small)
-                       message("%s %s\n", timestamp, msg);
-               else
-                       message("%s %s %s %s\n", timestamp, LocalHostName, res, msg);
+               if (pri == 0 || LOG_PRI(pri) < logLevel) {
+                       if (option_mask32 & OPT_small)
+                               message("%s %s\n", timestamp, msg);
+                       else
+                               message("%s %s %s %s\n", timestamp, LocalHostName, res, msg);
+               }
        }
 }
 
@@ -471,11 +435,10 @@ static void quit_signal(int sig)
 {
        logMessage(LOG_SYSLOG | LOG_INFO, "System log daemon exiting.");
        unlink(lfile);
-#ifdef CONFIG_FEATURE_IPC_SYSLOG
-       ipcsyslog_cleanup();
-#endif
+       if (ENABLE_FEATURE_IPC_SYSLOG)
+               ipcsyslog_cleanup();
 
-       exit(TRUE);
+       exit(1);
 }
 
 static void domark(int sig)
@@ -529,7 +492,7 @@ static int serveConnection(char *tmpbuf, int n_read)
        return n_read;
 }
 
-static void doSyslogd(void) __attribute__ ((noreturn));
+static void doSyslogd(void) ATTRIBUTE_NORETURN;
 static void doSyslogd(void)
 {
        struct sockaddr_un sunx;
@@ -558,35 +521,22 @@ static void doSyslogd(void)
        memset(&sunx, 0, sizeof(sunx));
        sunx.sun_family = AF_UNIX;
        strncpy(sunx.sun_path, lfile, sizeof(sunx.sun_path));
-       if ((sock_fd = socket(AF_UNIX, SOCK_DGRAM, 0)) < 0) {
-               bb_perror_msg_and_die("Couldn't get file descriptor for socket "
-                                                  _PATH_LOG);
-       }
-
+       sock_fd = xsocket(AF_UNIX, SOCK_DGRAM, 0);
        addrLength = sizeof(sunx.sun_family) + strlen(sunx.sun_path);
        if (bind(sock_fd, (struct sockaddr *) &sunx, addrLength) < 0) {
-               bb_perror_msg_and_die("Could not connect to socket " _PATH_LOG);
+               bb_perror_msg_and_die("cannot connect to socket %s", lfile);
        }
 
        if (chmod(lfile, 0666) < 0) {
-               bb_perror_msg_and_die("Could not set permission on " _PATH_LOG);
+               bb_perror_msg_and_die("cannot set permission on %s", lfile);
        }
-#ifdef CONFIG_FEATURE_IPC_SYSLOG
-       if (circular_logging == TRUE) {
+       if (ENABLE_FEATURE_IPC_SYSLOG && (option_mask32 & OPT_circularlog)) {
                ipcsyslog_init();
        }
-#endif
-
-#ifdef CONFIG_FEATURE_REMOTE_LOG
-       if (doRemoteLog == TRUE) {
-               init_RemoteLog();
-       }
-#endif
 
-       logMessage(LOG_SYSLOG | LOG_INFO, "syslogd started: " BB_BANNER);
+       logMessage(LOG_SYSLOG | LOG_INFO, "syslogd started: " "BusyBox v" BB_VER );
 
        for (;;) {
-
                FD_ZERO(&fds);
                FD_SET(sock_fd, &fds);
 
@@ -595,118 +545,99 @@ static void doSyslogd(void)
                                /* alarm may have happened. */
                                continue;
                        }
-                       bb_perror_msg_and_die("select error");
+                       bb_perror_msg_and_die("select");
                }
 
                if (FD_ISSET(sock_fd, &fds)) {
                        int i;
+#if MAXLINE > BUFSIZ
+# define TMP_BUF_SZ BUFSIZ
+#else
+# define TMP_BUF_SZ MAXLINE
+#endif
+#define tmpbuf bb_common_bufsiz1
 
-                       RESERVE_CONFIG_BUFFER(tmpbuf, MAXLINE + 1);
-
-                       memset(tmpbuf, '\0', MAXLINE + 1);
-                       if ((i = recv(sock_fd, tmpbuf, MAXLINE, 0)) > 0) {
+                       if ((i = recv(sock_fd, tmpbuf, TMP_BUF_SZ, 0)) > 0) {
+                               tmpbuf[i] = '\0';
                                serveConnection(tmpbuf, i);
                        } else {
                                bb_perror_msg_and_die("UNIX socket error");
                        }
-                       RELEASE_CONFIG_BUFFER(tmpbuf);
                }                               /* FD_ISSET() */
        }                                       /* for main loop */
 }
 
-extern int syslogd_main(int argc, char **argv)
-{
-       int opt;
-
-       int doFork = TRUE;
 
+int syslogd_main(int argc, char **argv)
+{
+       char OPTION_DECL;
        char *p;
 
        /* do normal option parsing */
-       while ((opt = getopt(argc, argv, "m:nO:s:Sb:R:LC::")) > 0) {
-               switch (opt) {
-               case 'm':
-                       MarkInterval = atoi(optarg) * 60;
-                       break;
-               case 'n':
-                       doFork = FALSE;
-                       break;
-               case 'O':
-                       logFilePath = optarg;
-                       break;
-#ifdef CONFIG_FEATURE_ROTATE_LOGFILE
-               case 's':
-                       logFileSize = atoi(optarg) * 1024;
-                       break;
-               case 'b':
-                       logFileRotate = atoi(optarg);
-                       if( logFileRotate > 99 ) logFileRotate = 99;
-                       break;
-#endif
-#ifdef CONFIG_FEATURE_REMOTE_LOG
-               case 'R':
-                       RemoteHost = bb_xstrdup(optarg);
-                       if ((p = strchr(RemoteHost, ':'))) {
-                               RemotePort = atoi(p + 1);
-                               *p = '\0';
-                       }
-                       doRemoteLog = TRUE;
-                       break;
-               case 'L':
-                       local_logging = TRUE;
-                       break;
+       getopt32(argc, argv, OPTION_STR, OPTION_PARAM);
+       if (option_mask32 & OPT_mark) MarkInterval = xatoul_range(opt_m, 0, INT_MAX/60) * 60; // -m
+       //if (option_mask32 & OPT_nofork) // -n
+       //if (option_mask32 & OPT_outfile) // -O
+       if (option_mask32 & OPT_loglevel) { // -l
+               logLevel = xatoi_u(opt_l);
+               /* Valid levels are between 1 and 8 */
+               if (logLevel < 1 || logLevel > 8)
+                       bb_show_usage();
+       }
+       //if (option_mask32 & OPT_small) // -S
+#if ENABLE_FEATURE_ROTATE_LOGFILE
+       if (option_mask32 & OPT_filesize) logFileSize = xatoul_range(opt_s, 0, INT_MAX/1024) * 1024; // -s
+       if (option_mask32 & OPT_rotatecnt) { // -b
+               logFileRotate = xatoi_u(opt_b);
+               if (logFileRotate > 99) logFileRotate = 99; 
+       }
 #endif
-#ifdef CONFIG_FEATURE_IPC_SYSLOG
-               case 'C':
-                       if (optarg) {
-                               int buf_size = atoi(optarg);
-                               if (buf_size >= 4) {
-                                       shm_size = buf_size * 1024;
-                               }
-                       }
-                       circular_logging = TRUE;
-                       break;
+#if ENABLE_FEATURE_REMOTE_LOG
+       if (option_mask32 & OPT_remotelog) { // -R
+               int port = 514;
+               char *host = xstrdup(opt_R);
+               p = strchr(host, ':');
+               if (p) {
+                       port = xatou16(p + 1);
+                       *p = '\0';
+               }
+               remoteaddr.sin_family = AF_INET;
+               /* FIXME: looks ip4-specific. need to do better */
+               remoteaddr.sin_addr = *(struct in_addr *) *(xgethostbyname(host)->h_addr_list);
+               remoteaddr.sin_port = htons(port);
+               free(host);
+       }
+       //if (option_mask32 & OPT_locallog) // -L
 #endif
-               case 'S':
-                       small = true;
-                       break;
-               default:
-                       bb_show_usage();
+#if ENABLE_FEATURE_IPC_SYSLOG
+       if (option_mask32 & OPT_circularlog) { // -C
+               if (opt_C) {
+                       shm_size = xatoul_range(opt_C, 4, INT_MAX/1024) * 1024;
                }
        }
-
-#ifdef CONFIG_FEATURE_REMOTE_LOG
-       /* If they have not specified remote logging, then log locally */
-       if (doRemoteLog == FALSE)
-               local_logging = TRUE;
 #endif
 
+       /* If they have not specified remote logging, then log locally */
+       if (ENABLE_FEATURE_REMOTE_LOG && !(option_mask32 & OPT_remotelog))
+               option_mask32 |= OPT_locallog;
 
        /* Store away localhost's name before the fork */
        gethostname(LocalHostName, sizeof(LocalHostName));
-       if ((p = strchr(LocalHostName, '.'))) {
+       p = strchr(LocalHostName, '.');
+       if (p) {
                *p = '\0';
        }
 
        umask(0);
 
-       if (doFork == TRUE) {
-#if defined(__uClinux__)
+       if (!(option_mask32 & OPT_nofork)) {
+#ifdef BB_NOMMU
                vfork_daemon_rexec(0, 1, argc, argv, "-n");
-#else /* __uClinux__ */
-               if(daemon(0, 1) < 0)
-                       bb_perror_msg_and_die("daemon");
-#endif /* __uClinux__ */
+#else
+               xdaemon(0, 1);
+#endif
        }
        doSyslogd();
 
        return EXIT_SUCCESS;
 }
-
-/*
-Local Variables
-c-file-style: "linux"
-c-basic-offset: 4
-tab-width: 4
-End:
-*/