randomtest fixes
[oweals/busybox.git] / sysklogd / syslogd.c
index 89391036a75c86f9739802e53426c5cb7d3fa8f4..6bc450bf998bc0fe696ce928e4486eacf08fc957 100644 (file)
@@ -21,7 +21,6 @@
 #include <syslog.h>
 */
 
-#include <paths.h>
 #include <sys/un.h>
 #include <sys/uio.h>
 
@@ -47,7 +46,7 @@
 #undef SYSLOGD_WRLOCK
 
 enum {
-       MAX_READ = 256,
+       MAX_READ = CONFIG_FEATURE_SYSLOGD_READ_BUFFER_SIZE,
        DNS_WAIT_SEC = 2 * 60,
 };
 
@@ -58,6 +57,15 @@ struct shbuf_ds {
        char data[1];   /* data/messages */
 };
 
+#if ENABLE_FEATURE_REMOTE_LOG
+typedef struct {
+       int remoteFD;
+       unsigned last_dns_resolve;
+       len_and_sockaddr *remoteAddr;
+       const char *remoteHostname;
+} remoteHost_t;
+#endif
+
 /* Allows us to have smaller initializer. Ugly. */
 #define GLOBALS \
        const char *logFilePath;                \
@@ -66,7 +74,7 @@ struct shbuf_ds {
        /*int markInterval;*/                   \
        /* level of messages to be logged */    \
        int logLevel;                           \
-USE_FEATURE_ROTATE_LOGFILE( \
+IF_FEATURE_ROTATE_LOGFILE( \
        /* max size of file before rotation */  \
        unsigned logFileSize;                   \
        /* number of rotated message files */   \
@@ -74,12 +82,7 @@ USE_FEATURE_ROTATE_LOGFILE( \
        unsigned curFileSize;                   \
        smallint isRegular;                     \
 ) \
-USE_FEATURE_REMOTE_LOG( \
-       /* udp socket for remote logging */     \
-       int remoteFD;                           \
-       len_and_sockaddr* remoteAddr;           \
-) \
-USE_FEATURE_IPC_SYSLOG( \
+IF_FEATURE_IPC_SYSLOG( \
        int shmid; /* ipc shared memory id */   \
        int s_semid; /* ipc semaphore id */     \
        int shm_size;                           \
@@ -95,10 +98,8 @@ struct globals {
        GLOBALS
 
 #if ENABLE_FEATURE_REMOTE_LOG
-       unsigned last_dns_resolve;
-       char *remoteAddrStr;
+       llist_t *remoteHosts;
 #endif
-
 #if ENABLE_FEATURE_IPC_SYSLOG
        struct shbuf_ds *shbuf;
 #endif
@@ -128,9 +129,6 @@ static const struct init_globals init_data = {
        .logFileSize = 200 * 1024,
        .logFileRotate = 1,
 #endif
-#if ENABLE_FEATURE_REMOTE_LOG
-       .remoteFD = -1,
-#endif
 #if ENABLE_FEATURE_IPC_SYSLOG
        .shmid = -1,
        .s_semid = -1,
@@ -153,41 +151,41 @@ enum {
        OPTBIT_outfile, // -O
        OPTBIT_loglevel, // -l
        OPTBIT_small, // -S
-       USE_FEATURE_ROTATE_LOGFILE(OPTBIT_filesize   ,) // -s
-       USE_FEATURE_ROTATE_LOGFILE(OPTBIT_rotatecnt  ,) // -b
-       USE_FEATURE_REMOTE_LOG(    OPTBIT_remotelog  ,) // -R
-       USE_FEATURE_REMOTE_LOG(    OPTBIT_locallog   ,) // -L
-       USE_FEATURE_IPC_SYSLOG(    OPTBIT_circularlog,) // -C
-       USE_FEATURE_SYSLOGD_DUP(   OPTBIT_dup        ,) // -D
+       IF_FEATURE_ROTATE_LOGFILE(OPTBIT_filesize   ,)  // -s
+       IF_FEATURE_ROTATE_LOGFILE(OPTBIT_rotatecnt  ,)  // -b
+       IF_FEATURE_REMOTE_LOG(    OPTBIT_remotelog  ,)  // -R
+       IF_FEATURE_REMOTE_LOG(    OPTBIT_locallog   ,)  // -L
+       IF_FEATURE_IPC_SYSLOG(    OPTBIT_circularlog,)  // -C
+       IF_FEATURE_SYSLOGD_DUP(   OPTBIT_dup        ,)  // -D
 
        OPT_mark        = 1 << OPTBIT_mark    ,
        OPT_nofork      = 1 << OPTBIT_nofork  ,
        OPT_outfile     = 1 << OPTBIT_outfile ,
        OPT_loglevel    = 1 << OPTBIT_loglevel,
        OPT_small       = 1 << OPTBIT_small   ,
-       OPT_filesize    = USE_FEATURE_ROTATE_LOGFILE((1 << OPTBIT_filesize   )) + 0,
-       OPT_rotatecnt   = USE_FEATURE_ROTATE_LOGFILE((1 << OPTBIT_rotatecnt  )) + 0,
-       OPT_remotelog   = USE_FEATURE_REMOTE_LOG(    (1 << OPTBIT_remotelog  )) + 0,
-       OPT_locallog    = USE_FEATURE_REMOTE_LOG(    (1 << OPTBIT_locallog   )) + 0,
-       OPT_circularlog = USE_FEATURE_IPC_SYSLOG(    (1 << OPTBIT_circularlog)) + 0,
-       OPT_dup         = USE_FEATURE_SYSLOGD_DUP(   (1 << OPTBIT_dup        )) + 0,
+       OPT_filesize    = IF_FEATURE_ROTATE_LOGFILE((1 << OPTBIT_filesize   )) + 0,
+       OPT_rotatecnt   = IF_FEATURE_ROTATE_LOGFILE((1 << OPTBIT_rotatecnt  )) + 0,
+       OPT_remotelog   = IF_FEATURE_REMOTE_LOG(    (1 << OPTBIT_remotelog  )) + 0,
+       OPT_locallog    = IF_FEATURE_REMOTE_LOG(    (1 << OPTBIT_locallog   )) + 0,
+       OPT_circularlog = IF_FEATURE_IPC_SYSLOG(    (1 << OPTBIT_circularlog)) + 0,
+       OPT_dup         = IF_FEATURE_SYSLOGD_DUP(   (1 << OPTBIT_dup        )) + 0,
 };
 #define OPTION_STR "m:nO:l:S" \
-       USE_FEATURE_ROTATE_LOGFILE("s:" ) \
-       USE_FEATURE_ROTATE_LOGFILE("b:" ) \
-       USE_FEATURE_REMOTE_LOG(    "R:" ) \
-       USE_FEATURE_REMOTE_LOG(    "L"  ) \
-       USE_FEATURE_IPC_SYSLOG(    "C::") \
-       USE_FEATURE_SYSLOGD_DUP(   "D"  )
+       IF_FEATURE_ROTATE_LOGFILE("s:" ) \
+       IF_FEATURE_ROTATE_LOGFILE("b:" ) \
+       IF_FEATURE_REMOTE_LOG(    "R:" ) \
+       IF_FEATURE_REMOTE_LOG(    "L"  ) \
+       IF_FEATURE_IPC_SYSLOG(    "C::") \
+       IF_FEATURE_SYSLOGD_DUP(   "D"  )
 #define OPTION_DECL *opt_m, *opt_l \
-       USE_FEATURE_ROTATE_LOGFILE(,*opt_s) \
-       USE_FEATURE_ROTATE_LOGFILE(,*opt_b) \
-       USE_FEATURE_IPC_SYSLOG(    ,*opt_C = NULL)
+       IF_FEATURE_ROTATE_LOGFILE(,*opt_s) \
+       IF_FEATURE_ROTATE_LOGFILE(,*opt_b) \
+       IF_FEATURE_IPC_SYSLOG(    ,*opt_C = NULL)
 #define OPTION_PARAM &opt_m, &G.logFilePath, &opt_l \
-       USE_FEATURE_ROTATE_LOGFILE(,&opt_s) \
-       USE_FEATURE_ROTATE_LOGFILE(,&opt_b) \
-       USE_FEATURE_REMOTE_LOG(    ,&G.remoteAddrStr) \
-       USE_FEATURE_IPC_SYSLOG(    ,&opt_C)
+       IF_FEATURE_ROTATE_LOGFILE(,&opt_s) \
+       IF_FEATURE_ROTATE_LOGFILE(,&opt_b) \
+       IF_FEATURE_REMOTE_LOG(    ,&remoteAddrList) \
+       IF_FEATURE_IPC_SYSLOG(    ,&opt_C)
 
 
 /* circular buffer variables/structures */
@@ -423,6 +421,8 @@ static void timestamp_and_log(int pri, char *msg, int len)
        char *timestamp;
        time_t now;
 
+       /* Jan 18 00:11:22 msg... */
+       /* 01234567890123456 */
        if (len < 16 || msg[3] != ' ' || msg[6] != ' '
         || msg[9] != ':' || msg[12] != ':' || msg[15] != ' '
        ) {
@@ -533,20 +533,20 @@ static NOINLINE int create_socket(void)
 }
 
 #if ENABLE_FEATURE_REMOTE_LOG
-static int try_to_resolve_remote(void)
+static int try_to_resolve_remote(remoteHost_t *rh)
 {
-       if (!G.remoteAddr) {
+       if (!rh->remoteAddr) {
                unsigned now = monotonic_sec();
 
                /* Don't resolve name too often - DNS timeouts can be big */
-               if ((now - G.last_dns_resolve) < DNS_WAIT_SEC)
+               if ((now - rh->last_dns_resolve) < DNS_WAIT_SEC)
                        return -1;
-               G.last_dns_resolve = now;
-               G.remoteAddr = host2sockaddr(G.remoteAddrStr, 514);
-               if (!G.remoteAddr)
+               rh->last_dns_resolve = now;
+               rh->remoteAddr = host2sockaddr(rh->remoteHostname, 514);
+               if (!rh->remoteAddr)
                        return -1;
        }
-       return socket(G.remoteAddr->u.sa.sa_family, SOCK_DGRAM, 0);
+       return socket(rh->remoteAddr->u.sa.sa_family, SOCK_DGRAM, 0);
 }
 #endif
 
@@ -554,6 +554,9 @@ static void do_syslogd(void) NORETURN;
 static void do_syslogd(void)
 {
        int sock_fd;
+#if ENABLE_FEATURE_REMOTE_LOG
+       llist_t *item;
+#endif
 #if ENABLE_FEATURE_SYSLOGD_DUP
        int last_sz = -1;
        char *last_buf;
@@ -619,23 +622,25 @@ static void do_syslogd(void)
                last_sz = sz;
 #endif
 #if ENABLE_FEATURE_REMOTE_LOG
+               /* Stock syslogd sends it '\n'-terminated
+                * over network, mimic that */
+               recvbuf[sz] = '\n';
+
                /* We are not modifying log messages in any way before send */
                /* Remote site cannot trust _us_ anyway and need to do validation again */
-               if (G.remoteAddrStr) {
-                       if (-1 == G.remoteFD) {
-                               G.remoteFD = try_to_resolve_remote();
-                               if (-1 == G.remoteFD)
-                                       goto no_luck;
+               for (item = G.remoteHosts; item != NULL; item = item->link) {
+                       remoteHost_t *rh = (remoteHost_t *)item->data;
+
+                       if (rh->remoteFD == -1) {
+                               rh->remoteFD = try_to_resolve_remote(rh);
+                               if (rh->remoteFD == -1)
+                                       continue;
                        }
-                       /* Stock syslogd sends it '\n'-terminated
-                        * over network, mimic that */
-                       recvbuf[sz] = '\n';
-                       /* send message to remote logger, ignore possible error */
+                       /* Send message to remote logger, ignore possible error */
                        /* TODO: on some errors, close and set G.remoteFD to -1
                         * so that DNS resolution and connect is retried? */
-                       sendto(G.remoteFD, recvbuf, sz+1, MSG_DONTWAIT,
-                                   &G.remoteAddr->u.sa, G.remoteAddr->len);
- no_luck: ;
+                       sendto(rh->remoteFD, recvbuf, sz+1, MSG_DONTWAIT,
+                               &(rh->remoteAddr->u.sa), rh->remoteAddr->len);
                }
 #endif
                if (!ENABLE_FEATURE_REMOTE_LOG || (option_mask32 & OPT_locallog)) {
@@ -655,17 +660,27 @@ static void do_syslogd(void)
 int syslogd_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
 int syslogd_main(int argc UNUSED_PARAM, char **argv)
 {
-       char OPTION_DECL;
        int opts;
+       char OPTION_DECL;
+#if ENABLE_FEATURE_REMOTE_LOG
+       llist_t *remoteAddrList = NULL;
+#endif
 
        INIT_G();
+
+       /* No non-option params, -R can occur multiple times */
+       opt_complementary = "=0" IF_FEATURE_REMOTE_LOG(":R::");
+       opts = getopt32(argv, OPTION_STR, OPTION_PARAM);
 #if ENABLE_FEATURE_REMOTE_LOG
-       G.last_dns_resolve = monotonic_sec() - DNS_WAIT_SEC - 1;
+       while (remoteAddrList) {
+               remoteHost_t *rh = xzalloc(sizeof(*rh));
+               rh->remoteHostname = llist_pop(&remoteAddrList);
+               rh->remoteFD = -1;
+               rh->last_dns_resolve = monotonic_sec() - DNS_WAIT_SEC - 1;
+               llist_add_to(&G.remoteHosts, rh);
+       }
 #endif
 
-       /* do normal option parsing */
-       opt_complementary = "=0"; /* no non-option params */
-       opts = getopt32(argv, OPTION_STR, OPTION_PARAM);
 #ifdef SYSLOGD_MARK
        if (opts & OPT_mark) // -m
                G.markInterval = xatou_range(opt_m, 0, INT_MAX/60) * 60;
@@ -697,7 +712,7 @@ int syslogd_main(int argc UNUSED_PARAM, char **argv)
        if (!(opts & OPT_nofork)) {
                bb_daemonize_or_rexec(DAEMON_CHDIR_ROOT, argv);
        }
-       umask(0);
+       //umask(0); - why??
        write_pidfile("/var/run/syslogd.pid");
        do_syslogd();
        /* return EXIT_SUCCESS; */