A missing securetty file is not an error.

[oweals/busybox.git] / sysklogd / logger.c

diff --git a/sysklogd/logger.c b/sysklogd/logger.c
index 9f730915f460c6016907bddf2fa8e34936edf825..bb63975e71cd02c683b5a0cc59750f2e3d0ee139 100644 (file)
--- a/sysklogd/logger.c
+++ b/sysklogd/logger.c
@@ -2,8 +2,8 @@
 /*
  * Mini logger implementation for busybox
  *
- * Copyright (C) 1999,2000,2001 by Lineo, inc.
- * Written by Erik Andersen <andersen@lineo.com>, <andersee@debian.org>
+ * Copyright (C) 1999,2000 by Lineo, inc. and Erik Andersen
+ * Copyright (C) 1999,2000,2001 by Erik Andersen <andersee@debian.org>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -30,7 +30,7 @@
 #include <stdlib.h>
 
 #include "busybox.h"
-#if !defined BB_SYSLOGD
+#if !defined CONFIG_SYSLOGD
 
 #define SYSLOG_NAMES
 #include <sys/syslog.h>
@@ -105,8 +105,8 @@ extern int logger_main(int argc, char **argv)
 {
        int pri = LOG_USER | LOG_NOTICE;
        int option = 0;
-       int c, i, len, opt;
-       char *message=NULL, buf[1024], name[128];
+       int c, i, opt;
+       char buf[1024], name[128];
 
        /* Fill out the name string early (may be overwritten later) */
        my_getpwuid(name, geteuid());
@@ -121,7 +121,7 @@ extern int logger_main(int argc, char **argv)
                                pri = pencode(optarg);
                                break;
                        case 't':
-                               strncpy(name, optarg, sizeof(name));
+                               safe_strncpy(name, optarg, sizeof(name));
                                break;
                        default:
                                show_usage();
@@ -143,16 +143,21 @@ extern int logger_main(int argc, char **argv)
                        }
                } while (c != EOF);
        } else {
-               len = 1; /* for the '\0' */
-               message=xcalloc(1, 1);
-               for (i = optind; i < argc; i++) {
-                       len += strlen(argv[i]);
-                       len += 1;  /* for the space between the args */
+               char *message = NULL;
+               int len = argc - optind; /* for the space between the args
+                                           and  '\0' */
+               opt = len;
+               argv += optind;
+               for (i = 0; i < opt; i++) {
+                       len += strlen(*argv);
                        message = xrealloc(message, len);
-                       strcat(message, argv[i]);
+                       if(!i)
+                               message[0] = 0;
+                        else
                        strcat(message, " ");
+                       strcat(message, *argv);
+                       argv++;
                }
-               message[strlen(message)-1] = '\0';
                syslog(pri, "%s", message);
        }