Change all calls to low level digest routines in the library and
[oweals/openssl.git] / ssl / s3_enc.c
index f340fc5d5f55de6955d87aca93c026c5f333f1b1..2fbfead2cf554d3c53b0d8d7238f6e44219f9ee1 100644 (file)
@@ -57,8 +57,6 @@
  */
 
 #include <stdio.h>
-#include <openssl/md5.h>
-#include <openssl/sha.h>
 #include <openssl/evp.h>
 #include "ssl_locl.h"
 
@@ -81,11 +79,11 @@ static unsigned char ssl3_pad_2[48]={
 static int ssl3_handshake_mac(SSL *s, EVP_MD_CTX *in_ctx,
        const char *sender, int len, unsigned char *p);
 
-static void ssl3_generate_key_block(SSL *s, unsigned char *km, int num)
+static int ssl3_generate_key_block(SSL *s, unsigned char *km, int num)
        {
-       MD5_CTX m5;
-       SHA_CTX s1;
-       unsigned char buf[8],smd[SHA_DIGEST_LENGTH];
+       EVP_MD_CTX m5;
+       EVP_MD_CTX s1;
+       unsigned char buf[16],smd[SHA_DIGEST_LENGTH];
        unsigned char c='A';
        int i,j,k;
 
@@ -96,32 +94,40 @@ static void ssl3_generate_key_block(SSL *s, unsigned char *km, int num)
        for (i=0; i<num; i+=MD5_DIGEST_LENGTH)
                {
                k++;
+               if (k > sizeof buf)
+                       {
+                       /* bug: 'buf' is too small for this ciphersuite */
+                       SSLerr(SSL_F_SSL3_GENERATE_KEY_BLOCK, ERR_R_INTERNAL_ERROR);
+                       return 0;
+                       }
+               
                for (j=0; j<k; j++)
                        buf[j]=c;
                c++;
-               SHA1_Init(  &s1);
-               SHA1_Update(&s1,buf,k);
-               SHA1_Update(&s1,s->session->master_key,
+               EVP_DigestInit(&s1,EVP_sha1());
+               EVP_DigestUpdate(&s1,buf,k);
+               EVP_DigestUpdate(&s1,s->session->master_key,
                        s->session->master_key_length);
-               SHA1_Update(&s1,s->s3->server_random,SSL3_RANDOM_SIZE);
-               SHA1_Update(&s1,s->s3->client_random,SSL3_RANDOM_SIZE);
-               SHA1_Final( smd,&s1);
+               EVP_DigestUpdate(&s1,s->s3->server_random,SSL3_RANDOM_SIZE);
+               EVP_DigestUpdate(&s1,s->s3->client_random,SSL3_RANDOM_SIZE);
+               EVP_DigestFinal(&s1,smd,NULL);
 
-               MD5_Init(  &m5);
-               MD5_Update(&m5,s->session->master_key,
+               EVP_DigestInit(&m5,EVP_md5());
+               EVP_DigestUpdate(&m5,s->session->master_key,
                        s->session->master_key_length);
-               MD5_Update(&m5,smd,SHA_DIGEST_LENGTH);
+               EVP_DigestUpdate(&m5,smd,SHA_DIGEST_LENGTH);
                if ((i+MD5_DIGEST_LENGTH) > num)
                        {
-                       MD5_Final(smd,&m5);
+                       EVP_DigestFinal(&m5,smd,NULL);
                        memcpy(km,smd,(num-i));
                        }
                else
-                       MD5_Final(km,&m5);
+                       EVP_DigestFinal(&m5,km,NULL);
 
                km+=MD5_DIGEST_LENGTH;
                }
        memset(smd,0,SHA_DIGEST_LENGTH);
+       return 1;
        }
 
 int ssl3_change_cipher_state(SSL *s, int which)
@@ -134,7 +140,7 @@ int ssl3_change_cipher_state(SSL *s, int which)
        const EVP_CIPHER *c;
        COMP_METHOD *comp;
        const EVP_MD *m;
-       MD5_CTX md;
+       EVP_MD_CTX md;
        int exp,n,i,j,k,cl;
 
        exp=SSL_C_IS_EXPORT(s->s3->tmp.new_cipher);
@@ -150,7 +156,7 @@ int ssl3_change_cipher_state(SSL *s, int which)
                {
                if ((s->enc_read_ctx == NULL) &&
                        ((s->enc_read_ctx=(EVP_CIPHER_CTX *)
-                       Malloc(sizeof(EVP_CIPHER_CTX))) == NULL))
+                       OPENSSL_malloc(sizeof(EVP_CIPHER_CTX))) == NULL))
                        goto err;
                dd= s->enc_read_ctx;
                s->read_hash=m;
@@ -170,7 +176,7 @@ int ssl3_change_cipher_state(SSL *s, int which)
                                }
                        if (s->s3->rrec.comp == NULL)
                                s->s3->rrec.comp=(unsigned char *)
-                                       Malloc(SSL3_RT_MAX_PLAIN_LENGTH);
+                                       OPENSSL_malloc(SSL3_RT_MAX_PLAIN_LENGTH);
                        if (s->s3->rrec.comp == NULL)
                                goto err;
                        }
@@ -181,7 +187,7 @@ int ssl3_change_cipher_state(SSL *s, int which)
                {
                if ((s->enc_write_ctx == NULL) &&
                        ((s->enc_write_ctx=(EVP_CIPHER_CTX *)
-                       Malloc(sizeof(EVP_CIPHER_CTX))) == NULL))
+                       OPENSSL_malloc(sizeof(EVP_CIPHER_CTX))) == NULL))
                        goto err;
                dd= s->enc_write_ctx;
                s->write_hash=m;
@@ -234,7 +240,7 @@ int ssl3_change_cipher_state(SSL *s, int which)
 
        if (n > s->s3->tmp.key_block_length)
                {
-               SSLerr(SSL_F_SSL3_CHANGE_CIPHER_STATE,SSL_R_INTERNAL_ERROR);
+               SSLerr(SSL_F_SSL3_CHANGE_CIPHER_STATE,ERR_R_INTERNAL_ERROR);
                goto err2;
                }
 
@@ -244,19 +250,19 @@ int ssl3_change_cipher_state(SSL *s, int which)
                /* In here I set both the read and write key/iv to the
                 * same value since only the correct one will be used :-).
                 */
-               MD5_Init(&md);
-               MD5_Update(&md,key,j);
-               MD5_Update(&md,er1,SSL3_RANDOM_SIZE);
-               MD5_Update(&md,er2,SSL3_RANDOM_SIZE);
-               MD5_Final(&(exp_key[0]),&md);
+               EVP_DigestInit(&md,EVP_md5());
+               EVP_DigestUpdate(&md,key,j);
+               EVP_DigestUpdate(&md,er1,SSL3_RANDOM_SIZE);
+               EVP_DigestUpdate(&md,er2,SSL3_RANDOM_SIZE);
+               EVP_DigestFinal(&md,&(exp_key[0]),NULL);
                key= &(exp_key[0]);
 
                if (k > 0)
                        {
-                       MD5_Init(&md);
-                       MD5_Update(&md,er1,SSL3_RANDOM_SIZE);
-                       MD5_Update(&md,er2,SSL3_RANDOM_SIZE);
-                       MD5_Final(&(exp_iv[0]),&md);
+                       EVP_DigestInit(&md,EVP_md5());
+                       EVP_DigestUpdate(&md,er1,SSL3_RANDOM_SIZE);
+                       EVP_DigestUpdate(&md,er2,SSL3_RANDOM_SIZE);
+                       EVP_DigestFinal(&md,&(exp_iv[0]),NULL);
                        iv= &(exp_iv[0]);
                        }
                }
@@ -300,15 +306,14 @@ int ssl3_setup_key_block(SSL *s)
 
        ssl3_cleanup_key_block(s);
 
-       if ((p=Malloc(num)) == NULL)
+       if ((p=OPENSSL_malloc(num)) == NULL)
                goto err;
 
        s->s3->tmp.key_block_length=num;
        s->s3->tmp.key_block=p;
 
-       ssl3_generate_key_block(s,p,num);
+       return ssl3_generate_key_block(s,p,num);
 
-       return(1);
 err:
        SSLerr(SSL_F_SSL3_SETUP_KEY_BLOCK,ERR_R_MALLOC_FAILURE);
        return(0);
@@ -320,7 +325,7 @@ void ssl3_cleanup_key_block(SSL *s)
                {
                memset(s->s3->tmp.key_block,0,
                        s->s3->tmp.key_block_length);
-               Free(s->s3->tmp.key_block);
+               OPENSSL_free(s->s3->tmp.key_block);
                s->s3->tmp.key_block=NULL;
                }
        s->s3->tmp.key_block_length=0;
@@ -356,7 +361,7 @@ int ssl3_enc(SSL *s, int send)
        if ((s->session == NULL) || (ds == NULL) ||
                (enc == NULL))
                {
-               memcpy(rec->data,rec->input,rec->length);
+               memmove(rec->data,rec->input,rec->length);
                rec->input=rec->data;
                }
        else
@@ -366,7 +371,6 @@ int ssl3_enc(SSL *s, int send)
 
                /* COMPRESS */
 
-               /* This should be using (bs-1) and bs instead of 7 and 8 */
                if ((bs != 1) && send)
                        {
                        i=bs-((int)l%bs);
@@ -376,12 +380,24 @@ int ssl3_enc(SSL *s, int send)
                        rec->length+=i;
                        rec->input[l-1]=(i-1);
                        }
-
+               
+               if (!send)
+                       {
+                       if (l == 0 || l%bs != 0)
+                               {
+                               SSLerr(SSL_F_SSL3_ENC,SSL_R_BLOCK_CIPHER_PAD_IS_WRONG);
+                               ssl3_send_alert(s,SSL3_AL_FATAL,SSL_AD_DECRYPT_ERROR);
+                               return(0);
+                               }
+                       }
+               
                EVP_Cipher(ds,rec->data,rec->input,l);
 
                if ((bs != 1) && !send)
                        {
                        i=rec->data[l-1]+1;
+                       /* SSL 3.0 bounds the number of padding bytes by the block size;
+                        * padding bytes (except that last) are arbitrary */
                        if (i > bs)
                                {
                                SSLerr(SSL_F_SSL3_ENC,SSL_R_BLOCK_CIPHER_PAD_IS_WRONG);
@@ -443,7 +459,7 @@ static int ssl3_handshake_mac(SSL *s, EVP_MD_CTX *in_ctx,
        EVP_DigestUpdate(&ctx,ssl3_pad_1,npad);
        EVP_DigestFinal(&ctx,md_buf,&i);
 
-       EVP_DigestInit(&ctx,EVP_MD_CTX_type(&ctx));
+       EVP_DigestInit(&ctx,EVP_MD_CTX_md(&ctx));
        EVP_DigestUpdate(&ctx,s->session->master_key,
                s->session->master_key_length);
        EVP_DigestUpdate(&ctx,ssl3_pad_2,npad);
@@ -504,7 +520,10 @@ int ssl3_mac(SSL *ssl, unsigned char *md, int send)
        EVP_DigestFinal( &md_ctx,md,&md_size);
 
        for (i=7; i>=0; i--)
-               if (++seq[i]) break; 
+               {
+               ++seq[i];
+               if (seq[i] != 0) break; 
+               }
 
        return(md_size);
        }