Fix Bleichenbacher PKCS #1 1.5 countermeasure.
[oweals/openssl.git] / ssl / s3_clnt.c
index 625e1ae276027888d2c694246ac1920532a65868..eec45cfa485d0d0a7ae6a4f06a3f3abf430d15b4 100644 (file)
 #include <openssl/evp.h>
 #include "ssl_locl.h"
 
-#ifndef OPENSSL_NO_KRB5
-#include "kssl.h"
-#endif
-
 static SSL_METHOD *ssl3_get_client_method(int ver);
 static int ssl3_client_hello(SSL *s);
 static int ssl3_get_server_hello(SSL *s);
@@ -147,7 +143,7 @@ int ssl3_connect(SSL *s)
 
                        if ((s->version & 0xff00 ) != 0x0300)
                                {
-                               SSLerr(SSL_F_SSL3_CONNECT, ERR_R_INTERNAL_ERROR);
+                               SSLerr(SSL_F_SSL3_CONNECT, SSL_R_INTERNAL_ERROR);
                                ret = -1;
                                goto end;
                                }
@@ -691,13 +687,12 @@ static int ssl3_get_server_certificate(SSL *s)
        STACK_OF(X509) *sk=NULL;
        SESS_CERT *sc;
        EVP_PKEY *pkey=NULL;
-        int need_cert = 1; /* VRS: 0=> will allow null cert if auth == KRB5 */
 
        n=ssl3_get_message(s,
                SSL3_ST_CR_CERT_A,
                SSL3_ST_CR_CERT_B,
                -1,
-#if defined(OPENSSL_SYS_MSDOS) && !defined(OPENSSL_SYS_WIN32)
+#if defined(MSDOS) && !defined(WIN32)
                1024*30, /* 30k max cert list :-) */
 #else
                1024*100, /* 100k max cert list :-) */
@@ -787,23 +782,10 @@ static int ssl3_get_server_certificate(SSL *s)
         * certificate, which we don't include in s3_srvr.c */
        x=sk_X509_value(sk,0);
        sk=NULL;
-       /* VRS 19990621: possible memory leak; sk=null ==> !sk_pop_free() @end */
 
        pkey=X509_get_pubkey(x);
 
-        /* VRS: allow null cert if auth == KRB5 */
-        need_cert =
-                ((s->s3->tmp.new_cipher->algorithms & (SSL_MKEY_MASK|SSL_AUTH_MASK))
-                        == (SSL_aKRB5|SSL_kKRB5))? 0: 1;
-
-#ifdef KSSL_DEBUG
-       printf("pkey,x = %p, %p\n", pkey,x);
-       printf("ssl_cert_type(x,pkey) = %d\n", ssl_cert_type(x,pkey));
-       printf("cipher, alg, nc = %s, %lx, %d\n", s->s3->tmp.new_cipher->name,
-                s->s3->tmp.new_cipher->algorithms, need_cert);
-#endif    /* KSSL_DEBUG */
-
-       if (need_cert  &&  ((pkey == NULL) || EVP_PKEY_missing_parameters(pkey)))
+       if ((pkey == NULL) || EVP_PKEY_missing_parameters(pkey))
                {
                x=NULL;
                al=SSL3_AL_FATAL;
@@ -812,7 +794,7 @@ static int ssl3_get_server_certificate(SSL *s)
                }
 
        i=ssl_cert_type(x,pkey);
-       if (need_cert && i < 0)
+       if (i < 0)
                {
                x=NULL;
                al=SSL3_AL_FATAL;
@@ -820,31 +802,19 @@ static int ssl3_get_server_certificate(SSL *s)
                goto f_err;
                }
 
-        if (need_cert)
-                {
-                sc->peer_cert_type=i;
-                CRYPTO_add(&x->references,1,CRYPTO_LOCK_X509);
-                /* Why would the following ever happen?
-                 * We just created sc a couple of lines ago. */
-                if (sc->peer_pkeys[i].x509 != NULL)
-                        X509_free(sc->peer_pkeys[i].x509);
-                sc->peer_pkeys[i].x509=x;
-                sc->peer_key= &(sc->peer_pkeys[i]);
-
-                if (s->session->peer != NULL)
-                        X509_free(s->session->peer);
-                CRYPTO_add(&x->references,1,CRYPTO_LOCK_X509);
-                s->session->peer=x;
-                }
-        else
-                {
-                sc->peer_cert_type=i;
-                sc->peer_key= NULL;
-
-                if (s->session->peer != NULL)
-                        X509_free(s->session->peer);
-                s->session->peer=NULL;
-                }
+       sc->peer_cert_type=i;
+       CRYPTO_add(&x->references,1,CRYPTO_LOCK_X509);
+       if (sc->peer_pkeys[i].x509 != NULL) /* Why would this ever happen?
+                                                                                * We just created sc a couple of
+                                                                                * lines ago. */
+               X509_free(sc->peer_pkeys[i].x509);
+       sc->peer_pkeys[i].x509=x;
+       sc->peer_key= &(sc->peer_pkeys[i]);
+
+       if (s->session->peer != NULL)
+               X509_free(s->session->peer);
+       CRYPTO_add(&x->references,1,CRYPTO_LOCK_X509);
+       s->session->peer=x;
        s->session->verify_result = s->verify_result;
 
        x=NULL;
@@ -864,7 +834,7 @@ err:
 
 static int ssl3_get_key_exchange(SSL *s)
        {
-#ifndef OPENSSL_NO_RSA
+#ifndef NO_RSA
        unsigned char *q,md_buf[EVP_MAX_MD_SIZE*2];
 #endif
        EVP_MD_CTX md_ctx;
@@ -872,10 +842,10 @@ static int ssl3_get_key_exchange(SSL *s)
        int al,i,j,param_len,ok;
        long n,alg;
        EVP_PKEY *pkey=NULL;
-#ifndef OPENSSL_NO_RSA
+#ifndef NO_RSA
        RSA *rsa=NULL;
 #endif
-#ifndef OPENSSL_NO_DH
+#ifndef NO_DH
        DH *dh=NULL;
 #endif
 
@@ -898,14 +868,14 @@ static int ssl3_get_key_exchange(SSL *s)
 
        if (s->session->sess_cert != NULL)
                {
-#ifndef OPENSSL_NO_RSA
+#ifndef NO_RSA
                if (s->session->sess_cert->peer_rsa_tmp != NULL)
                        {
                        RSA_free(s->session->sess_cert->peer_rsa_tmp);
                        s->session->sess_cert->peer_rsa_tmp=NULL;
                        }
 #endif
-#ifndef OPENSSL_NO_DH
+#ifndef NO_DH
                if (s->session->sess_cert->peer_dh_tmp)
                        {
                        DH_free(s->session->sess_cert->peer_dh_tmp);
@@ -921,7 +891,7 @@ static int ssl3_get_key_exchange(SSL *s)
        param_len=0;
        alg=s->s3->tmp.new_cipher->algorithms;
 
-#ifndef OPENSSL_NO_RSA
+#ifndef NO_RSA
        if (alg & SSL_kRSA)
                {
                if ((rsa=RSA_new()) == NULL)
@@ -965,17 +935,17 @@ static int ssl3_get_key_exchange(SSL *s)
                        pkey=X509_get_pubkey(s->session->sess_cert->peer_pkeys[SSL_PKEY_RSA_ENC].x509);
                else
                        {
-                       SSLerr(SSL_F_SSL3_GET_KEY_EXCHANGE,ERR_R_INTERNAL_ERROR);
+                       SSLerr(SSL_F_SSL3_GET_KEY_EXCHANGE,SSL_R_INTERNAL_ERROR);
                        goto err;
                        }
                s->session->sess_cert->peer_rsa_tmp=rsa;
                rsa=NULL;
                }
-#else /* OPENSSL_NO_RSA */
+#else /* NO_RSA */
        if (0)
                ;
 #endif
-#ifndef OPENSSL_NO_DH
+#ifndef NO_DH
        else if (alg & SSL_kEDH)
                {
                if ((dh=DH_new()) == NULL)
@@ -1029,14 +999,14 @@ static int ssl3_get_key_exchange(SSL *s)
                p+=i;
                n-=param_len;
 
-#ifndef OPENSSL_NO_RSA
+#ifndef NO_RSA
                if (alg & SSL_aRSA)
                        pkey=X509_get_pubkey(s->session->sess_cert->peer_pkeys[SSL_PKEY_RSA_ENC].x509);
 #else
                if (0)
                        ;
 #endif
-#ifndef OPENSSL_NO_DSA
+#ifndef NO_DSA
                else if (alg & SSL_aDSS)
                        pkey=X509_get_pubkey(s->session->sess_cert->peer_pkeys[SSL_PKEY_DSA_SIGN].x509);
 #endif
@@ -1051,7 +1021,7 @@ static int ssl3_get_key_exchange(SSL *s)
                SSLerr(SSL_F_SSL3_GET_KEY_EXCHANGE,SSL_R_TRIED_TO_USE_UNSUPPORTED_CIPHER);
                goto f_err;
                }
-#endif /* !OPENSSL_NO_DH */
+#endif /* !NO_DH */
        if (alg & SSL_aFZA)
                {
                al=SSL_AD_HANDSHAKE_FAILURE;
@@ -1078,7 +1048,7 @@ static int ssl3_get_key_exchange(SSL *s)
                        goto f_err;
                        }
 
-#ifndef OPENSSL_NO_RSA
+#ifndef NO_RSA
                if (pkey->type == EVP_PKEY_RSA)
                        {
                        int num;
@@ -1114,7 +1084,7 @@ static int ssl3_get_key_exchange(SSL *s)
                        }
                else
 #endif
-#ifndef OPENSSL_NO_DSA
+#ifndef NO_DSA
                        if (pkey->type == EVP_PKEY_DSA)
                        {
                        /* lets do DSS */
@@ -1133,7 +1103,7 @@ static int ssl3_get_key_exchange(SSL *s)
                else
 #endif
                        {
-                       SSLerr(SSL_F_SSL3_GET_KEY_EXCHANGE,ERR_R_INTERNAL_ERROR);
+                       SSLerr(SSL_F_SSL3_GET_KEY_EXCHANGE,SSL_R_INTERNAL_ERROR);
                        goto err;
                        }
                }
@@ -1142,7 +1112,7 @@ static int ssl3_get_key_exchange(SSL *s)
                /* still data left over */
                if (!(alg & SSL_aNULL))
                        {
-                       SSLerr(SSL_F_SSL3_GET_KEY_EXCHANGE,ERR_R_INTERNAL_ERROR);
+                       SSLerr(SSL_F_SSL3_GET_KEY_EXCHANGE,SSL_R_INTERNAL_ERROR);
                        goto err;
                        }
                if (n != 0)
@@ -1158,11 +1128,11 @@ f_err:
        ssl3_send_alert(s,SSL3_AL_FATAL,al);
 err:
        EVP_PKEY_free(pkey);
-#ifndef OPENSSL_NO_RSA
+#ifndef NO_RSA
        if (rsa != NULL)
                RSA_free(rsa);
 #endif
-#ifndef OPENSSL_NO_DH
+#ifndef NO_DH
        if (dh != NULL)
                DH_free(dh);
 #endif
@@ -1182,7 +1152,7 @@ static int ssl3_get_certificate_request(SSL *s)
                SSL3_ST_CR_CERT_REQ_A,
                SSL3_ST_CR_CERT_REQ_B,
                -1,
-#if defined(OPENSSL_SYS_MSDOS) && !defined(OPENSSL_SYS_WIN32)
+#if defined(MSDOS) && !defined(WIN32)
                1024*30,  /* 30k max cert list :-) */
 #else
                1024*100, /* 100k max cert list :-) */
@@ -1348,13 +1318,10 @@ static int ssl3_send_client_key_exchange(SSL *s)
        unsigned char *p,*d;
        int n;
        unsigned long l;
-#ifndef OPENSSL_NO_RSA
+#ifndef NO_RSA
        unsigned char *q;
        EVP_PKEY *pkey=NULL;
 #endif
-#ifndef OPENSSL_NO_KRB5
-        KSSL_ERR kssl_err;
-#endif /* OPENSSL_NO_KRB5 */
 
        if (s->state == SSL3_ST_CW_KEY_EXCH_A)
                {
@@ -1363,10 +1330,8 @@ static int ssl3_send_client_key_exchange(SSL *s)
 
                l=s->s3->tmp.new_cipher->algorithms;
 
-                /* Fool emacs indentation */
-                if (0) {}
-#ifndef OPENSSL_NO_RSA
-               else if (l & SSL_kRSA)
+#ifndef NO_RSA
+               if (l & SSL_kRSA)
                        {
                        RSA *rsa;
                        unsigned char tmp_buf[SSL_MAX_MASTER_KEY_LENGTH];
@@ -1380,7 +1345,7 @@ static int ssl3_send_client_key_exchange(SSL *s)
                                        (pkey->type != EVP_PKEY_RSA) ||
                                        (pkey->pkey.rsa == NULL))
                                        {
-                                       SSLerr(SSL_F_SSL3_SEND_CLIENT_KEY_EXCHANGE,ERR_R_INTERNAL_ERROR);
+                                       SSLerr(SSL_F_SSL3_SEND_CLIENT_KEY_EXCHANGE,SSL_R_INTERNAL_ERROR);
                                        goto err;
                                        }
                                rsa=pkey->pkey.rsa;
@@ -1423,75 +1388,10 @@ static int ssl3_send_client_key_exchange(SSL *s)
                                        tmp_buf,SSL_MAX_MASTER_KEY_LENGTH);
                        memset(tmp_buf,0,SSL_MAX_MASTER_KEY_LENGTH);
                        }
+               else
 #endif
-#ifndef OPENSSL_NO_KRB5
-               else if (l & SSL_kKRB5)
-                        {
-                        krb5_error_code        krb5rc;
-                        KSSL_CTX       *kssl_ctx = s->kssl_ctx;
-                        krb5_data      krb5_ap_req;
-
-#ifdef KSSL_DEBUG
-                        printf("ssl3_send_client_key_exchange(%lx & %lx)\n",
-                                l, SSL_kKRB5);
-#endif /* KSSL_DEBUG */
-
-                        /*
-                        **     Tried to send random tmp_buf[] as PMS in Kerberos ticket
-                        **     by passing  krb5_mk_req_extended(ctx,authctx,opts, tmp_buf, ...)
-                        **     but: I can't retrieve the PMS on the other side!  There is
-                        **     some indication in the krb5 source that this is only used
-                        **     to generate a checksum.  OTOH, the Tung book shows data
-                        **     ("GET widget01.txt") being passed in krb5_mk_req_extended()
-                        **     by way of krb5_sendauth().  I don't get it.
-                        **     Until Kerberos goes 3DES, the big PMS secret would only be
-                        **     encrypted in 1-DES anyway.  So losing the PMS shouldn't be
-                        **     a big deal.
-                        */
-                        krb5rc = kssl_cget_tkt(kssl_ctx, &krb5_ap_req,
-                                &kssl_err);
-#ifdef KSSL_DEBUG
-                        {
-                        printf("kssl_cget_tkt rtn %d\n", krb5rc);
-                        kssl_ctx_show(kssl_ctx);
-                        if (krb5rc && kssl_err.text)
-                                printf("kssl_cget_tkt kssl_err=%s\n", kssl_err.text);
-                        }
-#endif /* KSSL_DEBUG */
-
-                        if (krb5rc)
-                                {
-                                ssl3_send_alert(s,SSL3_AL_FATAL,SSL_AD_HANDSHAKE_FAILURE);
-                                SSLerr(SSL_F_SSL3_SEND_CLIENT_KEY_EXCHANGE, kssl_err.reason);
-                                goto err;
-                                }
-
-                        /*     Send ticket (copy to *p, set n = length)
-                         */
-                        n = krb5_ap_req.length;
-                        memcpy(p, krb5_ap_req.data, krb5_ap_req.length);
-                        if (krb5_ap_req.data)  
-                                kssl_krb5_free_data_contents(NULL,&krb5_ap_req);
-
-                        /*     19991013 VRS -  3DES is kind of bogus here,
-                        **     at least until Kerberos supports 3DES.  The only
-                        **     real secret is the 8-byte Kerberos session key;
-                        **     the other key material ((s->) client_random, server_random)
-                        **     could be sniffed.  Mixing in these nonces should help
-                        **     protect against replay attacks, however.
-                        **
-                        **     Alternate code for Kerberos Purists:
-                        **
-                        **     memcpy(s->session->master_key, kssl_ctx->key, kssl_ctx->length);
-                        **     s->session->master_key_length = kssl_ctx->length;
-                        */
-                        s->session->master_key_length=
-                                s->method->ssl3_enc->generate_master_secret(s,
-                                        s->session->master_key,        kssl_ctx->key,kssl_ctx->length);
-                        }
-#endif
-#ifndef OPENSSL_NO_DH
-               else if (l & (SSL_kEDH|SSL_kDHr|SSL_kDHd))
+#ifndef NO_DH
+               if (l & (SSL_kEDH|SSL_kDHr|SSL_kDHd))
                        {
                        DH *dh_srvr,*dh_clnt;
 
@@ -1545,11 +1445,11 @@ static int ssl3_send_client_key_exchange(SSL *s)
 
                        /* perhaps clean things up a bit EAY EAY EAY EAY*/
                        }
-#endif
                else
+#endif
                        {
                        ssl3_send_alert(s,SSL3_AL_FATAL,SSL_AD_HANDSHAKE_FAILURE);
-                       SSLerr(SSL_F_SSL3_SEND_CLIENT_KEY_EXCHANGE,ERR_R_INTERNAL_ERROR);
+                       SSLerr(SSL_F_SSL3_SEND_CLIENT_KEY_EXCHANGE,SSL_R_INTERNAL_ERROR);
                        goto err;
                        }
                
@@ -1573,11 +1473,11 @@ static int ssl3_send_client_verify(SSL *s)
        unsigned char *p,*d;
        unsigned char data[MD5_DIGEST_LENGTH+SHA_DIGEST_LENGTH];
        EVP_PKEY *pkey;
-#ifndef OPENSSL_NO_RSA
+#ifndef NO_RSA
        unsigned u=0;
 #endif
        unsigned long n;
-#ifndef OPENSSL_NO_DSA
+#ifndef NO_DSA
        int j;
 #endif
 
@@ -1590,7 +1490,7 @@ static int ssl3_send_client_verify(SSL *s)
                s->method->ssl3_enc->cert_verify_mac(s,&(s->s3->finish_dgst2),
                        &(data[MD5_DIGEST_LENGTH]));
 
-#ifndef OPENSSL_NO_RSA
+#ifndef NO_RSA
                if (pkey->type == EVP_PKEY_RSA)
                        {
                        s->method->ssl3_enc->cert_verify_mac(s,
@@ -1607,7 +1507,7 @@ static int ssl3_send_client_verify(SSL *s)
                        }
                else
 #endif
-#ifndef OPENSSL_NO_DSA
+#ifndef NO_DSA
                        if (pkey->type == EVP_PKEY_DSA)
                        {
                        if (!DSA_sign(pkey->save_type,
@@ -1624,7 +1524,7 @@ static int ssl3_send_client_verify(SSL *s)
                else
 #endif
                        {
-                       SSLerr(SSL_F_SSL3_SEND_CLIENT_VERIFY,ERR_R_INTERNAL_ERROR);
+                       SSLerr(SSL_F_SSL3_SEND_CLIENT_VERIFY,SSL_R_INTERNAL_ERROR);
                        goto err;
                        }
                *(d++)=SSL3_MT_CERTIFICATE_VERIFY;
@@ -1723,10 +1623,10 @@ static int ssl3_check_cert_and_algorithm(SSL *s)
        long algs;
        EVP_PKEY *pkey=NULL;
        SESS_CERT *sc;
-#ifndef OPENSSL_NO_RSA
+#ifndef NO_RSA
        RSA *rsa;
 #endif
-#ifndef OPENSSL_NO_DH
+#ifndef NO_DH
        DH *dh;
 #endif
 
@@ -1734,20 +1634,20 @@ static int ssl3_check_cert_and_algorithm(SSL *s)
 
        if (sc == NULL)
                {
-               SSLerr(SSL_F_SSL3_CHECK_CERT_AND_ALGORITHM,ERR_R_INTERNAL_ERROR);
+               SSLerr(SSL_F_SSL3_CHECK_CERT_AND_ALGORITHM,SSL_R_INTERNAL_ERROR);
                goto err;
                }
 
        algs=s->s3->tmp.new_cipher->algorithms;
 
        /* we don't have a certificate */
-       if (algs & (SSL_aDH|SSL_aNULL|SSL_aKRB5))
+       if (algs & (SSL_aDH|SSL_aNULL))
                return(1);
 
-#ifndef OPENSSL_NO_RSA
+#ifndef NO_RSA
        rsa=s->session->sess_cert->peer_rsa_tmp;
 #endif
-#ifndef OPENSSL_NO_DH
+#ifndef NO_DH
        dh=s->session->sess_cert->peer_dh_tmp;
 #endif
 
@@ -1765,14 +1665,14 @@ static int ssl3_check_cert_and_algorithm(SSL *s)
                SSLerr(SSL_F_SSL3_CHECK_CERT_AND_ALGORITHM,SSL_R_MISSING_RSA_SIGNING_CERT);
                goto f_err;
                }
-#ifndef OPENSSL_NO_DSA
+#ifndef NO_DSA
        else if ((algs & SSL_aDSS) && !has_bits(i,EVP_PK_DSA|EVP_PKT_SIGN))
                {
                SSLerr(SSL_F_SSL3_CHECK_CERT_AND_ALGORITHM,SSL_R_MISSING_DSA_SIGNING_CERT);
                goto f_err;
                }
 #endif
-#ifndef OPENSSL_NO_RSA
+#ifndef NO_RSA
        if ((algs & SSL_kRSA) &&
                !(has_bits(i,EVP_PK_RSA|EVP_PKT_ENC) || (rsa != NULL)))
                {
@@ -1780,7 +1680,7 @@ static int ssl3_check_cert_and_algorithm(SSL *s)
                goto f_err;
                }
 #endif
-#ifndef OPENSSL_NO_DH
+#ifndef NO_DH
        if ((algs & SSL_kEDH) &&
                !(has_bits(i,EVP_PK_DH|EVP_PKT_EXCH) || (dh != NULL)))
                {
@@ -1792,7 +1692,7 @@ static int ssl3_check_cert_and_algorithm(SSL *s)
                SSLerr(SSL_F_SSL3_CHECK_CERT_AND_ALGORITHM,SSL_R_MISSING_DH_RSA_CERT);
                goto f_err;
                }
-#ifndef OPENSSL_NO_DSA
+#ifndef NO_DSA
        else if ((algs & SSL_kDHd) && !has_bits(i,EVP_PK_DH|EVP_PKS_DSA))
                {
                SSLerr(SSL_F_SSL3_CHECK_CERT_AND_ALGORITHM,SSL_R_MISSING_DH_DSA_CERT);
@@ -1803,7 +1703,7 @@ static int ssl3_check_cert_and_algorithm(SSL *s)
 
        if (SSL_C_IS_EXPORT(s->s3->tmp.new_cipher) && !has_bits(i,EVP_PKT_EXP))
                {
-#ifndef OPENSSL_NO_RSA
+#ifndef NO_RSA
                if (algs & SSL_kRSA)
                        {
                        if (rsa == NULL
@@ -1815,7 +1715,7 @@ static int ssl3_check_cert_and_algorithm(SSL *s)
                        }
                else
 #endif
-#ifndef OPENSSL_NO_DH
+#ifndef NO_DH
                        if (algs & (SSL_kEDH|SSL_kDHr|SSL_kDHd))
                            {
                            if (dh == NULL