LocalPlayer::accelerateHorizontal: cleanups

[oweals/minetest.git] / src / staticobject.h

diff --git a/src/staticobject.h b/src/staticobject.h
index 575c15b18d9de747c9fbaf717cb30ce169d90a22..fb73befd38f3b405d321e64a90822e0f8453b09a 100644 (file)
--- a/src/staticobject.h
+++ b/src/staticobject.h
@@ -23,21 +23,17 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "irrlichttypes_bloated.h"
 #include <string>
 #include <sstream>
-#include <list>
+#include <vector>
 #include <map>
 #include "debug.h"
 
 struct StaticObject
 {
-       u8 type;
+       u8 type = 0;
        v3f pos;
        std::string data;
 
-       StaticObject():
-               type(0),
-               pos(0,0,0)
-       {
-       }
+       StaticObject() {}
        StaticObject(u8 type_, v3f pos_, const std::string &data_):
                type(type_),
                pos(pos_),
@@ -68,8 +64,7 @@ public:
                        {
                                dstream<<"ERROR: StaticObjectList::insert(): "
                                                <<"id already exists"<<std::endl;
-                               assert(0);
-                               return;
+                               FATAL_ERROR("StaticObjectList::insert()");
                        }
                        m_active[id] = obj;
                }
@@ -77,10 +72,10 @@ public:
 
        void remove(u16 id)
        {
-               assert(id != 0);
+               assert(id != 0); // Pre-condition
                if(m_active.find(id) == m_active.end())
                {
-                       dstream<<"WARNING: StaticObjectList::remove(): id="<<id
+                       warningstream<<"StaticObjectList::remove(): id="<<id
                                        <<" not found"<<std::endl;
                        return;
                }
@@ -89,13 +84,13 @@ public:
 
        void serialize(std::ostream &os);
        void deSerialize(std::istream &is);
-       
+
        /*
                NOTE: When an object is transformed to active, it is removed
                from m_stored and inserted to m_active.
                The caller directly manipulates these containers.
        */
-       std::list<StaticObject> m_stored;
+       std::vector<StaticObject> m_stored;
        std::map<u16, StaticObject> m_active;
 
 private: