Fix Lua panic when error() message is not a string
[oweals/minetest.git] / src / server.cpp
index 0346d197d7d3c6843b26cb66ec94d4e72f5ca83b..6ecbd70973d58b5163b0336f895584bd356343de 100644 (file)
@@ -64,6 +64,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "chat_interface.h"
 #include "remoteplayer.h"
 #include "server/player_sao.h"
+#include "server/serverinventorymgr.h"
 #include "translation.h"
 
 class ClientNotFoundException : public BaseException
@@ -338,11 +339,6 @@ Server::~Server()
        infostream << "Server: Deinitializing scripting" << std::endl;
        delete m_script;
 
-       // Delete detached inventories
-       for (auto &detached_inventory : m_detached_inventories) {
-               delete detached_inventory.second;
-       }
-
        while (!m_unsent_map_edit_queue.empty()) {
                delete m_unsent_map_edit_queue.front();
                m_unsent_map_edit_queue.pop();
@@ -388,6 +384,9 @@ void Server::init()
 
        m_script = new ServerScripting(this);
 
+       // Must be created before mod loading because we have some inventory creation
+       m_inventory_mgr = std::unique_ptr<ServerInventoryManager>(new ServerInventoryManager());
+
        m_script->loadMod(getBuiltinLuaPath() + DIR_DELIM "init.lua", BUILTIN_MOD_NAME);
 
        m_modmgr->loadMods(m_script);
@@ -413,8 +412,8 @@ void Server::init()
        // Perform pending node name resolutions
        m_nodedef->runNodeResolveCallbacks();
 
-       // unmap node names for connected nodeboxes
-       m_nodedef->mapNodeboxConnections();
+       // unmap node names in cross-references
+       m_nodedef->resolveCrossrefs();
 
        // init the recipe hashes to speed up crafting
        m_craftdef->initHashes(this);
@@ -422,6 +421,7 @@ void Server::init()
        // Initialize Environment
        m_env = new ServerEnvironment(servermap, m_script, this, m_path_world);
 
+       m_inventory_mgr->setEnv(m_env);
        m_clients.setEnv(m_env);
 
        if (!servermap->settings_mgr.makeMapgenParams())
@@ -443,6 +443,8 @@ void Server::init()
 
        m_env->loadMeta();
 
+       // Those settings can be overwritten in world.mt, they are
+       // intended to be cached after environment loading.
        m_liquid_transform_every = g_settings->getFloat("liquid_update");
        m_max_chatmessage_length = g_settings->getU16("chat_message_max_size");
        m_csm_restriction_flags = g_settings->getU64("csm_restriction_flags");
@@ -451,6 +453,8 @@ void Server::init()
 
 void Server::start()
 {
+       init();
+
        infostream << "Starting server on " << m_bind_addr.serializeString()
                        << "..." << std::endl;
 
@@ -714,34 +718,35 @@ void Server::AsyncRunStep(bool initial_step)
                std::unordered_map<u16, std::vector<ActiveObjectMessage>*> buffered_messages;
 
                // Get active object messages from environment
+               ActiveObjectMessage aom(0);
+               u32 aom_count = 0;
                for(;;) {
-                       ActiveObjectMessage aom = m_env->getActiveObjectMessage();
-                       if (aom.id == 0)
+                       if (!m_env->getActiveObjectMessage(&aom))
                                break;
 
                        std::vector<ActiveObjectMessage>* message_list = nullptr;
-                       std::unordered_map<u16, std::vector<ActiveObjectMessage>* >::iterator n;
-                       n = buffered_messages.find(aom.id);
+                       auto n = buffered_messages.find(aom.id);
                        if (n == buffered_messages.end()) {
                                message_list = new std::vector<ActiveObjectMessage>;
                                buffered_messages[aom.id] = message_list;
-                       }
-                       else {
+                       } else {
                                message_list = n->second;
                        }
-                       message_list->push_back(aom);
+                       message_list->push_back(std::move(aom));
+                       aom_count++;
                }
 
-               m_aom_buffer_counter->increment(buffered_messages.size());
+               m_aom_buffer_counter->increment(aom_count);
 
                m_clients.lock();
                const RemoteClientMap &clients = m_clients.getClientList();
                // Route data to every client
+               std::string reliable_data, unreliable_data;
                for (const auto &client_it : clients) {
+                       reliable_data.clear();
+                       unreliable_data.clear();
                        RemoteClient *client = client_it.second;
                        PlayerSAO *player = getPlayerSAO(client->peer_id);
-                       std::string reliable_data;
-                       std::string unreliable_data;
                        // Go through all objects in message buffer
                        for (const auto &buffered_message : buffered_messages) {
                                // If object does not exist or is not known by client, skip it
@@ -766,19 +771,15 @@ void Server::AsyncRunStep(bool initial_step)
                                                                client->m_known_objects.end())
                                                        continue;
                                        }
-                                       // Compose the full new data with header
-                                       std::string new_data;
-                                       // Add object id
-                                       char buf[2];
-                                       writeU16((u8*)&buf[0], aom.id);
-                                       new_data.append(buf, 2);
-                                       // Add data
-                                       new_data += serializeString(aom.datastring);
-                                       // Add data to buffer
-                                       if (aom.reliable)
-                                               reliable_data += new_data;
-                                       else
-                                               unreliable_data += new_data;
+
+                                       // Add full new data to appropriate buffer
+                                       std::string &buffer = aom.reliable ? reliable_data : unreliable_data;
+                                       char idbuf[2];
+                                       writeU16((u8*) idbuf, aom.id);
+                                       // u16 id
+                                       // std::string data
+                                       buffer.append(idbuf, sizeof(idbuf));
+                                       buffer.append(serializeString(aom.datastring));
                                }
                        }
                        /*
@@ -1180,82 +1181,6 @@ void Server::onMapEditEvent(const MapEditEvent &event)
        m_unsent_map_edit_queue.push(new MapEditEvent(event));
 }
 
-Inventory* Server::getInventory(const InventoryLocation &loc)
-{
-       switch (loc.type) {
-       case InventoryLocation::UNDEFINED:
-       case InventoryLocation::CURRENT_PLAYER:
-               break;
-       case InventoryLocation::PLAYER:
-       {
-               RemotePlayer *player = m_env->getPlayer(loc.name.c_str());
-               if(!player)
-                       return NULL;
-               PlayerSAO *playersao = player->getPlayerSAO();
-               if(!playersao)
-                       return NULL;
-               return playersao->getInventory();
-       }
-               break;
-       case InventoryLocation::NODEMETA:
-       {
-               NodeMetadata *meta = m_env->getMap().getNodeMetadata(loc.p);
-               if(!meta)
-                       return NULL;
-               return meta->getInventory();
-       }
-               break;
-       case InventoryLocation::DETACHED:
-       {
-               if(m_detached_inventories.count(loc.name) == 0)
-                       return NULL;
-               return m_detached_inventories[loc.name];
-       }
-               break;
-       default:
-               sanity_check(false); // abort
-               break;
-       }
-       return NULL;
-}
-
-void Server::setInventoryModified(const InventoryLocation &loc)
-{
-       switch(loc.type){
-       case InventoryLocation::UNDEFINED:
-               break;
-       case InventoryLocation::PLAYER:
-       {
-
-               RemotePlayer *player = m_env->getPlayer(loc.name.c_str());
-
-               if (!player)
-                       return;
-
-               player->setModified(true);
-               player->inventory.setModified(true);
-               // Updates are sent in ServerEnvironment::step()
-       }
-               break;
-       case InventoryLocation::NODEMETA:
-       {
-               MapEditEvent event;
-               event.type = MEET_BLOCK_NODE_METADATA_CHANGED;
-               event.p = loc.p;
-               m_env->getMap().dispatchEvent(event);
-       }
-               break;
-       case InventoryLocation::DETACHED:
-       {
-               // Updates are sent in ServerEnvironment::step()
-       }
-               break;
-       default:
-               sanity_check(false); // abort
-               break;
-       }
-}
-
 void Server::SetBlocksNotSent(std::map<v3s16, MapBlock *>& block)
 {
        std::vector<session_t> clients = m_clients.getClientIDs();
@@ -1576,17 +1501,15 @@ void Server::SendShowFormspecMessage(session_t peer_id, const std::string &forms
 
 // Spawns a particle on peer with peer_id
 void Server::SendSpawnParticle(session_t peer_id, u16 protocol_version,
-                               v3f pos, v3f velocity, v3f acceleration,
-                               float expirationtime, float size, bool collisiondetection,
-                               bool collision_removal, bool object_collision,
-                               bool vertical, const std::string &texture,
-                               const struct TileAnimationParams &animation, u8 glow)
+       const ParticleParameters &p)
 {
        static thread_local const float radius =
                        g_settings->getS16("max_block_send_distance") * MAP_BLOCKSIZE * BS;
 
        if (peer_id == PEER_ID_INEXISTENT) {
                std::vector<session_t> clients = m_clients.getClientIDs();
+               const v3f pos = p.pos * BS;
+               const float radius_sq = radius * radius;
 
                for (const session_t client_id : clients) {
                        RemotePlayer *player = m_env->getPlayer(client_id);
@@ -1598,76 +1521,78 @@ void Server::SendSpawnParticle(session_t peer_id, u16 protocol_version,
                                continue;
 
                        // Do not send to distant clients
-                       if (sao->getBasePosition().getDistanceFrom(pos * BS) > radius)
+                       if (sao->getBasePosition().getDistanceFromSQ(pos) > radius_sq)
                                continue;
 
-                       SendSpawnParticle(client_id, player->protocol_version,
-                                       pos, velocity, acceleration,
-                                       expirationtime, size, collisiondetection, collision_removal,
-                                       object_collision, vertical, texture, animation, glow);
+                       SendSpawnParticle(client_id, player->protocol_version, p);
                }
                return;
        }
+       assert(protocol_version != 0);
 
        NetworkPacket pkt(TOCLIENT_SPAWN_PARTICLE, 0, peer_id);
 
-       pkt << pos << velocity << acceleration << expirationtime
-                       << size << collisiondetection;
-       pkt.putLongString(texture);
-       pkt << vertical;
-       pkt << collision_removal;
-       // This is horrible but required (why are there two ways to serialize pkts?)
-       std::ostringstream os(std::ios_base::binary);
-       animation.serialize(os, protocol_version);
-       pkt.putRawString(os.str());
-       pkt << glow;
-       pkt << object_collision;
+       {
+               // NetworkPacket and iostreams are incompatible...
+               std::ostringstream oss(std::ios_base::binary);
+               p.serialize(oss, protocol_version);
+               pkt.putRawString(oss.str());
+       }
 
        Send(&pkt);
 }
 
 // Adds a ParticleSpawner on peer with peer_id
 void Server::SendAddParticleSpawner(session_t peer_id, u16 protocol_version,
-       u16 amount, float spawntime, v3f minpos, v3f maxpos,
-       v3f minvel, v3f maxvel, v3f minacc, v3f maxacc, float minexptime, float maxexptime,
-       float minsize, float maxsize, bool collisiondetection, bool collision_removal,
-       bool object_collision, u16 attached_id, bool vertical, const std::string &texture, u32 id,
-       const struct TileAnimationParams &animation, u8 glow)
+       const ParticleSpawnerParameters &p, u16 attached_id, u32 id)
 {
+       static thread_local const float radius =
+                       g_settings->getS16("max_block_send_distance") * MAP_BLOCKSIZE * BS;
+
        if (peer_id == PEER_ID_INEXISTENT) {
-               // This sucks and should be replaced:
                std::vector<session_t> clients = m_clients.getClientIDs();
+               const v3f pos = (p.minpos + p.maxpos) / 2.0f * BS;
+               const float radius_sq = radius * radius;
+               /* Don't send short-lived spawners to distant players.
+                * This could be replaced with proper tracking at some point. */
+               const bool distance_check = !attached_id && p.time <= 1.0f;
+
                for (const session_t client_id : clients) {
                        RemotePlayer *player = m_env->getPlayer(client_id);
                        if (!player)
                                continue;
+
+                       if (distance_check) {
+                               PlayerSAO *sao = player->getPlayerSAO();
+                               if (!sao)
+                                       continue;
+                               if (sao->getBasePosition().getDistanceFromSQ(pos) > radius_sq)
+                                       continue;
+                       }
+
                        SendAddParticleSpawner(client_id, player->protocol_version,
-                                       amount, spawntime, minpos, maxpos,
-                                       minvel, maxvel, minacc, maxacc, minexptime, maxexptime,
-                                       minsize, maxsize, collisiondetection, collision_removal,
-                                       object_collision, attached_id, vertical, texture, id,
-                                       animation, glow);
+                               p, attached_id, id);
                }
                return;
        }
+       assert(protocol_version != 0);
 
-       NetworkPacket pkt(TOCLIENT_ADD_PARTICLESPAWNER, 0, peer_id);
+       NetworkPacket pkt(TOCLIENT_ADD_PARTICLESPAWNER, 100, peer_id);
 
-       pkt << amount << spawntime << minpos << maxpos << minvel << maxvel
-                       << minacc << maxacc << minexptime << maxexptime << minsize
-                       << maxsize << collisiondetection;
+       pkt << p.amount << p.time << p.minpos << p.maxpos << p.minvel
+               << p.maxvel << p.minacc << p.maxacc << p.minexptime << p.maxexptime
+               << p.minsize << p.maxsize << p.collisiondetection;
 
-       pkt.putLongString(texture);
+       pkt.putLongString(p.texture);
 
-       pkt << id << vertical;
-       pkt << collision_removal;
-       pkt << attached_id;
-       // This is horrible but required
-       std::ostringstream os(std::ios_base::binary);
-       animation.serialize(os, protocol_version);
-       pkt.putRawString(os.str());
-       pkt << glow;
-       pkt << object_collision;
+       pkt << id << p.vertical << p.collision_removal << attached_id;
+       {
+               std::ostringstream os(std::ios_base::binary);
+               p.animation.serialize(os, protocol_version);
+               pkt.putRawString(os.str());
+       }
+       pkt << p.glow << p.object_collision;
+       pkt << p.node.param0 << p.node.param2 << p.node_tile;
 
        Send(&pkt);
 }
@@ -1676,7 +1601,6 @@ void Server::SendDeleteParticleSpawner(session_t peer_id, u32 id)
 {
        NetworkPacket pkt(TOCLIENT_DELETE_PARTICLESPAWNER, 4, peer_id);
 
-       // Ugly error in this packet
        pkt << id;
 
        if (peer_id != PEER_ID_INEXISTENT)
@@ -1693,7 +1617,7 @@ void Server::SendHUDAdd(session_t peer_id, u32 id, HudElement *form)
        pkt << id << (u8) form->type << form->pos << form->name << form->scale
                        << form->text << form->number << form->item << form->dir
                        << form->align << form->offset << form->world_pos << form->size
-                       << form->z_index;
+                       << form->z_index << form->text2;
 
        Send(&pkt);
 }
@@ -1719,6 +1643,7 @@ void Server::SendHUDChange(session_t peer_id, u32 id, HudElementStat stat, void
                        break;
                case HUD_STAT_NAME:
                case HUD_STAT_TEXT:
+               case HUD_STAT_TEXT2:
                        pkt << *(std::string *) value;
                        break;
                case HUD_STAT_WORLD_POS:
@@ -1770,8 +1695,8 @@ void Server::SendSetSky(session_t peer_id, const SkyboxParams &params)
                pkt << params.clouds;
        } else { // Handle current clients and future clients
                pkt << params.bgcolor << params.type
-               << params.clouds << params.sun_tint
-               << params.moon_tint << params.tint_type;
+               << params.clouds << params.fog_sun_tint
+               << params.fog_moon_tint << params.fog_tint_type;
 
                if (params.type == "skybox") {
                        pkt << (u16) params.textures.size();
@@ -2712,40 +2637,20 @@ void Server::sendRequestedMedia(session_t peer_id,
        }
 }
 
-void Server::sendDetachedInventory(const std::string &name, session_t peer_id)
+void Server::sendDetachedInventory(Inventory *inventory, const std::string &name, session_t peer_id)
 {
-       const auto &inv_it = m_detached_inventories.find(name);
-       const auto &player_it = m_detached_inventories_player.find(name);
-
-       if (player_it == m_detached_inventories_player.end() ||
-                       player_it->second.empty()) {
-               // OK. Send to everyone
-       } else {
-               if (!m_env)
-                       return; // Mods are not done loading
-
-               RemotePlayer *p = m_env->getPlayer(player_it->second.c_str());
-               if (!p)
-                       return; // Player is offline
-
-               if (peer_id != PEER_ID_INEXISTENT && peer_id != p->getPeerId())
-                       return; // Caller requested send to a different player, so don't send.
-
-               peer_id = p->getPeerId();
-       }
-
        NetworkPacket pkt(TOCLIENT_DETACHED_INVENTORY, 0, peer_id);
        pkt << name;
 
-       if (inv_it == m_detached_inventories.end()) {
+       if (!inventory) {
                pkt << false; // Remove inventory
        } else {
                pkt << true; // Update inventory
 
                // Serialization & NetworkPacket isn't a love story
                std::ostringstream os(std::ios_base::binary);
-               inv_it->second->serialize(os);
-               inv_it->second->setModified(false);
+               inventory->serialize(os);
+               inventory->setModified(false);
 
                const std::string &os_str = os.str();
                pkt << static_cast<u16>(os_str.size()); // HACK: to keep compatibility with 5.0.0 clients
@@ -2760,16 +2665,17 @@ void Server::sendDetachedInventory(const std::string &name, session_t peer_id)
 
 void Server::sendDetachedInventories(session_t peer_id, bool incremental)
 {
-       for (const auto &detached_inventory : m_detached_inventories) {
-               const std::string &name = detached_inventory.first;
-               if (incremental) {
-                       Inventory *inv = detached_inventory.second;
-                       if (!inv || !inv->checkModified())
-                               continue;
-               }
-
-               sendDetachedInventory(name, peer_id);
+       // Lookup player name, to filter detached inventories just after
+       std::string peer_name;
+       if (peer_id != PEER_ID_INEXISTENT) {
+               peer_name = getClient(peer_id, CS_Created)->getName();
        }
+
+       auto send_cb = [this, peer_id](const std::string &name, Inventory *inv) {
+               sendDetachedInventory(inv, name, peer_id);
+       };
+
+       m_inventory_mgr->sendDetachedInventories(peer_name, incremental, send_cb);
 }
 
 /*
@@ -3442,15 +3348,12 @@ void Server::setClouds(RemotePlayer *player, const CloudParams &params)
        SendCloudParams(player->getPeerId(), params);
 }
 
-bool Server::overrideDayNightRatio(RemotePlayer *player, bool do_override,
+void Server::overrideDayNightRatio(RemotePlayer *player, bool do_override,
        float ratio)
 {
-       if (!player)
-               return false;
-
+       sanity_check(player);
        player->overrideDayNightRatio(do_override, ratio);
        SendOverrideDayNightRatio(player->getPeerId(), do_override, ratio);
-       return true;
 }
 
 void Server::notifyPlayers(const std::wstring &msg)
@@ -3458,12 +3361,8 @@ void Server::notifyPlayers(const std::wstring &msg)
        SendChatMessage(PEER_ID_INEXISTENT, ChatMessage(msg));
 }
 
-void Server::spawnParticle(const std::string &playername, v3f pos,
-       v3f velocity, v3f acceleration,
-       float expirationtime, float size, bool
-       collisiondetection, bool collision_removal, bool object_collision,
-       bool vertical, const std::string &texture,
-       const struct TileAnimationParams &animation, u8 glow)
+void Server::spawnParticle(const std::string &playername,
+       const ParticleParameters &p)
 {
        // m_env will be NULL if the server is initializing
        if (!m_env)
@@ -3479,18 +3378,11 @@ void Server::spawnParticle(const std::string &playername, v3f pos,
                proto_ver = player->protocol_version;
        }
 
-       SendSpawnParticle(peer_id, proto_ver, pos, velocity, acceleration,
-                       expirationtime, size, collisiondetection, collision_removal,
-                       object_collision, vertical, texture, animation, glow);
+       SendSpawnParticle(peer_id, proto_ver, p);
 }
 
-u32 Server::addParticleSpawner(u16 amount, float spawntime,
-       v3f minpos, v3f maxpos, v3f minvel, v3f maxvel, v3f minacc, v3f maxacc,
-       float minexptime, float maxexptime, float minsize, float maxsize,
-       bool collisiondetection, bool collision_removal, bool object_collision,
-       ServerActiveObject *attached, bool vertical, const std::string &texture,
-       const std::string &playername, const struct TileAnimationParams &animation,
-       u8 glow)
+u32 Server::addParticleSpawner(const ParticleSpawnerParameters &p,
+       ServerActiveObject *attached, const std::string &playername)
 {
        // m_env will be NULL if the server is initializing
        if (!m_env)
@@ -3510,16 +3402,11 @@ u32 Server::addParticleSpawner(u16 amount, float spawntime,
 
        u32 id;
        if (attached_id == 0)
-               id = m_env->addParticleSpawner(spawntime);
+               id = m_env->addParticleSpawner(p.time);
        else
-               id = m_env->addParticleSpawner(spawntime, attached_id);
-
-       SendAddParticleSpawner(peer_id, proto_ver, amount, spawntime,
-               minpos, maxpos, minvel, maxvel, minacc, maxacc,
-               minexptime, maxexptime, minsize, maxsize, collisiondetection,
-               collision_removal, object_collision, attached_id, vertical,
-               texture, id, animation, glow);
+               id = m_env->addParticleSpawner(p.time, attached_id);
 
+       SendAddParticleSpawner(peer_id, proto_ver, p, attached_id, id);
        return id;
 }
 
@@ -3541,52 +3428,6 @@ void Server::deleteParticleSpawner(const std::string &playername, u32 id)
        SendDeleteParticleSpawner(peer_id, id);
 }
 
-Inventory* Server::createDetachedInventory(const std::string &name, const std::string &player)
-{
-       if(m_detached_inventories.count(name) > 0){
-               infostream<<"Server clearing detached inventory \""<<name<<"\""<<std::endl;
-               delete m_detached_inventories[name];
-       } else {
-               infostream<<"Server creating detached inventory \""<<name<<"\""<<std::endl;
-       }
-       Inventory *inv = new Inventory(m_itemdef);
-       sanity_check(inv);
-       m_detached_inventories[name] = inv;
-       if (!player.empty())
-               m_detached_inventories_player[name] = player;
-
-       //TODO find a better way to do this
-       sendDetachedInventory(name,PEER_ID_INEXISTENT);
-       return inv;
-}
-
-bool Server::removeDetachedInventory(const std::string &name)
-{
-       const auto &inv_it = m_detached_inventories.find(name);
-       if (inv_it == m_detached_inventories.end())
-               return false;
-
-       delete inv_it->second;
-       m_detached_inventories.erase(inv_it);
-
-       if (!m_env) // Mods are not done loading
-               return true;
-
-       const auto &player_it = m_detached_inventories_player.find(name);
-       if (player_it != m_detached_inventories_player.end()) {
-               RemotePlayer *player = m_env->getPlayer(player_it->second.c_str());
-
-               if (player && player->getPeerId() != PEER_ID_INEXISTENT)
-                       sendDetachedInventory(name, player->getPeerId());
-
-               m_detached_inventories_player.erase(player_it);
-       } else {
-               // Notify all players about the change
-               sendDetachedInventory(name, PEER_ID_INEXISTENT);
-       }
-       return true;
-}
-
 // actions: time-reversed list
 // Return value: success/failure
 bool Server::rollbackRevertActions(const std::list<RollbackAction> &actions,
@@ -3607,7 +3448,7 @@ bool Server::rollbackRevertActions(const std::list<RollbackAction> &actions,
 
        for (const RollbackAction &action : actions) {
                num_tried++;
-               bool success = action.applyRevert(map, this, this);
+               bool success = action.applyRevert(map, m_inventory_mgr.get(), this);
                if(!success){
                        num_failed++;
                        std::ostringstream os;