Optimize updateFastFaceRow processing by removing some TileSpec copy (#5678)

[oweals/minetest.git] / src / nodemetadata.cpp

diff --git a/src/nodemetadata.cpp b/src/nodemetadata.cpp
index d63dac6966432c9447628eafb9c855cec94ad34d..9b60cf33e1a39d8d92f461b06528d8f9ba5b193b 100644 (file)
--- a/src/nodemetadata.cpp
+++ b/src/nodemetadata.cpp
@@ -31,10 +31,8 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 */
 
 NodeMetadata::NodeMetadata(IItemDefManager *item_def_mgr):
-       m_stringvars(),
        m_inventory(new Inventory(item_def_mgr))
-{
-}
+{}
 
 NodeMetadata::~NodeMetadata()
 {
@@ -70,10 +68,15 @@ void NodeMetadata::deSerialize(std::istream &is)
 
 void NodeMetadata::clear()
 {
-       m_stringvars.clear();
+       Metadata::clear();
        m_inventory->clear();
 }
 
+bool NodeMetadata::empty() const
+{
+       return Metadata::empty() && m_inventory->getLists().size() == 0;
+}
+
 /*
        NodeMetadataList
 */
@@ -84,14 +87,13 @@ void NodeMetadataList::serialize(std::ostream &os) const
                Version 0 is a placeholder for "nothing to see here; go away."
        */
 
-       if(m_data.empty()){
+       u16 count = countNonEmpty();
+       if (count == 0) {
                writeU8(os, 0); // version
                return;
        }
 
        writeU8(os, 1); // version
-
-       u16 count = m_data.size();
        writeU16(os, count);
 
        for(std::map<v3s16, NodeMetadata*>::const_iterator
@@ -100,6 +102,8 @@ void NodeMetadataList::serialize(std::ostream &os) const
        {
                v3s16 p = i->first;
                NodeMetadata *data = i->second;
+               if (data->empty())
+                       continue;
 
                u16 p16 = p.Z * MAP_BLOCKSIZE * MAP_BLOCKSIZE + p.Y * MAP_BLOCKSIZE + p.X;
                writeU16(os, p16);
@@ -120,7 +124,7 @@ void NodeMetadataList::deSerialize(std::istream &is, IItemDefManager *item_def_m
        }
 
        if (version != 1) {
-               std::string err_str = std::string(__FUNCTION_NAME)
+               std::string err_str = std::string(FUNCTION_NAME)
                        + ": version " + itos(version) + " not supported";
                infostream << err_str << std::endl;
                throw SerializationError(err_str);
@@ -139,7 +143,7 @@ void NodeMetadataList::deSerialize(std::istream &is, IItemDefManager *item_def_m
                p.X = p16;
 
                if (m_data.find(p) != m_data.end()) {
-                       infostream<<"WARNING: NodeMetadataList::deSerialize(): "
+                       warningstream<<"NodeMetadataList::deSerialize(): "
                                        <<"already set data at position"
                                        <<"("<<p.X<<","<<p.Y<<","<<p.Z<<"): Ignoring."
                                        <<std::endl;
@@ -200,34 +204,13 @@ void NodeMetadataList::clear()
        m_data.clear();
 }
 
-std::string NodeMetadata::getString(const std::string &name,
-       unsigned short recursion) const
-{
-       StringMap::const_iterator it = m_stringvars.find(name);
-       if (it == m_stringvars.end())
-               return "";
-
-       return resolveString(it->second, recursion);
-}
-
-void NodeMetadata::setString(const std::string &name, const std::string &var)
-{
-       if (var.empty()) {
-               m_stringvars.erase(name);
-       } else {
-               m_stringvars[name] = var;
-       }
-}
-
-std::string NodeMetadata::resolveString(const std::string &str,
-       unsigned short recursion) const
+int NodeMetadataList::countNonEmpty() const
 {
-       if (recursion > 1) {
-               return str;
-       }
-       if (str.substr(0, 2) == "${" && str[str.length() - 1] == '}') {
-               return getString(str.substr(2, str.length() - 3), recursion + 1);
+       int n = 0;
+       std::map<v3s16, NodeMetadata*>::const_iterator it;
+       for (it = m_data.begin(); it != m_data.end(); ++it) {
+               if (!it->second->empty())
+                       n++;
        }
-       return str;
+       return n;
 }
-