Noise: Prevent unittest crash caused by division by zero

[oweals/minetest.git] / src / mapgen_valleys.h

diff --git a/src/mapgen_valleys.h b/src/mapgen_valleys.h
index 0e268c1cf4e40b1c7d2bf170928de3a85ca60c05..573f598a58fe34a86ab2c94ae76bf491fe41547d 100644 (file)
--- a/src/mapgen_valleys.h
+++ b/src/mapgen_valleys.h
@@ -1,8 +1,7 @@
 /*
 Minetest Valleys C
-Copyright (C) 2010-2015 kwolekr, Ryan Kwolek <kwolekr@minetest.net>
-Copyright (C) 2010-2015 paramat, Matt Gregory
-Copyright (C) 2016 Duane Robertson <duane@duanerobertson.com>
+Copyright (C) 2016-2017 Duane Robertson <duane@duanerobertson.com>
+Copyright (C) 2016-2017 paramat
 
 Based on Valleys Mapgen by Gael de Sailly
  (https://forum.minetest.net/viewtopic.php?f=9&t=11430)
@@ -46,16 +45,16 @@ class BiomeGenOriginal;
 //extern Profiler *mapgen_profiler;
 
 
-struct MapgenValleysParams : public MapgenSpecificParams {
-       u32 spflags;
-       s16 large_cave_depth;
-       s16 massive_cave_depth;
-       u16 altitude_chill;
-       u16 lava_features;
-       u16 river_depth;
-       u16 river_size;
-       u16 water_features;
-       float cave_width;
+struct MapgenValleysParams : public MapgenParams {
+       u32 spflags = MGVALLEYS_HUMID_RIVERS | MGVALLEYS_ALT_CHILL;
+       s16 large_cave_depth = -33;
+       s16 massive_cave_depth = -256; // highest altitude of massive caves
+       u16 altitude_chill = 90; // The altitude at which temperature drops by 20C.
+       u16 lava_features = 0; // How often water will occur in caves.
+       u16 river_depth = 4; // How deep to carve river channels.
+       u16 river_size = 5; // How wide to make rivers.
+       u16 water_features = 0; // How often water will occur in caves.
+       float cave_width = 0.09f;
        NoiseParams np_cave1;
        NoiseParams np_cave2;
        NoiseParams np_filler_depth;
@@ -85,40 +84,28 @@ struct TerrainNoise {
        float inter_valley_fill;
 };
 
-class MapgenValleys : public Mapgen {
+class MapgenValleys : public MapgenBasic {
 public:
 
-       MapgenValleys(int mapgenid, MapgenParams *params, EmergeManager *emerge);
+       MapgenValleys(int mapgenid, MapgenValleysParams *params, EmergeManager *emerge);
        ~MapgenValleys();
 
+       virtual MapgenType getType() const { return MAPGEN_VALLEYS; }
+
        virtual void makeChunk(BlockMakeData *data);
        int getSpawnLevelAtPoint(v2s16 p);
 
        s16 large_cave_depth;
 
 private:
-       EmergeManager *m_emerge;
-       BiomeManager *bmgr;
        BiomeGenOriginal *m_bgen;
 
-       int ystride;
-       int zstride;
-       int zstride_1d;
-
-       float map_gen_limit;
-
        bool humid_rivers;
        bool use_altitude_chill;
        float humidity_adjust;
        s16 cave_water_max_height;
        s16 lava_max_height;
 
-       v3s16 node_min;
-       v3s16 node_max;
-       v3s16 full_node_min;
-       v3s16 full_node_max;
-
-       u32 spflags;
        float altitude_chill;
        s16 lava_features_lim;
        s16 massive_cave_depth;
@@ -126,33 +113,16 @@ private:
        float river_size_factor;
        float *tcave_cache;
        s16 water_features_lim;
-       float cave_width;
-       Noise *noise_filler_depth;
-       Noise *noise_cave1;
-       Noise *noise_cave2;
        Noise *noise_inter_valley_fill;
        Noise *noise_inter_valley_slope;
        Noise *noise_rivers;
+       Noise *noise_cave1;
+       Noise *noise_cave2;
        Noise *noise_massive_caves;
        Noise *noise_terrain_height;
        Noise *noise_valley_depth;
        Noise *noise_valley_profile;
 
-       content_t c_cobble;
-       content_t c_desert_stone;
-       content_t c_dirt;
-       content_t c_ice;
-       content_t c_lava_source;
-       content_t c_mossycobble;
-       content_t c_river_water_source;
-       content_t c_sand;
-       content_t c_sandstone;
-       content_t c_sandstonebrick;
-       content_t c_stair_cobble;
-       content_t c_stair_sandstonebrick;
-       content_t c_stone;
-       content_t c_water_source;
-
        float terrainLevelAtPoint(s16 x, s16 z);
 
        void calculateNoise();
@@ -161,22 +131,7 @@ private:
        float terrainLevelFromNoise(TerrainNoise *tn);
        float adjustedTerrainLevelFromNoise(TerrainNoise *tn);
 
-       MgStoneType generateBiomes();
-       void dustTopNodes();
-
-       void generateCaves(s16 max_stone_y);
-};
-
-struct MapgenFactoryValleys : public MapgenFactory {
-       Mapgen *createMapgen(int mgid, MapgenParams *params, EmergeManager *emerge)
-       {
-               return new MapgenValleys(mgid, params, emerge);
-       };
-
-       MapgenSpecificParams *createMapgenParams()
-       {
-               return new MapgenValleysParams();
-       };
+       virtual void generateCaves(s16 max_stone_y, s16 large_cave_depth);
 };
 
 #endif