Cleanup in content_mapblock (#5746)
[oweals/minetest.git] / src / mapgen_v5.cpp
index 0c063dc6f9f6eaa5f3a286543f3c24e1011b6740..1c4d1fd70ac3ab761d9e67344a9a47e8eaa243f7 100644 (file)
@@ -33,7 +33,6 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "emerge.h"
 #include "dungeongen.h"
 #include "cavegen.h"
-#include "treegen.h"
 #include "mg_biome.h"
 #include "mg_ore.h"
 #include "mg_decoration.h"
@@ -41,68 +40,32 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 
 
 FlagDesc flagdesc_mapgen_v5[] = {
-       {NULL,         0}
+       {"caverns", MGV5_CAVERNS},
+       {NULL,      0}
 };
 
 
-MapgenV5::MapgenV5(int mapgenid, MapgenParams *params, EmergeManager *emerge)
+MapgenV5::MapgenV5(int mapgenid, MapgenV5Params *params, EmergeManager *emerge)
        : MapgenBasic(mapgenid, params, emerge)
 {
-       this->m_emerge = emerge;
-       this->bmgr     = emerge->biomemgr;
-
-       // amount of elements to skip for the next index
-       // for noise/height/biome maps (not vmanip)
-       this->ystride = csize.X;
-
-       this->heightmap = new s16[csize.X * csize.Z];
-
-       MapgenV5Params *sp = (MapgenV5Params *)params->sparams;
-
-       this->spflags    = sp->spflags;
-       this->cave_width = sp->cave_width;
+       this->spflags          = params->spflags;
+       this->cave_width       = params->cave_width;
+       this->cavern_limit     = params->cavern_limit;
+       this->cavern_taper     = params->cavern_taper;
+       this->cavern_threshold = params->cavern_threshold;
 
        // Terrain noise
-       noise_filler_depth = new Noise(&sp->np_filler_depth, seed, csize.X, csize.Z);
-       noise_factor       = new Noise(&sp->np_factor,       seed, csize.X, csize.Z);
-       noise_height       = new Noise(&sp->np_height,       seed, csize.X, csize.Z);
+       noise_filler_depth = new Noise(&params->np_filler_depth, seed, csize.X, csize.Z);
+       noise_factor       = new Noise(&params->np_factor,       seed, csize.X, csize.Z);
+       noise_height       = new Noise(&params->np_height,       seed, csize.X, csize.Z);
 
        // 3D terrain noise
        // 1-up 1-down overgeneration
-       noise_ground = new Noise(&sp->np_ground, seed, csize.X, csize.Y + 2, csize.Z);
-
-       MapgenBasic::np_cave1 = sp->np_cave1;
-       MapgenBasic::np_cave2 = sp->np_cave2;
-
-       //// Initialize biome generator
-       biomegen = emerge->biomemgr->createBiomeGen(
-               BIOMEGEN_ORIGINAL, params->bparams, csize);
-       biomemap = biomegen->biomemap;
-
-       //// Resolve nodes to be used
-       c_stone                = ndef->getId("mapgen_stone");
-       c_water_source         = ndef->getId("mapgen_water_source");
-       c_lava_source          = ndef->getId("mapgen_lava_source");
-       c_desert_stone         = ndef->getId("mapgen_desert_stone");
-       c_ice                  = ndef->getId("mapgen_ice");
-       c_sandstone            = ndef->getId("mapgen_sandstone");
-
-       c_cobble               = ndef->getId("mapgen_cobble");
-       c_stair_cobble         = ndef->getId("mapgen_stair_cobble");
-       c_mossycobble          = ndef->getId("mapgen_mossycobble");
-       c_sandstonebrick       = ndef->getId("mapgen_sandstonebrick");
-       c_stair_sandstonebrick = ndef->getId("mapgen_stair_sandstonebrick");
-
-       if (c_ice == CONTENT_IGNORE)
-               c_ice = CONTENT_AIR;
-       if (c_mossycobble == CONTENT_IGNORE)
-               c_mossycobble = c_cobble;
-       if (c_stair_cobble == CONTENT_IGNORE)
-               c_stair_cobble = c_cobble;
-       if (c_sandstonebrick == CONTENT_IGNORE)
-               c_sandstonebrick = c_sandstone;
-       if (c_stair_sandstonebrick == CONTENT_IGNORE)
-               c_stair_sandstonebrick = c_sandstone;
+       noise_ground = new Noise(&params->np_ground, seed, csize.X, csize.Y + 2, csize.Z);
+       // 1 down overgeneration
+       MapgenBasic::np_cave1  = params->np_cave1;
+       MapgenBasic::np_cave2  = params->np_cave2;
+       MapgenBasic::np_cavern = params->np_cavern;
 }
 
 
@@ -112,56 +75,60 @@ MapgenV5::~MapgenV5()
        delete noise_factor;
        delete noise_height;
        delete noise_ground;
-
-       delete biomegen;
-
-       delete[] heightmap;
 }
 
 
 MapgenV5Params::MapgenV5Params()
 {
-       spflags    = 0;
-       cave_width = 0.125;
+       spflags          = MGV5_CAVERNS;
+       cave_width       = 0.125;
+       cavern_limit     = -256;
+       cavern_taper     = 256;
+       cavern_threshold = 0.7;
 
        np_filler_depth = NoiseParams(0, 1,  v3f(150, 150, 150), 261,    4, 0.7,  2.0);
        np_factor       = NoiseParams(0, 1,  v3f(250, 250, 250), 920381, 3, 0.45, 2.0);
        np_height       = NoiseParams(0, 10, v3f(250, 250, 250), 84174,  4, 0.5,  2.0);
+       np_ground       = NoiseParams(0, 40, v3f(80,  80,  80),  983240, 4, 0.55, 2.0, NOISE_FLAG_EASED);
        np_cave1        = NoiseParams(0, 12, v3f(50,  50,  50),  52534,  4, 0.5,  2.0);
        np_cave2        = NoiseParams(0, 12, v3f(50,  50,  50),  10325,  4, 0.5,  2.0);
-       np_ground       = NoiseParams(0, 40, v3f(80,  80,  80),  983240, 4, 0.55, 2.0, NOISE_FLAG_EASED);
+       np_cavern       = NoiseParams(0, 1,  v3f(384, 128, 384), 723,    5, 0.63, 2.0);
 }
 
 
-//#define CAVE_NOISE_SCALE 12.0
-//#define CAVE_NOISE_THRESHOLD (1.5/CAVE_NOISE_SCALE) = 0.125
-
-
 void MapgenV5Params::readParams(const Settings *settings)
 {
-       settings->getFlagStrNoEx("mgv5_spflags",  spflags, flagdesc_mapgen_v5);
-       settings->getFloatNoEx("mgv5_cave_width", cave_width);
+       settings->getFlagStrNoEx("mgv5_spflags",        spflags, flagdesc_mapgen_v5);
+       settings->getFloatNoEx("mgv5_cave_width",       cave_width);
+       settings->getS16NoEx("mgv5_cavern_limit",       cavern_limit);
+       settings->getS16NoEx("mgv5_cavern_taper",       cavern_taper);
+       settings->getFloatNoEx("mgv5_cavern_threshold", cavern_threshold);
 
        settings->getNoiseParams("mgv5_np_filler_depth", np_filler_depth);
        settings->getNoiseParams("mgv5_np_factor",       np_factor);
        settings->getNoiseParams("mgv5_np_height",       np_height);
+       settings->getNoiseParams("mgv5_np_ground",       np_ground);
        settings->getNoiseParams("mgv5_np_cave1",        np_cave1);
        settings->getNoiseParams("mgv5_np_cave2",        np_cave2);
-       settings->getNoiseParams("mgv5_np_ground",       np_ground);
+       settings->getNoiseParams("mgv5_np_cavern",       np_cavern);
 }
 
 
 void MapgenV5Params::writeParams(Settings *settings) const
 {
-       settings->setFlagStr("mgv5_spflags",  spflags, flagdesc_mapgen_v5, U32_MAX);
-       settings->setFloat("mgv5_cave_width", cave_width);
+       settings->setFlagStr("mgv5_spflags",        spflags, flagdesc_mapgen_v5, U32_MAX);
+       settings->setFloat("mgv5_cave_width",       cave_width);
+       settings->setS16("mgv5_cavern_limit",       cavern_limit);
+       settings->setS16("mgv5_cavern_taper",       cavern_taper);
+       settings->setFloat("mgv5_cavern_threshold", cavern_threshold);
 
        settings->setNoiseParams("mgv5_np_filler_depth", np_filler_depth);
        settings->setNoiseParams("mgv5_np_factor",       np_factor);
        settings->setNoiseParams("mgv5_np_height",       np_height);
+       settings->setNoiseParams("mgv5_np_ground",       np_ground);
        settings->setNoiseParams("mgv5_np_cave1",        np_cave1);
        settings->setNoiseParams("mgv5_np_cave2",        np_cave2);
-       settings->setNoiseParams("mgv5_np_ground",       np_ground);
+       settings->setNoiseParams("mgv5_np_cavern",       np_cavern);
 }
 
 
@@ -225,9 +192,6 @@ void MapgenV5::makeChunk(BlockMakeData *data)
        // Create a block-specific seed
        blockseed = getBlockSeed2(full_node_min, seed);
 
-       // Make some noise
-       calculateNoise();
-
        // Generate base terrain
        s16 stone_surface_max_y = generateBaseTerrain();
 
@@ -236,56 +200,27 @@ void MapgenV5::makeChunk(BlockMakeData *data)
 
        // Init biome generator, place biome-specific nodes, and build biomemap
        biomegen->calcBiomeNoise(node_min);
-       biomegen->getBiomes(heightmap);
        MgStoneType stone_type = generateBiomes();
 
-       // Generate caves
-       if ((flags & MG_CAVES) && (stone_surface_max_y >= node_min.Y))
-               generateCaves(stone_surface_max_y, MGV5_LARGE_CAVE_DEPTH);
+       // Generate caverns, tunnels and classic caves
+       if (flags & MG_CAVES) {
+               bool near_cavern = false;
+               // Generate caverns
+               if (spflags & MGV5_CAVERNS)
+                       near_cavern = generateCaverns(stone_surface_max_y);
+               // Generate tunnels and classic caves
+               if (near_cavern)
+                       // Disable classic caves in this mapchunk by setting
+                       // 'large cave depth' to world base. Avoids excessive liquid in
+                       // large caverns and floating blobs of overgenerated liquid.
+                       generateCaves(stone_surface_max_y, -MAX_MAP_GENERATION_LIMIT);
+               else
+                       generateCaves(stone_surface_max_y, MGV5_LARGE_CAVE_DEPTH);
+       }
 
        // Generate dungeons and desert temples
-       if ((flags & MG_DUNGEONS) && (stone_surface_max_y >= node_min.Y)) {
-               DungeonParams dp;
-
-               dp.np_rarity  = nparams_dungeon_rarity;
-               dp.np_density = nparams_dungeon_density;
-               dp.np_wetness = nparams_dungeon_wetness;
-               dp.c_water    = c_water_source;
-               if (stone_type == MGSTONE_STONE) {
-                       dp.c_cobble = c_cobble;
-                       dp.c_moss   = c_mossycobble;
-                       dp.c_stair  = c_stair_cobble;
-
-                       dp.diagonal_dirs = false;
-                       dp.mossratio     = 3.0;
-                       dp.holesize      = v3s16(1, 2, 1);
-                       dp.roomsize      = v3s16(0, 0, 0);
-                       dp.notifytype    = GENNOTIFY_DUNGEON;
-               } else if (stone_type == MGSTONE_DESERT_STONE) {
-                       dp.c_cobble = c_desert_stone;
-                       dp.c_moss   = c_desert_stone;
-                       dp.c_stair  = c_desert_stone;
-
-                       dp.diagonal_dirs = true;
-                       dp.mossratio     = 0.0;
-                       dp.holesize      = v3s16(2, 3, 2);
-                       dp.roomsize      = v3s16(2, 5, 2);
-                       dp.notifytype    = GENNOTIFY_TEMPLE;
-               } else if (stone_type == MGSTONE_SANDSTONE) {
-                       dp.c_cobble = c_sandstonebrick;
-                       dp.c_moss   = c_sandstonebrick;
-                       dp.c_stair  = c_sandstonebrick;
-
-                       dp.diagonal_dirs = false;
-                       dp.mossratio     = 0.0;
-                       dp.holesize      = v3s16(2, 2, 2);
-                       dp.roomsize      = v3s16(2, 0, 2);
-                       dp.notifytype    = GENNOTIFY_DUNGEON;
-               }
-
-               DungeonGen dgen(this, &dp);
-               dgen.generate(blockseed, full_node_min, full_node_max);
-       }
+       if (flags & MG_DUNGEONS)
+               generateDungeons(stone_surface_max_y, stone_type);
 
        // Generate the registered decorations
        if (flags & MG_DECORATIONS)
@@ -312,49 +247,16 @@ void MapgenV5::makeChunk(BlockMakeData *data)
 }
 
 
-void MapgenV5::calculateNoise()
-{
-       //TimeTaker t("calculateNoise", NULL, PRECISION_MICRO);
-       s16 x = node_min.X;
-       s16 y = node_min.Y - 1;
-       s16 z = node_min.Z;
-
-       noise_factor->perlinMap2D(x, z);
-       noise_height->perlinMap2D(x, z);
-       noise_ground->perlinMap3D(x, y, z);
-
-       // Cave noises are calculated in generateCaves()
-       // only if solid terrain is present in mapchunk
-
-       noise_filler_depth->perlinMap2D(x, z);
-
-       //printf("calculateNoise: %dus\n", t.stop());
-}
-
-
-//bool is_cave(u32 index) {
-//     double d1 = contour(noise_cave1->result[index]);
-//     double d2 = contour(noise_cave2->result[index]);
-//     return d1*d2 > CAVE_NOISE_THRESHOLD;
-//}
-
-//bool val_is_ground(v3s16 p, u32 index, u32 index2d) {
-//     double f = 0.55 + noise_factor->result[index2d];
-//     if(f < 0.01)
-//             f = 0.01;
-//     else if(f >= 1.0)
-//             f *= 1.6;
-//     double h = WATER_LEVEL + 10 * noise_height->result[index2d];
-//     return (noise_ground->result[index] * f > (double)p.Y - h);
-//}
-
-
 int MapgenV5::generateBaseTerrain()
 {
        u32 index = 0;
        u32 index2d = 0;
        int stone_surface_max_y = -MAX_MAP_GENERATION_LIMIT;
 
+       noise_factor->perlinMap2D(node_min.X, node_min.Z);
+       noise_height->perlinMap2D(node_min.X, node_min.Z);
+       noise_ground->perlinMap3D(node_min.X, node_min.Y - 1, node_min.Z);
+
        for (s16 z=node_min.Z; z<=node_max.Z; z++) {
                for (s16 y=node_min.Y - 1; y<=node_max.Y + 1; y++) {
                        u32 vi = vm->m_area.index(node_min.X, y, z);