Revert "Plantlike: Fix visual_scale being applied squared (#5115)"
[oweals/minetest.git] / src / guiFormSpecMenu.cpp
index 084a53c9da5fdde0c74cd045fa9fee2d026b60be..67b3a9ad0d66c14ae97604f965ed82cabbbbd146 100644 (file)
@@ -81,13 +81,12 @@ static unsigned int font_line_height(gui::IGUIFont *font)
 GUIFormSpecMenu::GUIFormSpecMenu(irr::IrrlichtDevice* dev,
                JoystickController *joystick,
                gui::IGUIElement* parent, s32 id, IMenuManager *menumgr,
-               InventoryManager *invmgr, IGameDef *gamedef,
+               Client *client,
                ISimpleTextureSource *tsrc, IFormSource* fsrc, TextDest* tdst,
-               Client* client, bool remap_dbl_click) :
+               bool remap_dbl_click) :
        GUIModalMenu(dev->getGUIEnvironment(), parent, id, menumgr),
        m_device(dev),
-       m_invmgr(invmgr),
-       m_gamedef(gamedef),
+       m_invmgr(client),
        m_tsrc(tsrc),
        m_client(client),
        m_selected_item(NULL),
@@ -279,10 +278,36 @@ void GUIFormSpecMenu::parseSize(parserData* data,std::string element)
        errorstream<< "Invalid size element (" << parts.size() << "): '" << element << "'"  << std::endl;
 }
 
+void GUIFormSpecMenu::parseContainer(parserData* data, std::string element)
+{
+       std::vector<std::string> parts = split(element, ',');
+
+       if (parts.size() >= 2) {
+               if (parts[1].find(';') != std::string::npos)
+                       parts[1] = parts[1].substr(0, parts[1].find(';'));
+
+               container_stack.push(pos_offset);
+               pos_offset.X += MYMAX(0, stof(parts[0]));
+               pos_offset.Y += MYMAX(0, stof(parts[1]));
+               return;
+       }
+       errorstream<< "Invalid container start element (" << parts.size() << "): '" << element << "'"  << std::endl;
+}
+
+void GUIFormSpecMenu::parseContainerEnd(parserData* data)
+{
+       if (container_stack.empty()) {
+               errorstream<< "Invalid container end element, no matching container start element"  << std::endl;
+       } else {
+               pos_offset = container_stack.top();
+               container_stack.pop();
+       }
+}
+
 void GUIFormSpecMenu::parseList(parserData* data,std::string element)
 {
-       if (m_gamedef == 0) {
-               warningstream<<"invalid use of 'list' with m_gamedef==0"<<std::endl;
+       if (m_client == 0) {
+               warningstream<<"invalid use of 'list' with m_client==0"<<std::endl;
                return;
        }
 
@@ -309,7 +334,7 @@ void GUIFormSpecMenu::parseList(parserData* data,std::string element)
                else
                        loc.deSerialize(location);
 
-               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner;
+               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y;
 
@@ -336,8 +361,8 @@ void GUIFormSpecMenu::parseList(parserData* data,std::string element)
 
 void GUIFormSpecMenu::parseListRing(parserData* data, std::string element)
 {
-       if (m_gamedef == 0) {
-               errorstream << "WARNING: invalid use of 'listring' with m_gamedef==0" << std::endl;
+       if (m_client == 0) {
+               errorstream << "WARNING: invalid use of 'listring' with m_client==0" << std::endl;
                return;
        }
 
@@ -386,7 +411,7 @@ void GUIFormSpecMenu::parseCheckbox(parserData* data,std::string element)
 
                MY_CHECKPOS("checkbox",0);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float) spacing.X;
                pos.Y += stof(v_pos[1]) * (float) spacing.Y;
 
@@ -437,7 +462,7 @@ void GUIFormSpecMenu::parseScrollBar(parserData* data, std::string element)
 
                MY_CHECKPOS("scrollbar",0);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float) spacing.X;
                pos.Y += stof(v_pos[1]) * (float) spacing.Y;
 
@@ -495,10 +520,10 @@ void GUIFormSpecMenu::parseImage(parserData* data,std::string element)
                std::vector<std::string> v_geom = split(parts[1],',');
                std::string name = unescape_string(parts[2]);
 
-               MY_CHECKPOS("image",0);
-               MY_CHECKGEOM("image",1);
+               MY_CHECKPOS("image", 0);
+               MY_CHECKGEOM("image", 1);
 
-               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner;
+               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float) spacing.X;
                pos.Y += stof(v_pos[1]) * (float) spacing.Y;
 
@@ -506,23 +531,21 @@ void GUIFormSpecMenu::parseImage(parserData* data,std::string element)
                geom.X = stof(v_geom[0]) * (float)imgsize.X;
                geom.Y = stof(v_geom[1]) * (float)imgsize.Y;
 
-               if(!data->explicit_size)
+               if (!data->explicit_size)
                        warningstream<<"invalid use of image without a size[] element"<<std::endl;
                m_images.push_back(ImageDrawSpec(name, pos, geom));
                return;
-       }
-
-       if (parts.size() == 2) {
+       } else if (parts.size() == 2) {
                std::vector<std::string> v_pos = split(parts[0],',');
                std::string name = unescape_string(parts[1]);
 
-               MY_CHECKPOS("image",0);
+               MY_CHECKPOS("image", 0);
 
-               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner;
+               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float) spacing.X;
                pos.Y += stof(v_pos[1]) * (float) spacing.Y;
 
-               if(!data->explicit_size)
+               if (!data->explicit_size)
                        warningstream<<"invalid use of image without a size[] element"<<std::endl;
                m_images.push_back(ImageDrawSpec(name, pos));
                return;
@@ -544,7 +567,7 @@ void GUIFormSpecMenu::parseItemImage(parserData* data,std::string element)
                MY_CHECKPOS("itemimage",0);
                MY_CHECKGEOM("itemimage",1);
 
-               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner;
+               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float) spacing.X;
                pos.Y += stof(v_pos[1]) * (float) spacing.Y;
 
@@ -576,7 +599,7 @@ void GUIFormSpecMenu::parseButton(parserData* data,std::string element,
                MY_CHECKPOS("button",0);
                MY_CHECKGEOM("button",1);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y;
 
@@ -629,9 +652,9 @@ void GUIFormSpecMenu::parseBackground(parserData* data,std::string element)
                MY_CHECKPOS("background",0);
                MY_CHECKGEOM("background",1);
 
-               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner;
-               pos.X += stof(v_pos[0]) * (float)spacing.X - ((float)spacing.X-(float)imgsize.X)/2;
-               pos.Y += stof(v_pos[1]) * (float)spacing.Y - ((float)spacing.Y-(float)imgsize.Y)/2;
+               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner + pos_offset * spacing;
+               pos.X += stof(v_pos[0]) * (float)spacing.X - ((float)spacing.X - (float)imgsize.X)/2;
+               pos.Y += stof(v_pos[1]) * (float)spacing.Y - ((float)spacing.Y - (float)imgsize.Y)/2;
 
                v2s32 geom;
                geom.X = stof(v_geom[0]) * (float)spacing.X;
@@ -705,7 +728,7 @@ void GUIFormSpecMenu::parseTable(parserData* data,std::string element)
                MY_CHECKPOS("table",0);
                MY_CHECKGEOM("table",1);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y;
 
@@ -776,7 +799,7 @@ void GUIFormSpecMenu::parseTextList(parserData* data,std::string element)
                MY_CHECKPOS("textlist",0);
                MY_CHECKGEOM("textlist",1);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y;
 
@@ -841,7 +864,7 @@ void GUIFormSpecMenu::parseDropDown(parserData* data,std::string element)
 
                MY_CHECKPOS("dropdown",0);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y;
 
@@ -890,6 +913,16 @@ void GUIFormSpecMenu::parseDropDown(parserData* data,std::string element)
                                << element << "'"  << std::endl;
 }
 
+void GUIFormSpecMenu::parseFieldCloseOnEnter(parserData *data,
+               const std::string &element)
+{
+       std::vector<std::string> parts = split(element,';');
+       if (parts.size() == 2 ||
+                       (parts.size() > 2 && m_formspec_version > FORMSPEC_API_VERSION)) {
+               field_close_on_enter[parts[0]] = is_yes(parts[1]);
+       }
+}
+
 void GUIFormSpecMenu::parsePwdField(parserData* data,std::string element)
 {
        std::vector<std::string> parts = split(element,';');
@@ -905,7 +938,7 @@ void GUIFormSpecMenu::parsePwdField(parserData* data,std::string element)
                MY_CHECKPOS("pwdfield",0);
                MY_CHECKGEOM("pwdfield",1);
 
-               v2s32 pos;
+               v2s32 pos = pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y;
 
@@ -953,8 +986,11 @@ void GUIFormSpecMenu::parsePwdField(parserData* data,std::string element)
                evt.KeyInput.PressedDown = true;
                e->OnEvent(evt);
 
-               if (parts.size() >= 5 && !is_yes(parts[4])) {
-                       spec.close_on_enter = false;
+               if (parts.size() >= 5) {
+                       // TODO: remove after 2016-11-03
+                       warningstream << "pwdfield: use field_close_on_enter[name, enabled]" <<
+                                       " instead of the 5th param" << std::endl;
+                       field_close_on_enter[name] = is_yes(parts[4]);
                }
 
                m_fields.push_back(spec);
@@ -975,7 +1011,7 @@ void GUIFormSpecMenu::parseSimpleField(parserData* data,
        if(data->explicit_size)
                warningstream<<"invalid use of unpositioned \"field\" in inventory"<<std::endl;
 
-       v2s32 pos = padding + AbsoluteRect.UpperLeftCorner;
+       v2s32 pos = padding + AbsoluteRect.UpperLeftCorner + pos_offset * spacing;
        pos.Y = ((m_fields.size()+2)*60);
        v2s32 size = DesiredRect.getSize();
 
@@ -1038,8 +1074,11 @@ void GUIFormSpecMenu::parseSimpleField(parserData* data,
                }
        }
 
-       if (parts.size() >= 4 && !is_yes(parts[3])) {
-               spec.close_on_enter = false;
+       if (parts.size() >= 4) {
+               // TODO: remove after 2016-11-03
+               warningstream << "field/simple: use field_close_on_enter[name, enabled]" <<
+                               " instead of the 4th param" << std::endl;
+               field_close_on_enter[name] = is_yes(parts[3]);
        }
 
        m_fields.push_back(spec);
@@ -1058,9 +1097,9 @@ void GUIFormSpecMenu::parseTextArea(parserData* data,
        MY_CHECKPOS(type,0);
        MY_CHECKGEOM(type,1);
 
-       v2s32 pos;
-       pos.X = stof(v_pos[0]) * (float) spacing.X;
-       pos.Y = stof(v_pos[1]) * (float) spacing.Y;
+       v2s32 pos = pos_offset * spacing;
+       pos.X += stof(v_pos[0]) * (float) spacing.X;
+       pos.Y += stof(v_pos[1]) * (float) spacing.Y;
 
        v2s32 geom;
 
@@ -1147,8 +1186,11 @@ void GUIFormSpecMenu::parseTextArea(parserData* data,
                }
        }
 
-       if (parts.size() >= 6 && !is_yes(parts[5])) {
-               spec.close_on_enter = false;
+       if (parts.size() >= 6) {
+               // TODO: remove after 2016-11-03
+               warningstream << "field/textarea: use field_close_on_enter[name, enabled]" <<
+                               " instead of the 6th param" << std::endl;
+               field_close_on_enter[name] = is_yes(parts[5]);
        }
 
        m_fields.push_back(spec);
@@ -1185,7 +1227,7 @@ void GUIFormSpecMenu::parseLabel(parserData* data,std::string element)
 
                MY_CHECKPOS("label",0);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += (stof(v_pos[1]) + 7.0/30.0) * (float)spacing.Y;
 
@@ -1242,7 +1284,7 @@ void GUIFormSpecMenu::parseVertLabel(parserData* data,std::string element)
 
                MY_CHECKPOS("vertlabel",1);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y;
 
@@ -1296,7 +1338,7 @@ void GUIFormSpecMenu::parseImageButton(parserData* data,std::string element,
                MY_CHECKPOS("imagebutton",0);
                MY_CHECKGEOM("imagebutton",1);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y;
                v2s32 geom;
@@ -1401,7 +1443,7 @@ void GUIFormSpecMenu::parseTabHeader(parserData* data,std::string element)
 
                spec.ftype = f_TabHeader;
 
-               v2s32 pos(0,0);
+               v2s32 pos = pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y - m_btn_height * 2;
                v2s32 geom;
@@ -1443,8 +1485,8 @@ void GUIFormSpecMenu::parseTabHeader(parserData* data,std::string element)
 void GUIFormSpecMenu::parseItemImageButton(parserData* data,std::string element)
 {
 
-       if (m_gamedef == 0) {
-               warningstream << "invalid use of item_image_button with m_gamedef==0"
+       if (m_client == 0) {
+               warningstream << "invalid use of item_image_button with m_client==0"
                        << std::endl;
                return;
        }
@@ -1466,7 +1508,7 @@ void GUIFormSpecMenu::parseItemImageButton(parserData* data,std::string element)
                MY_CHECKPOS("itemimagebutton",0);
                MY_CHECKGEOM("itemimagebutton",1);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y;
                v2s32 geom;
@@ -1478,7 +1520,7 @@ void GUIFormSpecMenu::parseItemImageButton(parserData* data,std::string element)
                if(!data->explicit_size)
                        warningstream<<"invalid use of item_image_button without a size[] element"<<std::endl;
 
-               IItemDefManager *idef = m_gamedef->idef();
+               IItemDefManager *idef = m_client->idef();
                ItemStack item;
                item.deSerialize(item_name, idef);
 
@@ -1504,7 +1546,7 @@ void GUIFormSpecMenu::parseItemImageButton(parserData* data,std::string element)
                rect+=data->basepos-padding;
                spec.rect=rect;
                m_fields.push_back(spec);
-               pos = padding + AbsoluteRect.UpperLeftCorner;
+               pos = padding + AbsoluteRect.UpperLeftCorner + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float) spacing.X;
                pos.Y += stof(v_pos[1]) * (float) spacing.Y;
                m_itemimages.push_back(ImageDrawSpec("", item_name, e, pos, geom));
@@ -1527,7 +1569,7 @@ void GUIFormSpecMenu::parseBox(parserData* data,std::string element)
                MY_CHECKPOS("box",0);
                MY_CHECKGEOM("box",1);
 
-               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner;
+               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float) spacing.X;
                pos.Y += stof(v_pos[1]) * (float) spacing.Y;
 
@@ -1689,8 +1731,18 @@ void GUIFormSpecMenu::parseElement(parserData* data, std::string element)
        std::string type = trim(parts[0]);
        std::string description = trim(parts[1]);
 
+       if (type == "container") {
+               parseContainer(data, description);
+               return;
+       }
+
+       if (type == "container_end") {
+               parseContainerEnd(data);
+               return;
+       }
+
        if (type == "list") {
-               parseList(data,description);
+               parseList(data, description);
                return;
        }
 
@@ -1700,22 +1752,22 @@ void GUIFormSpecMenu::parseElement(parserData* data, std::string element)
        }
 
        if (type == "checkbox") {
-               parseCheckbox(data,description);
+               parseCheckbox(data, description);
                return;
        }
 
        if (type == "image") {
-               parseImage(data,description);
+               parseImage(data, description);
                return;
        }
 
        if (type == "item_image") {
-               parseItemImage(data,description);
+               parseItemImage(data, description);
                return;
        }
 
-       if ((type == "button") || (type == "button_exit")) {
-               parseButton(data,description,type);
+       if (type == "button" || type == "button_exit") {
+               parseButton(data, description, type);
                return;
        }
 
@@ -1749,6 +1801,11 @@ void GUIFormSpecMenu::parseElement(parserData* data, std::string element)
                return;
        }
 
+       if (type == "field_close_on_enter") {
+               parseFieldCloseOnEnter(data, description);
+               return;
+       }
+
        if (type == "pwdfield") {
                parsePwdField(data,description);
                return;
@@ -2036,10 +2093,16 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
        gui::IGUIFont *old_font = skin->getFont();
        skin->setFont(m_font);
 
+       pos_offset = v2s32();
        for (; i< elements.size(); i++) {
                parseElement(&mydata, elements[i]);
        }
 
+       if (!container_stack.empty()) {
+               errorstream << "Invalid formspec string: container was never closed!"
+                       << std::endl;
+       }
+
        // If there are fields without explicit size[], add a "Proceed"
        // button and adjust size to fit all the fields.
        if (m_fields.size() && !mydata.explicit_size) {
@@ -2233,14 +2296,19 @@ void GUIFormSpecMenu::drawList(const ListDrawSpec &s, int phase,
                        if(!item.empty())
                        {
                                drawItemStack(driver, m_font, item,
-                                       rect, &AbsoluteClippingRect, m_gamedef,
+                                       rect, &AbsoluteClippingRect, m_client,
                                        rotation_kind);
                        }
 
                        // Draw tooltip
                        std::wstring tooltip_text = L"";
                        if (hovering && !m_selected_item) {
-                               tooltip_text = utf8_to_wide(item.getDefinition(m_gamedef->idef()).description);
+                               const std::string &desc = item.metadata.getString("description");
+                               if (desc.empty())
+                                       tooltip_text =
+                                               utf8_to_wide(item.getDefinition(m_client->idef()).description);
+                               else
+                                       tooltip_text = utf8_to_wide(desc);
                        }
                        if (tooltip_text != L"") {
                                std::vector<std::wstring> tt_rows = str_split(tooltip_text, L'\n');
@@ -2250,7 +2318,7 @@ void GUIFormSpecMenu::drawList(const ListDrawSpec &s, int phase,
                                this->bringToFront(m_tooltip_element);
                                setStaticText(m_tooltip_element, tooltip_text.c_str());
                                s32 tooltip_width = m_tooltip_element->getTextWidth() + m_btn_height;
-#if IRRLICHT_VERSION_MAJOR <= 1 && IRRLICHT_VERSION_MINOR <= 8 && IRRLICHT_VERSION_REVISION < 2
+#if (IRRLICHT_VERSION_MAJOR <= 1 && IRRLICHT_VERSION_MINOR <= 8 && IRRLICHT_VERSION_REVISION < 2) || USE_FREETYPE == 1
                                s32 tooltip_height = m_tooltip_element->getTextHeight() * tt_rows.size() + 5;
 #else
                                s32 tooltip_height = m_tooltip_element->getTextHeight() + 5;
@@ -2285,7 +2353,7 @@ void GUIFormSpecMenu::drawSelectedItem()
        if (!m_selected_item) {
                drawItemStack(driver, m_font, ItemStack(),
                        core::rect<s32>(v2s32(0, 0), v2s32(0, 0)),
-                       NULL, m_gamedef, IT_ROT_DRAGGED);
+                       NULL, m_client, IT_ROT_DRAGGED);
                return;
        }
 
@@ -2298,7 +2366,8 @@ void GUIFormSpecMenu::drawSelectedItem()
 
        core::rect<s32> imgrect(0,0,imgsize.X,imgsize.Y);
        core::rect<s32> rect = imgrect + (m_pointer - imgrect.getCenter());
-       drawItemStack(driver, m_font, stack, rect, NULL, m_gamedef, IT_ROT_DRAGGED);
+       rect.constrainTo(driver->getViewPort());
+       drawItemStack(driver, m_font, stack, rect, NULL, m_client, IT_ROT_DRAGGED);
 }
 
 void GUIFormSpecMenu::drawMenu()
@@ -2423,11 +2492,11 @@ void GUIFormSpecMenu::drawMenu()
        */
        for(u32 i=0; i<m_itemimages.size(); i++)
        {
-               if (m_gamedef == 0)
+               if (m_client == 0)
                        break;
 
                const ImageDrawSpec &spec = m_itemimages[i];
-               IItemDefManager *idef = m_gamedef->idef();
+               IItemDefManager *idef = m_client->idef();
                ItemStack item;
                item.deSerialize(spec.item_name, idef);
                core::rect<s32> imgrect(0, 0, spec.geom.X, spec.geom.Y);
@@ -2444,7 +2513,7 @@ void GUIFormSpecMenu::drawMenu()
 #endif
                }
                drawItemStack(driver, m_font, item, rect, &AbsoluteClippingRect,
-                               m_gamedef, IT_ROT_NONE);
+                               m_client, IT_ROT_NONE);
        }
 
        /*
@@ -2462,7 +2531,7 @@ void GUIFormSpecMenu::drawMenu()
        if (!item_hovered) {
                drawItemStack(driver, m_font, ItemStack(),
                        core::rect<s32>(v2s32(0, 0), v2s32(0, 0)),
-                       NULL, m_gamedef, IT_ROT_HOVERED);
+                       NULL, m_client, IT_ROT_HOVERED);
        }
 
 /* TODO find way to show tooltips on touchscreen */
@@ -3405,7 +3474,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
 
                        // Check how many items can be moved
                        move_amount = stack_from.count = MYMIN(move_amount, stack_from.count);
-                       ItemStack leftover = stack_to.addItem(stack_from, m_gamedef->idef());
+                       ItemStack leftover = stack_to.addItem(stack_from, m_client->idef());
                        // If source stack cannot be added to destination stack at all,
                        // they are swapped
                        if ((leftover.count == stack_from.count) &&
@@ -3649,7 +3718,11 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                        if (s.ftype == f_Unknown &&
                                                        s.fid == event.GUIEvent.Caller->getID()) {
                                                current_field_enter_pending = s.fname;
-                                               close_on_enter = s.close_on_enter;
+                                               UNORDERED_MAP<std::string, bool>::const_iterator it =
+                                                       field_close_on_enter.find(s.fname);
+                                               if (it != field_close_on_enter.end())
+                                                       close_on_enter = (*it).second;
+
                                                break;
                                        }
                                }