Clang format: only show errors on non whitelisted files
[oweals/minetest.git] / src / guiFormSpecMenu.cpp
index 581da894b4cb412e2c3e7328be4fb26115c849d5..330124fe1aebf7441a9c6531fa7e2b6de27c1f9e 100644 (file)
@@ -28,7 +28,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "constants.h"
 #include "gamedef.h"
 #include "keycode.h"
-#include "strfnd.h"
+#include "util/strfnd.h"
 #include <IGUICheckBox.h>
 #include <IGUIEditBox.h>
 #include <IGUIButton.h>
@@ -42,15 +42,20 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "filesys.h"
 #include "gettime.h"
 #include "gettext.h"
-#include "scripting_game.h"
+#include "serverscripting.h"
 #include "porting.h"
-#include "main.h"
 #include "settings.h"
 #include "client.h"
 #include "fontengine.h"
 #include "util/hex.h"
 #include "util/numeric.h"
 #include "util/string.h" // for parseColorString()
+#include "irrlicht_changes/static_text.h"
+#include "guiscalingfilter.h"
+
+#if USE_FREETYPE && IRRLICHT_VERSION_MAJOR == 1 && IRRLICHT_VERSION_MINOR < 9
+#include "intlGUIEditBox.h"
+#endif
 
 #define MY_CHECKPOS(a,b)                                                                                                       \
        if (v_pos.size() != 2) {                                                                                                \
@@ -74,14 +79,14 @@ static unsigned int font_line_height(gui::IGUIFont *font)
 }
 
 GUIFormSpecMenu::GUIFormSpecMenu(irr::IrrlichtDevice* dev,
+               JoystickController *joystick,
                gui::IGUIElement* parent, s32 id, IMenuManager *menumgr,
-               InventoryManager *invmgr, IGameDef *gamedef,
+               Client *client,
                ISimpleTextureSource *tsrc, IFormSource* fsrc, TextDest* tdst,
-               Client* client) :
+               bool remap_dbl_click) :
        GUIModalMenu(dev->getGUIEnvironment(), parent, id, menumgr),
        m_device(dev),
-       m_invmgr(invmgr),
-       m_gamedef(gamedef),
+       m_invmgr(client),
        m_tsrc(tsrc),
        m_client(client),
        m_selected_item(NULL),
@@ -96,10 +101,13 @@ GUIFormSpecMenu::GUIFormSpecMenu(irr::IrrlichtDevice* dev,
        m_form_src(fsrc),
        m_text_dst(tdst),
        m_formspec_version(0),
-       m_focused_element(L""),
-       m_font(NULL)
+       m_focused_element(""),
+       m_joystick(joystick),
+       current_field_enter_pending(""),
+       m_font(NULL),
+       m_remap_dbl_click(remap_dbl_click)
 #ifdef __ANDROID__
-       ,m_JavaDialogFieldName(L"")
+       , m_JavaDialogFieldName("")
 #endif
 {
        current_keys_pending.key_down = false;
@@ -226,7 +234,7 @@ void GUIFormSpecMenu::setInitialFocus()
                Environment->setFocus(*(children.begin()));
 }
 
-GUITable* GUIFormSpecMenu::getTable(std::wstring tablename)
+GUITable* GUIFormSpecMenu::getTable(const std::string &tablename)
 {
        for (u32 i = 0; i < m_tables.size(); ++i) {
                if (tablename == m_tables[i].first.fname)
@@ -235,36 +243,13 @@ GUITable* GUIFormSpecMenu::getTable(std::wstring tablename)
        return 0;
 }
 
-std::vector<std::string> split(const std::string &s, char delim) {
-       std::vector<std::string> tokens;
-
-       std::string current = "";
-       bool last_was_escape = false;
-       for(unsigned int i=0; i < s.size(); i++) {
-               if (last_was_escape) {
-                       current += '\\';
-                       current += s.c_str()[i];
-                       last_was_escape = false;
-               }
-               else {
-                       if (s.c_str()[i] == delim) {
-                               tokens.push_back(current);
-                               current = "";
-                               last_was_escape = false;
-                       }
-                       else if (s.c_str()[i] == '\\'){
-                               last_was_escape = true;
-                       }
-                       else {
-                               current += s.c_str()[i];
-                               last_was_escape = false;
-                       }
-               }
+std::vector<std::string>* GUIFormSpecMenu::getDropDownValues(const std::string &name)
+{
+       for (u32 i = 0; i < m_dropdowns.size(); ++i) {
+               if (name == m_dropdowns[i].first.fname)
+                       return &m_dropdowns[i].second;
        }
-       //push last element
-       tokens.push_back(current);
-
-       return tokens;
+       return NULL;
 }
 
 void GUIFormSpecMenu::parseSize(parserData* data,std::string element)
@@ -293,10 +278,36 @@ void GUIFormSpecMenu::parseSize(parserData* data,std::string element)
        errorstream<< "Invalid size element (" << parts.size() << "): '" << element << "'"  << std::endl;
 }
 
+void GUIFormSpecMenu::parseContainer(parserData* data, std::string element)
+{
+       std::vector<std::string> parts = split(element, ',');
+
+       if (parts.size() >= 2) {
+               if (parts[1].find(';') != std::string::npos)
+                       parts[1] = parts[1].substr(0, parts[1].find(';'));
+
+               container_stack.push(pos_offset);
+               pos_offset.X += MYMAX(0, stof(parts[0]));
+               pos_offset.Y += MYMAX(0, stof(parts[1]));
+               return;
+       }
+       errorstream<< "Invalid container start element (" << parts.size() << "): '" << element << "'"  << std::endl;
+}
+
+void GUIFormSpecMenu::parseContainerEnd(parserData* data)
+{
+       if (container_stack.empty()) {
+               errorstream<< "Invalid container end element, no matching container start element"  << std::endl;
+       } else {
+               pos_offset = container_stack.top();
+               container_stack.pop();
+       }
+}
+
 void GUIFormSpecMenu::parseList(parserData* data,std::string element)
 {
-       if (m_gamedef == 0) {
-               errorstream<<"WARNING: invalid use of 'list' with m_gamedef==0"<<std::endl;
+       if (m_client == 0) {
+               warningstream<<"invalid use of 'list' with m_client==0"<<std::endl;
                return;
        }
 
@@ -323,7 +334,7 @@ void GUIFormSpecMenu::parseList(parserData* data,std::string element)
                else
                        loc.deSerialize(location);
 
-               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner;
+               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y;
 
@@ -341,13 +352,48 @@ void GUIFormSpecMenu::parseList(parserData* data,std::string element)
                }
 
                if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of list without a size[] element"<<std::endl;
+                       warningstream<<"invalid use of list without a size[] element"<<std::endl;
                m_inventorylists.push_back(ListDrawSpec(loc, listname, pos, geom, start_i));
                return;
        }
        errorstream<< "Invalid list element(" << parts.size() << "): '" << element << "'"  << std::endl;
 }
 
+void GUIFormSpecMenu::parseListRing(parserData* data, std::string element)
+{
+       if (m_client == 0) {
+               errorstream << "WARNING: invalid use of 'listring' with m_client==0" << std::endl;
+               return;
+       }
+
+       std::vector<std::string> parts = split(element, ';');
+
+       if (parts.size() == 2) {
+               std::string location = parts[0];
+               std::string listname = parts[1];
+
+               InventoryLocation loc;
+
+               if (location == "context" || location == "current_name")
+                       loc = m_current_inventory_location;
+               else
+                       loc.deSerialize(location);
+
+               m_inventory_rings.push_back(ListRingSpec(loc, listname));
+               return;
+       } else if ((element == "") && (m_inventorylists.size() > 1)) {
+               size_t siz = m_inventorylists.size();
+               // insert the last two inv list elements into the list ring
+               const ListDrawSpec &spa = m_inventorylists[siz - 2];
+               const ListDrawSpec &spb = m_inventorylists[siz - 1];
+               m_inventory_rings.push_back(ListRingSpec(spa.inventoryloc, spa.listname));
+               m_inventory_rings.push_back(ListRingSpec(spb.inventoryloc, spb.listname));
+               return;
+       }
+       errorstream<< "Invalid list ring element(" << parts.size() << ", "
+               << m_inventorylists.size() << "): '" << element << "'"  << std::endl;
+}
+
 void GUIFormSpecMenu::parseCheckbox(parserData* data,std::string element)
 {
        std::vector<std::string> parts = split(element,';');
@@ -365,7 +411,7 @@ void GUIFormSpecMenu::parseCheckbox(parserData* data,std::string element)
 
                MY_CHECKPOS("checkbox",0);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float) spacing.X;
                pos.Y += stof(v_pos[1]) * (float) spacing.Y;
 
@@ -374,7 +420,7 @@ void GUIFormSpecMenu::parseCheckbox(parserData* data,std::string element)
                if (selected == "true")
                        fselected = true;
 
-               std::wstring wlabel = narrow_to_wide(label);
+               std::wstring wlabel = utf8_to_wide(unescape_string(label));
 
                core::rect<s32> rect = core::rect<s32>(
                                pos.X, pos.Y + ((imgsize.Y/2) - m_btn_height),
@@ -382,7 +428,7 @@ void GUIFormSpecMenu::parseCheckbox(parserData* data,std::string element)
                                pos.Y + ((imgsize.Y/2) + m_btn_height));
 
                FieldSpec spec(
-                               narrow_to_wide(name),
+                               name,
                                wlabel, //Needed for displaying text on MSVC
                                wlabel,
                                258+m_fields.size()
@@ -411,12 +457,12 @@ void GUIFormSpecMenu::parseScrollBar(parserData* data, std::string element)
        if (parts.size() >= 5) {
                std::vector<std::string> v_pos = split(parts[0],',');
                std::vector<std::string> v_dim = split(parts[1],',');
-               std::string name = parts[2];
+               std::string name = parts[3];
                std::string value = parts[4];
 
                MY_CHECKPOS("scrollbar",0);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float) spacing.X;
                pos.Y += stof(v_pos[1]) * (float) spacing.Y;
 
@@ -434,7 +480,7 @@ void GUIFormSpecMenu::parseScrollBar(parserData* data, std::string element)
                                core::rect<s32>(pos.X, pos.Y, pos.X + dim.X, pos.Y + dim.Y);
 
                FieldSpec spec(
-                               narrow_to_wide(name),
+                               name,
                                L"",
                                L"",
                                258+m_fields.size()
@@ -474,10 +520,10 @@ void GUIFormSpecMenu::parseImage(parserData* data,std::string element)
                std::vector<std::string> v_geom = split(parts[1],',');
                std::string name = unescape_string(parts[2]);
 
-               MY_CHECKPOS("image",0);
-               MY_CHECKGEOM("image",1);
+               MY_CHECKPOS("image", 0);
+               MY_CHECKGEOM("image", 1);
 
-               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner;
+               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float) spacing.X;
                pos.Y += stof(v_pos[1]) * (float) spacing.Y;
 
@@ -485,24 +531,22 @@ void GUIFormSpecMenu::parseImage(parserData* data,std::string element)
                geom.X = stof(v_geom[0]) * (float)imgsize.X;
                geom.Y = stof(v_geom[1]) * (float)imgsize.Y;
 
-               if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of image without a size[] element"<<std::endl;
+               if (!data->explicit_size)
+                       warningstream<<"invalid use of image without a size[] element"<<std::endl;
                m_images.push_back(ImageDrawSpec(name, pos, geom));
                return;
-       }
-
-       if (parts.size() == 2) {
+       } else if (parts.size() == 2) {
                std::vector<std::string> v_pos = split(parts[0],',');
                std::string name = unescape_string(parts[1]);
 
-               MY_CHECKPOS("image",0);
+               MY_CHECKPOS("image", 0);
 
-               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner;
+               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float) spacing.X;
                pos.Y += stof(v_pos[1]) * (float) spacing.Y;
 
-               if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of image without a size[] element"<<std::endl;
+               if (!data->explicit_size)
+                       warningstream<<"invalid use of image without a size[] element"<<std::endl;
                m_images.push_back(ImageDrawSpec(name, pos));
                return;
        }
@@ -523,7 +567,7 @@ void GUIFormSpecMenu::parseItemImage(parserData* data,std::string element)
                MY_CHECKPOS("itemimage",0);
                MY_CHECKGEOM("itemimage",1);
 
-               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner;
+               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float) spacing.X;
                pos.Y += stof(v_pos[1]) * (float) spacing.Y;
 
@@ -532,8 +576,8 @@ void GUIFormSpecMenu::parseItemImage(parserData* data,std::string element)
                geom.Y = stof(v_geom[1]) * (float)imgsize.Y;
 
                if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of item_image without a size[] element"<<std::endl;
-               m_itemimages.push_back(ImageDrawSpec(name, pos, geom));
+                       warningstream<<"invalid use of item_image without a size[] element"<<std::endl;
+               m_itemimages.push_back(ImageDrawSpec("", name, pos, geom));
                return;
        }
        errorstream<< "Invalid ItemImage element(" << parts.size() << "): '" << element << "'"  << std::endl;
@@ -555,7 +599,7 @@ void GUIFormSpecMenu::parseButton(parserData* data,std::string element,
                MY_CHECKPOS("button",0);
                MY_CHECKGEOM("button",1);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y;
 
@@ -568,14 +612,12 @@ void GUIFormSpecMenu::parseButton(parserData* data,std::string element,
                                                pos.X + geom.X, pos.Y + m_btn_height);
 
                if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of button without a size[] element"<<std::endl;
-
-               label = unescape_string(label);
+                       warningstream<<"invalid use of button without a size[] element"<<std::endl;
 
-               std::wstring wlabel = narrow_to_wide(label);
+               std::wstring wlabel = utf8_to_wide(unescape_string(label));
 
                FieldSpec spec(
-                       narrow_to_wide(name),
+                       name,
                        wlabel,
                        L"",
                        258+m_fields.size()
@@ -610,25 +652,25 @@ void GUIFormSpecMenu::parseBackground(parserData* data,std::string element)
                MY_CHECKPOS("background",0);
                MY_CHECKGEOM("background",1);
 
-               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner;
-               pos.X += stof(v_pos[0]) * (float)spacing.X - ((float)spacing.X-(float)imgsize.X)/2;
-               pos.Y += stof(v_pos[1]) * (float)spacing.Y - ((float)spacing.Y-(float)imgsize.Y)/2;
+               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner + pos_offset * spacing;
+               pos.X += stof(v_pos[0]) * (float)spacing.X - ((float)spacing.X - (float)imgsize.X)/2;
+               pos.Y += stof(v_pos[1]) * (float)spacing.Y - ((float)spacing.Y - (float)imgsize.Y)/2;
 
                v2s32 geom;
                geom.X = stof(v_geom[0]) * (float)spacing.X;
                geom.Y = stof(v_geom[1]) * (float)spacing.Y;
 
-               if (parts.size() == 4) {
-                       m_clipbackground = is_yes(parts[3]);
-                       if (m_clipbackground) {
-                               pos.X = stoi(v_pos[0]); //acts as offset
-                               pos.Y = stoi(v_pos[1]); //acts as offset
-                       }
+               if (!data->explicit_size)
+                       warningstream<<"invalid use of background without a size[] element"<<std::endl;
+
+               bool clip = false;
+               if (parts.size() == 4 && is_yes(parts[3])) {
+                       pos.X = stoi(v_pos[0]); //acts as offset
+                       pos.Y = stoi(v_pos[1]); //acts as offset
+                       clip = true;
                }
+               m_backgrounds.push_back(ImageDrawSpec(name, pos, geom, clip));
 
-               if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of background without a size[] element"<<std::endl;
-               m_backgrounds.push_back(ImageDrawSpec(name, pos, geom));
                return;
        }
        errorstream<< "Invalid background element(" << parts.size() << "): '" << element << "'"  << std::endl;
@@ -686,7 +728,7 @@ void GUIFormSpecMenu::parseTable(parserData* data,std::string element)
                MY_CHECKPOS("table",0);
                MY_CHECKGEOM("table",1);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y;
 
@@ -694,13 +736,10 @@ void GUIFormSpecMenu::parseTable(parserData* data,std::string element)
                geom.X = stof(v_geom[0]) * (float)spacing.X;
                geom.Y = stof(v_geom[1]) * (float)spacing.Y;
 
-
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
-               std::wstring fname_w = narrow_to_wide(name);
-
                FieldSpec spec(
-                       fname_w,
+                       name,
                        L"",
                        L"",
                        258+m_fields.size()
@@ -709,7 +748,7 @@ void GUIFormSpecMenu::parseTable(parserData* data,std::string element)
                spec.ftype = f_Table;
 
                for (unsigned int i = 0; i < items.size(); ++i) {
-                       items[i] = unescape_string(items[i]);
+                       items[i] = unescape_enriched(unescape_string(items[i]));
                }
 
                //now really show table
@@ -722,8 +761,8 @@ void GUIFormSpecMenu::parseTable(parserData* data,std::string element)
 
                e->setTable(data->table_options, data->table_columns, items);
 
-               if (data->table_dyndata.find(fname_w) != data->table_dyndata.end()) {
-                       e->setDynamicData(data->table_dyndata[fname_w]);
+               if (data->table_dyndata.find(name) != data->table_dyndata.end()) {
+                       e->setDynamicData(data->table_dyndata[name]);
                }
 
                if ((str_initial_selection != "") &&
@@ -760,7 +799,7 @@ void GUIFormSpecMenu::parseTextList(parserData* data,std::string element)
                MY_CHECKPOS("textlist",0);
                MY_CHECKGEOM("textlist",1);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y;
 
@@ -771,10 +810,8 @@ void GUIFormSpecMenu::parseTextList(parserData* data,std::string element)
 
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
-               std::wstring fname_w = narrow_to_wide(name);
-
                FieldSpec spec(
-                       fname_w,
+                       name,
                        L"",
                        L"",
                        258+m_fields.size()
@@ -783,7 +820,7 @@ void GUIFormSpecMenu::parseTextList(parserData* data,std::string element)
                spec.ftype = f_Table;
 
                for (unsigned int i = 0; i < items.size(); ++i) {
-                       items[i] = unescape_string(items[i]);
+                       items[i] = unescape_enriched(unescape_string(items[i]));
                }
 
                //now really show list
@@ -796,8 +833,8 @@ void GUIFormSpecMenu::parseTextList(parserData* data,std::string element)
 
                e->setTextList(items, is_yes(str_transparent));
 
-               if (data->table_dyndata.find(fname_w) != data->table_dyndata.end()) {
-                       e->setDynamicData(data->table_dyndata[fname_w]);
+               if (data->table_dyndata.find(name) != data->table_dyndata.end()) {
+                       e->setDynamicData(data->table_dyndata[name]);
                }
 
                if ((str_initial_selection != "") &&
@@ -827,7 +864,7 @@ void GUIFormSpecMenu::parseDropDown(parserData* data,std::string element)
 
                MY_CHECKPOS("dropdown",0);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y;
 
@@ -836,10 +873,8 @@ void GUIFormSpecMenu::parseDropDown(parserData* data,std::string element)
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y,
                                pos.X + width, pos.Y + (m_btn_height * 2));
 
-               std::wstring fname_w = narrow_to_wide(name);
-
                FieldSpec spec(
-                       fname_w,
+                       name,
                        L"",
                        L"",
                        258+m_fields.size()
@@ -856,25 +891,44 @@ void GUIFormSpecMenu::parseDropDown(parserData* data,std::string element)
                }
 
                for (unsigned int i=0; i < items.size(); i++) {
-                       e->addItem(narrow_to_wide(items[i]).c_str());
+                       e->addItem(unescape_enriched(unescape_string(
+                               utf8_to_wide(items[i]))).c_str());
                }
 
                if (str_initial_selection != "")
                        e->setSelected(stoi(str_initial_selection.c_str())-1);
 
                m_fields.push_back(spec);
+
+               m_dropdowns.push_back(std::pair<FieldSpec,
+                       std::vector<std::string> >(spec, std::vector<std::string>()));
+               std::vector<std::string> &values = m_dropdowns.back().second;
+               for (unsigned int i = 0; i < items.size(); i++) {
+                       values.push_back(unescape_string(items[i]));
+               }
+
                return;
        }
        errorstream << "Invalid dropdown element(" << parts.size() << "): '"
                                << element << "'"  << std::endl;
 }
 
+void GUIFormSpecMenu::parseFieldCloseOnEnter(parserData *data,
+               const std::string &element)
+{
+       std::vector<std::string> parts = split(element,';');
+       if (parts.size() == 2 ||
+                       (parts.size() > 2 && m_formspec_version > FORMSPEC_API_VERSION)) {
+               field_close_on_enter[parts[0]] = is_yes(parts[1]);
+       }
+}
+
 void GUIFormSpecMenu::parsePwdField(parserData* data,std::string element)
 {
        std::vector<std::string> parts = split(element,';');
 
-       if ((parts.size() == 4) ||
-               ((parts.size() > 4) && (m_formspec_version > FORMSPEC_API_VERSION)))
+       if ((parts.size() == 4) || (parts.size() == 5) ||
+               ((parts.size() > 5) && (m_formspec_version > FORMSPEC_API_VERSION)))
        {
                std::vector<std::string> v_pos = split(parts[0],',');
                std::vector<std::string> v_geom = split(parts[1],',');
@@ -884,7 +938,7 @@ void GUIFormSpecMenu::parsePwdField(parserData* data,std::string element)
                MY_CHECKPOS("pwdfield",0);
                MY_CHECKGEOM("pwdfield",1);
 
-               v2s32 pos;
+               v2s32 pos = pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y;
 
@@ -897,12 +951,10 @@ void GUIFormSpecMenu::parsePwdField(parserData* data,std::string element)
 
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
-               label = unescape_string(label);
-
-               std::wstring wlabel = narrow_to_wide(label);
+               std::wstring wlabel = utf8_to_wide(unescape_string(label));
 
                FieldSpec spec(
-                       narrow_to_wide(name),
+                       name,
                        wlabel,
                        L"",
                        258+m_fields.size()
@@ -920,7 +972,7 @@ void GUIFormSpecMenu::parsePwdField(parserData* data,std::string element)
                        int font_height = g_fontengine->getTextHeight();
                        rect.UpperLeftCorner.Y -= font_height;
                        rect.LowerRightCorner.Y = rect.UpperLeftCorner.Y + font_height;
-                       Environment->addStaticText(spec.flabel.c_str(), rect, false, true, this, 0);
+                       addStaticText(Environment, spec.flabel.c_str(), rect, false, true, this, 0);
                }
 
                e->setPasswordBox(true,L'*');
@@ -933,6 +985,14 @@ void GUIFormSpecMenu::parsePwdField(parserData* data,std::string element)
                evt.KeyInput.Shift       = 0;
                evt.KeyInput.PressedDown = true;
                e->OnEvent(evt);
+
+               if (parts.size() >= 5) {
+                       // TODO: remove after 2016-11-03
+                       warningstream << "pwdfield: use field_close_on_enter[name, enabled]" <<
+                                       " instead of the 5th param" << std::endl;
+                       field_close_on_enter[name] = is_yes(parts[4]);
+               }
+
                m_fields.push_back(spec);
                return;
        }
@@ -949,9 +1009,9 @@ void GUIFormSpecMenu::parseSimpleField(parserData* data,
        core::rect<s32> rect;
 
        if(data->explicit_size)
-               errorstream<<"WARNING: invalid use of unpositioned \"field\" in inventory"<<std::endl;
+               warningstream<<"invalid use of unpositioned \"field\" in inventory"<<std::endl;
 
-       v2s32 pos = padding + AbsoluteRect.UpperLeftCorner;
+       v2s32 pos = padding + AbsoluteRect.UpperLeftCorner + pos_offset * spacing;
        pos.Y = ((m_fields.size()+2)*60);
        v2s32 size = DesiredRect.getSize();
 
@@ -962,29 +1022,36 @@ void GUIFormSpecMenu::parseSimpleField(parserData* data,
        if(m_form_src)
                default_val = m_form_src->resolveText(default_val);
 
-       default_val = unescape_string(default_val);
-       label = unescape_string(label);
 
-       std::wstring wlabel = narrow_to_wide(label);
+       std::wstring wlabel = utf8_to_wide(unescape_string(label));
 
        FieldSpec spec(
-               narrow_to_wide(name),
+               name,
                wlabel,
-               narrow_to_wide(default_val),
+               utf8_to_wide(unescape_string(default_val)),
                258+m_fields.size()
        );
 
        if (name == "")
        {
                // spec field id to 0, this stops submit searching for a value that isn't there
-               Environment->addStaticText(spec.flabel.c_str(), rect, false, true, this, spec.fid);
+               addStaticText(Environment, spec.flabel.c_str(), rect, false, true, this, spec.fid);
        }
        else
        {
                spec.send = true;
-               gui::IGUIEditBox *e =
-                       Environment->addEditBox(spec.fdefault.c_str(), rect, true, this, spec.fid);
-
+               gui::IGUIElement *e;
+#if USE_FREETYPE && IRRLICHT_VERSION_MAJOR == 1 && IRRLICHT_VERSION_MINOR < 9
+               if (g_settings->getBool("freetype")) {
+                       e = (gui::IGUIElement *) new gui::intlGUIEditBox(spec.fdefault.c_str(),
+                               true, Environment, this, spec.fid, rect);
+                       e->drop();
+               } else {
+#else
+               {
+#endif
+                       e = Environment->addEditBox(spec.fdefault.c_str(), rect, true, this, spec.fid);
+               }
                if (spec.fname == data->focused_fieldname) {
                        Environment->setFocus(e);
                }
@@ -1003,10 +1070,17 @@ void GUIFormSpecMenu::parseSimpleField(parserData* data,
                        int font_height = g_fontengine->getTextHeight();
                        rect.UpperLeftCorner.Y -= font_height;
                        rect.LowerRightCorner.Y = rect.UpperLeftCorner.Y + font_height;
-                       Environment->addStaticText(spec.flabel.c_str(), rect, false, true, this, 0);
+                       addStaticText(Environment, spec.flabel.c_str(), rect, false, true, this, 0);
                }
        }
 
+       if (parts.size() >= 4) {
+               // TODO: remove after 2016-11-03
+               warningstream << "field/simple: use field_close_on_enter[name, enabled]" <<
+                               " instead of the 4th param" << std::endl;
+               field_close_on_enter[name] = is_yes(parts[3]);
+       }
+
        m_fields.push_back(spec);
 }
 
@@ -1023,9 +1097,9 @@ void GUIFormSpecMenu::parseTextArea(parserData* data,
        MY_CHECKPOS(type,0);
        MY_CHECKGEOM(type,1);
 
-       v2s32 pos;
-       pos.X = stof(v_pos[0]) * (float) spacing.X;
-       pos.Y = stof(v_pos[1]) * (float) spacing.Y;
+       v2s32 pos = pos_offset * spacing;
+       pos.X += stof(v_pos[0]) * (float) spacing.X;
+       pos.Y += stof(v_pos[1]) * (float) spacing.Y;
 
        v2s32 geom;
 
@@ -1046,34 +1120,42 @@ void GUIFormSpecMenu::parseTextArea(parserData* data,
        core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
        if(!data->explicit_size)
-               errorstream<<"WARNING: invalid use of positioned "<<type<<" without a size[] element"<<std::endl;
+               warningstream<<"invalid use of positioned "<<type<<" without a size[] element"<<std::endl;
 
        if(m_form_src)
                default_val = m_form_src->resolveText(default_val);
 
 
-       default_val = unescape_string(default_val);
-       label = unescape_string(label);
-
-       std::wstring wlabel = narrow_to_wide(label);
+       std::wstring wlabel = utf8_to_wide(unescape_string(label));
 
        FieldSpec spec(
-               narrow_to_wide(name),
+               name,
                wlabel,
-               narrow_to_wide(default_val),
+               utf8_to_wide(unescape_string(default_val)),
                258+m_fields.size()
        );
 
        if (name == "")
        {
                // spec field id to 0, this stops submit searching for a value that isn't there
-               Environment->addStaticText(spec.flabel.c_str(), rect, false, true, this, spec.fid);
+               addStaticText(Environment, spec.flabel.c_str(), rect, false, true, this, spec.fid);
        }
        else
        {
                spec.send = true;
-               gui::IGUIEditBox *e =
-                       Environment->addEditBox(spec.fdefault.c_str(), rect, true, this, spec.fid);
+
+               gui::IGUIEditBox *e;
+#if USE_FREETYPE && IRRLICHT_VERSION_MAJOR == 1 && IRRLICHT_VERSION_MINOR < 9
+               if (g_settings->getBool("freetype")) {
+                       e = (gui::IGUIEditBox *) new gui::intlGUIEditBox(spec.fdefault.c_str(),
+                               true, Environment, this, spec.fid, rect);
+                       e->drop();
+               } else {
+#else
+               {
+#endif
+                       e = Environment->addEditBox(spec.fdefault.c_str(), rect, true, this, spec.fid);
+               }
 
                if (spec.fname == data->focused_fieldname) {
                        Environment->setFocus(e);
@@ -1100,9 +1182,17 @@ void GUIFormSpecMenu::parseTextArea(parserData* data,
                        int font_height = g_fontengine->getTextHeight();
                        rect.UpperLeftCorner.Y -= font_height;
                        rect.LowerRightCorner.Y = rect.UpperLeftCorner.Y + font_height;
-                       Environment->addStaticText(spec.flabel.c_str(), rect, false, true, this, 0);
+                       addStaticText(Environment, spec.flabel.c_str(), rect, false, true, this, 0);
                }
        }
+
+       if (parts.size() >= 6) {
+               // TODO: remove after 2016-11-03
+               warningstream << "field/textarea: use field_close_on_enter[name, enabled]" <<
+                               " instead of the 6th param" << std::endl;
+               field_close_on_enter[name] = is_yes(parts[5]);
+       }
+
        m_fields.push_back(spec);
 }
 
@@ -1116,8 +1206,8 @@ void GUIFormSpecMenu::parseField(parserData* data,std::string element,
                return;
        }
 
-       if ((parts.size() == 5) ||
-               ((parts.size() > 5) && (m_formspec_version > FORMSPEC_API_VERSION)))
+       if ((parts.size() == 5) || (parts.size() == 6) ||
+               ((parts.size() > 6) && (m_formspec_version > FORMSPEC_API_VERSION)))
        {
                parseTextArea(data,parts,type);
                return;
@@ -1137,14 +1227,13 @@ void GUIFormSpecMenu::parseLabel(parserData* data,std::string element)
 
                MY_CHECKPOS("label",0);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += (stof(v_pos[1]) + 7.0/30.0) * (float)spacing.Y;
 
                if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of label without a size[] element"<<std::endl;
+                       warningstream<<"invalid use of label without a size[] element"<<std::endl;
 
-               text = unescape_string(text);
                std::vector<std::string> lines = split(text, '\n');
 
                for (unsigned int i = 0; i != lines.size(); i++) {
@@ -1158,19 +1247,19 @@ void GUIFormSpecMenu::parseLabel(parserData* data,std::string element)
                        // in the integer cases: 0.4 is not exactly
                        // representable in binary floating point.
                        s32 posy = pos.Y + ((float)i) * spacing.Y * 2.0 / 5.0;
-                       std::wstring wlabel = narrow_to_wide(lines[i]);
+                       std::wstring wlabel = utf8_to_wide(unescape_string(lines[i]));
                        core::rect<s32> rect = core::rect<s32>(
                                pos.X, posy - m_btn_height,
                                pos.X + m_font->getDimension(wlabel.c_str()).Width,
                                posy + m_btn_height);
                        FieldSpec spec(
-                               L"",
+                               "",
                                wlabel,
                                L"",
                                258+m_fields.size()
                        );
                        gui::IGUIStaticText *e =
-                               Environment->addStaticText(spec.flabel.c_str(),
+                               addStaticText(Environment, spec.flabel.c_str(),
                                        rect, false, false, this, spec.fid);
                        e->setTextAlignment(gui::EGUIA_UPPERLEFT,
                                                gui::EGUIA_CENTER);
@@ -1190,11 +1279,12 @@ void GUIFormSpecMenu::parseVertLabel(parserData* data,std::string element)
                ((parts.size() > 2) && (m_formspec_version > FORMSPEC_API_VERSION)))
        {
                std::vector<std::string> v_pos = split(parts[0],',');
-               std::wstring text = narrow_to_wide(unescape_string(parts[1]));
+               std::wstring text = unescape_enriched(
+                       unescape_string(utf8_to_wide(parts[1])));
 
                MY_CHECKPOS("vertlabel",1);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y;
 
@@ -1207,7 +1297,7 @@ void GUIFormSpecMenu::parseVertLabel(parserData* data,std::string element)
                //actually text.length() would be correct but adding +1 avoids to break all mods
 
                if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of label without a size[] element"<<std::endl;
+                       warningstream<<"invalid use of label without a size[] element"<<std::endl;
 
                std::wstring label = L"";
 
@@ -1217,13 +1307,13 @@ void GUIFormSpecMenu::parseVertLabel(parserData* data,std::string element)
                }
 
                FieldSpec spec(
-                       L"",
+                       "",
                        label,
                        L"",
                        258+m_fields.size()
                );
                gui::IGUIStaticText *t =
-                               Environment->addStaticText(spec.flabel.c_str(), rect, false, false, this, spec.fid);
+                               addStaticText(Environment, spec.flabel.c_str(), rect, false, false, this, spec.fid);
                t->setTextAlignment(gui::EGUIA_CENTER, gui::EGUIA_CENTER);
                m_fields.push_back(spec);
                return;
@@ -1248,7 +1338,7 @@ void GUIFormSpecMenu::parseImageButton(parserData* data,std::string element,
                MY_CHECKPOS("imagebutton",0);
                MY_CHECKGEOM("imagebutton",1);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y;
                v2s32 geom;
@@ -1273,18 +1363,17 @@ void GUIFormSpecMenu::parseImageButton(parserData* data,std::string element,
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
                if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of image_button without a size[] element"<<std::endl;
+                       warningstream<<"invalid use of image_button without a size[] element"<<std::endl;
 
                image_name = unescape_string(image_name);
                pressed_image_name = unescape_string(pressed_image_name);
-               label = unescape_string(label);
 
-               std::wstring wlabel = narrow_to_wide(label);
+               std::wstring wlabel = utf8_to_wide(unescape_string(label));
 
                FieldSpec spec(
-                       narrow_to_wide(name),
+                       name,
                        wlabel,
-                       narrow_to_wide(image_name),
+                       utf8_to_wide(image_name),
                        258+m_fields.size()
                );
                spec.ftype = f_Button;
@@ -1306,8 +1395,10 @@ void GUIFormSpecMenu::parseImageButton(parserData* data,std::string element,
                }
 
                e->setUseAlphaChannel(true);
-               e->setImage(texture);
-               e->setPressedImage(pressed_texture);
+               e->setImage(guiScalingImageButton(
+                       Environment->getVideoDriver(), texture, geom.X, geom.Y));
+               e->setPressedImage(guiScalingImageButton(
+                       Environment->getVideoDriver(), pressed_texture, geom.X, geom.Y));
                e->setScaleImage(true);
                e->setNotClipped(noclip);
                e->setDrawBorder(drawborder);
@@ -1344,7 +1435,7 @@ void GUIFormSpecMenu::parseTabHeader(parserData* data,std::string element)
                }
 
                FieldSpec spec(
-                       narrow_to_wide(name),
+                       name,
                        L"",
                        L"",
                        258+m_fields.size()
@@ -1352,7 +1443,7 @@ void GUIFormSpecMenu::parseTabHeader(parserData* data,std::string element)
 
                spec.ftype = f_TabHeader;
 
-               v2s32 pos(0,0);
+               v2s32 pos = pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y - m_btn_height * 2;
                v2s32 geom;
@@ -1374,8 +1465,9 @@ void GUIFormSpecMenu::parseTabHeader(parserData* data,std::string element)
 
                e->setNotClipped(true);
 
-               for (unsigned int i=0; i< buttons.size(); i++) {
-                       e->addTab(narrow_to_wide(buttons[i]).c_str(), -1);
+               for (unsigned int i = 0; i < buttons.size(); i++) {
+                       e->addTab(unescape_enriched(unescape_string(
+                               utf8_to_wide(buttons[i]))).c_str(), -1);
                }
 
                if ((tab_index >= 0) &&
@@ -1393,10 +1485,9 @@ void GUIFormSpecMenu::parseTabHeader(parserData* data,std::string element)
 void GUIFormSpecMenu::parseItemImageButton(parserData* data,std::string element)
 {
 
-       if (m_gamedef == 0) {
-               errorstream <<
-                               "WARNING: invalid use of item_image_button with m_gamedef==0"
-                               << std::endl;
+       if (m_client == 0) {
+               warningstream << "invalid use of item_image_button with m_client==0"
+                       << std::endl;
                return;
        }
 
@@ -1411,10 +1502,13 @@ void GUIFormSpecMenu::parseItemImageButton(parserData* data,std::string element)
                std::string name = parts[3];
                std::string label = parts[4];
 
+               label = unescape_string(label);
+               item_name = unescape_string(item_name);
+
                MY_CHECKPOS("itemimagebutton",0);
                MY_CHECKGEOM("itemimagebutton",1);
 
-               v2s32 pos = padding;
+               v2s32 pos = padding + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float)spacing.X;
                pos.Y += stof(v_pos[1]) * (float)spacing.Y;
                v2s32 geom;
@@ -1424,40 +1518,39 @@ void GUIFormSpecMenu::parseItemImageButton(parserData* data,std::string element)
                core::rect<s32> rect = core::rect<s32>(pos.X, pos.Y, pos.X+geom.X, pos.Y+geom.Y);
 
                if(!data->explicit_size)
-                       errorstream<<"WARNING: invalid use of item_image_button without a size[] element"<<std::endl;
+                       warningstream<<"invalid use of item_image_button without a size[] element"<<std::endl;
 
-               IItemDefManager *idef = m_gamedef->idef();
+               IItemDefManager *idef = m_client->idef();
                ItemStack item;
                item.deSerialize(item_name, idef);
-               video::ITexture *texture = idef->getInventoryTexture(item.getDefinition(idef).name, m_gamedef);
 
-               m_tooltips[narrow_to_wide(name)] =
-                       TooltipSpec (item.getDefinition(idef).description,
+               m_tooltips[name] =
+                       TooltipSpec(item.getDefinition(idef).description,
                                                m_default_tooltip_bgcolor,
                                                m_default_tooltip_color);
 
-               label = unescape_string(label);
                FieldSpec spec(
-                       narrow_to_wide(name),
-                       narrow_to_wide(label),
-                       narrow_to_wide(item_name),
-                       258+m_fields.size()
+                       name,
+                       utf8_to_wide(label),
+                       utf8_to_wide(item_name),
+                       258 + m_fields.size()
                );
 
-               gui::IGUIButton *e = Environment->addButton(rect, this, spec.fid, spec.flabel.c_str());
+               gui::IGUIButton *e = Environment->addButton(rect, this, spec.fid, L"");
 
                if (spec.fname == data->focused_fieldname) {
                        Environment->setFocus(e);
                }
 
-               e->setUseAlphaChannel(true);
-               e->setImage(texture);
-               e->setPressedImage(texture);
-               e->setScaleImage(true);
                spec.ftype = f_Button;
                rect+=data->basepos-padding;
                spec.rect=rect;
                m_fields.push_back(spec);
+               pos = padding + AbsoluteRect.UpperLeftCorner + pos_offset * spacing;
+               pos.X += stof(v_pos[0]) * (float) spacing.X;
+               pos.Y += stof(v_pos[1]) * (float) spacing.Y;
+               m_itemimages.push_back(ImageDrawSpec("", item_name, e, pos, geom));
+               m_static_texts.push_back(StaticTextSpec(utf8_to_wide(label), rect, e));
                return;
        }
        errorstream<< "Invalid ItemImagebutton element(" << parts.size() << "): '" << element << "'"  << std::endl;
@@ -1476,7 +1569,7 @@ void GUIFormSpecMenu::parseBox(parserData* data,std::string element)
                MY_CHECKPOS("box",0);
                MY_CHECKGEOM("box",1);
 
-               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner;
+               v2s32 pos = padding + AbsoluteRect.UpperLeftCorner + pos_offset * spacing;
                pos.X += stof(v_pos[0]) * (float) spacing.X;
                pos.Y += stof(v_pos[1]) * (float) spacing.Y;
 
@@ -1550,13 +1643,15 @@ void GUIFormSpecMenu::parseTooltip(parserData* data, std::string element)
        std::vector<std::string> parts = split(element,';');
        if (parts.size() == 2) {
                std::string name = parts[0];
-               m_tooltips[narrow_to_wide(name)] = TooltipSpec (parts[1], m_default_tooltip_bgcolor, m_default_tooltip_color);
+               m_tooltips[name] = TooltipSpec(unescape_string(parts[1]),
+                       m_default_tooltip_bgcolor, m_default_tooltip_color);
                return;
        } else if (parts.size() == 4) {
                std::string name = parts[0];
                video::SColor tmp_color1, tmp_color2;
                if ( parseColorString(parts[2], tmp_color1, false) && parseColorString(parts[3], tmp_color2, false) ) {
-                       m_tooltips[narrow_to_wide(name)] = TooltipSpec (parts[1], tmp_color1, tmp_color2);
+                       m_tooltips[name] = TooltipSpec(unescape_string(parts[1]),
+                               tmp_color1, tmp_color2);
                        return;
                }
        }
@@ -1611,6 +1706,74 @@ bool GUIFormSpecMenu::parseSizeDirect(parserData* data, std::string element)
        return true;
 }
 
+bool GUIFormSpecMenu::parsePositionDirect(parserData *data, const std::string &element)
+{
+       if (element.empty())
+               return false;
+
+       std::vector<std::string> parts = split(element, '[');
+
+       if (parts.size() != 2)
+               return false;
+
+       std::string type = trim(parts[0]);
+       std::string description = trim(parts[1]);
+
+       if (type != "position")
+               return false;
+
+       parsePosition(data, description);
+
+       return true;
+}
+
+void GUIFormSpecMenu::parsePosition(parserData *data, const std::string &element)
+{
+       std::vector<std::string> parts = split(element, ',');
+
+       if (parts.size() == 2) {
+               data->offset.X = stof(parts[0]);
+               data->offset.Y = stof(parts[1]);
+               return;
+       }
+
+       errorstream << "Invalid position element (" << parts.size() << "): '" << element << "'" << std::endl;
+}
+
+bool GUIFormSpecMenu::parseAnchorDirect(parserData *data, const std::string &element)
+{
+       if (element.empty())
+               return false;
+
+       std::vector<std::string> parts = split(element, '[');
+
+       if (parts.size() != 2)
+               return false;
+
+       std::string type = trim(parts[0]);
+       std::string description = trim(parts[1]);
+
+       if (type != "anchor")
+               return false;
+
+       parseAnchor(data, description);
+
+       return true;
+}
+
+void GUIFormSpecMenu::parseAnchor(parserData *data, const std::string &element)
+{
+       std::vector<std::string> parts = split(element, ',');
+
+       if (parts.size() == 2) {
+               data->anchor.X = stof(parts[0]);
+               data->anchor.Y = stof(parts[1]);
+               return;
+       }
+
+       errorstream << "Invalid anchor element (" << parts.size() << "): '" << element << "'" << std::endl;
+}
+
 void GUIFormSpecMenu::parseElement(parserData* data, std::string element)
 {
        //some prechecks
@@ -1636,28 +1799,43 @@ void GUIFormSpecMenu::parseElement(parserData* data, std::string element)
        std::string type = trim(parts[0]);
        std::string description = trim(parts[1]);
 
+       if (type == "container") {
+               parseContainer(data, description);
+               return;
+       }
+
+       if (type == "container_end") {
+               parseContainerEnd(data);
+               return;
+       }
+
        if (type == "list") {
-               parseList(data,description);
+               parseList(data, description);
+               return;
+       }
+
+       if (type == "listring") {
+               parseListRing(data, description);
                return;
        }
 
        if (type == "checkbox") {
-               parseCheckbox(data,description);
+               parseCheckbox(data, description);
                return;
        }
 
        if (type == "image") {
-               parseImage(data,description);
+               parseImage(data, description);
                return;
        }
 
        if (type == "item_image") {
-               parseItemImage(data,description);
+               parseItemImage(data, description);
                return;
        }
 
-       if ((type == "button") || (type == "button_exit")) {
-               parseButton(data,description,type);
+       if (type == "button" || type == "button_exit") {
+               parseButton(data, description, type);
                return;
        }
 
@@ -1691,6 +1869,11 @@ void GUIFormSpecMenu::parseElement(parserData* data, std::string element)
                return;
        }
 
+       if (type == "field_close_on_enter") {
+               parseFieldCloseOnEnter(data, description);
+               return;
+       }
+
        if (type == "pwdfield") {
                parsePwdField(data,description);
                return;
@@ -1768,7 +1951,7 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
 
        //preserve tables
        for (u32 i = 0; i < m_tables.size(); ++i) {
-               std::wstring tablename = m_tables[i].first.fname;
+               std::string tablename = m_tables[i].first.fname;
                GUITable *table = m_tables[i].second;
                mydata.table_dyndata[tablename] = table->getDynamicData();
        }
@@ -1802,6 +1985,8 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
 
        mydata.size= v2s32(100,100);
        mydata.screensize = screensize;
+       mydata.offset = v2f32(0.5f, 0.5f);
+       mydata.anchor = v2f32(0.5f, 0.5f);
 
        // Base position of contents of form
        mydata.basepos = getBasePos();
@@ -1818,6 +2003,8 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
        m_fields.clear();
        m_boxes.clear();
        m_tooltips.clear();
+       m_inventory_rings.clear();
+       m_static_texts.clear();
 
        // Set default values (fits old formspec values)
        m_bgcolor = video::SColor(140,0,0,0);
@@ -1832,12 +2019,11 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
        m_slotbordercolor = video::SColor(200,0,0,0);
        m_slotborder = false;
 
-       m_clipbackground = false;
        // Add tooltip
        {
                assert(m_tooltip_element == NULL);
                // Note: parent != this so that the tooltip isn't clipped by the menu rectangle
-               m_tooltip_element = Environment->addStaticText(L"",core::rect<s32>(0,0,110,18));
+               m_tooltip_element = addStaticText(Environment, L"",core::rect<s32>(0,0,110,18));
                m_tooltip_element->enableOverrideColor(true);
                m_tooltip_element->setBackgroundColor(m_default_tooltip_bgcolor);
                m_tooltip_element->setDrawBackground(true);
@@ -1867,6 +2053,21 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
                }
        }
 
+       /* "position" element is always after "size" element if it used */
+       for (; i< elements.size(); i++) {
+               if (!parsePositionDirect(&mydata, elements[i])) {
+                       break;
+               }
+       }
+
+       /* "anchor" element is always after "position" (or  "size" element) if it used */
+       for (; i< elements.size(); i++) {
+               if (!parseAnchorDirect(&mydata, elements[i])) {
+                       break;
+               }
+       }
+
+
        if (mydata.explicit_size) {
                // compute scaling for specified form size
                if (m_lock) {
@@ -1950,10 +2151,10 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
                        padding.Y*2+spacing.Y*(mydata.invsize.Y-1.0)+imgsize.Y + m_btn_height*2.0/3.0
                );
                DesiredRect = mydata.rect = core::rect<s32>(
-                               mydata.screensize.X/2 - mydata.size.X/2 + offset.X,
-                               mydata.screensize.Y/2 - mydata.size.Y/2 + offset.Y,
-                               mydata.screensize.X/2 + mydata.size.X/2 + offset.X,
-                               mydata.screensize.Y/2 + mydata.size.Y/2 + offset.Y
+                               (s32)((f32)mydata.screensize.X * mydata.offset.X) - (s32)(mydata.anchor.X * (f32)mydata.size.X) + offset.X,
+                               (s32)((f32)mydata.screensize.Y * mydata.offset.Y) - (s32)(mydata.anchor.Y * (f32)mydata.size.Y) + offset.Y,
+                               (s32)((f32)mydata.screensize.X * mydata.offset.X) + (s32)((1.0 - mydata.anchor.X) * (f32)mydata.size.X) + offset.X,
+                               (s32)((f32)mydata.screensize.Y * mydata.offset.Y) + (s32)((1.0 - mydata.anchor.Y) * (f32)mydata.size.Y) + offset.Y
                );
        } else {
                // Non-size[] form must consist only of text fields and
@@ -1962,10 +2163,10 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
                m_font = g_fontengine->getFont();
                m_btn_height = font_line_height(m_font) * 0.875;
                DesiredRect = core::rect<s32>(
-                       mydata.screensize.X/2 - 580/2,
-                       mydata.screensize.Y/2 - 300/2,
-                       mydata.screensize.X/2 + 580/2,
-                       mydata.screensize.Y/2 + 300/2
+                       (s32)((f32)mydata.screensize.X * mydata.offset.X) - (s32)(mydata.anchor.X * 580.0),
+                       (s32)((f32)mydata.screensize.Y * mydata.offset.Y) - (s32)(mydata.anchor.Y * 300.0),
+                       (s32)((f32)mydata.screensize.X * mydata.offset.X) + (s32)((1.0 - mydata.anchor.X) * 580.0),
+                       (s32)((f32)mydata.screensize.Y * mydata.offset.Y) + (s32)((1.0 - mydata.anchor.Y) * 300.0)
                );
        }
        recalculateAbsolutePosition(false);
@@ -1973,14 +2174,20 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
        m_tooltip_element->setOverrideFont(m_font);
 
        gui::IGUISkin* skin = Environment->getSkin();
-       assert(skin != NULL);
+       sanity_check(skin != NULL);
        gui::IGUIFont *old_font = skin->getFont();
        skin->setFont(m_font);
 
+       pos_offset = v2s32();
        for (; i< elements.size(); i++) {
                parseElement(&mydata, elements[i]);
        }
 
+       if (!container_stack.empty()) {
+               errorstream << "Invalid formspec string: container was never closed!"
+                       << std::endl;
+       }
+
        // If there are fields without explicit size[], add a "Proceed"
        // button and adjust size to fit all the fields.
        if (m_fields.size() && !mydata.explicit_size) {
@@ -2023,7 +2230,7 @@ void GUIFormSpecMenu::regenerateGui(v2u32 screensize)
 bool GUIFormSpecMenu::getAndroidUIInput()
 {
        /* no dialog shown */
-       if (m_JavaDialogFieldName == L"") {
+       if (m_JavaDialogFieldName == "") {
                return false;
        }
 
@@ -2032,8 +2239,8 @@ bool GUIFormSpecMenu::getAndroidUIInput()
                return true;
        }
 
-       std::wstring fieldname = m_JavaDialogFieldName;
-       m_JavaDialogFieldName = L"";
+       std::string fieldname = m_JavaDialogFieldName;
+       m_JavaDialogFieldName = "";
 
        /* no value abort dialog processing */
        if (porting::getInputDialogState() != 0) {
@@ -2041,7 +2248,7 @@ bool GUIFormSpecMenu::getAndroidUIInput()
        }
 
        for(std::vector<FieldSpec>::iterator iter =  m_fields.begin();
-                       iter != m_fields.end(); iter++) {
+                       iter != m_fields.end(); ++iter) {
 
                if (iter->fname != fieldname) {
                        continue;
@@ -2059,7 +2266,7 @@ bool GUIFormSpecMenu::getAndroidUIInput()
                std::string text = porting::getInputDialogValue();
 
                ((gui::IGUIEditBox*) tochange)->
-                       setText(narrow_to_wide(text).c_str());
+                       setText(utf8_to_wide(text).c_str());
        }
        return false;
 }
@@ -2089,13 +2296,14 @@ GUIFormSpecMenu::ItemSpec GUIFormSpecMenu::getItemAtPos(v2s32 p) const
        return ItemSpec(InventoryLocation(), "", -1);
 }
 
-void GUIFormSpecMenu::drawList(const ListDrawSpec &s, int phase)
+void GUIFormSpecMenu::drawList(const ListDrawSpec &s, int phase,
+               bool &item_hovered)
 {
        video::IVideoDriver* driver = Environment->getVideoDriver();
 
        Inventory *inv = m_invmgr->getInventory(s.inventoryloc);
        if(!inv){
-               infostream<<"GUIFormSpecMenu::drawList(): WARNING: "
+               warningstream<<"GUIFormSpecMenu::drawList(): "
                                <<"The inventory location "
                                <<"\""<<s.inventoryloc.dump()<<"\" doesn't exist"
                                <<std::endl;
@@ -2103,7 +2311,7 @@ void GUIFormSpecMenu::drawList(const ListDrawSpec &s, int phase)
        }
        InventoryList *ilist = inv->getList(s.listname);
        if(!ilist){
-               infostream<<"GUIFormSpecMenu::drawList(): WARNING: "
+               warningstream<<"GUIFormSpecMenu::drawList(): "
                                <<"The inventory list \""<<s.listname<<"\" @ \""
                                <<s.inventoryloc.dump()<<"\" doesn't exist"
                                <<std::endl;
@@ -2130,13 +2338,16 @@ void GUIFormSpecMenu::drawList(const ListDrawSpec &s, int phase)
                        && m_selected_item->listname == s.listname
                        && m_selected_item->i == item_i;
                bool hovering = rect.isPointInside(m_pointer);
+               ItemRotationKind rotation_kind = selected ? IT_ROT_SELECTED :
+                       (hovering ? IT_ROT_HOVERED : IT_ROT_NONE);
 
-               if(phase == 0)
-               {
-                       if(hovering)
+               if (phase == 0) {
+                       if (hovering) {
+                               item_hovered = true;
                                driver->draw2DRectangle(m_slotbg_h, rect, &AbsoluteClippingRect);
-                       else
+                       } else {
                                driver->draw2DRectangle(m_slotbg_n, rect, &AbsoluteClippingRect);
+                       }
                }
 
                //Draw inv slot borders
@@ -2170,22 +2381,36 @@ void GUIFormSpecMenu::drawList(const ListDrawSpec &s, int phase)
                        if(!item.empty())
                        {
                                drawItemStack(driver, m_font, item,
-                                               rect, &AbsoluteClippingRect, m_gamedef);
+                                       rect, &AbsoluteClippingRect, m_client,
+                                       rotation_kind);
                        }
 
                        // Draw tooltip
-                       std::string tooltip_text = "";
-                       if (hovering && !m_selected_item)
-                               tooltip_text = item.getDefinition(m_gamedef->idef()).description;
-                       if (tooltip_text != "") {
-                               std::vector<std::string> tt_rows = str_split(tooltip_text, '\n');
+                       std::wstring tooltip_text = L"";
+                       if (hovering && !m_selected_item) {
+                               const std::string &desc = item.metadata.getString("description");
+                               if (desc.empty())
+                                       tooltip_text =
+                                               utf8_to_wide(item.getDefinition(m_client->idef()).description);
+                               else
+                                       tooltip_text = utf8_to_wide(desc);
+                               // Show itemstring as fallback for easier debugging
+                               if (!item.name.empty() && tooltip_text.empty())
+                                       tooltip_text = utf8_to_wide(item.name);
+                       }
+                       if (tooltip_text != L"") {
+                               std::vector<std::wstring> tt_rows = str_split(tooltip_text, L'\n');
                                m_tooltip_element->setBackgroundColor(m_default_tooltip_bgcolor);
                                m_tooltip_element->setOverrideColor(m_default_tooltip_color);
                                m_tooltip_element->setVisible(true);
                                this->bringToFront(m_tooltip_element);
-                               m_tooltip_element->setText(narrow_to_wide(tooltip_text).c_str());
+                               setStaticText(m_tooltip_element, tooltip_text.c_str());
                                s32 tooltip_width = m_tooltip_element->getTextWidth() + m_btn_height;
+#if (IRRLICHT_VERSION_MAJOR <= 1 && IRRLICHT_VERSION_MINOR <= 8 && IRRLICHT_VERSION_REVISION < 2) || USE_FREETYPE == 1
                                s32 tooltip_height = m_tooltip_element->getTextHeight() * tt_rows.size() + 5;
+#else
+                               s32 tooltip_height = m_tooltip_element->getTextHeight() + 5;
+#endif
                                v2u32 screenSize = driver->getScreenSize();
                                int tooltip_offset_x = m_btn_height;
                                int tooltip_offset_y = m_btn_height;
@@ -2211,21 +2436,26 @@ void GUIFormSpecMenu::drawList(const ListDrawSpec &s, int phase)
 
 void GUIFormSpecMenu::drawSelectedItem()
 {
-       if(!m_selected_item)
-               return;
-
        video::IVideoDriver* driver = Environment->getVideoDriver();
 
+       if (!m_selected_item) {
+               drawItemStack(driver, m_font, ItemStack(),
+                       core::rect<s32>(v2s32(0, 0), v2s32(0, 0)),
+                       NULL, m_client, IT_ROT_DRAGGED);
+               return;
+       }
+
        Inventory *inv = m_invmgr->getInventory(m_selected_item->inventoryloc);
-       assert(inv);
+       sanity_check(inv);
        InventoryList *list = inv->getList(m_selected_item->listname);
-       assert(list);
+       sanity_check(list);
        ItemStack stack = list->getItem(m_selected_item->i);
        stack.count = m_selected_amount;
 
        core::rect<s32> imgrect(0,0,imgsize.X,imgsize.Y);
        core::rect<s32> rect = imgrect + (m_pointer - imgrect.getCenter());
-       drawItemStack(driver, m_font, stack, rect, NULL, m_gamedef);
+       rect.constrainTo(driver->getViewPort());
+       drawItemStack(driver, m_font, stack, rect, NULL, m_client, IT_ROT_DRAGGED);
 }
 
 void GUIFormSpecMenu::drawMenu()
@@ -2239,7 +2469,7 @@ void GUIFormSpecMenu::drawMenu()
        }
 
        gui::IGUISkin* skin = Environment->getSkin();
-       assert(skin != NULL);
+       sanity_check(skin != NULL);
        gui::IGUIFont *old_font = skin->getFont();
        skin->setFont(m_font);
 
@@ -2270,7 +2500,7 @@ void GUIFormSpecMenu::drawMenu()
                        // Image rectangle on screen
                        core::rect<s32> rect = imgrect + spec.pos;
 
-                       if (m_clipbackground) {
+                       if (spec.clip) {
                                core::dimension2d<s32> absrec_size = AbsoluteRect.getSize();
                                rect = core::rect<s32>(AbsoluteRect.UpperLeftCorner.X - spec.pos.X,
                                                                        AbsoluteRect.UpperLeftCorner.Y - spec.pos.Y,
@@ -2280,12 +2510,11 @@ void GUIFormSpecMenu::drawMenu()
 
                        const video::SColor color(255,255,255,255);
                        const video::SColor colors[] = {color,color,color,color};
-                       driver->draw2DImage(texture, rect,
+                       draw2DImageFilterScaled(driver, texture, rect,
                                core::rect<s32>(core::position2d<s32>(0,0),
                                                core::dimension2di(texture->getOriginalSize())),
                                NULL/*&AbsoluteClippingRect*/, colors, true);
-               }
-               else {
+               } else {
                        errorstream << "GUIFormSpecMenu::drawMenu() Draw backgrounds unable to load texture:" << std::endl;
                        errorstream << "\t" << spec.name << std::endl;
                }
@@ -2307,6 +2536,12 @@ void GUIFormSpecMenu::drawMenu()
 
                driver->draw2DRectangle(todraw, rect, 0);
        }
+
+       /*
+               Call base class
+       */
+       gui::IGUIElement::draw();
+
        /*
                Draw images
        */
@@ -2330,7 +2565,7 @@ void GUIFormSpecMenu::drawMenu()
                        core::rect<s32> rect = imgrect + spec.pos;
                        const video::SColor color(255,255,255,255);
                        const video::SColor colors[] = {color,color,color,color};
-                       driver->draw2DImage(texture, rect,
+                       draw2DImageFilterScaled(driver, texture, rect,
                                core::rect<s32>(core::position2d<s32>(0,0),img_origsize),
                                NULL/*&AbsoluteClippingRect*/, colors, true);
                }
@@ -2345,24 +2580,28 @@ void GUIFormSpecMenu::drawMenu()
        */
        for(u32 i=0; i<m_itemimages.size(); i++)
        {
-               if (m_gamedef == 0)
+               if (m_client == 0)
                        break;
 
                const ImageDrawSpec &spec = m_itemimages[i];
-               IItemDefManager *idef = m_gamedef->idef();
+               IItemDefManager *idef = m_client->idef();
                ItemStack item;
-               item.deSerialize(spec.name, idef);
-               video::ITexture *texture = idef->getInventoryTexture(item.getDefinition(idef).name, m_gamedef);
-               // Image size on screen
+               item.deSerialize(spec.item_name, idef);
                core::rect<s32> imgrect(0, 0, spec.geom.X, spec.geom.Y);
-               // Image rectangle on screen
+               // Viewport rectangle on screen
                core::rect<s32> rect = imgrect + spec.pos;
-               const video::SColor color(255,255,255,255);
-               const video::SColor colors[] = {color,color,color,color};
-               driver->draw2DImage(texture, rect,
-                       core::rect<s32>(core::position2d<s32>(0,0),
-                                       core::dimension2di(texture->getOriginalSize())),
-                       NULL/*&AbsoluteClippingRect*/, colors, true);
+               if (spec.parent_button && spec.parent_button->isPressed()) {
+#if (IRRLICHT_VERSION_MAJOR == 1 && IRRLICHT_VERSION_MINOR < 8)
+                       rect += core::dimension2d<s32>(
+                               0.05 * (float)rect.getWidth(), 0.05 * (float)rect.getHeight());
+#else
+                       rect += core::dimension2d<s32>(
+                               skin->getSize(irr::gui::EGDS_BUTTON_PRESSED_IMAGE_OFFSET_X),
+                               skin->getSize(irr::gui::EGDS_BUTTON_PRESSED_IMAGE_OFFSET_Y));
+#endif
+               }
+               drawItemStack(driver, m_font, item, rect, &AbsoluteClippingRect,
+                               m_client, IT_ROT_NONE);
        }
 
        /*
@@ -2370,23 +2609,46 @@ void GUIFormSpecMenu::drawMenu()
                Phase 0: Item slot rectangles
                Phase 1: Item images; prepare tooltip
        */
-       int start_phase=0;
-       for(int phase=start_phase; phase<=1; phase++)
-       for(u32 i=0; i<m_inventorylists.size(); i++)
-       {
-               drawList(m_inventorylists[i], phase);
+       bool item_hovered = false;
+       int start_phase = 0;
+       for (int phase = start_phase; phase <= 1; phase++) {
+               for (u32 i = 0; i < m_inventorylists.size(); i++) {
+                       drawList(m_inventorylists[i], phase, item_hovered);
+               }
+       }
+       if (!item_hovered) {
+               drawItemStack(driver, m_font, ItemStack(),
+                       core::rect<s32>(v2s32(0, 0), v2s32(0, 0)),
+                       NULL, m_client, IT_ROT_HOVERED);
        }
-
-       /*
-               Call base class
-       */
-       gui::IGUIElement::draw();
 
 /* TODO find way to show tooltips on touchscreen */
 #ifndef HAVE_TOUCHSCREENGUI
        m_pointer = m_device->getCursorControl()->getPosition();
 #endif
 
+       /*
+               Draw static text elements
+       */
+       for (u32 i = 0; i < m_static_texts.size(); i++) {
+               const StaticTextSpec &spec = m_static_texts[i];
+               core::rect<s32> rect = spec.rect;
+               if (spec.parent_button && spec.parent_button->isPressed()) {
+#if (IRRLICHT_VERSION_MAJOR == 1 && IRRLICHT_VERSION_MINOR < 8)
+                       rect += core::dimension2d<s32>(
+                               0.05 * (float)rect.getWidth(), 0.05 * (float)rect.getHeight());
+#else
+                       // Use image offset instead of text's because its a bit smaller
+                       // and fits better, also TEXT_OFFSET_X is always 0
+                       rect += core::dimension2d<s32>(
+                               skin->getSize(irr::gui::EGDS_BUTTON_PRESSED_IMAGE_OFFSET_X),
+                               skin->getSize(irr::gui::EGDS_BUTTON_PRESSED_IMAGE_OFFSET_Y));
+#endif
+               }
+               video::SColor color(255, 255, 255, 255);
+               m_font->draw(spec.text.c_str(), rect, color, true, true, &rect);
+       }
+
        /*
                Draw fields/buttons tooltips
        */
@@ -2399,7 +2661,7 @@ void GUIFormSpecMenu::drawMenu()
                u32 delta = 0;
                if (id == -1) {
                        m_old_tooltip_id = id;
-                       m_old_tooltip = "";
+                       m_old_tooltip = L"";
                } else {
                        if (id == m_old_tooltip_id) {
                                delta = porting::getDeltaMs(m_hovered_time, getTimeMs());
@@ -2411,12 +2673,14 @@ void GUIFormSpecMenu::drawMenu()
 
                if (id != -1 && delta >= m_tooltip_show_delay) {
                        for(std::vector<FieldSpec>::iterator iter =  m_fields.begin();
-                                       iter != m_fields.end(); iter++) {
-                               if ( (iter->fid == id) && (m_tooltips[iter->fname].tooltip != "") ){
+                                       iter != m_fields.end(); ++iter) {
+                               if (iter->fid == id && m_tooltips[iter->fname].tooltip != L"") {
                                        if (m_old_tooltip != m_tooltips[iter->fname].tooltip) {
+                                               m_tooltip_element->setBackgroundColor(m_tooltips[iter->fname].bgcolor);
+                                               m_tooltip_element->setOverrideColor(m_tooltips[iter->fname].color);
                                                m_old_tooltip = m_tooltips[iter->fname].tooltip;
-                                               m_tooltip_element->setText(narrow_to_wide(m_tooltips[iter->fname].tooltip).c_str());
-                                               std::vector<std::string> tt_rows = str_split(m_tooltips[iter->fname].tooltip, '\n');
+                                               setStaticText(m_tooltip_element, m_tooltips[iter->fname].tooltip.c_str());
+                                               std::vector<std::wstring> tt_rows = str_split(m_tooltips[iter->fname].tooltip, L'\n');
                                                s32 tooltip_width = m_tooltip_element->getTextWidth() + m_btn_height;
                                                s32 tooltip_height = m_tooltip_element->getTextHeight() * tt_rows.size() + 5;
                                                int tooltip_offset_x = m_btn_height;
@@ -2437,8 +2701,6 @@ void GUIFormSpecMenu::drawMenu()
                                                core::position2d<s32>(tooltip_x, tooltip_y),
                                                core::dimension2d<s32>(tooltip_width, tooltip_height)));
                                        }
-                                       m_tooltip_element->setBackgroundColor(m_tooltips[iter->fname].bgcolor);
-                                       m_tooltip_element->setOverrideColor(m_tooltips[iter->fname].color);
                                        m_tooltip_element->setVisible(true);
                                        this->bringToFront(m_tooltip_element);
                                        break;
@@ -2447,6 +2709,8 @@ void GUIFormSpecMenu::drawMenu()
                }
        }
 
+       m_tooltip_element->draw();
+
        /*
                Draw dragged item stack
        */
@@ -2574,7 +2838,7 @@ void GUIFormSpecMenu::acceptInput(FormspecQuitMode quitmode=quit_mode_no)
 {
        if(m_text_dst)
        {
-               std::map<std::string, std::string> fields;
+               StringMap fields;
 
                if (quitmode == quit_mode_accept) {
                        fields["quit"] = "true";
@@ -2601,6 +2865,11 @@ void GUIFormSpecMenu::acceptInput(FormspecQuitMode quitmode=quit_mode_no)
                        current_keys_pending.key_enter = false;
                }
 
+               if (!current_field_enter_pending.empty()) {
+                       fields["key_enter_field"] = current_field_enter_pending;
+                       current_field_enter_pending = "";
+               }
+
                if (current_keys_pending.key_escape) {
                        fields["key_escape"] = "true";
                        current_keys_pending.key_escape = false;
@@ -2609,11 +2878,10 @@ void GUIFormSpecMenu::acceptInput(FormspecQuitMode quitmode=quit_mode_no)
                for(unsigned int i=0; i<m_fields.size(); i++) {
                        const FieldSpec &s = m_fields[i];
                        if(s.send) {
-                               std::string name  = wide_to_narrow(s.fname);
-                               if(s.ftype == f_Button) {
-                                       fields[name] = wide_to_narrow(s.flabel);
-                               }
-                               else if(s.ftype == f_Table) {
+                               std::string name = s.fname;
+                               if (s.ftype == f_Button) {
+                                       fields[name] = wide_to_utf8(s.flabel);
+                               } else if (s.ftype == f_Table) {
                                        GUITable *table = getTable(s.fname);
                                        if (table) {
                                                fields[name] = table->checkEvent();
@@ -2629,8 +2897,11 @@ void GUIFormSpecMenu::acceptInput(FormspecQuitMode quitmode=quit_mode_no)
                                        }
                                        s32 selected = e->getSelected();
                                        if (selected >= 0) {
-                                               fields[name] =
-                                                       wide_to_narrow(e->getItem(selected));
+                                               std::vector<std::string> *dropdown_values =
+                                                       getDropDownValues(s.fname);
+                                               if (dropdown_values && selected < (s32)dropdown_values->size()) {
+                                                       fields[name] = (*dropdown_values)[selected];
+                                               }
                                        }
                                }
                                else if (s.ftype == f_TabHeader) {
@@ -2686,7 +2957,7 @@ void GUIFormSpecMenu::acceptInput(FormspecQuitMode quitmode=quit_mode_no)
                                {
                                        IGUIElement* e = getElementFromId(s.fid);
                                        if(e != NULL) {
-                                               fields[name] = wide_to_narrow(e->getText());
+                                               fields[name] = wide_to_utf8(e->getText());
                                        }
                                }
                        }
@@ -2725,7 +2996,7 @@ bool GUIFormSpecMenu::preprocessEvent(const SEvent& event)
                if (hovered && isMyChild(hovered) &&
                                hovered->getType() == gui::EGUIET_TAB_CONTROL) {
                        gui::IGUISkin* skin = Environment->getSkin();
-                       assert(skin != NULL);
+                       sanity_check(skin != NULL);
                        gui::IGUIFont *old_font = skin->getFont();
                        skin->setFont(m_font);
                        bool retval = hovered->OnEvent(event);
@@ -2771,7 +3042,7 @@ bool GUIFormSpecMenu::preprocessEvent(const SEvent& event)
                                core::position2d<s32>(x, y));
                if (event.MouseInput.Event == EMIE_LMOUSE_PRESSED_DOWN) {
                        m_old_tooltip_id = -1;
-                       m_old_tooltip = "";
+                       m_old_tooltip = L"";
                }
                if (!isChild(hovered,this)) {
                        if (DoubleClickDetection(event)) {
@@ -2794,7 +3065,7 @@ bool GUIFormSpecMenu::preprocessEvent(const SEvent& event)
                        }
                        m_JavaDialogFieldName = getNameByID(hovered->getID());
                        std::string message   = gettext("Enter ");
-                       std::string label     = wide_to_narrow(getLabelByID(hovered->getID()));
+                       std::string label     = wide_to_utf8(getLabelByID(hovered->getID()));
                        if (label == "") {
                                label = "text";
                        }
@@ -2814,7 +3085,7 @@ bool GUIFormSpecMenu::preprocessEvent(const SEvent& event)
                        }
 
                        porting::showInputDialog(gettext("ok"), "",
-                                       wide_to_narrow(((gui::IGUIEditBox*) hovered)->getText()),
+                                       wide_to_utf8(((gui::IGUIEditBox*) hovered)->getText()),
                                        type);
                        return retval;
                }
@@ -2930,12 +3201,44 @@ bool GUIFormSpecMenu::preprocessEvent(const SEvent& event)
        }
        #endif
 
+       if (event.EventType == irr::EET_JOYSTICK_INPUT_EVENT) {
+               /* TODO add a check like:
+               if (event.JoystickEvent != joystick_we_listen_for)
+                       return false;
+               */
+               bool handled = m_joystick->handleEvent(event.JoystickEvent);
+               if (handled) {
+                       if (m_joystick->wasKeyDown(KeyType::ESC)) {
+                               tryClose();
+                       } else if (m_joystick->wasKeyDown(KeyType::JUMP)) {
+                               if (m_allowclose) {
+                                       acceptInput(quit_mode_accept);
+                                       quitMenu();
+                               }
+                       }
+               }
+               return handled;
+       }
+
        return false;
 }
 
 /******************************************************************************/
 bool GUIFormSpecMenu::DoubleClickDetection(const SEvent event)
 {
+       /* The following code is for capturing double-clicks of the mouse button
+        * and translating the double-click into an EET_KEY_INPUT_EVENT event
+        * -- which closes the form -- under some circumstances.
+        *
+        * There have been many github issues reporting this as a bug even though it
+        * was an intended feature.  For this reason, remapping the double-click as
+        * an ESC must be explicitly set when creating this class via the
+        * /p remap_dbl_click parameter of the constructor.
+        */
+
+       if (!m_remap_dbl_click)
+               return false;
+
        if (event.MouseInput.Event == EMIE_LMOUSE_PRESSED_DOWN) {
                m_doubleclickdetect[0].pos  = m_doubleclickdetect[1].pos;
                m_doubleclickdetect[0].time = m_doubleclickdetect[1].time;
@@ -2974,26 +3277,32 @@ bool GUIFormSpecMenu::DoubleClickDetection(const SEvent event)
                delete translated;
                return true;
        }
+
        return false;
 }
 
+void GUIFormSpecMenu::tryClose()
+{
+       if (m_allowclose) {
+               doPause = false;
+               acceptInput(quit_mode_cancel);
+               quitMenu();
+       } else {
+               m_text_dst->gotText(L"MenuQuit");
+       }
+}
+
 bool GUIFormSpecMenu::OnEvent(const SEvent& event)
 {
-       if(event.EventType==EET_KEY_INPUT_EVENT) {
+       if (event.EventType==EET_KEY_INPUT_EVENT) {
                KeyPress kp(event.KeyInput);
                if (event.KeyInput.PressedDown && ( (kp == EscapeKey) ||
-                       (kp == getKeySetting("keymap_inventory")) || (kp == CancelKey))) {
-                       if (m_allowclose) {
-                               doPause = false;
-                               acceptInput(quit_mode_cancel);
-                               quitMenu();
-                       } else {
-                               m_text_dst->gotText(narrow_to_wide("MenuQuit"));
-                       }
+                               (kp == getKeySetting("keymap_inventory")) || (kp == CancelKey))) {
+                       tryClose();
                        return true;
                } else if (m_client != NULL && event.KeyInput.PressedDown &&
-                       (kp == getKeySetting("keymap_screenshot"))) {
-                               m_client->makeScreenshot(m_device);
+                               (kp == getKeySetting("keymap_screenshot"))) {
+                       m_client->makeScreenshot(m_device);
                }
                if (event.KeyInput.PressedDown &&
                        (event.KeyInput.Key==KEY_RETURN ||
@@ -3013,7 +3322,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                break;
                                default:
                                        //can't happen at all!
-                                       assert("reached a source line that can't ever been reached" == 0);
+                                       FATAL_ERROR("Reached a source line that can't ever been reached");
                                        break;
                        }
                        if (current_keys_pending.key_enter && m_allowclose) {
@@ -3044,44 +3353,45 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
 
                Inventory *inv_selected = NULL;
                Inventory *inv_s = NULL;
+               InventoryList *list_s = NULL;
 
-               if(m_selected_item) {
+               if (m_selected_item) {
                        inv_selected = m_invmgr->getInventory(m_selected_item->inventoryloc);
-                       assert(inv_selected);
-                       assert(inv_selected->getList(m_selected_item->listname) != NULL);
+                       sanity_check(inv_selected);
+                       sanity_check(inv_selected->getList(m_selected_item->listname) != NULL);
                }
 
                u32 s_count = 0;
 
-               if(s.isValid())
+               if (s.isValid())
                do { // breakable
                        inv_s = m_invmgr->getInventory(s.inventoryloc);
 
-                       if(!inv_s) {
-                               errorstream<<"InventoryMenu: The selected inventory location "
-                                               <<"\""<<s.inventoryloc.dump()<<"\" doesn't exist"
-                                               <<std::endl;
+                       if (!inv_s) {
+                               errorstream << "InventoryMenu: The selected inventory location "
+                                               << "\"" << s.inventoryloc.dump() << "\" doesn't exist"
+                                               << std::endl;
                                s.i = -1;  // make it invalid again
                                break;
                        }
 
-                       InventoryList *list = inv_s->getList(s.listname);
-                       if(list == NULL) {
-                               verbosestream<<"InventoryMenu: The selected inventory list \""
-                                               <<s.listname<<"\" does not exist"<<std::endl;
+                       list_s = inv_s->getList(s.listname);
+                       if (list_s == NULL) {
+                               verbosestream << "InventoryMenu: The selected inventory list \""
+                                               << s.listname << "\" does not exist" << std::endl;
                                s.i = -1;  // make it invalid again
                                break;
                        }
 
-                       if((u32)s.i >= list->getSize()) {
-                               infostream<<"InventoryMenu: The selected inventory list \""
-                                               <<s.listname<<"\" is too small (i="<<s.i<<", size="
-                                               <<list->getSize()<<")"<<std::endl;
+                       if ((u32)s.i >= list_s->getSize()) {
+                               infostream << "InventoryMenu: The selected inventory list \""
+                                               << s.listname << "\" is too small (i=" << s.i << ", size="
+                                               << list_s->getSize() << ")" << std::endl;
                                s.i = -1;  // make it invalid again
                                break;
                        }
 
-                       s_count = list->getItem(s.i).count;
+                       s_count = list_s->getItem(s.i).count;
                } while(0);
 
                bool identical = (m_selected_item != NULL) && s.isValid() &&
@@ -3093,25 +3403,29 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                // up/down: 0 = down (press), 1 = up (release), 2 = unknown event, -1 movement
                int button = 0;
                int updown = 2;
-               if(event.MouseInput.Event == EMIE_LMOUSE_PRESSED_DOWN)
+               if (event.MouseInput.Event == EMIE_LMOUSE_PRESSED_DOWN)
                        { button = 0; updown = 0; }
-               else if(event.MouseInput.Event == EMIE_RMOUSE_PRESSED_DOWN)
+               else if (event.MouseInput.Event == EMIE_RMOUSE_PRESSED_DOWN)
                        { button = 1; updown = 0; }
-               else if(event.MouseInput.Event == EMIE_MMOUSE_PRESSED_DOWN)
+               else if (event.MouseInput.Event == EMIE_MMOUSE_PRESSED_DOWN)
                        { button = 2; updown = 0; }
-               else if(event.MouseInput.Event == EMIE_LMOUSE_LEFT_UP)
+               else if (event.MouseInput.Event == EMIE_LMOUSE_LEFT_UP)
                        { button = 0; updown = 1; }
-               else if(event.MouseInput.Event == EMIE_RMOUSE_LEFT_UP)
+               else if (event.MouseInput.Event == EMIE_RMOUSE_LEFT_UP)
                        { button = 1; updown = 1; }
-               else if(event.MouseInput.Event == EMIE_MMOUSE_LEFT_UP)
+               else if (event.MouseInput.Event == EMIE_MMOUSE_LEFT_UP)
                        { button = 2; updown = 1; }
-               else if(event.MouseInput.Event == EMIE_MOUSE_MOVED)
+               else if (event.MouseInput.Event == EMIE_MOUSE_MOVED)
                        { updown = -1;}
 
                // Set this number to a positive value to generate a move action
                // from m_selected_item to s.
                u32 move_amount = 0;
 
+               // Set this number to a positive value to generate a move action
+               // from s to the next inventory ring.
+               u32 shift_move_amount = 0;
+
                // Set this number to a positive value to generate a drop action
                // from m_selected_item.
                u32 drop_amount = 0;
@@ -3119,7 +3433,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                // Set this number to a positive value to generate a craft action at s.
                u32 craft_amount = 0;
 
-               if(updown == 0) {
+               if (updown == 0) {
                        // Some mouse button has been pressed
 
                        //infostream<<"Mouse button "<<button<<" pressed at p=("
@@ -3127,40 +3441,49 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
 
                        m_selected_dragging = false;
 
-                       if(s.isValid() && s.listname == "craftpreview") {
+                       if (s.isValid() && s.listname == "craftpreview") {
                                // Craft preview has been clicked: craft
                                craft_amount = (button == 2 ? 10 : 1);
-                       }
-                       else if(m_selected_item == NULL) {
-                               if(s_count != 0) {
-                                       // Non-empty stack has been clicked: select it
+                       } else if (m_selected_item == NULL) {
+                               if (s_count != 0) {
+                                       // Non-empty stack has been clicked: select or shift-move it
                                        m_selected_item = new ItemSpec(s);
 
-                                       if(button == 1)  // right
-                                               m_selected_amount = (s_count + 1) / 2;
-                                       else if(button == 2)  // middle
-                                               m_selected_amount = MYMIN(s_count, 10);
+                                       u32 count;
+                                       if (button == 1)  // right
+                                               count = (s_count + 1) / 2;
+                                       else if (button == 2)  // middle
+                                               count = MYMIN(s_count, 10);
                                        else  // left
-                                               m_selected_amount = s_count;
+                                               count = s_count;
 
-                                       m_selected_dragging = true;
-                                       m_rmouse_auto_place = false;
+                                       if (!event.MouseInput.Shift) {
+                                               // no shift: select item
+                                               m_selected_amount = count;
+                                               m_selected_dragging = true;
+                                               m_rmouse_auto_place = false;
+                                       } else {
+                                               // shift pressed: move item
+                                               if (button != 1)
+                                                       shift_move_amount = count;
+                                               else // count of 1 at left click like after drag & drop
+                                                       shift_move_amount = 1;
+                                       }
                                }
-                       }
-                       else { // m_selected_item != NULL
+                       } else { // m_selected_item != NULL
                                assert(m_selected_amount >= 1);
 
-                               if(s.isValid()) {
+                               if (s.isValid()) {
                                        // Clicked a slot: move
-                                       if(button == 1)  // right
+                                       if (button == 1)  // right
                                                move_amount = 1;
-                                       else if(button == 2)  // middle
+                                       else if (button == 2)  // middle
                                                move_amount = MYMIN(m_selected_amount, 10);
                                        else  // left
                                                move_amount = m_selected_amount;
 
-                                       if(identical) {
-                                               if(move_amount >= m_selected_amount)
+                                       if (identical) {
+                                               if (move_amount >= m_selected_amount)
                                                        m_selected_amount = 0;
                                                else
                                                        m_selected_amount -= move_amount;
@@ -3169,29 +3492,28 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                }
                                else if (!getAbsoluteClippingRect().isPointInside(m_pointer)) {
                                        // Clicked outside of the window: drop
-                                       if(button == 1)  // right
+                                       if (button == 1)  // right
                                                drop_amount = 1;
-                                       else if(button == 2)  // middle
+                                       else if (button == 2)  // middle
                                                drop_amount = MYMIN(m_selected_amount, 10);
                                        else  // left
                                                drop_amount = m_selected_amount;
                                }
                        }
                }
-               else if(updown == 1) {
+               else if (updown == 1) {
                        // Some mouse button has been released
 
                        //infostream<<"Mouse button "<<button<<" released at p=("
                        //      <<p.X<<","<<p.Y<<")"<<std::endl;
 
-                       if(m_selected_item != NULL && m_selected_dragging && s.isValid()) {
-                               if(!identical) {
+                       if (m_selected_item != NULL && m_selected_dragging && s.isValid()) {
+                               if (!identical) {
                                        // Dragged to different slot: move all selected
                                        move_amount = m_selected_amount;
                                }
-                       }
-                       else if(m_selected_item != NULL && m_selected_dragging &&
-                               !(getAbsoluteClippingRect().isPointInside(m_pointer))) {
+                       } else if (m_selected_item != NULL && m_selected_dragging &&
+                                       !(getAbsoluteClippingRect().isPointInside(m_pointer))) {
                                // Dragged outside of window: drop all selected
                                drop_amount = m_selected_amount;
                        }
@@ -3200,14 +3522,13 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        // Keep count of how many times right mouse button has been
                        // clicked. One click is drag without dropping. Click + release
                        // + click changes to drop one item when moved mode
-                       if(button == 1 && m_selected_item != NULL)
+                       if (button == 1 && m_selected_item != NULL)
                                m_rmouse_auto_place = !m_rmouse_auto_place;
-               }
-               else if(updown == -1) {
+               } else if (updown == -1) {
                        // Mouse has been moved and rmb is down and mouse pointer just
                        // entered a new inventory field (checked in the entry-if, this
                        // is the only action here that is generated by mouse movement)
-                       if(m_selected_item != NULL && s.isValid()){
+                       if (m_selected_item != NULL && s.isValid()) {
                                // Move 1 item
                                // TODO: middle mouse to move 10 items might be handy
                                if (m_rmouse_auto_place) {
@@ -3215,7 +3536,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                        // or contains the same item type as what is going to be
                                        // moved
                                        InventoryList *list_from = inv_selected->getList(m_selected_item->listname);
-                                       InventoryList *list_to = inv_s->getList(s.listname);
+                                       InventoryList *list_to = list_s;
                                        assert(list_from && list_to);
                                        ItemStack stack_from = list_from->getItem(m_selected_item->i);
                                        ItemStack stack_to = list_to->getItem(s.i);
@@ -3226,8 +3547,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                }
 
                // Possibly send inventory action to server
-               if(move_amount > 0)
-               {
+               if (move_amount > 0) {
                        // Send IACTION_MOVE
 
                        assert(m_selected_item && m_selected_item->isValid());
@@ -3235,14 +3555,14 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
 
                        assert(inv_selected && inv_s);
                        InventoryList *list_from = inv_selected->getList(m_selected_item->listname);
-                       InventoryList *list_to = inv_s->getList(s.listname);
+                       InventoryList *list_to = list_s;
                        assert(list_from && list_to);
                        ItemStack stack_from = list_from->getItem(m_selected_item->i);
                        ItemStack stack_to = list_to->getItem(s.i);
 
                        // Check how many items can be moved
                        move_amount = stack_from.count = MYMIN(move_amount, stack_from.count);
-                       ItemStack leftover = stack_to.addItem(stack_from, m_gamedef->idef());
+                       ItemStack leftover = stack_to.addItem(stack_from, m_client->idef());
                        // If source stack cannot be added to destination stack at all,
                        // they are swapped
                        if ((leftover.count == stack_from.count) &&
@@ -3254,7 +3574,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                m_selected_content_guess_inventory = s.inventoryloc;
                        }
                        // Source stack goes fully into destination stack
-                       else if(leftover.empty()) {
+                       else if (leftover.empty()) {
                                m_selected_amount -= move_amount;
                                m_selected_content_guess = ItemStack(); // Clear
                        }
@@ -3265,7 +3585,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                m_selected_content_guess = ItemStack(); // Clear
                        }
 
-                       infostream<<"Handing IACTION_MOVE to manager"<<std::endl;
+                       infostream << "Handing IACTION_MOVE to manager" << std::endl;
                        IMoveAction *a = new IMoveAction();
                        a->count = move_amount;
                        a->from_inv = m_selected_item->inventoryloc;
@@ -3275,8 +3595,68 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        a->to_list = s.listname;
                        a->to_i = s.i;
                        m_invmgr->inventoryAction(a);
-               }
-               else if(drop_amount > 0) {
+               } else if (shift_move_amount > 0) {
+                       u32 mis = m_inventory_rings.size();
+                       u32 i = 0;
+                       for (; i < mis; i++) {
+                               const ListRingSpec &sp = m_inventory_rings[i];
+                               if (sp.inventoryloc == s.inventoryloc
+                                               && sp.listname == s.listname)
+                                       break;
+                       }
+                       do {
+                               if (i >= mis) // if not found
+                                       break;
+                               u32 to_inv_ind = (i + 1) % mis;
+                               const ListRingSpec &to_inv_sp = m_inventory_rings[to_inv_ind];
+                               InventoryList *list_from = list_s;
+                               if (!s.isValid())
+                                       break;
+                               Inventory *inv_to = m_invmgr->getInventory(to_inv_sp.inventoryloc);
+                               if (!inv_to)
+                                       break;
+                               InventoryList *list_to = inv_to->getList(to_inv_sp.listname);
+                               if (!list_to)
+                                       break;
+                               ItemStack stack_from = list_from->getItem(s.i);
+                               assert(shift_move_amount <= stack_from.count);
+                               if (m_client->getProtoVersion() >= 25) {
+                                       infostream << "Handing IACTION_MOVE to manager" << std::endl;
+                                       IMoveAction *a = new IMoveAction();
+                                       a->count = shift_move_amount;
+                                       a->from_inv = s.inventoryloc;
+                                       a->from_list = s.listname;
+                                       a->from_i = s.i;
+                                       a->to_inv = to_inv_sp.inventoryloc;
+                                       a->to_list = to_inv_sp.listname;
+                                       a->move_somewhere = true;
+                                       m_invmgr->inventoryAction(a);
+                               } else {
+                                       // find a place (or more than one) to add the new item
+                                       u32 ilt_size = list_to->getSize();
+                                       ItemStack leftover;
+                                       for (u32 slot_to = 0; slot_to < ilt_size
+                                                       && shift_move_amount > 0; slot_to++) {
+                                               list_to->itemFits(slot_to, stack_from, &leftover);
+                                               if (leftover.count < stack_from.count) {
+                                                       infostream << "Handing IACTION_MOVE to manager" << std::endl;
+                                                       IMoveAction *a = new IMoveAction();
+                                                       a->count = MYMIN(shift_move_amount,
+                                                               (u32) (stack_from.count - leftover.count));
+                                                       shift_move_amount -= a->count;
+                                                       a->from_inv = s.inventoryloc;
+                                                       a->from_list = s.listname;
+                                                       a->from_i = s.i;
+                                                       a->to_inv = to_inv_sp.inventoryloc;
+                                                       a->to_list = to_inv_sp.listname;
+                                                       a->to_i = slot_to;
+                                                       m_invmgr->inventoryAction(a);
+                                                       stack_from = leftover;
+                                               }
+                                       }
+                               }
+                       } while (0);
+               } else if (drop_amount > 0) {
                        m_selected_content_guess = ItemStack(); // Clear
 
                        // Send IACTION_DROP
@@ -3292,15 +3672,14 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        assert(drop_amount > 0 && drop_amount <= m_selected_amount);
                        m_selected_amount -= drop_amount;
 
-                       infostream<<"Handing IACTION_DROP to manager"<<std::endl;
+                       infostream << "Handing IACTION_DROP to manager" << std::endl;
                        IDropAction *a = new IDropAction();
                        a->count = drop_amount;
                        a->from_inv = m_selected_item->inventoryloc;
                        a->from_list = m_selected_item->listname;
                        a->from_i = m_selected_item->i;
                        m_invmgr->inventoryAction(a);
-               }
-               else if(craft_amount > 0) {
+               } else if (craft_amount > 0) {
                        m_selected_content_guess = ItemStack(); // Clear
 
                        // Send IACTION_CRAFT
@@ -3308,7 +3687,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        assert(s.isValid());
                        assert(inv_s);
 
-                       infostream<<"Handing IACTION_CRAFT to manager"<<std::endl;
+                       infostream << "Handing IACTION_CRAFT to manager" << std::endl;
                        ICraftAction *a = new ICraftAction();
                        a->count = craft_amount;
                        a->craft_inv = s.inventoryloc;
@@ -3316,7 +3695,7 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                }
 
                // If m_selected_amount has been decreased to zero, deselect
-               if(m_selected_amount == 0) {
+               if (m_selected_amount == 0) {
                        delete m_selected_item;
                        m_selected_item = NULL;
                        m_selected_amount = 0;
@@ -3325,12 +3704,12 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                }
                m_old_pointer = m_pointer;
        }
-       if(event.EventType==EET_GUI_EVENT) {
+       if (event.EventType == EET_GUI_EVENT) {
 
-               if(event.GUIEvent.EventType==gui::EGET_TAB_CHANGED
+               if (event.GUIEvent.EventType == gui::EGET_TAB_CHANGED
                                && isVisible()) {
                        // find the element that was clicked
-                       for(unsigned int i=0; i<m_fields.size(); i++) {
+                       for (unsigned int i=0; i<m_fields.size(); i++) {
                                FieldSpec &s = m_fields[i];
                                if ((s.ftype == f_TabHeader) &&
                                                (s.fid == event.GUIEvent.Caller->getID())) {
@@ -3341,16 +3720,16 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                }
                        }
                }
-               if(event.GUIEvent.EventType==gui::EGET_ELEMENT_FOCUS_LOST
+               if (event.GUIEvent.EventType == gui::EGET_ELEMENT_FOCUS_LOST
                                && isVisible()) {
-                       if(!canTakeFocus(event.GUIEvent.Element)) {
+                       if (!canTakeFocus(event.GUIEvent.Element)) {
                                infostream<<"GUIFormSpecMenu: Not allowing focus change."
                                                <<std::endl;
                                // Returning true disables focus change
                                return true;
                        }
                }
-               if((event.GUIEvent.EventType == gui::EGET_BUTTON_CLICKED) ||
+               if ((event.GUIEvent.EventType == gui::EGET_BUTTON_CLICKED) ||
                                (event.GUIEvent.EventType == gui::EGET_CHECKBOX_CHANGED) ||
                                (event.GUIEvent.EventType == gui::EGET_COMBO_BOX_CHANGED) ||
                                (event.GUIEvent.EventType == gui::EGET_SCROLL_BAR_CHANGED)) {
@@ -3362,26 +3741,26 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                        quitMenu();
                                } else {
                                        acceptInput();
-                                       m_text_dst->gotText(narrow_to_wide("ExitButton"));
+                                       m_text_dst->gotText(L"ExitButton");
                                }
                                // quitMenu deallocates menu
                                return true;
                        }
 
                        // find the element that was clicked
-                       for(u32 i=0; i<m_fields.size(); i++) {
+                       for (u32 i = 0; i < m_fields.size(); i++) {
                                FieldSpec &s = m_fields[i];
                                // if its a button, set the send field so
                                // lua knows which button was pressed
                                if (((s.ftype == f_Button) || (s.ftype == f_CheckBox)) &&
                                                (s.fid == event.GUIEvent.Caller->getID())) {
                                        s.send = true;
-                                       if(s.is_exit) {
+                                       if (s.is_exit) {
                                                if (m_allowclose) {
                                                        acceptInput(quit_mode_accept);
                                                        quitMenu();
                                                } else {
-                                                       m_text_dst->gotText(narrow_to_wide("ExitButton"));
+                                                       m_text_dst->gotText(L"ExitButton");
                                                }
                                                return true;
                                        } else {
@@ -3389,11 +3768,10 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                                                s.send = false;
                                                return true;
                                        }
-                               }
-                               else if ((s.ftype == f_DropDown) &&
+                               } else if ((s.ftype == f_DropDown) &&
                                                (s.fid == event.GUIEvent.Caller->getID())) {
                                        // only send the changed dropdown
-                                       for(u32 i=0; i<m_fields.size(); i++) {
+                                       for (u32 i = 0; i < m_fields.size(); i++) {
                                                FieldSpec &s2 = m_fields[i];
                                                if (s2.ftype == f_DropDown) {
                                                        s2.send = false;
@@ -3404,17 +3782,15 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
 
                                        // revert configuration to make sure dropdowns are sent on
                                        // regular button click
-                                       for(u32 i=0; i<m_fields.size(); i++) {
+                                       for (u32 i = 0; i < m_fields.size(); i++) {
                                                FieldSpec &s2 = m_fields[i];
                                                if (s2.ftype == f_DropDown) {
                                                        s2.send = true;
                                                }
                                        }
                                        return true;
-                               }
-                               else if ((s.ftype == f_ScrollBar) &&
-                                       (s.fid == event.GUIEvent.Caller->getID()))
-                               {
+                               } else if ((s.ftype == f_ScrollBar) &&
+                                               (s.fid == event.GUIEvent.Caller->getID())) {
                                        s.fdefault = L"Changed";
                                        acceptInput(quit_mode_no);
                                        s.fdefault = L"";
@@ -3422,10 +3798,25 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        }
                }
 
-               if(event.GUIEvent.EventType == gui::EGET_EDITBOX_ENTER) {
-                       if(event.GUIEvent.Caller->getID() > 257) {
+               if (event.GUIEvent.EventType == gui::EGET_EDITBOX_ENTER) {
+                       if (event.GUIEvent.Caller->getID() > 257) {
+                               bool close_on_enter = true;
+                               for (u32 i = 0; i < m_fields.size(); i++) {
+                                       FieldSpec &s = m_fields[i];
+                                       if (s.ftype == f_Unknown &&
+                                                       s.fid == event.GUIEvent.Caller->getID()) {
+                                               current_field_enter_pending = s.fname;
+                                               UNORDERED_MAP<std::string, bool>::const_iterator it =
+                                                       field_close_on_enter.find(s.fname);
+                                               if (it != field_close_on_enter.end())
+                                                       close_on_enter = (*it).second;
+
+                                               break;
+                                       }
+                               }
 
-                               if (m_allowclose) {
+                               if (m_allowclose && close_on_enter) {
+                                       current_keys_pending.key_enter = true;
                                        acceptInput(quit_mode_accept);
                                        quitMenu();
                                } else {
@@ -3437,11 +3828,11 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
                        }
                }
 
-               if(event.GUIEvent.EventType == gui::EGET_TABLE_CHANGED) {
+               if (event.GUIEvent.EventType == gui::EGET_TABLE_CHANGED) {
                        int current_id = event.GUIEvent.Caller->getID();
-                       if(current_id > 257) {
+                       if (current_id > 257) {
                                // find the element that was clicked
-                               for(u32 i=0; i<m_fields.size(); i++) {
+                               for (u32 i = 0; i < m_fields.size(); i++) {
                                        FieldSpec &s = m_fields[i];
                                        // if it's a table, set the send field
                                        // so lua knows which table was changed
@@ -3464,15 +3855,15 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event)
  * @param id of element
  * @return name string or empty string
  */
-std::wstring GUIFormSpecMenu::getNameByID(s32 id)
+std::string GUIFormSpecMenu::getNameByID(s32 id)
 {
        for(std::vector<FieldSpec>::iterator iter =  m_fields.begin();
-                               iter != m_fields.end(); iter++) {
+                               iter != m_fields.end(); ++iter) {
                if (iter->fid == id) {
                        return iter->fname;
                }
        }
-       return L"";
+       return "";
 }
 
 /**
@@ -3483,7 +3874,7 @@ std::wstring GUIFormSpecMenu::getNameByID(s32 id)
 std::wstring GUIFormSpecMenu::getLabelByID(s32 id)
 {
        for(std::vector<FieldSpec>::iterator iter =  m_fields.begin();
-                               iter != m_fields.end(); iter++) {
+                               iter != m_fields.end(); ++iter) {
                if (iter->fid == id) {
                        return iter->flabel;
                }