- Clear colors when reading property info.
[oweals/minetest.git] / src / content_cao.cpp
index 5bf4d8e9ccd3e905beb7b4a1d4d8218d749e0732..a8b4ae2e1e830d26854d7d01bff00bab236f85f0 100644 (file)
@@ -22,17 +22,15 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include <IBillboardSceneNode.h>
 #include <IMeshManipulator.h>
 #include <IAnimatedMeshSceneNode.h>
-#include <IBoneSceneNode.h>
 #include "content_cao.h"
 #include "util/numeric.h" // For IntervalLimiter
 #include "util/serialize.h"
-#include "util/mathconstants.h"
+#include "util/basic_macros.h"
 #include "client/tile.h"
 #include "environment.h"
 #include "collision.h"
 #include "settings.h"
 #include "serialization.h" // For decompressZlib
-#include "gamedef.h"
 #include "clientobject.h"
 #include "mesh.h"
 #include "itemdef.h"
@@ -43,25 +41,15 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "localplayer.h"
 #include "map.h"
 #include "camera.h" // CameraModes
+#include "client.h"
 #include "wieldmesh.h"
-#include "log.h"
+#include <algorithm>
+#include "client/renderingengine.h"
 
 class Settings;
 struct ToolCapabilities;
 
-#define PP(x) "("<<(x).X<<","<<(x).Y<<","<<(x).Z<<")"
-
-std::map<u16, ClientActiveObject::Factory> ClientActiveObject::m_types;
-
-SmoothTranslator::SmoothTranslator():
-       vect_old(0,0,0),
-       vect_show(0,0,0),
-       vect_aim(0,0,0),
-       anim_counter(0),
-       anim_time(0),
-       anim_time_counter(0),
-       aim_is_end(true)
-{}
+std::unordered_map<u16, ClientActiveObject::Factory> ClientActiveObject::m_types;
 
 void SmoothTranslator::init(v3f vect)
 {
@@ -74,11 +62,6 @@ void SmoothTranslator::init(v3f vect)
        aim_is_end = true;
 }
 
-void SmoothTranslator::sharpen()
-{
-       init(vect_show);
-}
-
 void SmoothTranslator::update(v3f vect_new, bool is_end_position, float update_interval)
 {
        aim_is_end = is_end_position;
@@ -115,11 +98,6 @@ void SmoothTranslator::translate(f32 dtime)
        vect_show = vect_old + vect_move * moveratio;
 }
 
-bool SmoothTranslator::is_moving()
-{
-       return ((anim_time_counter / anim_time) < 1.4);
-}
-
 /*
        Other stuff
 */
@@ -140,18 +118,17 @@ static void setBillboardTextureMatrix(scene::IBillboardSceneNode *bill,
 class TestCAO : public ClientActiveObject
 {
 public:
-       TestCAO(IGameDef *gamedef, ClientEnvironment *env);
-       virtual ~TestCAO();
-       
+       TestCAO(Client *client, ClientEnvironment *env);
+       virtual ~TestCAO() = default;
+
        ActiveObjectType getType() const
        {
                return ACTIVEOBJECT_TYPE_TEST;
        }
-       
-       static ClientActiveObject* create(IGameDef *gamedef, ClientEnvironment *env);
 
-       void addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
-                       IrrlichtDevice *irr);
+       static ClientActiveObject* create(Client *client, ClientEnvironment *env);
+
+       void addToScene(ITextureSource *tsrc);
        void removeFromScene(bool permanent);
        void updateLight(u8 light_at_pos);
        v3s16 getLightPosition();
@@ -161,7 +138,7 @@ public:
 
        void processMessage(const std::string &data);
 
-       bool getCollisionBox(aabb3f *toset) { return false; }
+       bool getCollisionBox(aabb3f *toset) const { return false; }
 private:
        scene::IMeshSceneNode *m_node;
        v3f m_position;
@@ -170,31 +147,26 @@ private:
 // Prototype
 TestCAO proto_TestCAO(NULL, NULL);
 
-TestCAO::TestCAO(IGameDef *gamedef, ClientEnvironment *env):
-       ClientActiveObject(0, gamedef, env),
+TestCAO::TestCAO(Client *client, ClientEnvironment *env):
+       ClientActiveObject(0, client, env),
        m_node(NULL),
        m_position(v3f(0,10*BS,0))
 {
        ClientActiveObject::registerType(getType(), create);
 }
 
-TestCAO::~TestCAO()
+ClientActiveObject* TestCAO::create(Client *client, ClientEnvironment *env)
 {
+       return new TestCAO(client, env);
 }
 
-ClientActiveObject* TestCAO::create(IGameDef *gamedef, ClientEnvironment *env)
-{
-       return new TestCAO(gamedef, env);
-}
-
-void TestCAO::addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
-                       IrrlichtDevice *irr)
+void TestCAO::addToScene(ITextureSource *tsrc)
 {
        if(m_node != NULL)
                return;
-       
+
        //video::IVideoDriver* driver = smgr->getVideoDriver();
-       
+
        scene::SMesh *mesh = new scene::SMesh();
        scene::IMeshBuffer *buf = new scene::SMeshBuffer();
        video::SColor c(255,255,255,255);
@@ -217,14 +189,14 @@ void TestCAO::addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
        // Add to mesh
        mesh->addMeshBuffer(buf);
        buf->drop();
-       m_node = smgr->addMeshSceneNode(mesh, NULL);
+       m_node = RenderingEngine::get_scene_manager()->addMeshSceneNode(mesh, NULL);
        mesh->drop();
        updateNodePos();
 }
 
 void TestCAO::removeFromScene(bool permanent)
 {
-       if(m_node == NULL)
+       if (!m_node)
                return;
 
        m_node->remove();
@@ -242,7 +214,7 @@ v3s16 TestCAO::getLightPosition()
 
 void TestCAO::updateNodePos()
 {
-       if(m_node == NULL)
+       if (!m_node)
                return;
 
        m_node->setPosition(m_position);
@@ -277,315 +249,23 @@ void TestCAO::processMessage(const std::string &data)
        }
 }
 
-/*
-       ItemCAO
-*/
-
-class ItemCAO : public ClientActiveObject
-{
-public:
-       ItemCAO(IGameDef *gamedef, ClientEnvironment *env);
-       virtual ~ItemCAO();
-       
-       ActiveObjectType getType() const
-       {
-               return ACTIVEOBJECT_TYPE_ITEM;
-       }
-       
-       static ClientActiveObject* create(IGameDef *gamedef, ClientEnvironment *env);
-
-       void addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
-                       IrrlichtDevice *irr);
-       void removeFromScene(bool permanent);
-       void updateLight(u8 light_at_pos);
-       v3s16 getLightPosition();
-       void updateNodePos();
-       void updateInfoText();
-       void updateTexture();
-
-       void step(float dtime, ClientEnvironment *env);
-
-       void processMessage(const std::string &data);
-
-       void initialize(const std::string &data);
-       
-       core::aabbox3d<f32>* getSelectionBox()
-               {return &m_selection_box;}
-       v3f getPosition()
-               {return m_position;}
-       
-       std::string infoText()
-               {return m_infotext;}
-
-       bool getCollisionBox(aabb3f *toset) { return false; }
-private:
-       core::aabbox3d<f32> m_selection_box;
-       scene::IMeshSceneNode *m_node;
-       v3f m_position;
-       std::string m_itemstring;
-       std::string m_infotext;
-};
-
-#include "inventory.h"
-
-// Prototype
-ItemCAO proto_ItemCAO(NULL, NULL);
-
-ItemCAO::ItemCAO(IGameDef *gamedef, ClientEnvironment *env):
-       ClientActiveObject(0, gamedef, env),
-       m_selection_box(-BS/3.,0.0,-BS/3., BS/3.,BS*2./3.,BS/3.),
-       m_node(NULL),
-       m_position(v3f(0,10*BS,0))
-{
-       if(!gamedef && !env)
-       {
-               ClientActiveObject::registerType(getType(), create);
-       }
-}
-
-ItemCAO::~ItemCAO()
-{
-}
-
-ClientActiveObject* ItemCAO::create(IGameDef *gamedef, ClientEnvironment *env)
-{
-       return new ItemCAO(gamedef, env);
-}
-
-void ItemCAO::addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
-                       IrrlichtDevice *irr)
-{
-       if(m_node != NULL)
-               return;
-       
-       //video::IVideoDriver* driver = smgr->getVideoDriver();
-       
-       scene::SMesh *mesh = new scene::SMesh();
-       scene::IMeshBuffer *buf = new scene::SMeshBuffer();
-       video::SColor c(255,255,255,255);
-       video::S3DVertex vertices[4] =
-       {
-               /*video::S3DVertex(-BS/2,-BS/4,0, 0,0,0, c, 0,1),
-               video::S3DVertex(BS/2,-BS/4,0, 0,0,0, c, 1,1),
-               video::S3DVertex(BS/2,BS/4,0, 0,0,0, c, 1,0),
-               video::S3DVertex(-BS/2,BS/4,0, 0,0,0, c, 0,0),*/
-               video::S3DVertex(BS/3.,0,0, 0,0,0, c, 0,1),
-               video::S3DVertex(-BS/3.,0,0, 0,0,0, c, 1,1),
-               video::S3DVertex(-BS/3.,0+BS*2./3.,0, 0,0,0, c, 1,0),
-               video::S3DVertex(BS/3.,0+BS*2./3.,0, 0,0,0, c, 0,0),
-       };
-       u16 indices[] = {0,1,2,2,3,0};
-       buf->append(vertices, 4, indices, 6);
-       // Set material
-       buf->getMaterial().setFlag(video::EMF_LIGHTING, false);
-       buf->getMaterial().setFlag(video::EMF_BACK_FACE_CULLING, false);
-       // Initialize with a generated placeholder texture
-       buf->getMaterial().setTexture(0, tsrc->getTexture(""));
-       buf->getMaterial().setFlag(video::EMF_BILINEAR_FILTER, false);
-       buf->getMaterial().setFlag(video::EMF_FOG_ENABLE, true);
-       buf->getMaterial().MaterialType = video::EMT_TRANSPARENT_ALPHA_CHANNEL;
-       // Add to mesh
-       mesh->addMeshBuffer(buf);
-       buf->drop();
-       m_node = smgr->addMeshSceneNode(mesh, NULL);
-       mesh->drop();
-       updateNodePos();
-
-       /*
-               Update image of node
-       */
-
-       updateTexture();
-}
-
-void ItemCAO::removeFromScene(bool permanent)
-{
-       if(m_node == NULL)
-               return;
-
-       m_node->remove();
-       m_node = NULL;
-}
-
-void ItemCAO::updateLight(u8 light_at_pos)
-{
-       if(m_node == NULL)
-               return;
-
-       u8 li = decode_light(light_at_pos);
-       video::SColor color(255,li,li,li);
-       setMeshColor(m_node->getMesh(), color);
-}
-
-v3s16 ItemCAO::getLightPosition()
-{
-       return floatToInt(m_position + v3f(0,0.5*BS,0), BS);
-}
-
-void ItemCAO::updateNodePos()
-{
-       if(m_node == NULL)
-               return;
-
-       m_node->setPosition(m_position);
-}
-
-void ItemCAO::updateInfoText()
-{
-       try{
-               IItemDefManager *idef = m_gamedef->idef();
-               ItemStack item;
-               item.deSerialize(m_itemstring, idef);
-               if(item.isKnown(idef))
-                       m_infotext = item.getDefinition(idef).description;
-               else
-                       m_infotext = "Unknown item: '" + m_itemstring + "'";
-               if(item.count >= 2)
-                       m_infotext += " (" + itos(item.count) + ")";
-       }
-       catch(SerializationError &e)
-       {
-               m_infotext = "Unknown item: '" + m_itemstring + "'";
-       }
-}
-
-void ItemCAO::updateTexture()
-{
-       if(m_node == NULL)
-               return;
-
-       // Create an inventory item to see what is its image
-       std::istringstream is(m_itemstring, std::ios_base::binary);
-       video::ITexture *texture = NULL;
-       try{
-               IItemDefManager *idef = m_gamedef->idef();
-               ItemStack item;
-               item.deSerialize(is, idef);
-               texture = idef->getInventoryTexture(item.getDefinition(idef).name, m_gamedef);
-       }
-       catch(SerializationError &e)
-       {
-               infostream<<"WARNING: "<<__FUNCTION_NAME
-                               <<": error deSerializing itemstring \""
-                               <<m_itemstring<<std::endl;
-       }
-       
-       // Set meshbuffer texture
-       m_node->getMaterial(0).setTexture(0, texture);
-}
-
-
-void ItemCAO::step(float dtime, ClientEnvironment *env)
-{
-       if(m_node)
-       {
-               /*v3f rot = m_node->getRotation();
-               rot.Y += dtime * 120;
-               m_node->setRotation(rot);*/
-               LocalPlayer *player = env->getLocalPlayer();
-               assert(player);
-               v3f rot = m_node->getRotation();
-               rot.Y = 180.0 - (player->getYaw());
-               m_node->setRotation(rot);
-       }
-}
-
-void ItemCAO::processMessage(const std::string &data)
-{
-       //infostream<<"ItemCAO: Got message"<<std::endl;
-       std::istringstream is(data, std::ios::binary);
-       // command
-       u8 cmd = readU8(is);
-       if(cmd == 0)
-       {
-               // pos
-               m_position = readV3F1000(is);
-               updateNodePos();
-       }
-       if(cmd == 1)
-       {
-               // itemstring
-               m_itemstring = deSerializeString(is);
-               updateInfoText();
-               updateTexture();
-       }
-}
-
-void ItemCAO::initialize(const std::string &data)
-{
-       infostream<<"ItemCAO: Got init data"<<std::endl;
-       
-       {
-               std::istringstream is(data, std::ios::binary);
-               // version
-               u8 version = readU8(is);
-               // check version
-               if(version != 0)
-                       return;
-               // pos
-               m_position = readV3F1000(is);
-               // itemstring
-               m_itemstring = deSerializeString(is);
-       }
-       
-       updateNodePos();
-       updateInfoText();
-}
-
 /*
        GenericCAO
 */
 
 #include "genericobject.h"
 
-GenericCAO::GenericCAO(IGameDef *gamedef, ClientEnvironment *env):
-               ClientActiveObject(0, gamedef, env),
-               //
-               m_is_player(false),
-               m_is_local_player(false),
-               m_id(0),
-               //
-               m_smgr(NULL),
-               m_irr(NULL),
-               m_selection_box(-BS/3.,-BS/3.,-BS/3., BS/3.,BS/3.,BS/3.),
-               m_meshnode(NULL),
-               m_animated_meshnode(NULL),
-               m_wield_meshnode(NULL),
-               m_spritenode(NULL),
-               m_nametag_color(video::SColor(255, 255, 255, 255)),
-               m_textnode(NULL),
-               m_position(v3f(0,10*BS,0)),
-               m_velocity(v3f(0,0,0)),
-               m_acceleration(v3f(0,0,0)),
-               m_yaw(0),
-               m_hp(1),
-               m_tx_size(1,1),
-               m_tx_basepos(0,0),
-               m_initial_tx_basepos_set(false),
-               m_tx_select_horiz_by_yawpitch(false),
-               m_animation_range(v2s32(0,0)),
-               m_animation_speed(15),
-               m_animation_blend(0),
-               m_bone_position(std::map<std::string, core::vector2d<v3f> >()),
-               m_attachment_bone(""),
-               m_attachment_position(v3f(0,0,0)),
-               m_attachment_rotation(v3f(0,0,0)),
-               m_attached_to_local(false),
-               m_anim_frame(0),
-               m_anim_num_frames(1),
-               m_anim_framelength(0.2),
-               m_anim_timer(0),
-               m_reset_textures_timer(-1),
-               m_visuals_expired(false),
-               m_step_distance_counter(0),
-               m_last_light(255),
-               m_is_visible(false)
+GenericCAO::GenericCAO(Client *client, ClientEnvironment *env):
+               ClientActiveObject(0, client, env)
 {
-       if(gamedef == NULL)
+       if (client == NULL) {
                ClientActiveObject::registerType(getType(), create);
+       } else {
+               m_client = client;
+       }
 }
 
-bool GenericCAO::getCollisionBox(aabb3f *toset)
+bool GenericCAO::getCollisionBox(aabb3f *toset) const
 {
        if (m_prop.physical)
        {
@@ -602,7 +282,7 @@ bool GenericCAO::getCollisionBox(aabb3f *toset)
        return false;
 }
 
-bool GenericCAO::collideWithObjects()
+bool GenericCAO::collideWithObjects() const
 {
        return m_prop.collideWithObjects;
 }
@@ -610,76 +290,62 @@ bool GenericCAO::collideWithObjects()
 void GenericCAO::initialize(const std::string &data)
 {
        infostream<<"GenericCAO: Got init data"<<std::endl;
+       processInitData(data);
+
+       if (m_is_player) {
+               // Check if it's the current player
+               LocalPlayer *player = m_env->getLocalPlayer();
+               if (player && strcmp(player->getName(), m_name.c_str()) == 0) {
+                       m_is_local_player = true;
+                       m_is_visible = false;
+                       player->setCAO(this);
+               }
+       }
+}
+
+void GenericCAO::processInitData(const std::string &data)
+{
        std::istringstream is(data, std::ios::binary);
        int num_messages = 0;
        // version
        u8 version = readU8(is);
        // check version
-       if(version == 1) // In PROTOCOL_VERSION 14
-       {
-               m_name = deSerializeString(is);
-               m_is_player = readU8(is);
-               m_id = readS16(is);
-               m_position = readV3F1000(is);
-               m_yaw = readF1000(is);
-               m_hp = readS16(is);
-               num_messages = readU8(is);
-       }
-       else if(version == 0) // In PROTOCOL_VERSION 13
-       {
+       if (version == 1) { // In PROTOCOL_VERSION 14
                m_name = deSerializeString(is);
                m_is_player = readU8(is);
+               m_id = readU16(is);
                m_position = readV3F1000(is);
                m_yaw = readF1000(is);
                m_hp = readS16(is);
                num_messages = readU8(is);
-       }
-       else
-       {
+       } else {
                errorstream<<"GenericCAO: Unsupported init data version"
                                <<std::endl;
                return;
        }
 
-       for(int i=0; i<num_messages; i++)
-       {
+       for (int i = 0; i < num_messages; i++) {
                std::string message = deSerializeLongString(is);
                processMessage(message);
        }
 
        pos_translator.init(m_position);
        updateNodePos();
-
-       if(m_is_player)
-       {
-               Player *player = m_env->getPlayer(m_name.c_str());
-               if(player && player->isLocal())
-               {
-                       m_is_local_player = true;
-                       m_is_visible = false;
-                       LocalPlayer* localplayer = dynamic_cast<LocalPlayer*>(player);
-
-                       assert( localplayer != NULL );
-                       localplayer->setCAO(this);
-               }
-               m_env->addPlayerName(m_name.c_str());
-       }
 }
 
 GenericCAO::~GenericCAO()
 {
-       if(m_is_player)
-       {
-               m_env->removePlayerName(m_name.c_str());
-       }
        removeFromScene(true);
 }
 
-core::aabbox3d<f32>* GenericCAO::getSelectionBox()
+bool GenericCAO::getSelectionBox(aabb3f *toset) const
 {
-       if(!m_prop.is_visible || !m_is_visible || m_is_local_player || getParent() != NULL)
-               return NULL;
-       return &m_selection_box;
+       if (!m_prop.is_visible || !m_is_visible || m_is_local_player
+                       || !m_prop.pointable || getParent() != NULL) {
+               return false;
+       }
+       *toset = m_selection_box;
+       return true;
 }
 
 v3f GenericCAO::getPosition()
@@ -688,43 +354,45 @@ v3f GenericCAO::getPosition()
                scene::ISceneNode *node = getSceneNode();
                if (node)
                        return node->getAbsolutePosition();
-               else
-                       return m_position;
+
+               return m_position;
        }
        return pos_translator.vect_show;
 }
 
 scene::ISceneNode* GenericCAO::getSceneNode()
 {
-       if (m_meshnode)
+       if (m_meshnode) {
                return m_meshnode;
-       if (m_animated_meshnode)
+       }
+
+       if (m_animated_meshnode) {
                return m_animated_meshnode;
-       if (m_wield_meshnode)
+       }
+
+       if (m_wield_meshnode) {
                return m_wield_meshnode;
-       if (m_spritenode)
+       }
+
+       if (m_spritenode) {
                return m_spritenode;
+       }
        return NULL;
 }
 
-scene::IMeshSceneNode* GenericCAO::getMeshSceneNode()
-{
-       return m_meshnode;
-}
-
 scene::IAnimatedMeshSceneNode* GenericCAO::getAnimatedMeshSceneNode()
 {
        return m_animated_meshnode;
 }
 
-WieldMeshSceneNode* GenericCAO::getWieldMeshSceneNode()
+void GenericCAO::setChildrenVisible(bool toset)
 {
-       return m_wield_meshnode;
-}
-
-scene::IBillboardSceneNode* GenericCAO::getSpriteSceneNode()
-{
-       return m_spritenode;
+       for (u16 cao_id : m_children) {
+               GenericCAO *obj = m_env->getGenericCAO(cao_id);
+               if (obj) {
+                       obj->setVisible(toset);
+               }
+       }
 }
 
 void GenericCAO::setAttachments()
@@ -732,11 +400,11 @@ void GenericCAO::setAttachments()
        updateAttachments();
 }
 
-ClientActiveObject* GenericCAO::getParent()
+ClientActiveObject* GenericCAO::getParent() const
 {
        ClientActiveObject *obj = NULL;
 
-       u16 attached_id = m_env->m_attachements[getId()];
+       u16 attached_id = m_env->attachement_parent_ids[getId()];
 
        if ((attached_id != 0) &&
                        (attached_id != getId())) {
@@ -748,18 +416,16 @@ ClientActiveObject* GenericCAO::getParent()
 void GenericCAO::removeFromScene(bool permanent)
 {
        // Should be true when removing the object permanently and false when refreshing (eg: updating visuals)
-       if((m_env != NULL) && (permanent)) 
+       if((m_env != NULL) && (permanent))
        {
-               for(std::vector<u16>::iterator ci = m_children.begin();
-                                               ci != m_children.end(); ci++)
-               {
-                       if (m_env->m_attachements[*ci] == getId()) {
-                               m_env->m_attachements[*ci] = 0;
+               for (u16 ci : m_children) {
+                       if (m_env->attachement_parent_ids[ci] == getId()) {
+                               m_env->attachement_parent_ids[ci] = 0;
                        }
                }
 
-               m_env->m_attachements[getId()] = 0;
-               
+               m_env->attachement_parent_ids[getId()] = 0;
+
                LocalPlayer* player = m_env->getLocalPlayer();
                if (this == player->parent) {
                        player->parent = NULL;
@@ -767,58 +433,47 @@ void GenericCAO::removeFromScene(bool permanent)
                }
        }
 
-       if(m_meshnode)
-       {
+       if (m_meshnode) {
                m_meshnode->remove();
                m_meshnode->drop();
                m_meshnode = NULL;
-       }
-       if(m_animated_meshnode)
-       {
+       } else if (m_animated_meshnode) {
                m_animated_meshnode->remove();
                m_animated_meshnode->drop();
                m_animated_meshnode = NULL;
-       }
-       if(m_wield_meshnode)
-       {
+       } else if (m_wield_meshnode) {
                m_wield_meshnode->remove();
                m_wield_meshnode->drop();
                m_wield_meshnode = NULL;
-       }
-       if(m_spritenode)
-       {
+       } else if (m_spritenode) {
                m_spritenode->remove();
                m_spritenode->drop();
                m_spritenode = NULL;
        }
-       if (m_textnode)
-       {
-               m_textnode->remove();
-               m_textnode->drop();
-               m_textnode = NULL;
+
+       if (m_nametag) {
+               m_client->getCamera()->removeNametag(m_nametag);
+               m_nametag = NULL;
        }
 }
 
-void GenericCAO::addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
-               IrrlichtDevice *irr)
+void GenericCAO::addToScene(ITextureSource *tsrc)
 {
-       m_smgr = smgr;
-       m_irr = irr;
+       m_smgr = RenderingEngine::get_scene_manager();
 
-       if (getSceneNode() != NULL)
+       if (getSceneNode() != NULL) {
                return;
+       }
 
        m_visuals_expired = false;
 
-       if(!m_prop.is_visible)
+       if (!m_prop.is_visible) {
                return;
+       }
 
-       //video::IVideoDriver* driver = smgr->getVideoDriver();
-
-       if(m_prop.visual == "sprite")
-       {
+       if (m_prop.visual == "sprite") {
                infostream<<"GenericCAO::addToScene(): single_sprite"<<std::endl;
-               m_spritenode = smgr->addBillboardSceneNode(
+               m_spritenode = RenderingEngine::get_scene_manager()->addBillboardSceneNode(
                                NULL, v2f(1, 1), v3f(0,0,0), -1);
                m_spritenode->grab();
                m_spritenode->setMaterialTexture(0,
@@ -836,56 +491,52 @@ void GenericCAO::addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
                        setBillboardTextureMatrix(m_spritenode,
                                        txs, tys, 0, 0);
                }
-       }
-       else if(m_prop.visual == "upright_sprite") {
+       } else if (m_prop.visual == "upright_sprite") {
                scene::SMesh *mesh = new scene::SMesh();
-               double dx = BS*m_prop.visual_size.X/2;
-               double dy = BS*m_prop.visual_size.Y/2;
-               { // Front
-               scene::IMeshBuffer *buf = new scene::SMeshBuffer();
+               double dx = BS * m_prop.visual_size.X / 2;
+               double dy = BS * m_prop.visual_size.Y / 2;
                u8 li = m_last_light;
-               video::SColor c(255,li,li,li);
-               video::S3DVertex vertices[4] =
-               {
-                       video::S3DVertex(-dx,-dy,0, 0,0,0, c, 0,1),
-                       video::S3DVertex(dx,-dy,0, 0,0,0, c, 1,1),
-                       video::S3DVertex(dx,dy,0, 0,0,0, c, 1,0),
-                       video::S3DVertex(-dx,dy,0, 0,0,0, c, 0,0),
-               };
-               u16 indices[] = {0,1,2,2,3,0};
-               buf->append(vertices, 4, indices, 6);
-               // Set material
-               buf->getMaterial().setFlag(video::EMF_LIGHTING, false);
-               buf->getMaterial().setFlag(video::EMF_BILINEAR_FILTER, false);
-               buf->getMaterial().setFlag(video::EMF_FOG_ENABLE, true);
-               buf->getMaterial().MaterialType = video::EMT_TRANSPARENT_ALPHA_CHANNEL;
-               // Add to mesh
-               mesh->addMeshBuffer(buf);
-               buf->drop();
+               video::SColor c(255, li, li, li);
+
+               { // Front
+                       scene::IMeshBuffer *buf = new scene::SMeshBuffer();
+                       video::S3DVertex vertices[4] = {
+                               video::S3DVertex(-dx, -dy, 0, 0,0,0, c, 1,1),
+                               video::S3DVertex( dx, -dy, 0, 0,0,0, c, 0,1),
+                               video::S3DVertex( dx,  dy, 0, 0,0,0, c, 0,0),
+                               video::S3DVertex(-dx,  dy, 0, 0,0,0, c, 1,0),
+                       };
+                       u16 indices[] = {0,1,2,2,3,0};
+                       buf->append(vertices, 4, indices, 6);
+                       // Set material
+                       buf->getMaterial().setFlag(video::EMF_LIGHTING, false);
+                       buf->getMaterial().setFlag(video::EMF_BILINEAR_FILTER, false);
+                       buf->getMaterial().setFlag(video::EMF_FOG_ENABLE, true);
+                       buf->getMaterial().MaterialType = video::EMT_TRANSPARENT_ALPHA_CHANNEL;
+                       // Add to mesh
+                       mesh->addMeshBuffer(buf);
+                       buf->drop();
                }
                { // Back
-               scene::IMeshBuffer *buf = new scene::SMeshBuffer();
-               u8 li = m_last_light;
-               video::SColor c(255,li,li,li);
-               video::S3DVertex vertices[4] =
-               {
-                       video::S3DVertex(dx,-dy,0, 0,0,0, c, 1,1),
-                       video::S3DVertex(-dx,-dy,0, 0,0,0, c, 0,1),
-                       video::S3DVertex(-dx,dy,0, 0,0,0, c, 0,0),
-                       video::S3DVertex(dx,dy,0, 0,0,0, c, 1,0),
-               };
-               u16 indices[] = {0,1,2,2,3,0};
-               buf->append(vertices, 4, indices, 6);
-               // Set material
-               buf->getMaterial().setFlag(video::EMF_LIGHTING, false);
-               buf->getMaterial().setFlag(video::EMF_BILINEAR_FILTER, false);
-               buf->getMaterial().setFlag(video::EMF_FOG_ENABLE, true);
-               buf->getMaterial().MaterialType = video::EMT_TRANSPARENT_ALPHA_CHANNEL_REF;
-               // Add to mesh
-               mesh->addMeshBuffer(buf);
-               buf->drop();
+                       scene::IMeshBuffer *buf = new scene::SMeshBuffer();
+                       video::S3DVertex vertices[4] = {
+                               video::S3DVertex( dx,-dy, 0, 0,0,0, c, 1,1),
+                               video::S3DVertex(-dx,-dy, 0, 0,0,0, c, 0,1),
+                               video::S3DVertex(-dx, dy, 0, 0,0,0, c, 0,0),
+                               video::S3DVertex( dx, dy, 0, 0,0,0, c, 1,0),
+                       };
+                       u16 indices[] = {0,1,2,2,3,0};
+                       buf->append(vertices, 4, indices, 6);
+                       // Set material
+                       buf->getMaterial().setFlag(video::EMF_LIGHTING, false);
+                       buf->getMaterial().setFlag(video::EMF_BILINEAR_FILTER, false);
+                       buf->getMaterial().setFlag(video::EMF_FOG_ENABLE, true);
+                       buf->getMaterial().MaterialType = video::EMT_TRANSPARENT_ALPHA_CHANNEL_REF;
+                       // Add to mesh
+                       mesh->addMeshBuffer(buf);
+                       buf->drop();
                }
-               m_meshnode = smgr->addMeshSceneNode(mesh, NULL);
+               m_meshnode = RenderingEngine::get_scene_manager()->addMeshSceneNode(mesh, NULL);
                m_meshnode->grab();
                mesh->drop();
                // Set it to use the materials of the meshbuffers directly.
@@ -895,10 +546,10 @@ void GenericCAO::addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
        else if(m_prop.visual == "cube") {
                infostream<<"GenericCAO::addToScene(): cube"<<std::endl;
                scene::IMesh *mesh = createCubeMesh(v3f(BS,BS,BS));
-               m_meshnode = smgr->addMeshSceneNode(mesh, NULL);
+               m_meshnode = RenderingEngine::get_scene_manager()->addMeshSceneNode(mesh, NULL);
                m_meshnode->grab();
                mesh->drop();
-               
+
                m_meshnode->setScale(v3f(m_prop.visual_size.X,
                                m_prop.visual_size.Y,
                                m_prop.visual_size.X));
@@ -912,10 +563,11 @@ void GenericCAO::addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
        }
        else if(m_prop.visual == "mesh") {
                infostream<<"GenericCAO::addToScene(): mesh"<<std::endl;
-               scene::IAnimatedMesh *mesh = m_gamedef->getMesh(m_prop.mesh);
+               scene::IAnimatedMesh *mesh = m_client->getMesh(m_prop.mesh, true);
                if(mesh)
                {
-                       m_animated_meshnode = smgr->addAnimatedMeshSceneNode(mesh, NULL);
+                       m_animated_meshnode = RenderingEngine::get_scene_manager()->
+                               addAnimatedMeshSceneNode(mesh, NULL);
                        m_animated_meshnode->grab();
                        mesh->drop(); // The scene node took hold of it
                        m_animated_meshnode->animateJoints(); // Needed for some animations
@@ -923,49 +575,66 @@ void GenericCAO::addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
                                        m_prop.visual_size.Y,
                                        m_prop.visual_size.X));
                        u8 li = m_last_light;
+
+                       // set vertex colors to ensure alpha is set
                        setMeshColor(m_animated_meshnode->getMesh(), video::SColor(255,li,li,li));
 
-                       m_animated_meshnode->setMaterialFlag(video::EMF_LIGHTING, false);
+                       setAnimatedMeshColor(m_animated_meshnode, video::SColor(255,li,li,li));
+
+                       bool backface_culling = m_prop.backface_culling;
+                       if (m_is_player)
+                               backface_culling = false;
+
+                       m_animated_meshnode->setMaterialFlag(video::EMF_LIGHTING, true);
                        m_animated_meshnode->setMaterialFlag(video::EMF_BILINEAR_FILTER, false);
                        m_animated_meshnode->setMaterialType(video::EMT_TRANSPARENT_ALPHA_CHANNEL_REF);
                        m_animated_meshnode->setMaterialFlag(video::EMF_FOG_ENABLE, true);
+                       m_animated_meshnode->setMaterialFlag(video::EMF_BACK_FACE_CULLING, backface_culling);
                }
                else
                        errorstream<<"GenericCAO::addToScene(): Could not load mesh "<<m_prop.mesh<<std::endl;
-       }
-       else if(m_prop.visual == "wielditem") {
-               infostream<<"GenericCAO::addToScene(): wielditem"<<std::endl;
-               infostream<<"textures: "<<m_prop.textures.size()<<std::endl;
-               if(m_prop.textures.size() >= 1){
-                       infostream<<"textures[0]: "<<m_prop.textures[0]<<std::endl;
-                       IItemDefManager *idef = m_gamedef->idef();
-                       ItemStack item(m_prop.textures[0], 1, 0, "", idef);
-
-                       m_wield_meshnode = new WieldMeshSceneNode(
-                                       smgr->getRootSceneNode(), smgr, -1);
-                       m_wield_meshnode->setItem(item, m_gamedef);
-
-                       m_wield_meshnode->setScale(v3f(m_prop.visual_size.X/2,
-                                       m_prop.visual_size.Y/2,
-                                       m_prop.visual_size.X/2));
-                       u8 li = m_last_light;
-                       m_wield_meshnode->setColor(video::SColor(255,li,li,li));
+       } else if (m_prop.visual == "wielditem") {
+               ItemStack item;
+               infostream << "GenericCAO::addToScene(): wielditem" << std::endl;
+               if (m_prop.wield_item.empty()) {
+                       // Old format, only textures are specified.
+                       infostream << "textures: " << m_prop.textures.size() << std::endl;
+                       if (!m_prop.textures.empty()) {
+                               infostream << "textures[0]: " << m_prop.textures[0]
+                                       << std::endl;
+                               IItemDefManager *idef = m_client->idef();
+                               item = ItemStack(m_prop.textures[0], 1, 0, idef);
+                       }
+               } else {
+                       infostream << "serialized form: " << m_prop.wield_item << std::endl;
+                       item.deSerialize(m_prop.wield_item, m_client->idef());
                }
+               m_wield_meshnode = new WieldMeshSceneNode(
+                       RenderingEngine::get_scene_manager(), -1);
+               m_wield_meshnode->setItem(item, m_client);
+
+               m_wield_meshnode->setScale(
+                       v3f(m_prop.visual_size.X / 2, m_prop.visual_size.Y / 2,
+                               m_prop.visual_size.X / 2));
+               u8 li = m_last_light;
+               m_wield_meshnode->setColor(video::SColor(255, li, li, li));
        } else {
                infostream<<"GenericCAO::addToScene(): \""<<m_prop.visual
                                <<"\" not supported"<<std::endl;
        }
-       updateTextures("");
+
+       /* don't update while punch texture modifier is active */
+       if (m_reset_textures_timer < 0)
+               updateTextures(m_current_texture_modifier);
 
        scene::ISceneNode *node = getSceneNode();
-       if (node && m_is_player && !m_is_local_player) {
-               // Add a text node for showing the name
-               gui::IGUIEnvironment* gui = irr->getGUIEnvironment();
-               std::wstring wname = narrow_to_wide(m_name);
-               m_textnode = smgr->addTextSceneNode(gui->getSkin()->getFont(),
-                               wname.c_str(), m_nametag_color, node);
-               m_textnode->grab();
-               m_textnode->setPosition(v3f(0, BS*1.1, 0));
+       if (node && !m_prop.nametag.empty() && !m_is_local_player) {
+               // Add nametag
+               v3f pos;
+               pos.Y = m_prop.collisionbox.MaxEdge.Y + 0.3f;
+               m_nametag = m_client->getCamera()->addNametag(node,
+                       m_prop.nametag, m_prop.nametag_color,
+                       pos);
        }
 
        updateNodePos();
@@ -976,24 +645,48 @@ void GenericCAO::addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
 
 void GenericCAO::updateLight(u8 light_at_pos)
 {
-       u8 li = decode_light(light_at_pos);
-       if(li != m_last_light)
-       {
+       // Don't update light of attached one
+       if (getParent() != NULL) {
+               return;
+       }
+
+       updateLightNoCheck(light_at_pos);
+
+       // Update light of all children
+       for (u16 i : m_children) {
+               ClientActiveObject *obj = m_env->getActiveObject(i);
+               if (obj) {
+                       obj->updateLightNoCheck(light_at_pos);
+               }
+       }
+}
+
+void GenericCAO::updateLightNoCheck(u8 light_at_pos)
+{
+       if (m_glow < 0)
+               return;
+
+       u8 li = decode_light(light_at_pos + m_glow);
+       if (li != m_last_light) {
                m_last_light = li;
                video::SColor color(255,li,li,li);
-               if(m_meshnode)
+               if (m_meshnode) {
                        setMeshColor(m_meshnode->getMesh(), color);
-               if(m_animated_meshnode)
-                       setMeshColor(m_animated_meshnode->getMesh(), color);
-               if(m_wield_meshnode)
+               } else if (m_animated_meshnode) {
+                       setAnimatedMeshColor(m_animated_meshnode, color);
+               } else if (m_wield_meshnode) {
                        m_wield_meshnode->setColor(color);
-               if(m_spritenode)
+               } else if (m_spritenode) {
                        m_spritenode->setColor(color);
+               }
        }
 }
 
 v3s16 GenericCAO::getLightPosition()
 {
+       if (m_is_player)
+               return floatToInt(m_position + v3f(0, 0.5 * BS, 0), BS);
+
        return floatToInt(m_position, BS);
 }
 
@@ -1014,27 +707,26 @@ void GenericCAO::updateNodePos()
                }
        }
 }
-       
+
 void GenericCAO::step(float dtime, ClientEnvironment *env)
 {
        // Handel model of local player instantly to prevent lags
-       if(m_is_local_player)
-       {
+       if (m_is_local_player) {
                LocalPlayer *player = m_env->getLocalPlayer();
-
-               if (m_is_visible)
-               {
+               if (m_is_visible) {
                        int old_anim = player->last_animation;
                        float old_anim_speed = player->last_animation_speed;
-                       m_position = player->getPosition() + v3f(0,BS,0);
+                       m_position = player->getPosition();
                        m_velocity = v3f(0,0,0);
                        m_acceleration = v3f(0,0,0);
                        pos_translator.vect_show = m_position;
                        m_yaw = player->getYaw();
-                       PlayerControl controls = player->getPlayerControl();
+                       const PlayerControl &controls = player->getPlayerControl();
 
                        bool walking = false;
-                       if(controls.up || controls.down || controls.left || controls.right)
+                       if (controls.up || controls.down || controls.left || controls.right ||
+                                       controls.forw_move_joystick_axis != 0.f ||
+                                       controls.sidew_move_joystick_axis != 0.f)
                                walking = true;
 
                        f32 new_speed = player->local_animation_speed;
@@ -1043,18 +735,17 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
 
                        // increase speed if using fast or flying fast
                        if((g_settings->getBool("fast_move") &&
-                                       m_gamedef->checkLocalPrivilege("fast")) &&
+                                       m_client->checkLocalPrivilege("fast")) &&
                                        (controls.aux1 ||
                                        (!player->touching_ground &&
                                        g_settings->getBool("free_move") &&
-                                       m_gamedef->checkLocalPrivilege("fly"))))
+                                       m_client->checkLocalPrivilege("fly"))))
                                        new_speed *= 1.5;
                        // slowdown speed if sneeking
-                       if(controls.sneak && walking)
+                       if (controls.sneak && walking)
                                new_speed /= 2;
 
-                       if(walking && (controls.LMB || controls.RMB))
-                       {
+                       if (walking && (controls.LMB || controls.RMB)) {
                                new_anim = player->local_animations[3];
                                player->last_animation = WD_ANIM;
                        } else if(walking) {
@@ -1067,8 +758,7 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
 
                        // Apply animations if input detected and not attached
                        // or set idle animation
-                       if ((new_anim.X + new_anim.Y) > 0 && !player->isAttached)
-                       {
+                       if ((new_anim.X + new_anim.Y) > 0 && !player->isAttached) {
                                allow_update = true;
                                m_animation_range = new_anim;
                                m_animation_speed = new_speed;
@@ -1076,8 +766,7 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
                        } else {
                                player->last_animation = NO_ANIM;
 
-                               if (old_anim != NO_ANIM)
-                               {
+                               if (old_anim != NO_ANIM) {
                                        m_animation_range = player->local_animations[0];
                                        updateAnimation();
                                }
@@ -1092,15 +781,13 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
                }
        }
 
-       if(m_visuals_expired && m_smgr && m_irr){
+       if (m_visuals_expired && m_smgr) {
                m_visuals_expired = false;
 
                // Attachments, part 1: All attached objects must be unparented first,
                // or Irrlicht causes a segmentation fault
-               for(std::vector<u16>::iterator ci = m_children.begin();
-                               ci != m_children.end();)
-               {
-                       if (m_env->m_attachements[*ci] != getId()) {
+               for (auto ci = m_children.begin(); ci != m_children.end();) {
+                       if (m_env->attachement_parent_ids[*ci] != getId()) {
                                ci = m_children.erase(ci);
                                continue;
                        }
@@ -1114,14 +801,12 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
                }
 
                removeFromScene(false);
-               addToScene(m_smgr, m_gamedef->tsrc(), m_irr);
+               addToScene(m_client->tsrc());
 
                // Attachments, part 2: Now that the parent has been refreshed, put its attachments back
-               for(std::vector<u16>::iterator ci = m_children.begin();
-                                               ci != m_children.end(); ci++)
-               {
+               for (u16 cao_id : m_children) {
                        // Get the object of the child
-                       ClientActiveObject *obj = m_env->getActiveObject(*ci);
+                       ClientActiveObject *obj = m_env->getActiveObject(cao_id);
                        if (obj)
                                obj->setAttachments();
                }
@@ -1151,22 +836,20 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
 
                if(m_prop.physical)
                {
-                       core::aabbox3d<f32> box = m_prop.collisionbox;
+                       aabb3f box = m_prop.collisionbox;
                        box.MinEdge *= BS;
                        box.MaxEdge *= BS;
                        collisionMoveResult moveresult;
                        f32 pos_max_d = BS*0.125; // Distance per iteration
                        v3f p_pos = m_position;
                        v3f p_velocity = m_velocity;
-                       v3f p_acceleration = m_acceleration;
                        moveresult = collisionMoveSimple(env,env->getGameDef(),
                                        pos_max_d, box, m_prop.stepheight, dtime,
-                                       p_pos, p_velocity, p_acceleration,
+                                       &p_pos, &p_velocity, m_acceleration,
                                        this, m_prop.collideWithObjects);
                        // Apply results
                        m_position = p_pos;
                        m_velocity = p_velocity;
-                       m_acceleration = p_acceleration;
 
                        bool is_end_position = moveresult.collides;
                        pos_translator.update(m_position, is_end_position, dtime);
@@ -1183,17 +866,18 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
 
                float moved = lastpos.getDistanceFrom(pos_translator.vect_show);
                m_step_distance_counter += moved;
-               if(m_step_distance_counter > 1.5*BS)
-               {
-                       m_step_distance_counter = 0;
-                       if(!m_is_local_player && m_prop.makes_footstep_sound)
-                       {
-                               INodeDefManager *ndef = m_gamedef->ndef();
-                               v3s16 p = floatToInt(getPosition() + v3f(0,
-                                               (m_prop.collisionbox.MinEdge.Y-0.5)*BS, 0), BS);
+               if (m_step_distance_counter > 1.5f * BS) {
+                       m_step_distance_counter = 0.0f;
+                       if (!m_is_local_player && m_prop.makes_footstep_sound) {
+                               INodeDefManager *ndef = m_client->ndef();
+                               v3s16 p = floatToInt(getPosition() +
+                                       v3f(0.0f, (m_prop.collisionbox.MinEdge.Y - 0.5f) * BS, 0.0f), BS);
                                MapNode n = m_env->getMap().getNodeNoEx(p);
                                SimpleSoundSpec spec = ndef->get(n).sound_footstep;
-                               m_gamedef->sound()->playSoundAt(spec, false, getPosition());
+                               // Reduce footstep gain, as non-local-player footsteps are
+                               // somehow louder.
+                               spec.gain *= 0.6f;
+                               m_client->sound()->playSoundAt(spec, false, getPosition());
                        }
                }
        }
@@ -1212,22 +896,32 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
        if(m_reset_textures_timer >= 0)
        {
                m_reset_textures_timer -= dtime;
-               if(m_reset_textures_timer <= 0){
+               if(m_reset_textures_timer <= 0) {
                        m_reset_textures_timer = -1;
-                       updateTextures("");
+                       updateTextures(m_previous_texture_modifier);
                }
        }
-       if(getParent() == NULL && fabs(m_prop.automatic_rotate) > 0.001)
+       if(!getParent() && fabs(m_prop.automatic_rotate) > 0.001)
        {
                m_yaw += dtime * m_prop.automatic_rotate * 180 / M_PI;
                updateNodePos();
        }
 
-       if (getParent() == NULL && m_prop.automatic_face_movement_dir &&
-                       (fabs(m_velocity.Z) > 0.001 || fabs(m_velocity.X) > 0.001))
-       {
-               m_yaw = atan2(m_velocity.Z,m_velocity.X) * 180 / M_PI
+       if (!getParent() && m_prop.automatic_face_movement_dir &&
+                       (fabs(m_velocity.Z) > 0.001 || fabs(m_velocity.X) > 0.001)) {
+
+               float target_yaw = atan2(m_velocity.Z, m_velocity.X) * 180 / M_PI
                                + m_prop.automatic_face_movement_dir_offset;
+               float max_rotation_delta =
+                               dtime * m_prop.automatic_face_movement_max_rotation_per_sec;
+               float delta = wrapDegrees_0_360(target_yaw - m_yaw);
+
+               if (delta > max_rotation_delta && 360 - delta > max_rotation_delta) {
+                       m_yaw += (delta < 180) ? max_rotation_delta : -max_rotation_delta;
+                       m_yaw = wrapDegrees_0_360(m_yaw);
+               } else {
+                       m_yaw = target_yaw;
+               }
                updateNodePos();
        }
 }
@@ -1282,20 +976,22 @@ void GenericCAO::updateTexturePos()
        }
 }
 
-void GenericCAO::updateTextures(const std::string &mod)
+void GenericCAO::updateTextures(std::string mod)
 {
-       ITextureSource *tsrc = m_gamedef->tsrc();
+       ITextureSource *tsrc = m_client->tsrc();
 
        bool use_trilinear_filter = g_settings->getBool("trilinear_filter");
        bool use_bilinear_filter = g_settings->getBool("bilinear_filter");
        bool use_anisotropic_filter = g_settings->getBool("anisotropic_filter");
 
-       if(m_spritenode)
-       {
-               if(m_prop.visual == "sprite")
-               {
+       m_previous_texture_modifier = m_current_texture_modifier;
+       m_current_texture_modifier = mod;
+       m_glow = m_prop.glow;
+
+       if (m_spritenode) {
+               if (m_prop.visual == "sprite") {
                        std::string texturestring = "unknown_node.png";
-                       if(m_prop.textures.size() >= 1)
+                       if (!m_prop.textures.empty())
                                texturestring = m_prop.textures[0];
                        texturestring += mod;
                        m_spritenode->setMaterialTexture(0,
@@ -1304,8 +1000,7 @@ void GenericCAO::updateTextures(const std::string &mod)
                        // This allows setting per-material colors. However, until a real lighting
                        // system is added, the code below will have no effect. Once MineTest
                        // has directional lighting, it should work automatically.
-                       if(m_prop.colors.size() >= 1)
-                       {
+                       if (!m_prop.colors.empty()) {
                                m_spritenode->getMaterial(0).AmbientColor = m_prop.colors[0];
                                m_spritenode->getMaterial(0).DiffuseColor = m_prop.colors[0];
                                m_spritenode->getMaterial(0).SpecularColor = m_prop.colors[0];
@@ -1316,20 +1011,17 @@ void GenericCAO::updateTextures(const std::string &mod)
                        m_spritenode->getMaterial(0).setFlag(video::EMF_ANISOTROPIC_FILTER, use_anisotropic_filter);
                }
        }
-       if(m_animated_meshnode)
-       {
-               if(m_prop.visual == "mesh")
-               {
+
+       if (m_animated_meshnode) {
+               if (m_prop.visual == "mesh") {
                        for (u32 i = 0; i < m_prop.textures.size() &&
-                                       i < m_animated_meshnode->getMaterialCount(); ++i)
-                       {
+                                       i < m_animated_meshnode->getMaterialCount(); ++i) {
                                std::string texturestring = m_prop.textures[i];
-                               if(texturestring == "")
+                               if (texturestring.empty())
                                        continue; // Empty texture string means don't modify that material
                                texturestring += mod;
                                video::ITexture* texture = tsrc->getTextureForMesh(texturestring);
-                               if(!texture)
-                               {
+                               if (!texture) {
                                        errorstream<<"GenericCAO::updateTextures(): Could not load texture "<<texturestring<<std::endl;
                                        continue;
                                }
@@ -1337,9 +1029,16 @@ void GenericCAO::updateTextures(const std::string &mod)
                                // Set material flags and texture
                                video::SMaterial& material = m_animated_meshnode->getMaterial(i);
                                material.TextureLayer[0].Texture = texture;
-                               material.setFlag(video::EMF_LIGHTING, false);
+                               material.setFlag(video::EMF_LIGHTING, true);
                                material.setFlag(video::EMF_BILINEAR_FILTER, false);
 
+                               // don't filter low-res textures, makes them look blurry
+                               // player models have a res of 64
+                               const core::dimension2d<u32> &size = texture->getOriginalSize();
+                               const u32 res = std::min(size.Height, size.Width);
+                               use_trilinear_filter &= res > 64;
+                               use_bilinear_filter &= res > 64;
+
                                m_animated_meshnode->getMaterial(i)
                                                .setFlag(video::EMF_TRILINEAR_FILTER, use_trilinear_filter);
                                m_animated_meshnode->getMaterial(i)
@@ -1393,13 +1092,11 @@ void GenericCAO::updateTextures(const std::string &mod)
                                m_meshnode->getMaterial(i).setFlag(video::EMF_BILINEAR_FILTER, use_bilinear_filter);
                                m_meshnode->getMaterial(i).setFlag(video::EMF_ANISOTROPIC_FILTER, use_anisotropic_filter);
                        }
-               }
-               else if(m_prop.visual == "upright_sprite")
-               {
+               } else if (m_prop.visual == "upright_sprite") {
                        scene::IMesh *mesh = m_meshnode->getMesh();
                        {
                                std::string tname = "unknown_object.png";
-                               if(m_prop.textures.size() >= 1)
+                               if (!m_prop.textures.empty())
                                        tname = m_prop.textures[0];
                                tname += mod;
                                scene::IMeshBuffer *buf = mesh->getMeshBuffer(0);
@@ -1409,8 +1106,7 @@ void GenericCAO::updateTextures(const std::string &mod)
                                // This allows setting per-material colors. However, until a real lighting
                                // system is added, the code below will have no effect. Once MineTest
                                // has directional lighting, it should work automatically.
-                               if(m_prop.colors.size() >= 1)
-                               {
+                               if(!m_prop.colors.empty()) {
                                        buf->getMaterial().AmbientColor = m_prop.colors[0];
                                        buf->getMaterial().DiffuseColor = m_prop.colors[0];
                                        buf->getMaterial().SpecularColor = m_prop.colors[0];
@@ -1422,9 +1118,9 @@ void GenericCAO::updateTextures(const std::string &mod)
                        }
                        {
                                std::string tname = "unknown_object.png";
-                               if(m_prop.textures.size() >= 2)
+                               if (m_prop.textures.size() >= 2)
                                        tname = m_prop.textures[1];
-                               else if(m_prop.textures.size() >= 1)
+                               else if (!m_prop.textures.empty())
                                        tname = m_prop.textures[0];
                                tname += mod;
                                scene::IMeshBuffer *buf = mesh->getMeshBuffer(1);
@@ -1434,17 +1130,16 @@ void GenericCAO::updateTextures(const std::string &mod)
                                // This allows setting per-material colors. However, until a real lighting
                                // system is added, the code below will have no effect. Once MineTest
                                // has directional lighting, it should work automatically.
-                               if(m_prop.colors.size() >= 2)
-                               {
+                               if (m_prop.colors.size() >= 2) {
                                        buf->getMaterial().AmbientColor = m_prop.colors[1];
                                        buf->getMaterial().DiffuseColor = m_prop.colors[1];
                                        buf->getMaterial().SpecularColor = m_prop.colors[1];
-                               }
-                               else if(m_prop.colors.size() >= 1)
-                               {
+                                       setMeshColor(mesh, m_prop.colors[1]);
+                               } else if (!m_prop.colors.empty()) {
                                        buf->getMaterial().AmbientColor = m_prop.colors[0];
                                        buf->getMaterial().DiffuseColor = m_prop.colors[0];
                                        buf->getMaterial().SpecularColor = m_prop.colors[0];
+                                       setMeshColor(mesh, m_prop.colors[0]);
                                }
 
                                buf->getMaterial().setFlag(video::EMF_TRILINEAR_FILTER, use_trilinear_filter);
@@ -1457,23 +1152,38 @@ void GenericCAO::updateTextures(const std::string &mod)
 
 void GenericCAO::updateAnimation()
 {
-       if(m_animated_meshnode == NULL)
+       if (!m_animated_meshnode)
                return;
-       m_animated_meshnode->setFrameLoop(m_animation_range.X, m_animation_range.Y);
-       m_animated_meshnode->setAnimationSpeed(m_animation_speed);
+
+       if (m_animated_meshnode->getStartFrame() != m_animation_range.X ||
+               m_animated_meshnode->getEndFrame() != m_animation_range.Y)
+                       m_animated_meshnode->setFrameLoop(m_animation_range.X, m_animation_range.Y);
+       if (m_animated_meshnode->getAnimationSpeed() != m_animation_speed)
+               m_animated_meshnode->setAnimationSpeed(m_animation_speed);
        m_animated_meshnode->setTransitionTime(m_animation_blend);
+// Requires Irrlicht 1.8 or greater
+#if (IRRLICHT_VERSION_MAJOR == 1 && IRRLICHT_VERSION_MINOR >= 8) || IRRLICHT_VERSION_MAJOR > 1
+       if (m_animated_meshnode->getLoopMode() != m_animation_loop)
+               m_animated_meshnode->setLoopMode(m_animation_loop);
+#endif
+}
+
+void GenericCAO::updateAnimationSpeed()
+{
+       if (!m_animated_meshnode)
+               return;
+        
+       m_animated_meshnode->setAnimationSpeed(m_animation_speed);
 }
 
 void GenericCAO::updateBonePosition()
 {
-       if(m_bone_position.empty() || m_animated_meshnode == NULL)
+       if (m_bone_position.empty() || !m_animated_meshnode)
                return;
 
        m_animated_meshnode->setJointMode(irr::scene::EJUOR_CONTROL); // To write positions to the mesh on render
-       for(std::map<std::string,
-                       core::vector2d<v3f> >::const_iterator ii = m_bone_position.begin();
-                       ii != m_bone_position.end(); ++ii)
-       {
+       for(std::unordered_map<std::string, core::vector2d<v3f>>::const_iterator
+                       ii = m_bone_position.begin(); ii != m_bone_position.end(); ++ii) {
                std::string bone_name = (*ii).first;
                v3f bone_pos = (*ii).second.X;
                v3f bone_rot = (*ii).second.Y;
@@ -1485,20 +1195,11 @@ void GenericCAO::updateBonePosition()
                }
        }
 }
-       
+
 void GenericCAO::updateAttachments()
 {
 
-       // localplayer itself can't be attached to localplayer
-       if (!m_is_local_player)
-       {
-               m_attached_to_local = getParent() != NULL && getParent()->isLocalPlayer();
-               // Objects attached to the local player should always be hidden
-               m_is_visible = !m_attached_to_local;
-       }
-
-       if(getParent() == NULL || m_attached_to_local) // Detach or don't attach
-       {
+       if (!getParent()) { // Detach or don't attach
                scene::ISceneNode *node = getSceneNode();
                if (node) {
                        v3f old_position = node->getAbsolutePosition();
@@ -1520,7 +1221,7 @@ void GenericCAO::updateAttachments()
                scene::ISceneNode *parent_node = getParent()->getSceneNode();
                scene::IAnimatedMeshSceneNode *parent_animated_mesh_node =
                                getParent()->getAnimatedMeshSceneNode();
-               if (parent_animated_mesh_node && m_attachment_bone != "") {
+               if (parent_animated_mesh_node && !m_attachment_bone.empty()) {
                        parent_node = parent_animated_mesh_node->getJointNode(m_attachment_bone.c_str());
                }
 
@@ -1543,11 +1244,10 @@ void GenericCAO::processMessage(const std::string &data)
        std::istringstream is(data, std::ios::binary);
        // command
        u8 cmd = readU8(is);
-       if(cmd == GENERIC_CMD_SET_PROPERTIES)
-       {
+       if (cmd == GENERIC_CMD_SET_PROPERTIES) {
                m_prop = gob_read_set_properties(is);
 
-               m_selection_box = m_prop.collisionbox;
+               m_selection_box = m_prop.selectionbox;
                m_selection_box.MinEdge *= BS;
                m_selection_box.MaxEdge *= BS;
 
@@ -1558,11 +1258,22 @@ void GenericCAO::processMessage(const std::string &data)
                        m_initial_tx_basepos_set = true;
                        m_tx_basepos = m_prop.initial_sprite_basepos;
                }
+               if (m_is_local_player) {
+                       LocalPlayer *player = m_env->getLocalPlayer();
+                       player->makes_footstep_sound = m_prop.makes_footstep_sound;
+                       aabb3f collision_box = m_prop.collisionbox;
+                       collision_box.MinEdge *= BS;
+                       collision_box.MaxEdge *= BS;
+                       player->setCollisionbox(collision_box);
+                       player->setEyeHeight(m_prop.eye_height);
+                       player->setZoomFOV(m_prop.zoom_fov);
+               }
+
+               if ((m_is_player && !m_is_local_player) && m_prop.nametag.empty())
+                       m_prop.nametag = m_name;
 
                expireVisuals();
-       }
-       else if(cmd == GENERIC_CMD_UPDATE_POSITION)
-       {
+       } else if (cmd == GENERIC_CMD_UPDATE_POSITION) {
                // Not sent by the server if this object is an attachment.
                // We might however get here if the server notices the object being detached before the client.
                m_position = readV3F1000(is);
@@ -1592,12 +1303,16 @@ void GenericCAO::processMessage(const std::string &data)
                        pos_translator.init(m_position);
                }
                updateNodePos();
-       }
-       else if(cmd == GENERIC_CMD_SET_TEXTURE_MOD) {
+       } else if (cmd == GENERIC_CMD_SET_TEXTURE_MOD) {
                std::string mod = deSerializeString(is);
+
+               // immediatly reset a engine issued texture modifier if a mod sends a different one
+               if (m_reset_textures_timer > 0) {
+                       m_reset_textures_timer = -1;
+                       updateTextures(m_previous_texture_modifier);
+               }
                updateTextures(mod);
-       }
-       else if(cmd == GENERIC_CMD_SET_SPRITE) {
+       } else if (cmd == GENERIC_CMD_SET_SPRITE) {
                v2s16 p = readV2S16(is);
                int num_frames = readU16(is);
                float framelength = readF1000(is);
@@ -1609,14 +1324,14 @@ void GenericCAO::processMessage(const std::string &data)
                m_tx_select_horiz_by_yawpitch = select_horiz_by_yawpitch;
 
                updateTexturePos();
-       }
-       else if(cmd == GENERIC_CMD_SET_PHYSICS_OVERRIDE) {
+       } else if (cmd == GENERIC_CMD_SET_PHYSICS_OVERRIDE) {
                float override_speed = readF1000(is);
                float override_jump = readF1000(is);
                float override_gravity = readF1000(is);
                // these are sent inverted so we get true when the server sends nothing
                bool sneak = !readU8(is);
                bool sneak_glitch = !readU8(is);
+               bool new_move = !readU8(is);
 
 
                if(m_is_local_player)
@@ -1627,15 +1342,17 @@ void GenericCAO::processMessage(const std::string &data)
                        player->physics_override_gravity = override_gravity;
                        player->physics_override_sneak = sneak;
                        player->physics_override_sneak_glitch = sneak_glitch;
+                       player->physics_override_new_move = new_move;
                }
-       }
-       else if(cmd == GENERIC_CMD_SET_ANIMATION) {
+       } else if (cmd == GENERIC_CMD_SET_ANIMATION) {
                // TODO: change frames send as v2s32 value
                v2f range = readV2F1000(is);
                if (!m_is_local_player) {
                        m_animation_range = v2s32((s32)range.X, (s32)range.Y);
                        m_animation_speed = readF1000(is);
                        m_animation_blend = readF1000(is);
+                       // these are sent inverted so we get true when the server sends nothing
+                       m_animation_loop = !readU8(is);
                        updateAnimation();
                } else {
                        LocalPlayer *player = m_env->getLocalPlayer();
@@ -1644,6 +1361,8 @@ void GenericCAO::processMessage(const std::string &data)
                                m_animation_range = v2s32((s32)range.X, (s32)range.Y);
                                m_animation_speed = readF1000(is);
                                m_animation_blend = readF1000(is);
+                               // these are sent inverted so we get true when the server sends nothing
+                               m_animation_loop = !readU8(is);
                        }
                        // update animation only if local animations present
                        // and received animation is unknown (except idle animation)
@@ -1659,25 +1378,43 @@ void GenericCAO::processMessage(const std::string &data)
                                        updateAnimation();
                        }
                }
-       }
-       else if(cmd == GENERIC_CMD_SET_BONE_POSITION) {
+       } else if (cmd == GENERIC_CMD_SET_ANIMATION_SPEED) {
+               m_animation_speed = readF1000(is);
+               updateAnimationSpeed();
+       } else if (cmd == GENERIC_CMD_SET_BONE_POSITION) {
                std::string bone = deSerializeString(is);
                v3f position = readV3F1000(is);
                v3f rotation = readV3F1000(is);
                m_bone_position[bone] = core::vector2d<v3f>(position, rotation);
 
                updateBonePosition();
-       }
-       else if(cmd == GENERIC_CMD_SET_ATTACHMENT) {
-               m_env->m_attachements[getId()] = readS16(is);
-               m_children.push_back(m_env->m_attachements[getId()]);
+       } else if (cmd == GENERIC_CMD_ATTACH_TO) {
+               u16 parentID = readS16(is);
+               u16 oldparent = m_env->attachement_parent_ids[getId()];
+               if (oldparent) {
+                       m_children.erase(std::remove(m_children.begin(), m_children.end(),
+                               getId()), m_children.end());
+               }
+               m_env->attachement_parent_ids[getId()] = parentID;
+               GenericCAO *parentobj = m_env->getGenericCAO(parentID);
+
+               if (parentobj) {
+                       parentobj->m_children.push_back(getId());
+               }
+
                m_attachment_bone = deSerializeString(is);
                m_attachment_position = readV3F1000(is);
                m_attachment_rotation = readV3F1000(is);
 
+               // localplayer itself can't be attached to localplayer
+               if (!m_is_local_player) {
+                       m_attached_to_local = getParent() != NULL && getParent()->isLocalPlayer();
+                       // Objects attached to the local player should be hidden by default
+                       m_is_visible = !m_attached_to_local;
+               }
+
                updateAttachments();
-       }
-       else if(cmd == GENERIC_CMD_PUNCHED) {
+       } else if (cmd == GENERIC_CMD_PUNCHED) {
                /*s16 damage =*/ readS16(is);
                s16 result_hp = readS16(is);
 
@@ -1696,17 +1433,16 @@ void GenericCAO::processMessage(const std::string &data)
                                                m_smgr, m_env, m_position,
                                                m_prop.visual_size * BS);
                                m_env->addSimpleObject(simple);
-                       } else {
+                       } else if (m_reset_textures_timer < 0) {
                                // TODO: Execute defined fast response
                                // Flashing shall suffice as there is no definition
                                m_reset_textures_timer = 0.05;
                                if(damage >= 2)
                                        m_reset_textures_timer += 0.05 * damage;
-                               updateTextures("^[brighten");
+                               updateTextures(m_current_texture_modifier + "^[brighten");
                        }
                }
-       }
-       else if(cmd == GENERIC_CMD_UPDATE_ARMOR_GROUPS) {
+       } else if (cmd == GENERIC_CMD_UPDATE_ARMOR_GROUPS) {
                m_armor_groups.clear();
                int armor_groups_size = readU16(is);
                for(int i=0; i<armor_groups_size; i++)
@@ -1715,14 +1451,32 @@ void GenericCAO::processMessage(const std::string &data)
                        int rating = readS16(is);
                        m_armor_groups[name] = rating;
                }
-       } else if (cmd == GENERIC_CMD_SET_NAMETAG_COLOR) {
-               m_nametag_color = readARGB8(is);
-               if (m_textnode != NULL) {
-                       m_textnode->setTextColor(m_nametag_color);
+       } else if (cmd == GENERIC_CMD_UPDATE_NAMETAG_ATTRIBUTES) {
+               // Deprecated, for backwards compatibility only.
+               readU8(is); // version
+               m_prop.nametag_color = readARGB8(is);
+               if (m_nametag != NULL) {
+                       m_nametag->nametag_color = m_prop.nametag_color;
+                       v3f pos;
+                       pos.Y = m_prop.collisionbox.MaxEdge.Y + 0.3f;
+                       m_nametag->nametag_pos = pos;
+               }
+       } else if (cmd == GENERIC_CMD_SPAWN_INFANT) {
+               u16 child_id = readU16(is);
+               u8 type = readU8(is);
+
+               if (GenericCAO *childobj = m_env->getGenericCAO(child_id)) {
+                       childobj->processInitData(deSerializeLongString(is));
+               } else {
+                       m_env->addActiveObject(child_id, type, deSerializeLongString(is));
                }
+       } else {
+               warningstream << FUNCTION_NAME
+                       << ": unknown command or outdated client \""
+                       << +cmd << "\"" << std::endl;
        }
 }
-       
+
 /* \pre punchitem != NULL
  */
 bool GenericCAO::directReportPunch(v3f dir, const ItemStack *punchitem,
@@ -1730,7 +1484,7 @@ bool GenericCAO::directReportPunch(v3f dir, const ItemStack *punchitem,
 {
        assert(punchitem);      // pre-condition
        const ToolCapabilities *toolcap =
-                       &punchitem->getToolCapabilities(m_gamedef->idef());
+                       &punchitem->getToolCapabilities(m_client->idef());
        PunchDamageResult result = getPunchDamage(
                        m_armor_groups,
                        toolcap,
@@ -1753,10 +1507,12 @@ bool GenericCAO::directReportPunch(v3f dir, const ItemStack *punchitem,
                }
                // TODO: Execute defined fast response
                // Flashing shall suffice as there is no definition
-               m_reset_textures_timer = 0.05;
-               if(result.damage >= 2)
-                       m_reset_textures_timer += 0.05 * result.damage;
-               updateTextures("^[brighten");
+               if (m_reset_textures_timer < 0) {
+                       m_reset_textures_timer = 0.05;
+                       if (result.damage >= 2)
+                               m_reset_textures_timer += 0.05 * result.damage;
+                       updateTextures(m_current_texture_modifier + "^[brighten");
+               }
        }
 
        return false;
@@ -1768,7 +1524,7 @@ std::string GenericCAO::debugInfoText()
        os<<"GenericCAO hp="<<m_hp<<"\n";
        os<<"armor={";
        for(ItemGroupList::const_iterator i = m_armor_groups.begin();
-                       i != m_armor_groups.end(); i++)
+                       i != m_armor_groups.end(); ++i)
        {
                os<<i->first<<"="<<i->second<<", ";
        }