C++11 patchset 9: move hardcoded init parameters to class definitions (part 1) (...
[oweals/minetest.git] / src / content_cao.cpp
index 35ab1c508e29dcc5a78f004d1e64078b6f515739..0b9df64515e27bee79a7c1f36117d4b55f72fbd3 100644 (file)
@@ -26,13 +26,12 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "content_cao.h"
 #include "util/numeric.h" // For IntervalLimiter
 #include "util/serialize.h"
-#include "util/mathconstants.h"
+#include "util/basic_macros.h"
 #include "client/tile.h"
 #include "environment.h"
 #include "collision.h"
 #include "settings.h"
 #include "serialization.h" // For decompressZlib
-#include "gamedef.h"
 #include "clientobject.h"
 #include "mesh.h"
 #include "itemdef.h"
@@ -45,23 +44,12 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "camera.h" // CameraModes
 #include "wieldmesh.h"
 #include "log.h"
+#include <algorithm>
 
 class Settings;
 struct ToolCapabilities;
 
-#define PP(x) "("<<(x).X<<","<<(x).Y<<","<<(x).Z<<")"
-
-std::map<u16, ClientActiveObject::Factory> ClientActiveObject::m_types;
-
-SmoothTranslator::SmoothTranslator():
-       vect_old(0,0,0),
-       vect_show(0,0,0),
-       vect_aim(0,0,0),
-       anim_counter(0),
-       anim_time(0),
-       anim_time_counter(0),
-       aim_is_end(true)
-{}
+std::unordered_map<u16, ClientActiveObject::Factory> ClientActiveObject::m_types;
 
 void SmoothTranslator::init(v3f vect)
 {
@@ -74,11 +62,6 @@ void SmoothTranslator::init(v3f vect)
        aim_is_end = true;
 }
 
-void SmoothTranslator::sharpen()
-{
-       init(vect_show);
-}
-
 void SmoothTranslator::update(v3f vect_new, bool is_end_position, float update_interval)
 {
        aim_is_end = is_end_position;
@@ -115,11 +98,6 @@ void SmoothTranslator::translate(f32 dtime)
        vect_show = vect_old + vect_move * moveratio;
 }
 
-bool SmoothTranslator::is_moving()
-{
-       return ((anim_time_counter / anim_time) < 1.4);
-}
-
 /*
        Other stuff
 */
@@ -140,7 +118,7 @@ static void setBillboardTextureMatrix(scene::IBillboardSceneNode *bill,
 class TestCAO : public ClientActiveObject
 {
 public:
-       TestCAO(IGameDef *gamedef, ClientEnvironment *env);
+       TestCAO(Client *client, ClientEnvironment *env);
        virtual ~TestCAO();
 
        ActiveObjectType getType() const
@@ -148,7 +126,7 @@ public:
                return ACTIVEOBJECT_TYPE_TEST;
        }
 
-       static ClientActiveObject* create(IGameDef *gamedef, ClientEnvironment *env);
+       static ClientActiveObject* create(Client *client, ClientEnvironment *env);
 
        void addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
                        IrrlichtDevice *irr);
@@ -161,7 +139,7 @@ public:
 
        void processMessage(const std::string &data);
 
-       bool getCollisionBox(aabb3f *toset) { return false; }
+       bool getCollisionBox(aabb3f *toset) const { return false; }
 private:
        scene::IMeshSceneNode *m_node;
        v3f m_position;
@@ -170,8 +148,8 @@ private:
 // Prototype
 TestCAO proto_TestCAO(NULL, NULL);
 
-TestCAO::TestCAO(IGameDef *gamedef, ClientEnvironment *env):
-       ClientActiveObject(0, gamedef, env),
+TestCAO::TestCAO(Client *client, ClientEnvironment *env):
+       ClientActiveObject(0, client, env),
        m_node(NULL),
        m_position(v3f(0,10*BS,0))
 {
@@ -182,9 +160,9 @@ TestCAO::~TestCAO()
 {
 }
 
-ClientActiveObject* TestCAO::create(IGameDef *gamedef, ClientEnvironment *env)
+ClientActiveObject* TestCAO::create(Client *client, ClientEnvironment *env)
 {
-       return new TestCAO(gamedef, env);
+       return new TestCAO(client, env);
 }
 
 void TestCAO::addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
@@ -284,7 +262,7 @@ void TestCAO::processMessage(const std::string &data)
 class ItemCAO : public ClientActiveObject
 {
 public:
-       ItemCAO(IGameDef *gamedef, ClientEnvironment *env);
+       ItemCAO(Client *client, ClientEnvironment *env);
        virtual ~ItemCAO();
 
        ActiveObjectType getType() const
@@ -292,7 +270,7 @@ public:
                return ACTIVEOBJECT_TYPE_ITEM;
        }
 
-       static ClientActiveObject* create(IGameDef *gamedef, ClientEnvironment *env);
+       static ClientActiveObject* create(Client *client, ClientEnvironment *env);
 
        void addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
                        IrrlichtDevice *irr);
@@ -313,11 +291,12 @@ public:
                {return &m_selection_box;}
        v3f getPosition()
                {return m_position;}
-
+       inline float getYaw() const
+               {return 0;}
        std::string infoText()
                {return m_infotext;}
 
-       bool getCollisionBox(aabb3f *toset) { return false; }
+       bool getCollisionBox(aabb3f *toset) const { return false; }
 private:
        aabb3f m_selection_box;
        scene::IMeshSceneNode *m_node;
@@ -326,18 +305,16 @@ private:
        std::string m_infotext;
 };
 
-#include "inventory.h"
-
 // Prototype
 ItemCAO proto_ItemCAO(NULL, NULL);
 
-ItemCAO::ItemCAO(IGameDef *gamedef, ClientEnvironment *env):
-       ClientActiveObject(0, gamedef, env),
+ItemCAO::ItemCAO(Client *client, ClientEnvironment *env):
+       ClientActiveObject(0, client, env),
        m_selection_box(-BS/3.,0.0,-BS/3., BS/3.,BS*2./3.,BS/3.),
        m_node(NULL),
        m_position(v3f(0,10*BS,0))
 {
-       if(!gamedef && !env)
+       if(!client && !env)
        {
                ClientActiveObject::registerType(getType(), create);
        }
@@ -347,9 +324,9 @@ ItemCAO::~ItemCAO()
 {
 }
 
-ClientActiveObject* ItemCAO::create(IGameDef *gamedef, ClientEnvironment *env)
+ClientActiveObject* ItemCAO::create(Client *client, ClientEnvironment *env)
 {
-       return new ItemCAO(gamedef, env);
+       return new ItemCAO(client, env);
 }
 
 void ItemCAO::addToScene(scene::ISceneManager *smgr, ITextureSource *tsrc,
@@ -433,7 +410,7 @@ void ItemCAO::updateNodePos()
 void ItemCAO::updateInfoText()
 {
        try{
-               IItemDefManager *idef = m_gamedef->idef();
+               IItemDefManager *idef = m_client->idef();
                ItemStack item;
                item.deSerialize(m_itemstring, idef);
                if(item.isKnown(idef))
@@ -458,10 +435,10 @@ void ItemCAO::updateTexture()
        std::istringstream is(m_itemstring, std::ios_base::binary);
        video::ITexture *texture = NULL;
        try{
-               IItemDefManager *idef = m_gamedef->idef();
+               IItemDefManager *idef = m_client->idef();
                ItemStack item;
                item.deSerialize(is, idef);
-               texture = idef->getInventoryTexture(item.getDefinition(idef).name, m_gamedef);
+               texture = idef->getInventoryTexture(item.getDefinition(idef).name, m_client);
        }
        catch(SerializationError &e)
        {
@@ -538,57 +515,17 @@ void ItemCAO::initialize(const std::string &data)
 
 #include "genericobject.h"
 
-GenericCAO::GenericCAO(IGameDef *gamedef, ClientEnvironment *env):
-               ClientActiveObject(0, gamedef, env),
-               //
-               m_is_player(false),
-               m_is_local_player(false),
-               //
-               m_smgr(NULL),
-               m_irr(NULL),
-               m_gamedef(NULL),
-               m_selection_box(-BS/3.,-BS/3.,-BS/3., BS/3.,BS/3.,BS/3.),
-               m_meshnode(NULL),
-               m_animated_meshnode(NULL),
-               m_wield_meshnode(NULL),
-               m_spritenode(NULL),
-               m_nametag(NULL),
-               m_position(v3f(0,10*BS,0)),
-               m_velocity(v3f(0,0,0)),
-               m_acceleration(v3f(0,0,0)),
-               m_yaw(0),
-               m_hp(1),
-               m_tx_size(1,1),
-               m_tx_basepos(0,0),
-               m_initial_tx_basepos_set(false),
-               m_tx_select_horiz_by_yawpitch(false),
-               m_animation_range(v2s32(0,0)),
-               m_animation_speed(15),
-               m_animation_blend(0),
-               m_animation_loop(true),
-               m_bone_position(std::map<std::string, core::vector2d<v3f> >()),
-               m_attachment_bone(""),
-               m_attachment_position(v3f(0,0,0)),
-               m_attachment_rotation(v3f(0,0,0)),
-               m_attached_to_local(false),
-               m_anim_frame(0),
-               m_anim_num_frames(1),
-               m_anim_framelength(0.2),
-               m_anim_timer(0),
-               m_reset_textures_timer(-1),
-               m_visuals_expired(false),
-               m_step_distance_counter(0),
-               m_last_light(255),
-               m_is_visible(false)
+GenericCAO::GenericCAO(Client *client, ClientEnvironment *env):
+               ClientActiveObject(0, client, env)
 {
-       if (gamedef == NULL) {
+       if (client == NULL) {
                ClientActiveObject::registerType(getType(), create);
        } else {
-               m_gamedef = gamedef;
+               m_client = client;
        }
 }
 
-bool GenericCAO::getCollisionBox(aabb3f *toset)
+bool GenericCAO::getCollisionBox(aabb3f *toset) const
 {
        if (m_prop.physical)
        {
@@ -605,7 +542,7 @@ bool GenericCAO::getCollisionBox(aabb3f *toset)
        return false;
 }
 
-bool GenericCAO::collideWithObjects()
+bool GenericCAO::collideWithObjects() const
 {
        return m_prop.collideWithObjects;
 }
@@ -613,65 +550,61 @@ bool GenericCAO::collideWithObjects()
 void GenericCAO::initialize(const std::string &data)
 {
        infostream<<"GenericCAO: Got init data"<<std::endl;
+       processInitData(data);
+
+       if (m_is_player) {
+               // Check if it's the current player
+               LocalPlayer *player = m_env->getLocalPlayer();
+               if (player && strcmp(player->getName(), m_name.c_str()) == 0) {
+                       m_is_local_player = true;
+                       m_is_visible = false;
+                       player->setCAO(this);
+               }
+               if (m_client->getProtoVersion() < 33)
+                       m_env->addPlayerName(m_name.c_str());
+       }
+}
+
+void GenericCAO::processInitData(const std::string &data)
+{
        std::istringstream is(data, std::ios::binary);
        int num_messages = 0;
        // version
        u8 version = readU8(is);
        // check version
-       if(version == 1) // In PROTOCOL_VERSION 14
-       {
+       if (version == 1) { // In PROTOCOL_VERSION 14
                m_name = deSerializeString(is);
                m_is_player = readU8(is);
-               m_id = readS16(is);
+               m_id = readU16(is);
                m_position = readV3F1000(is);
                m_yaw = readF1000(is);
                m_hp = readS16(is);
                num_messages = readU8(is);
-       }
-       else if(version == 0) // In PROTOCOL_VERSION 13
-       {
+       } else if (version == 0) { // In PROTOCOL_VERSION 13
                m_name = deSerializeString(is);
                m_is_player = readU8(is);
                m_position = readV3F1000(is);
                m_yaw = readF1000(is);
                m_hp = readS16(is);
                num_messages = readU8(is);
-       }
-       else
-       {
+       } else {
                errorstream<<"GenericCAO: Unsupported init data version"
                                <<std::endl;
                return;
        }
 
-       for(int i=0; i<num_messages; i++)
-       {
+       for (int i = 0; i < num_messages; i++) {
                std::string message = deSerializeLongString(is);
                processMessage(message);
        }
 
        pos_translator.init(m_position);
        updateNodePos();
-
-       if(m_is_player)
-       {
-               Player *player = m_env->getPlayer(m_name.c_str());
-               if(player && player->isLocal())
-               {
-                       m_is_local_player = true;
-                       m_is_visible = false;
-                       LocalPlayer* localplayer = dynamic_cast<LocalPlayer*>(player);
-
-                       assert( localplayer != NULL );
-                       localplayer->setCAO(this);
-               }
-               m_env->addPlayerName(m_name.c_str());
-       }
 }
 
 GenericCAO::~GenericCAO()
 {
-       if (m_is_player) {
+       if (m_is_player && m_client->getProtoVersion() < 33) {
                m_env->removePlayerName(m_name.c_str());
        }
        removeFromScene(true);
@@ -710,26 +643,11 @@ scene::ISceneNode* GenericCAO::getSceneNode()
        return NULL;
 }
 
-scene::IMeshSceneNode* GenericCAO::getMeshSceneNode()
-{
-       return m_meshnode;
-}
-
 scene::IAnimatedMeshSceneNode* GenericCAO::getAnimatedMeshSceneNode()
 {
        return m_animated_meshnode;
 }
 
-WieldMeshSceneNode* GenericCAO::getWieldMeshSceneNode()
-{
-       return m_wield_meshnode;
-}
-
-scene::IBillboardSceneNode* GenericCAO::getSpriteSceneNode()
-{
-       return m_spritenode;
-}
-
 void GenericCAO::setChildrenVisible(bool toset)
 {
        for (std::vector<u16>::size_type i = 0; i < m_children.size(); i++) {
@@ -798,7 +716,7 @@ void GenericCAO::removeFromScene(bool permanent)
        }
 
        if (m_nametag) {
-               m_gamedef->getCamera()->removeNametag(m_nametag);
+               m_client->getCamera()->removeNametag(m_nametag);
                m_nametag = NULL;
        }
 }
@@ -839,54 +757,50 @@ void GenericCAO::addToScene(scene::ISceneManager *smgr,
                        setBillboardTextureMatrix(m_spritenode,
                                        txs, tys, 0, 0);
                }
-       }
-       else if(m_prop.visual == "upright_sprite") {
+       } else if (m_prop.visual == "upright_sprite") {
                scene::SMesh *mesh = new scene::SMesh();
-               double dx = BS*m_prop.visual_size.X/2;
-               double dy = BS*m_prop.visual_size.Y/2;
-               { // Front
-               scene::IMeshBuffer *buf = new scene::SMeshBuffer();
+               double dx = BS * m_prop.visual_size.X / 2;
+               double dy = BS * m_prop.visual_size.Y / 2;
                u8 li = m_last_light;
-               video::SColor c(255,li,li,li);
-               video::S3DVertex vertices[4] =
-               {
-                       video::S3DVertex(-dx,-dy,0, 0,0,0, c, 0,1),
-                       video::S3DVertex(dx,-dy,0, 0,0,0, c, 1,1),
-                       video::S3DVertex(dx,dy,0, 0,0,0, c, 1,0),
-                       video::S3DVertex(-dx,dy,0, 0,0,0, c, 0,0),
-               };
-               u16 indices[] = {0,1,2,2,3,0};
-               buf->append(vertices, 4, indices, 6);
-               // Set material
-               buf->getMaterial().setFlag(video::EMF_LIGHTING, false);
-               buf->getMaterial().setFlag(video::EMF_BILINEAR_FILTER, false);
-               buf->getMaterial().setFlag(video::EMF_FOG_ENABLE, true);
-               buf->getMaterial().MaterialType = video::EMT_TRANSPARENT_ALPHA_CHANNEL;
-               // Add to mesh
-               mesh->addMeshBuffer(buf);
-               buf->drop();
+               video::SColor c(255, li, li, li);
+
+               { // Front
+                       scene::IMeshBuffer *buf = new scene::SMeshBuffer();
+                       video::S3DVertex vertices[4] = {
+                               video::S3DVertex(-dx, -dy, 0, 0,0,0, c, 1,1),
+                               video::S3DVertex( dx, -dy, 0, 0,0,0, c, 0,1),
+                               video::S3DVertex( dx,  dy, 0, 0,0,0, c, 0,0),
+                               video::S3DVertex(-dx,  dy, 0, 0,0,0, c, 1,0),
+                       };
+                       u16 indices[] = {0,1,2,2,3,0};
+                       buf->append(vertices, 4, indices, 6);
+                       // Set material
+                       buf->getMaterial().setFlag(video::EMF_LIGHTING, false);
+                       buf->getMaterial().setFlag(video::EMF_BILINEAR_FILTER, false);
+                       buf->getMaterial().setFlag(video::EMF_FOG_ENABLE, true);
+                       buf->getMaterial().MaterialType = video::EMT_TRANSPARENT_ALPHA_CHANNEL;
+                       // Add to mesh
+                       mesh->addMeshBuffer(buf);
+                       buf->drop();
                }
                { // Back
-               scene::IMeshBuffer *buf = new scene::SMeshBuffer();
-               u8 li = m_last_light;
-               video::SColor c(255,li,li,li);
-               video::S3DVertex vertices[4] =
-               {
-                       video::S3DVertex(dx,-dy,0, 0,0,0, c, 1,1),
-                       video::S3DVertex(-dx,-dy,0, 0,0,0, c, 0,1),
-                       video::S3DVertex(-dx,dy,0, 0,0,0, c, 0,0),
-                       video::S3DVertex(dx,dy,0, 0,0,0, c, 1,0),
-               };
-               u16 indices[] = {0,1,2,2,3,0};
-               buf->append(vertices, 4, indices, 6);
-               // Set material
-               buf->getMaterial().setFlag(video::EMF_LIGHTING, false);
-               buf->getMaterial().setFlag(video::EMF_BILINEAR_FILTER, false);
-               buf->getMaterial().setFlag(video::EMF_FOG_ENABLE, true);
-               buf->getMaterial().MaterialType = video::EMT_TRANSPARENT_ALPHA_CHANNEL_REF;
-               // Add to mesh
-               mesh->addMeshBuffer(buf);
-               buf->drop();
+                       scene::IMeshBuffer *buf = new scene::SMeshBuffer();
+                       video::S3DVertex vertices[4] = {
+                               video::S3DVertex( dx,-dy, 0, 0,0,0, c, 1,1),
+                               video::S3DVertex(-dx,-dy, 0, 0,0,0, c, 0,1),
+                               video::S3DVertex(-dx, dy, 0, 0,0,0, c, 0,0),
+                               video::S3DVertex( dx, dy, 0, 0,0,0, c, 1,0),
+                       };
+                       u16 indices[] = {0,1,2,2,3,0};
+                       buf->append(vertices, 4, indices, 6);
+                       // Set material
+                       buf->getMaterial().setFlag(video::EMF_LIGHTING, false);
+                       buf->getMaterial().setFlag(video::EMF_BILINEAR_FILTER, false);
+                       buf->getMaterial().setFlag(video::EMF_FOG_ENABLE, true);
+                       buf->getMaterial().MaterialType = video::EMT_TRANSPARENT_ALPHA_CHANNEL_REF;
+                       // Add to mesh
+                       mesh->addMeshBuffer(buf);
+                       buf->drop();
                }
                m_meshnode = smgr->addMeshSceneNode(mesh, NULL);
                m_meshnode->grab();
@@ -915,7 +829,7 @@ void GenericCAO::addToScene(scene::ISceneManager *smgr,
        }
        else if(m_prop.visual == "mesh") {
                infostream<<"GenericCAO::addToScene(): mesh"<<std::endl;
-               scene::IAnimatedMesh *mesh = m_gamedef->getMesh(m_prop.mesh);
+               scene::IAnimatedMesh *mesh = m_client->getMesh(m_prop.mesh);
                if(mesh)
                {
                        m_animated_meshnode = smgr->addAnimatedMeshSceneNode(mesh, NULL);
@@ -942,33 +856,43 @@ void GenericCAO::addToScene(scene::ISceneManager *smgr,
                        errorstream<<"GenericCAO::addToScene(): Could not load mesh "<<m_prop.mesh<<std::endl;
        }
        else if(m_prop.visual == "wielditem") {
-               infostream<<"GenericCAO::addToScene(): wielditem"<<std::endl;
-               infostream<<"textures: "<<m_prop.textures.size()<<std::endl;
-               if(m_prop.textures.size() >= 1){
-                       infostream<<"textures[0]: "<<m_prop.textures[0]<<std::endl;
-                       IItemDefManager *idef = m_gamedef->idef();
-                       ItemStack item(m_prop.textures[0], 1, 0, "", idef);
-
-                       m_wield_meshnode = new WieldMeshSceneNode(
-                                       smgr->getRootSceneNode(), smgr, -1);
-                       m_wield_meshnode->setItem(item, m_gamedef);
-
-                       m_wield_meshnode->setScale(v3f(m_prop.visual_size.X/2,
-                                       m_prop.visual_size.Y/2,
-                                       m_prop.visual_size.X/2));
-                       u8 li = m_last_light;
-                       m_wield_meshnode->setColor(video::SColor(255,li,li,li));
+               ItemStack item;
+               infostream << "GenericCAO::addToScene(): wielditem" << std::endl;
+               if (m_prop.wield_item == "") {
+                       // Old format, only textures are specified.
+                       infostream << "textures: " << m_prop.textures.size() << std::endl;
+                       if (m_prop.textures.size() >= 1) {
+                               infostream << "textures[0]: " << m_prop.textures[0]
+                                       << std::endl;
+                               IItemDefManager *idef = m_client->idef();
+                               item = ItemStack(m_prop.textures[0], 1, 0, idef);
+                       }
+               } else {
+                       infostream << "serialized form: " << m_prop.wield_item << std::endl;
+                       item.deSerialize(m_prop.wield_item, m_client->idef());
                }
+               m_wield_meshnode = new WieldMeshSceneNode(smgr->getRootSceneNode(),
+                       smgr, -1);
+               m_wield_meshnode->setItem(item, m_client);
+
+               m_wield_meshnode->setScale(
+                       v3f(m_prop.visual_size.X / 2, m_prop.visual_size.Y / 2,
+                               m_prop.visual_size.X / 2));
+               u8 li = m_last_light;
+               m_wield_meshnode->setColor(video::SColor(255, li, li, li));
        } else {
                infostream<<"GenericCAO::addToScene(): \""<<m_prop.visual
                                <<"\" not supported"<<std::endl;
        }
-       updateTextures("");
+
+       /* don't update while punch texture modifier is active */
+       if (m_reset_textures_timer < 0)
+               updateTextures(m_current_texture_modifier);
 
        scene::ISceneNode *node = getSceneNode();
        if (node && m_prop.nametag != "" && !m_is_local_player) {
                // Add nametag
-               m_nametag = m_gamedef->getCamera()->addNametag(node,
+               m_nametag = m_client->getCamera()->addNametag(node,
                        m_prop.nametag, m_prop.nametag_color);
        }
 
@@ -1040,12 +964,9 @@ void GenericCAO::updateNodePos()
 void GenericCAO::step(float dtime, ClientEnvironment *env)
 {
        // Handel model of local player instantly to prevent lags
-       if(m_is_local_player)
-       {
+       if (m_is_local_player) {
                LocalPlayer *player = m_env->getLocalPlayer();
-
-               if (m_is_visible)
-               {
+               if (m_is_visible) {
                        int old_anim = player->last_animation;
                        float old_anim_speed = player->last_animation_speed;
                        m_position = player->getPosition() + v3f(0,BS,0);
@@ -1053,10 +974,12 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
                        m_acceleration = v3f(0,0,0);
                        pos_translator.vect_show = m_position;
                        m_yaw = player->getYaw();
-                       PlayerControl controls = player->getPlayerControl();
+                       const PlayerControl &controls = player->getPlayerControl();
 
                        bool walking = false;
-                       if(controls.up || controls.down || controls.left || controls.right)
+                       if (controls.up || controls.down || controls.left || controls.right ||
+                                       controls.forw_move_joystick_axis != 0.f ||
+                                       controls.sidew_move_joystick_axis != 0.f)
                                walking = true;
 
                        f32 new_speed = player->local_animation_speed;
@@ -1065,18 +988,17 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
 
                        // increase speed if using fast or flying fast
                        if((g_settings->getBool("fast_move") &&
-                                       m_gamedef->checkLocalPrivilege("fast")) &&
+                                       m_client->checkLocalPrivilege("fast")) &&
                                        (controls.aux1 ||
                                        (!player->touching_ground &&
                                        g_settings->getBool("free_move") &&
-                                       m_gamedef->checkLocalPrivilege("fly"))))
+                                       m_client->checkLocalPrivilege("fly"))))
                                        new_speed *= 1.5;
                        // slowdown speed if sneeking
-                       if(controls.sneak && walking)
+                       if (controls.sneak && walking)
                                new_speed /= 2;
 
-                       if(walking && (controls.LMB || controls.RMB))
-                       {
+                       if (walking && (controls.LMB || controls.RMB)) {
                                new_anim = player->local_animations[3];
                                player->last_animation = WD_ANIM;
                        } else if(walking) {
@@ -1089,8 +1011,7 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
 
                        // Apply animations if input detected and not attached
                        // or set idle animation
-                       if ((new_anim.X + new_anim.Y) > 0 && !player->isAttached)
-                       {
+                       if ((new_anim.X + new_anim.Y) > 0 && !player->isAttached) {
                                allow_update = true;
                                m_animation_range = new_anim;
                                m_animation_speed = new_speed;
@@ -1098,8 +1019,7 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
                        } else {
                                player->last_animation = NO_ANIM;
 
-                               if (old_anim != NO_ANIM)
-                               {
+                               if (old_anim != NO_ANIM) {
                                        m_animation_range = player->local_animations[0];
                                        updateAnimation();
                                }
@@ -1136,7 +1056,7 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
                }
 
                removeFromScene(false);
-               addToScene(m_smgr, m_gamedef->tsrc(), m_irr);
+               addToScene(m_smgr, m_client->tsrc(), m_irr);
 
                // Attachments, part 2: Now that the parent has been refreshed, put its attachments back
                for (std::vector<u16>::size_type i = 0; i < m_children.size(); i++) {
@@ -1206,12 +1126,12 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
                        m_step_distance_counter = 0;
                        if(!m_is_local_player && m_prop.makes_footstep_sound)
                        {
-                               INodeDefManager *ndef = m_gamedef->ndef();
+                               INodeDefManager *ndef = m_client->ndef();
                                v3s16 p = floatToInt(getPosition() + v3f(0,
                                                (m_prop.collisionbox.MinEdge.Y-0.5)*BS, 0), BS);
                                MapNode n = m_env->getMap().getNodeNoEx(p);
                                SimpleSoundSpec spec = ndef->get(n).sound_footstep;
-                               m_gamedef->sound()->playSoundAt(spec, false, getPosition());
+                               m_client->sound()->playSoundAt(spec, false, getPosition());
                        }
                }
        }
@@ -1230,9 +1150,9 @@ void GenericCAO::step(float dtime, ClientEnvironment *env)
        if(m_reset_textures_timer >= 0)
        {
                m_reset_textures_timer -= dtime;
-               if(m_reset_textures_timer <= 0){
+               if(m_reset_textures_timer <= 0) {
                        m_reset_textures_timer = -1;
-                       updateTextures("");
+                       updateTextures(m_previous_texture_modifier);
                }
        }
        if(getParent() == NULL && fabs(m_prop.automatic_rotate) > 0.001)
@@ -1310,14 +1230,17 @@ void GenericCAO::updateTexturePos()
        }
 }
 
-void GenericCAO::updateTextures(const std::string &mod)
+void GenericCAO::updateTextures(std::string mod)
 {
-       ITextureSource *tsrc = m_gamedef->tsrc();
+       ITextureSource *tsrc = m_client->tsrc();
 
        bool use_trilinear_filter = g_settings->getBool("trilinear_filter");
        bool use_bilinear_filter = g_settings->getBool("bilinear_filter");
        bool use_anisotropic_filter = g_settings->getBool("anisotropic_filter");
 
+       m_previous_texture_modifier = m_current_texture_modifier;
+       m_current_texture_modifier = mod;
+
        if(m_spritenode)
        {
                if(m_prop.visual == "sprite")
@@ -1507,10 +1430,8 @@ void GenericCAO::updateBonePosition()
                return;
 
        m_animated_meshnode->setJointMode(irr::scene::EJUOR_CONTROL); // To write positions to the mesh on render
-       for(std::map<std::string,
-                       core::vector2d<v3f> >::const_iterator ii = m_bone_position.begin();
-                       ii != m_bone_position.end(); ++ii)
-       {
+       for(std::unordered_map<std::string, core::vector2d<v3f>>::const_iterator
+                       ii = m_bone_position.begin(); ii != m_bone_position.end(); ++ii) {
                std::string bone_name = (*ii).first;
                v3f bone_pos = (*ii).second.X;
                v3f bone_rot = (*ii).second.Y;
@@ -1571,8 +1492,7 @@ void GenericCAO::processMessage(const std::string &data)
        std::istringstream is(data, std::ios::binary);
        // command
        u8 cmd = readU8(is);
-       if(cmd == GENERIC_CMD_SET_PROPERTIES)
-       {
+       if (cmd == GENERIC_CMD_SET_PROPERTIES) {
                m_prop = gob_read_set_properties(is);
 
                m_selection_box = m_prop.collisionbox;
@@ -1586,14 +1506,16 @@ void GenericCAO::processMessage(const std::string &data)
                        m_initial_tx_basepos_set = true;
                        m_tx_basepos = m_prop.initial_sprite_basepos;
                }
+               if (m_is_local_player) {
+                       LocalPlayer *player = m_env->getLocalPlayer();
+                       player->makes_footstep_sound = m_prop.makes_footstep_sound;
+               }
 
                if ((m_is_player && !m_is_local_player) && m_prop.nametag == "")
                        m_prop.nametag = m_name;
 
                expireVisuals();
-       }
-       else if(cmd == GENERIC_CMD_UPDATE_POSITION)
-       {
+       } else if (cmd == GENERIC_CMD_UPDATE_POSITION) {
                // Not sent by the server if this object is an attachment.
                // We might however get here if the server notices the object being detached before the client.
                m_position = readV3F1000(is);
@@ -1623,12 +1545,16 @@ void GenericCAO::processMessage(const std::string &data)
                        pos_translator.init(m_position);
                }
                updateNodePos();
-       }
-       else if(cmd == GENERIC_CMD_SET_TEXTURE_MOD) {
+       } else if (cmd == GENERIC_CMD_SET_TEXTURE_MOD) {
                std::string mod = deSerializeString(is);
+
+               // immediatly reset a engine issued texture modifier if a mod sends a different one
+               if (m_reset_textures_timer > 0) {
+                       m_reset_textures_timer = -1;
+                       updateTextures(m_previous_texture_modifier);
+               }
                updateTextures(mod);
-       }
-       else if(cmd == GENERIC_CMD_SET_SPRITE) {
+       } else if (cmd == GENERIC_CMD_SET_SPRITE) {
                v2s16 p = readV2S16(is);
                int num_frames = readU16(is);
                float framelength = readF1000(is);
@@ -1640,14 +1566,14 @@ void GenericCAO::processMessage(const std::string &data)
                m_tx_select_horiz_by_yawpitch = select_horiz_by_yawpitch;
 
                updateTexturePos();
-       }
-       else if(cmd == GENERIC_CMD_SET_PHYSICS_OVERRIDE) {
+       } else if (cmd == GENERIC_CMD_SET_PHYSICS_OVERRIDE) {
                float override_speed = readF1000(is);
                float override_jump = readF1000(is);
                float override_gravity = readF1000(is);
                // these are sent inverted so we get true when the server sends nothing
                bool sneak = !readU8(is);
                bool sneak_glitch = !readU8(is);
+               bool new_move = !readU8(is);
 
 
                if(m_is_local_player)
@@ -1658,9 +1584,9 @@ void GenericCAO::processMessage(const std::string &data)
                        player->physics_override_gravity = override_gravity;
                        player->physics_override_sneak = sneak;
                        player->physics_override_sneak_glitch = sneak_glitch;
+                       player->physics_override_new_move = new_move;
                }
-       }
-       else if(cmd == GENERIC_CMD_SET_ANIMATION) {
+       } else if (cmd == GENERIC_CMD_SET_ANIMATION) {
                // TODO: change frames send as v2s32 value
                v2f range = readV2F1000(is);
                if (!m_is_local_player) {
@@ -1694,8 +1620,7 @@ void GenericCAO::processMessage(const std::string &data)
                                        updateAnimation();
                        }
                }
-       }
-       else if(cmd == GENERIC_CMD_SET_BONE_POSITION) {
+       } else if (cmd == GENERIC_CMD_SET_BONE_POSITION) {
                std::string bone = deSerializeString(is);
                v3f position = readV3F1000(is);
                v3f rotation = readV3F1000(is);
@@ -1728,8 +1653,7 @@ void GenericCAO::processMessage(const std::string &data)
                }
 
                updateAttachments();
-       }
-       else if(cmd == GENERIC_CMD_PUNCHED) {
+       } else if (cmd == GENERIC_CMD_PUNCHED) {
                /*s16 damage =*/ readS16(is);
                s16 result_hp = readS16(is);
 
@@ -1748,17 +1672,16 @@ void GenericCAO::processMessage(const std::string &data)
                                                m_smgr, m_env, m_position,
                                                m_prop.visual_size * BS);
                                m_env->addSimpleObject(simple);
-                       } else {
+                       } else if (m_reset_textures_timer < 0) {
                                // TODO: Execute defined fast response
                                // Flashing shall suffice as there is no definition
                                m_reset_textures_timer = 0.05;
                                if(damage >= 2)
                                        m_reset_textures_timer += 0.05 * damage;
-                               updateTextures("^[brighten");
+                               updateTextures(m_current_texture_modifier + "^[brighten");
                        }
                }
-       }
-       else if(cmd == GENERIC_CMD_UPDATE_ARMOR_GROUPS) {
+       } else if (cmd == GENERIC_CMD_UPDATE_ARMOR_GROUPS) {
                m_armor_groups.clear();
                int armor_groups_size = readU16(is);
                for(int i=0; i<armor_groups_size; i++)
@@ -1774,6 +1697,19 @@ void GenericCAO::processMessage(const std::string &data)
                if (m_nametag != NULL) {
                        m_nametag->nametag_color = m_prop.nametag_color;
                }
+       } else if (cmd == GENERIC_CMD_SPAWN_INFANT) {
+               u16 child_id = readU16(is);
+               u8 type = readU8(is);
+
+               if (GenericCAO *childobj = m_env->getGenericCAO(child_id)) {
+                       childobj->processInitData(deSerializeLongString(is));
+               } else {
+                       m_env->addActiveObject(child_id, type, deSerializeLongString(is));
+               }
+       } else {
+               warningstream << FUNCTION_NAME
+                       << ": unknown command or outdated client \""
+                       << +cmd << "\"" << std::endl;
        }
 }
 
@@ -1784,7 +1720,7 @@ bool GenericCAO::directReportPunch(v3f dir, const ItemStack *punchitem,
 {
        assert(punchitem);      // pre-condition
        const ToolCapabilities *toolcap =
-                       &punchitem->getToolCapabilities(m_gamedef->idef());
+                       &punchitem->getToolCapabilities(m_client->idef());
        PunchDamageResult result = getPunchDamage(
                        m_armor_groups,
                        toolcap,
@@ -1807,10 +1743,12 @@ bool GenericCAO::directReportPunch(v3f dir, const ItemStack *punchitem,
                }
                // TODO: Execute defined fast response
                // Flashing shall suffice as there is no definition
-               m_reset_textures_timer = 0.05;
-               if(result.damage >= 2)
-                       m_reset_textures_timer += 0.05 * result.damage;
-               updateTextures("^[brighten");
+               if (m_reset_textures_timer < 0) {
+                       m_reset_textures_timer = 0.05;
+                       if (result.damage >= 2)
+                               m_reset_textures_timer += 0.05 * result.damage;
+                       updateTextures(m_current_texture_modifier + "^[brighten");
+               }
        }
 
        return false;