device matching against UUIDs: do not try floppies
[oweals/busybox.git] / runit / svlogd.c
index 8632ba6a5a7e9248f1c8b362b29fbb46b008182b..25799f6be556a3208135a448df9b67f3c9f4ae8b 100644 (file)
@@ -25,7 +25,7 @@ OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
 ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
 
-/* Busyboxed by Denis Vlasenko <vda.linux@googlemail.com> */
+/* Busyboxed by Denys Vlasenko <vda.linux@googlemail.com> */
 /* TODO: depends on runit_lib.c - review and reduce/eliminate */
 
 #include <sys/poll.h>
@@ -33,32 +33,11 @@ ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #include "libbb.h"
 #include "runit_lib.h"
 
-static unsigned verbose;
-static int linemax = 1000;
-////static int buflen = 1024;
-static int linelen;
+#define LESS(a,b) ((int)((unsigned)(b) - (unsigned)(a)) > 0)
 
-static char **fndir;
-static int fdwdir;
-static int wstat;
-static struct taia trotate;
+#define FMT_PTIME 30
 
-static char *line;
-static smallint exitasap;
-static smallint rotateasap;
-static smallint reopenasap;
-static smallint linecomplete = 1;
-
-static smallint tmaxflag;
-
-static char repl;
-static const char *replace = "";
-
-static sigset_t *blocked_sigset;
-static iopause_fd input;
-static int fl_flag_0;
-
-static struct logdir {
+struct logdir {
        ////char *btmp;
        /* pattern list to match, in "aa\0bb\0\cc\0\0" form */
        char *inst;
@@ -68,19 +47,74 @@ static struct logdir {
        unsigned sizemax;
        unsigned nmax;
        unsigned nmin;
-       /* int (not long) because of taia_uint() usage: */
-       unsigned tmax;
+       unsigned rotate_period;
        int ppid;
        int fddir;
        int fdcur;
        FILE* filecur; ////
        int fdlock;
-       struct taia trotate;
+       unsigned next_rotate;
        char fnsave[FMT_PTIME];
        char match;
        char matcherr;
-} *dir;
-static unsigned dirn;
+};
+
+
+struct globals {
+       struct logdir *dir;
+       unsigned verbose;
+       int linemax;
+       ////int buflen;
+       int linelen;
+
+       int fdwdir;
+       char **fndir;
+       int wstat;
+       unsigned nearest_rotate;
+
+       smallint exitasap;
+       smallint rotateasap;
+       smallint reopenasap;
+       smallint linecomplete;
+       smallint tmaxflag;
+
+       char repl;
+       const char *replace;
+       int fl_flag_0;
+       unsigned dirn;
+
+       sigset_t blocked_sigset;
+};
+#define G (*(struct globals*)ptr_to_globals)
+#define dir            (G.dir           )
+#define verbose        (G.verbose       )
+#define linemax        (G.linemax       )
+#define buflen         (G.buflen        )
+#define linelen        (G.linelen       )
+#define fndir          (G.fndir         )
+#define fdwdir         (G.fdwdir        )
+#define wstat          (G.wstat         )
+#define nearest_rotate (G.nearest_rotate)
+#define exitasap       (G.exitasap      )
+#define rotateasap     (G.rotateasap    )
+#define reopenasap     (G.reopenasap    )
+#define linecomplete   (G.linecomplete  )
+#define tmaxflag       (G.tmaxflag      )
+#define repl           (G.repl          )
+#define replace        (G.replace       )
+#define blocked_sigset (G.blocked_sigset)
+#define fl_flag_0      (G.fl_flag_0     )
+#define dirn           (G.dirn          )
+#define INIT_G() do { \
+       SET_PTR_TO_GLOBALS(xzalloc(sizeof(G))); \
+       linemax = 1000; \
+       /*buflen = 1024;*/ \
+       linecomplete = 1; \
+       replace = ""; \
+} while (0)
+
+#define line bb_common_bufsiz1
+
 
 #define FATAL "fatal: "
 #define WARNING "warning: "
@@ -111,12 +145,12 @@ static void pause_nomem(void)
 }
 static void pause1cannot(const char *m0)
 {
-       bb_perror_msg(PAUSE"cannot %s", m0);
+       bb_perror_msg(PAUSE"can't %s", m0);
        sleep(3);
 }
 static void pause2cannot(const char *m0, const char *m1)
 {
-       bb_perror_msg(PAUSE"cannot %s %s", m0, m1);
+       bb_perror_msg(PAUSE"can't %s %s", m0, m1);
        sleep(3);
 }
 
@@ -128,25 +162,77 @@ static char* wstrdup(const char *str)
        return s;
 }
 
-static unsigned processorstart(struct logdir *ld)
+/*** ex fmt_ptime.[ch] ***/
+
+/* NUL terminated */
+static void fmt_time_human_30nul(char *s)
+{
+       struct tm *t;
+       struct timeval tv;
+
+       gettimeofday(&tv, NULL);
+       t = gmtime(&(tv.tv_sec));
+       sprintf(s, "%04u-%02u-%02u_%02u:%02u:%02u.%06u000",
+               (unsigned)(1900 + t->tm_year),
+               (unsigned)(t->tm_mon + 1),
+               (unsigned)(t->tm_mday),
+               (unsigned)(t->tm_hour),
+               (unsigned)(t->tm_min),
+               (unsigned)(t->tm_sec),
+               (unsigned)(tv.tv_usec)
+       );
+       /* 4+1 + 2+1 + 2+1 + 2+1 + 2+1 + 2+1 + 9 = */
+       /* 5   + 3   + 3   + 3   + 3   + 3   + 9 = */
+       /* 20 (up to '.' inclusive) + 9 (not including '\0') */
+}
+
+/* NOT terminated! */
+static void fmt_time_bernstein_25(char *s)
 {
+       uint32_t pack[3];
+       struct timeval tv;
+       unsigned sec_hi;
+
+       gettimeofday(&tv, NULL);
+       sec_hi = (0x400000000000000aULL + tv.tv_sec) >> 32;
+       tv.tv_sec = (time_t)(0x400000000000000aULL) + tv.tv_sec;
+       tv.tv_usec *= 1000;
+       /* Network order is big-endian: most significant byte first.
+        * This is exactly what we want here */
+       pack[0] = htonl(sec_hi);
+       pack[1] = htonl(tv.tv_sec);
+       pack[2] = htonl(tv.tv_usec);
+       *s++ = '@';
+       bin2hex(s, (char*)pack, 12);
+}
+
+static void processorstart(struct logdir *ld)
+{
+       char sv_ch;
        int pid;
 
-       if (!ld->processor) return 0;
+       if (!ld->processor) return;
        if (ld->ppid) {
                warnx("processor already running", ld->name);
-               return 0;
+               return;
        }
-       while ((pid = fork()) == -1)
-               pause2cannot("fork for processor", ld->name);
+
+       /* vfork'ed child trashes this byte, save... */
+       sv_ch = ld->fnsave[26];
+
+       while ((pid = vfork()) == -1)
+               pause2cannot("vfork for processor", ld->name);
        if (!pid) {
                char *prog[4];
                int fd;
 
                /* child */
-               signal(SIGTERM, SIG_DFL);
-               signal(SIGALRM, SIG_DFL);
-               signal(SIGHUP, SIG_DFL);
+               /* Non-ignored signals revert to SIG_DFL on exec anyway */
+               /*bb_signals(0
+                       + (1 << SIGTERM)
+                       + (1 << SIGALRM)
+                       + (1 << SIGHUP)
+                       , SIG_DFL);*/
                sig_unblock(SIGTERM);
                sig_unblock(SIGALRM);
                sig_unblock(SIGHUP);
@@ -155,13 +241,13 @@ static unsigned processorstart(struct logdir *ld)
                        bb_error_msg(INFO"processing: %s/%s", ld->name, ld->fnsave);
                fd = xopen(ld->fnsave, O_RDONLY|O_NDELAY);
                xmove_fd(fd, 0);
-               ld->fnsave[26] = 't';
+               ld->fnsave[26] = 't'; /* <- that's why we need sv_ch! */
                fd = xopen(ld->fnsave, O_WRONLY|O_NDELAY|O_TRUNC|O_CREAT);
                xmove_fd(fd, 1);
                fd = open_read("state");
                if (fd == -1) {
                        if (errno != ENOENT)
-                               bb_perror_msg_and_die(FATAL"cannot %s processor %s", "open state for", ld->name);
+                               bb_perror_msg_and_die(FATAL"can't %s processor %s", "open state for", ld->name);
                        close(xopen("state", O_WRONLY|O_NDELAY|O_TRUNC|O_CREAT));
                        fd = xopen("state", O_RDONLY|O_NDELAY);
                }
@@ -174,11 +260,11 @@ static unsigned processorstart(struct logdir *ld)
                prog[1] = (char*)"-c";
                prog[2] = ld->processor;
                prog[3] = NULL;
-               execve("/bin/sh", prog, environ);
-               bb_perror_msg_and_die(FATAL"cannot %s processor %s", "run", ld->name);
+               execv("/bin/sh", prog);
+               bb_perror_msg_and_die(FATAL"can't %s processor %s", "run", ld->name);
        }
+       ld->fnsave[26] = sv_ch; /* ...restore */
        ld->ppid = pid;
-       return 1;
 }
 
 static unsigned processorstop(struct logdir *ld)
@@ -187,7 +273,7 @@ static unsigned processorstop(struct logdir *ld)
 
        if (ld->ppid) {
                sig_unblock(SIGHUP);
-               while (wait_pid(&wstat, ld->ppid) == -1)
+               while (safe_waitpid(ld->ppid, &wstat, 0) == -1)
                        pause2cannot("wait for processor", ld->name);
                sig_block(SIGHUP);
                ld->ppid = 0;
@@ -195,7 +281,7 @@ static unsigned processorstop(struct logdir *ld)
        if (ld->fddir == -1) return 1;
        while (fchdir(ld->fddir) == -1)
                pause2cannot("change directory, want processor", ld->name);
-       if (wait_exitcode(wstat) != 0) {
+       if (WEXITSTATUS(wstat) != 0) {
                warnx("processor failed, restart", ld->name);
                ld->fnsave[26] = 't';
                unlink(ld->fnsave);
@@ -215,7 +301,7 @@ static unsigned processorstop(struct logdir *ld)
                pause2cannot("set mode of processed", ld->name);
        ld->fnsave[26] = 'u';
        if (unlink(ld->fnsave) == -1)
-               bb_error_msg(WARNING"cannot unlink: %s/%s", ld->name, ld->fnsave);
+               bb_error_msg(WARNING"can't unlink: %s/%s", ld->name, ld->fnsave);
        while (rename("newstate", "state") == -1)
                pause2cannot("rename state", ld->name);
        if (verbose)
@@ -240,7 +326,7 @@ static void rmoldest(struct logdir *ld)
                if ((f->d_name[0] == '@') && (strlen(f->d_name) == 27)) {
                        if (f->d_name[26] == 't') {
                                if (unlink(f->d_name) == -1)
-                                       warn2("cannot unlink processor leftover", f->d_name);
+                                       warn2("can't unlink processor leftover", f->d_name);
                        } else {
                                ++n;
                                if (strcmp(f->d_name, oldest) < 0)
@@ -250,29 +336,29 @@ static void rmoldest(struct logdir *ld)
                }
        }
        if (errno)
-               warn2("cannot read directory", ld->name);
+               warn2("can't read directory", ld->name);
        closedir(d);
 
        if (ld->nmax && (n > ld->nmax)) {
                if (verbose)
                        bb_error_msg(INFO"delete: %s/%s", ld->name, oldest);
                if ((*oldest == '@') && (unlink(oldest) == -1))
-                       warn2("cannot unlink oldest logfile", ld->name);
+                       warn2("can't unlink oldest logfile", ld->name);
        }
 }
 
 static unsigned rotate(struct logdir *ld)
 {
        struct stat st;
-       struct taia now;
+       unsigned now;
 
        if (ld->fddir == -1) {
-               ld->tmax = 0;
+               ld->rotate_period = 0;
                return 0;
        }
        if (ld->ppid)
                while (!processorstop(ld))
-                       /* wait */;
+                       continue;
 
        while (fchdir(ld->fddir) == -1)
                pause2cannot("change directory, want rotate", ld->name);
@@ -284,17 +370,16 @@ static unsigned rotate(struct logdir *ld)
                ld->fnsave[26] = 'u';
        ld->fnsave[27] = '\0';
        do {
-               taia_now(&now);
-               fmt_taia25(ld->fnsave, &now);
+               fmt_time_bernstein_25(ld->fnsave);
                errno = 0;
                stat(ld->fnsave, &st);
        } while (errno != ENOENT);
 
-       if (ld->tmax && taia_less(&ld->trotate, &now)) {
-               taia_uint(&ld->trotate, ld->tmax);
-               taia_add(&ld->trotate, &now, &ld->trotate);
-               if (taia_less(&ld->trotate, &trotate))
-                       trotate = ld->trotate;
+       now = monotonic_sec();
+       if (ld->rotate_period && LESS(ld->next_rotate, now)) {
+               ld->next_rotate = now + ld->rotate_period;
+               if (LESS(ld->next_rotate, nearest_rotate))
+                       nearest_rotate = ld->next_rotate;
        }
 
        if (ld->size > 0) {
@@ -316,7 +401,7 @@ static unsigned rotate(struct logdir *ld)
                /* we presume this cannot fail */
                ld->filecur = fdopen(ld->fdcur, "a"); ////
                setvbuf(ld->filecur, NULL, _IOFBF, linelen); ////
-               coe(ld->fdcur);
+               close_on_exec_on(ld->fdcur);
                ld->size = 0;
                while (fchmod(ld->fdcur, 0644) == -1)
                        pause2cannot("set mode of current", ld->name);
@@ -367,7 +452,7 @@ static int buffer_pwrite(int n, char *s, unsigned len)
                                        if (strcmp(f->d_name, oldest) < 0)
                                                memcpy(oldest, f->d_name, 27);
                                }
-                       if (errno) warn2("cannot read directory, want remove old logfile",
+                       if (errno) warn2("can't read directory, want remove old logfile",
                                        ld->name);
                        closedir(d);
                        errno = ENOSPC;
@@ -377,7 +462,7 @@ static int buffer_pwrite(int n, char *s, unsigned len)
                                                        ld->name, oldest);
                                        errno = 0;
                                        if (unlink(oldest) == -1) {
-                                               warn2("cannot unlink oldest logfile", ld->name);
+                                               warn2("can't unlink oldest logfile", ld->name);
                                                errno = ENOSPC;
                                        }
                                        while (fchdir(fdwdir) == -1)
@@ -425,20 +510,22 @@ static void logdir_close(struct logdir *ld)
 static unsigned logdir_open(struct logdir *ld, const char *fn)
 {
        char buf[128];
-       struct taia now;
+       unsigned now;
        char *new, *s, *np;
        int i;
        struct stat st;
 
+       now = monotonic_sec();
+
        ld->fddir = open(fn, O_RDONLY|O_NDELAY);
        if (ld->fddir == -1) {
-               warn2("cannot open log directory", (char*)fn);
+               warn2("can't open log directory", (char*)fn);
                return 0;
        }
-       coe(ld->fddir);
+       close_on_exec_on(ld->fddir);
        if (fchdir(ld->fddir) == -1) {
                logdir_close(ld);
-               warn2("cannot change directory", (char*)fn);
+               warn2("can't change directory", (char*)fn);
                return 0;
        }
        ld->fdlock = open("lock", O_WRONLY|O_NDELAY|O_APPEND|O_CREAT, 0600);
@@ -446,17 +533,17 @@ static unsigned logdir_open(struct logdir *ld, const char *fn)
         || (lock_exnb(ld->fdlock) == -1)
        ) {
                logdir_close(ld);
-               warn2("cannot lock directory", (char*)fn);
+               warn2("can't lock directory", (char*)fn);
                while (fchdir(fdwdir) == -1)
                        pause1cannot("change to initial working directory");
                return 0;
        }
-       coe(ld->fdlock);
+       close_on_exec_on(ld->fdlock);
 
        ld->size = 0;
        ld->sizemax = 1000000;
        ld->nmax = ld->nmin = 10;
-       ld->tmax = 0;
+       ld->rotate_period = 0;
        ld->name = (char*)fn;
        ld->ppid = 0;
        ld->match = '+';
@@ -466,21 +553,25 @@ static unsigned logdir_open(struct logdir *ld, const char *fn)
        /* read config */
        i = open_read_close("config", buf, sizeof(buf));
        if (i < 0 && errno != ENOENT)
-               bb_perror_msg(WARNING"%s/config", ld->name);
+               bb_perror_msg(WARNING"%s/config", ld->name);
        if (i > 0) {
-               if (verbose) bb_error_msg(INFO"read: %s/config", ld->name);
+               if (verbose)
+                       bb_error_msg(INFO"read: %s/config", ld->name);
                s = buf;
                while (s) {
                        np = strchr(s, '\n');
-                       if (np) *np++ = '\0';
+                       if (np)
+                               *np++ = '\0';
                        switch (s[0]) {
                        case '+':
                        case '-':
                        case 'e':
                        case 'E':
+                               /* Add '\n'-terminated line to ld->inst */
                                while (1) {
-                                       int l = asprintf(&new, "%s%s\n", ld->inst?:"", s);
-                                       if (l >= 0 && new) break;
+                                       int l = asprintf(&new, "%s%s\n", ld->inst ? : "", s);
+                                       if (l >= 0 && new)
+                                               break;
                                        pause_nomem();
                                }
                                free(ld->inst);
@@ -508,12 +599,11 @@ static unsigned logdir_open(struct logdir *ld, const char *fn)
                                        /*{ "d", 24*60*60 },*/
                                        { }
                                };
-                               ld->tmax = xatou_sfx(&s[1], mh_suffixes);
-                               if (ld->tmax) {
-                                       taia_uint(&ld->trotate, ld->tmax);
-                                       taia_add(&ld->trotate, &now, &ld->trotate);
-                                       if (!tmaxflag || taia_less(&ld->trotate, &trotate))
-                                               trotate = ld->trotate;
+                               ld->rotate_period = xatou_sfx(&s[1], mh_suffixes);
+                               if (ld->rotate_period) {
+                                       ld->next_rotate = now + ld->rotate_period;
+                                       if (!tmaxflag || LESS(ld->next_rotate, nearest_rotate))
+                                               nearest_rotate = ld->next_rotate;
                                        tmaxflag = 1;
                                }
                                break;
@@ -531,7 +621,8 @@ static unsigned logdir_open(struct logdir *ld, const char *fn)
                s = ld->inst;
                while (s) {
                        np = strchr(s, '\n');
-                       if (np) *np++ = '\0';
+                       if (np)
+                               *np++ = '\0';
                        s = np;
                }
        }
@@ -539,13 +630,12 @@ static unsigned logdir_open(struct logdir *ld, const char *fn)
        /* open current */
        i = stat("current", &st);
        if (i != -1) {
-               if (st.st_size && ! (st.st_mode & S_IXUSR)) {
+               if (st.st_size && !(st.st_mode & S_IXUSR)) {
                        ld->fnsave[25] = '.';
                        ld->fnsave[26] = 'u';
                        ld->fnsave[27] = '\0';
                        do {
-                               taia_now(&now);
-                               fmt_taia25(ld->fnsave, &now);
+                               fmt_time_bernstein_25(ld->fnsave);
                                errno = 0;
                                stat(ld->fnsave, &st);
                        } while (errno != ENOENT);
@@ -554,14 +644,15 @@ static unsigned logdir_open(struct logdir *ld, const char *fn)
                        rmoldest(ld);
                        i = -1;
                } else {
-                       /* Be paranoid: st.st_size can be not just bigger, but WIDER! */
-                       /* (bug in original svlogd. remove this comment when fixed there) */
+                       /* st.st_size can be not just bigger, but WIDER!
+                        * This code is safe: if st.st_size > 4GB, we select
+                        * ld->sizemax (because it's "unsigned") */
                        ld->size = (st.st_size > ld->sizemax) ? ld->sizemax : st.st_size;
                }
        } else {
                if (errno != ENOENT) {
                        logdir_close(ld);
-                       warn2("cannot stat current", ld->name);
+                       warn2("can't stat current", ld->name);
                        while (fchdir(fdwdir) == -1)
                                pause1cannot("change to initial working directory");
                        return 0;
@@ -573,7 +664,7 @@ static unsigned logdir_open(struct logdir *ld, const char *fn)
        ld->filecur = fdopen(ld->fdcur, "a"); ////
        setvbuf(ld->filecur, NULL, _IOFBF, linelen); ////
 
-       coe(ld->fdcur);
+       close_on_exec_on(ld->fdcur);
        while (fchmod(ld->fdcur, 0644) == -1)
                pause2cannot("set mode of current", ld->name);
 
@@ -589,17 +680,17 @@ static unsigned logdir_open(struct logdir *ld, const char *fn)
 
 static void logdirs_reopen(void)
 {
-       struct taia now;
        int l;
        int ok = 0;
 
        tmaxflag = 0;
-       taia_now(&now);
        for (l = 0; l < dirn; ++l) {
                logdir_close(&dir[l]);
-               if (logdir_open(&dir[l], fndir[l])) ok = 1;
+               if (logdir_open(&dir[l], fndir[l]))
+                       ok = 1;
        }
-       if (!ok) fatalx("no functional log directories");
+       if (!ok)
+               fatalx("no functional log directories");
 }
 
 /* Will look good in libbb one day */
@@ -614,44 +705,57 @@ static ssize_t ndelay_read(int fd, void *buf, size_t count)
 }
 
 /* Used for reading stdin */
-static int buffer_pread(int fd, char *s, unsigned len, struct taia *now)
+static int buffer_pread(/*int fd, */char *s, unsigned len)
 {
+       unsigned now;
+       struct pollfd input;
        int i;
 
-       if (rotateasap) {
-               for (i = 0; i < dirn; ++i)
-                       rotate(dir+i);
-               rotateasap = 0;
-       }
-       if (exitasap) {
-               if (linecomplete)
-                       return 0;
-               len = 1;
-       }
-       if (reopenasap) {
-               logdirs_reopen();
-               reopenasap = 0;
-       }
-       taia_uint(&trotate, 2744);
-       taia_add(&trotate, now, &trotate);
-       for (i = 0; i < dirn; ++i)
-               if (dir[i].tmax) {
-                       if (taia_less(&dir[i].trotate, now))
-                               rotate(dir+i);
-                       if (taia_less(&dir[i].trotate, &trotate))
-                               trotate = dir[i].trotate;
-               }
+       input.fd = 0;
+       input.events = POLLIN;
 
        do {
-               sigprocmask(SIG_UNBLOCK, blocked_sigset, NULL);
-               iopause(&input, 1, &trotate, now);
-// TODO: do not unblock/block, but use sigpending after iopause
-// to see whether there was any sig? (one syscall less...)
-               sigprocmask(SIG_BLOCK, blocked_sigset, NULL);
-               i = ndelay_read(fd, s, len);
-               if (i >= 0) break;
+               if (rotateasap) {
+                       for (i = 0; i < dirn; ++i)
+                               rotate(dir + i);
+                       rotateasap = 0;
+               }
+               if (exitasap) {
+                       if (linecomplete)
+                               return 0;
+                       len = 1;
+               }
+               if (reopenasap) {
+                       logdirs_reopen();
+                       reopenasap = 0;
+               }
+               now = monotonic_sec();
+               nearest_rotate = now + (45 * 60 + 45);
+               for (i = 0; i < dirn; ++i) {
+                       if (dir[i].rotate_period) {
+                               if (LESS(dir[i].next_rotate, now))
+                                       rotate(dir + i);
+                               if (LESS(dir[i].next_rotate, nearest_rotate))
+                                       nearest_rotate = dir[i].next_rotate;
+                       }
+               }
+
+               sigprocmask(SIG_UNBLOCK, &blocked_sigset, NULL);
+               i = nearest_rotate - now;
+               if (i > 1000000)
+                       i = 1000000;
+               if (i <= 0)
+                       i = 1;
+               poll(&input, 1, i * 1000);
+               sigprocmask(SIG_BLOCK, &blocked_sigset, NULL);
+
+               i = ndelay_read(STDIN_FILENO, s, len);
+               if (i >= 0)
+                       break;
+               if (errno == EINTR)
+                       continue;
                if (errno != EAGAIN) {
-                       warn("cannot read standard input");
+                       warn("can't read standard input");
                        break;
                }
                /* else: EAGAIN - normal, repeat silently */
@@ -660,7 +764,8 @@ static int buffer_pread(int fd, char *s, unsigned len, struct taia *now)
        if (i > 0) {
                int cnt;
                linecomplete = (s[i-1] == '\n');
-               if (!repl) return i;
+               if (!repl)
+                       return i;
 
                cnt = i;
                while (--cnt >= 0) {
@@ -684,37 +789,39 @@ static int buffer_pread(int fd, char *s, unsigned len, struct taia *now)
        return i;
 }
 
-
-static void sig_term_handler(int sig_no)
+static void sig_term_handler(int sig_no UNUSED_PARAM)
 {
        if (verbose)
                bb_error_msg(INFO"sig%s received", "term");
        exitasap = 1;
 }
 
-static void sig_child_handler(int sig_no)
+static void sig_child_handler(int sig_no UNUSED_PARAM)
 {
-       int pid, l;
+       pid_t pid;
+       int l;
 
        if (verbose)
                bb_error_msg(INFO"sig%s received", "child");
-       while ((pid = wait_nohang(&wstat)) > 0)
-               for (l = 0; l < dirn; ++l)
+       while ((pid = wait_any_nohang(&wstat)) > 0) {
+               for (l = 0; l < dirn; ++l) {
                        if (dir[l].ppid == pid) {
                                dir[l].ppid = 0;
                                processorstop(&dir[l]);
                                break;
                        }
+               }
+       }
 }
 
-static void sig_alarm_handler(int sig_no)
+static void sig_alarm_handler(int sig_no UNUSED_PARAM)
 {
        if (verbose)
                bb_error_msg(INFO"sig%s received", "alarm");
        rotateasap = 1;
 }
 
-static void sig_hangup_handler(int sig_no)
+static void sig_hangup_handler(int sig_no UNUSED_PARAM)
 {
        if (verbose)
                bb_error_msg(INFO"sig%s received", "hangup");
@@ -745,10 +852,9 @@ static void logmatch(struct logdir *ld)
        }
 }
 
-int svlogd_main(int argc, char **argv);
+int svlogd_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
 int svlogd_main(int argc, char **argv)
 {
-       sigset_t ss;
        char *r,*l,*b;
        ssize_t stdin_cnt = 0;
        int i;
@@ -756,7 +862,7 @@ int svlogd_main(int argc, char **argv)
        unsigned timestamp = 0;
        void* (*memRchr)(const void *, int, size_t) = memchr;
 
-#define line bb_common_bufsiz1
+       INIT_G();
 
        opt_complementary = "tt:vv";
        opt = getopt32(argv, "r:R:l:b:tv",
@@ -785,7 +891,7 @@ int svlogd_main(int argc, char **argv)
        if (dirn <= 0) usage();
        ////if (buflen <= linemax) usage();
        fdwdir = xopen(".", O_RDONLY|O_NDELAY);
-       coe(fdwdir);
+       close_on_exec_on(fdwdir);
        dir = xzalloc(dirn * sizeof(struct logdir));
        for (i = 0; i < dirn; ++i) {
                dir[i].fddir = -1;
@@ -795,24 +901,21 @@ int svlogd_main(int argc, char **argv)
        }
        /* line = xmalloc(linemax + (timestamp ? 26 : 0)); */
        fndir = argv;
-       input.fd = 0;
-       input.events = IOPAUSE_READ;
        /* We cannot set NONBLOCK on fd #0 permanently - this setting
         * _isn't_ per-process! It is shared among all other processes
         * with the same stdin */
        fl_flag_0 = fcntl(0, F_GETFL);
 
-       blocked_sigset = &ss;
-       sigemptyset(&ss);
-       sigaddset(&ss, SIGTERM);
-       sigaddset(&ss, SIGCHLD);
-       sigaddset(&ss, SIGALRM);
-       sigaddset(&ss, SIGHUP);
-       sigprocmask(SIG_BLOCK, &ss, NULL);
-       sig_catch(SIGTERM, sig_term_handler);
-       sig_catch(SIGCHLD, sig_child_handler);
-       sig_catch(SIGALRM, sig_alarm_handler);
-       sig_catch(SIGHUP, sig_hangup_handler);
+       sigemptyset(&blocked_sigset);
+       sigaddset(&blocked_sigset, SIGTERM);
+       sigaddset(&blocked_sigset, SIGCHLD);
+       sigaddset(&blocked_sigset, SIGALRM);
+       sigaddset(&blocked_sigset, SIGHUP);
+       sigprocmask(SIG_BLOCK, &blocked_sigset, NULL);
+       bb_signals_recursive_norestart(1 << SIGTERM, sig_term_handler);
+       bb_signals_recursive_norestart(1 << SIGCHLD, sig_child_handler);
+       bb_signals_recursive_norestart(1 << SIGALRM, sig_alarm_handler);
+       bb_signals_recursive_norestart(1 << SIGHUP, sig_hangup_handler);
 
        logdirs_reopen();
 
@@ -826,7 +929,6 @@ int svlogd_main(int argc, char **argv)
 
        /* Each iteration processes one or more lines */
        while (1) {
-               struct taia now;
                char stamp[FMT_PTIME];
                char *lineptr;
                char *printptr;
@@ -846,8 +948,7 @@ int svlogd_main(int argc, char **argv)
                if (!np && !exitasap) {
                        i = linemax - stdin_cnt; /* avail. bytes at tail */
                        if (i >= 128) {
-                               taia_now(&now);
-                               i = buffer_pread(0, lineptr + stdin_cnt, i, &now);
+                               i = buffer_pread(/*0, */lineptr + stdin_cnt, i);
                                if (i <= 0) /* EOF or error on stdin */
                                        exitasap = 1;
                                else {
@@ -879,11 +980,10 @@ int svlogd_main(int argc, char **argv)
                printlen = linelen;
                printptr = lineptr;
                if (timestamp) {
-                       taia_now(&now);
                        if (timestamp == 1)
-                               fmt_taia25(stamp, &now);
+                               fmt_time_bernstein_25(stamp);
                        else /* 2: */
-                               fmt_ptime30nul(stamp, &now);
+                               fmt_time_human_30nul(stamp);
                        printlen += 26;
                        printptr -= 26;
                        memcpy(printptr, stamp, 25);
@@ -894,9 +994,11 @@ int svlogd_main(int argc, char **argv)
                        if (ld->fddir == -1) continue;
                        if (ld->inst)
                                logmatch(ld);
-                       if (ld->matcherr == 'e')
-                               ////full_write(2, printptr, printlen);
-                               fwrite(lineptr, 1, linelen, stderr);
+                       if (ld->matcherr == 'e') {
+                               /* runit-1.8.0 compat: if timestamping, do it on stderr too */
+                               ////full_write(STDERR_FILENO, printptr, printlen);
+                               fwrite(printptr, 1, printlen, stderr);
+                       }
                        if (ld->match != '+') continue;
                        buffer_pwrite(i, printptr, printlen);
                }
@@ -905,8 +1007,7 @@ int svlogd_main(int argc, char **argv)
                /* read/write repeatedly until we see it */
                while (ch != '\n') {
                        /* lineptr is emptied now, safe to use as buffer */
-                       taia_now(&now);
-                       stdin_cnt = exitasap ? -1 : buffer_pread(0, lineptr, linemax, &now);
+                       stdin_cnt = exitasap ? -1 : buffer_pread(/*0, */lineptr, linemax);
                        if (stdin_cnt <= 0) { /* EOF or error on stdin */
                                exitasap = 1;
                                lineptr[0] = ch = '\n';
@@ -922,9 +1023,10 @@ int svlogd_main(int argc, char **argv)
                        /* linelen == no of chars incl. '\n' (or == stdin_cnt) */
                        for (i = 0; i < dirn; ++i) {
                                if (dir[i].fddir == -1) continue;
-                               if (dir[i].matcherr == 'e')
-                                       ////full_write(2, lineptr, linelen);
+                               if (dir[i].matcherr == 'e') {
+                                       ////full_write(STDERR_FILENO, lineptr, linelen);
                                        fwrite(lineptr, 1, linelen, stderr);
+                               }
                                if (dir[i].match != '+') continue;
                                buffer_pwrite(i, lineptr, linelen);
                        }