Fix kbuild bugs noticed by Bernhard Fischer <rep.nop@aon.at>
[oweals/busybox.git] / networking / wget.c
index 3f36e4861f3c564a9415039e67ef28f16e009096..8850fdfb7168f5bc2f8ab28a2cfc85d0467f4cde 100644 (file)
 #include "busybox.h"
 #include <getopt.h>    /* for struct option */
 
-#ifdef CONFIG_LFS
-# define FILEOFF_TYPE off64_t
-# define FILEOFF_FMT "%lld"
-# define LSEEK lseek64
-# define STRTOOFF strtoll
-# define SAFE_STRTOOFF safe_strtoll
-/* stat64 etc as needed...  */
-#else
-# define FILEOFF_TYPE off_t
-# define FILEOFF_FMT "%ld"
-# define LSEEK lseek
-# define STRTOOFF strtol
-# define SAFE_STRTOOFF safe_strtol
-/* Do we need to undefine O_LARGEFILE? */
-#endif
-
 struct host_info {
+       // May be used if we ever will want to free() all xstrdup()s...
+       /* char *allocated; */
        char *host;
        int port;
        char *path;
@@ -43,9 +29,11 @@ static char *gethdr(char *buf, size_t bufsiz, FILE *fp, int *istrunc);
 static int ftpcmd(char *s1, char *s2, FILE *fp, char *buf);
 
 /* Globals (can be accessed from signal handlers */
-static FILEOFF_TYPE content_len;        /* Content-length of the file */
-static FILEOFF_TYPE beg_range;          /* Range at which continue begins */
-static FILEOFF_TYPE transferred;        /* Number of bytes transferred so far */
+static off_t content_len;        /* Content-length of the file */
+static off_t beg_range;          /* Range at which continue begins */
+#ifdef CONFIG_FEATURE_WGET_STATUSBAR
+static off_t transferred;        /* Number of bytes transferred so far */
+#endif
 static int chunked;                     /* chunked transfer encoding */
 #ifdef CONFIG_FEATURE_WGET_STATUSBAR
 static void progressmeter(int flag);
@@ -98,43 +86,24 @@ static char *base64enc(unsigned char *p, char *buf, int len)
 }
 #endif
 
-#define WGET_OPT_CONTINUE     1
-#define WGET_OPT_QUIET        2
-#define WGET_OPT_PASSIVE      4
-#define WGET_OPT_OUTNAME      8
-#define WGET_OPT_HEADER      16
-#define WGET_OPT_PREFIX      32
-#define WGET_OPT_PROXY       64
-#define WGET_OPT_USER_AGENT 128
-
-#if ENABLE_FEATURE_WGET_LONG_OPTIONS
-static const struct option wget_long_options[] = {
-       { "continue",        0, NULL, 'c' },
-       { "quiet",           0, NULL, 'q' },
-       { "passive-ftp",     0, NULL, 139 }, /* FIXME: what is this - 139?? */
-       { "output-document", 1, NULL, 'O' },
-       { "header",          1, NULL, 131 },
-       { "directory-prefix",1, NULL, 'P' },
-       { "proxy",           1, NULL, 'Y' },
-       { "user-agent",      1, NULL, 'U' },
-       { 0,                 0, 0, 0 }
-};
-#endif
-
 int wget_main(int argc, char **argv)
 {
-       int n, try=5, status;
-       unsigned opt;
-       int port;
-       char *proxy = 0;
-       char *dir_prefix=NULL;
-       char *s, buf[512];
-       char extra_headers[1024];
-       char *extra_headers_ptr = extra_headers;
-       int extra_headers_left = sizeof(extra_headers);
+       char buf[512];
        struct host_info server, target;
        struct sockaddr_in s_in;
+       int n, status;
+       int port;
+       int try = 5;
+       unsigned opt;
+       char *s;
+       char *proxy = 0;
+       char *dir_prefix = NULL;
+#if ENABLE_FEATURE_WGET_LONG_OPTIONS
+       char *extra_headers = NULL;
        llist_t *headers_llist = NULL;
+#endif
+
+       /* server.allocated = target.allocated = NULL; */
 
        FILE *sfp = NULL;               /* socket to web/ftp server         */
        FILE *dfp = NULL;               /* socket to ftp server (data)      */
@@ -142,38 +111,63 @@ int wget_main(int argc, char **argv)
        int got_clen = 0;               /* got content-length: from server  */
        int output_fd = -1;
        int use_proxy = 1;              /* Use proxies if env vars are set  */
-       char *proxy_flag = "on";        /* Use proxies if env vars are set  */
-       char *user_agent = "Wget";      /* Content of the "User-Agent" header field */
+       const char *proxy_flag = "on";  /* Use proxies if env vars are set  */
+       const char *user_agent = "Wget";/* Content of the "User-Agent" header field */
 
        /*
         * Crack command line.
         */
-       opt_complementary = "-1:\203::";
+       enum {
+               WGET_OPT_CONTINUE   = 0x1,
+               WGET_OPT_QUIET      = 0x2,
+               WGET_OPT_OUTNAME    = 0x4,
+               WGET_OPT_PREFIX     = 0x8,
+               WGET_OPT_PROXY      = 0x10,
+               WGET_OPT_USER_AGENT = 0x20,
+               WGET_OPT_PASSIVE    = 0x40,
+               WGET_OPT_HEADER     = 0x80,
+       };
 #if ENABLE_FEATURE_WGET_LONG_OPTIONS
+       static const struct option wget_long_options[] = {
+               // name, has_arg, flag, val
+               { "continue",         no_argument, NULL, 'c' },
+               { "quiet",            no_argument, NULL, 'q' },
+               { "output-document",  required_argument, NULL, 'O' },
+               { "directory-prefix", required_argument, NULL, 'P' },
+               { "proxy",            required_argument, NULL, 'Y' },
+               { "user-agent",       required_argument, NULL, 'U' },
+               { "passive-ftp",      no_argument, NULL, 0xff },
+               { "header",           required_argument, NULL, 0xfe },
+               { 0, 0, 0, 0 }
+};
        applet_long_options = wget_long_options;
 #endif
-       opt = getopt32(argc, argv, "cq\213O:\203:P:Y:U:",
-                                       &fname_out, &headers_llist,
-                                       &dir_prefix, &proxy_flag, &user_agent);
+       opt_complementary = "-1" USE_FEATURE_WGET_LONG_OPTIONS(":\xfe::");
+       opt = getopt32(argc, argv, "cqO:P:Y:U:",
+                               &fname_out, &dir_prefix,
+                               &proxy_flag, &user_agent
+                               USE_FEATURE_WGET_LONG_OPTIONS(, &headers_llist)
+                               );
        if (strcmp(proxy_flag, "off") == 0) {
                /* Use the proxy if necessary. */
                use_proxy = 0;
        }
-       if (opt & WGET_OPT_HEADER) {
+#if ENABLE_FEATURE_WGET_LONG_OPTIONS
+       if (headers_llist) {
+               int size = 1;
+               char *cp;
+               llist_t *ll = headers_llist = rev_llist(headers_llist);
+               while (ll) {
+                       size += strlen(ll->data) + 2;
+                       ll = ll->link;
+               }
+               extra_headers = cp = xmalloc(size);
                while (headers_llist) {
-                       int arglen = strlen(headers_llist->data);
-                       if (extra_headers_left - arglen - 2 <= 0)
-                               bb_error_msg_and_die("extra_headers buffer too small "
-                                       "(need %i)", extra_headers_left - arglen);
-                       strcpy(extra_headers_ptr, headers_llist->data);
-                       extra_headers_ptr += arglen;
-                       extra_headers_left -= ( arglen + 2 );
-                       *extra_headers_ptr++ = '\r';
-                       *extra_headers_ptr++ = '\n';
-                       *(extra_headers_ptr + 1) = 0;
+                       cp += sprintf(cp, "%s\r\n", headers_llist->data);
                        headers_llist = headers_llist->link;
                }
        }
+#endif
 
        parse_url(argv[optind], &target);
        server.host = target.host;
@@ -185,7 +179,7 @@ int wget_main(int argc, char **argv)
        if (use_proxy) {
                proxy = getenv(target.is_ftp ? "ftp_proxy" : "http_proxy");
                if (proxy && *proxy) {
-                       parse_url(xstrdup(proxy), &server);
+                       parse_url(proxy, &server);
                } else {
                        use_proxy = 0;
                }
@@ -227,11 +221,9 @@ int wget_main(int argc, char **argv)
                opt |= WGET_OPT_QUIET;
                opt &= ~WGET_OPT_CONTINUE;
        } else if (opt & WGET_OPT_CONTINUE) {
-               output_fd = open(fname_out, O_WRONLY|O_LARGEFILE);
+               output_fd = open(fname_out, O_WRONLY);
                if (output_fd >= 0) {
-                       beg_range = LSEEK(output_fd, 0, SEEK_END);
-                       if (beg_range == (FILEOFF_TYPE)-1)
-                               bb_perror_msg_and_die("lseek");
+                       beg_range = xlseek(output_fd, 0, SEEK_END);
                }
                /* File doesn't exist. We do not create file here yet.
                   We are not sure it exists on remove side */
@@ -294,41 +286,46 @@ int wget_main(int argc, char **argv)
 #endif
 
                        if (beg_range)
-                               fprintf(sfp, "Range: bytes="FILEOFF_FMT"-\r\n", beg_range);
-                       if(extra_headers_left < sizeof(extra_headers))
-                               fputs(extra_headers,sfp);
-                       fprintf(sfp,"Connection: close\r\n\r\n");
+                               fprintf(sfp, "Range: bytes=%"OFF_FMT"-\r\n", beg_range);
+#if ENABLE_FEATURE_WGET_LONG_OPTIONS
+                       if (extra_headers)
+                               fputs(extra_headers, sfp);
+#endif
+                       fprintf(sfp, "Connection: close\r\n\r\n");
 
                        /*
                        * Retrieve HTTP response line and check for "200" status code.
                        */
-read_response:
+ read_response:
                        if (fgets(buf, sizeof(buf), sfp) == NULL)
                                bb_error_msg_and_die("no response from server");
 
-                       for (s = buf ; *s != '\0' && !isspace(*s) ; ++s)
-                               ;
-                       for ( ; isspace(*s) ; ++s)
-                               ;
-                       switch (status = atoi(s)) {
-                               case 0:
-                               case 100:
-                                       while (gethdr(buf, sizeof(buf), sfp, &n) != NULL);
-                                       goto read_response;
-                               case 200:
-                                       break;
-                               case 300:       /* redirection */
-                               case 301:
-                               case 302:
-                               case 303:
+                       s = buf;
+                       while (*s != '\0' && !isspace(*s)) ++s;
+                       s = skip_whitespace(s);
+                       // FIXME: no error check
+                       // xatou wouldn't work: "200 OK"
+                       status = atoi(s);
+                       switch (status) {
+                       case 0:
+                       case 100:
+                               while (gethdr(buf, sizeof(buf), sfp, &n) != NULL)
+                                       /* eat all remaining headers */;
+                               goto read_response;
+                       case 200:
+                               break;
+                       case 300:       /* redirection */
+                       case 301:
+                       case 302:
+                       case 303:
+                               break;
+                       case 206:
+                               if (beg_range)
                                        break;
-                               case 206:
-                                       if (beg_range)
-                                               break;
-                                       /*FALLTHRU*/
-                               default:
-                                       chomp(buf);
-                                       bb_error_msg_and_die("server returned error %d: %s", atoi(s), buf);
+                               /*FALLTHRU*/
+                       default:
+                               chomp(buf);
+                               bb_error_msg_and_die("server returned error %s: %s", s, buf);
                        }
 
                        /*
@@ -343,18 +340,16 @@ read_response:
                                        continue;
                                }
                                if (strcasecmp(buf, "transfer-encoding") == 0) {
-                                       if (strcasecmp(s, "chunked") == 0) {
-                                               chunked = got_clen = 1;
-                                       } else {
+                                       if (strcasecmp(s, "chunked") != 0)
                                                bb_error_msg_and_die("server wants to do %s transfer encoding", s);
-                                       }
+                                       chunked = got_clen = 1;
                                }
                                if (strcasecmp(buf, "location") == 0) {
                                        if (s[0] == '/')
-                                               // FIXME: this is dirty
-                                               target.path = xstrdup(s+1);
+                                               /* free(target.allocated); */
+                                               target.path = /* target.allocated = */ xstrdup(s+1);
                                        else {
-                                               parse_url(xstrdup(s), &target);
+                                               parse_url(s, &target);
                                                if (use_proxy == 0) {
                                                        server.host = target.host;
                                                        server.port = target.port;
@@ -368,9 +363,9 @@ read_response:
                } while(status >= 300);
 
                dfp = sfp;
-       }
-       else
-       {
+
+       } else {
+
                /*
                 *  FTP session
                 */
@@ -389,14 +384,14 @@ read_response:
                if (s)
                        *(s++) = '\0';
                switch (ftpcmd("USER ", target.user, sfp, buf)) {
-                       case 230:
+               case 230:
+                       break;
+               case 331:
+                       if (ftpcmd("PASS ", s, sfp, buf) == 230)
                                break;
-                       case 331:
-                               if (ftpcmd("PASS ", s, sfp, buf) == 230)
-                                       break;
-                               /* FALLTHRU (failed login) */
-                       default:
-                               bb_error_msg_and_die("ftp login: %s", buf+4);
+                       /* FALLTHRU (failed login) */
+               default:
+                       bb_error_msg_and_die("ftp login: %s", buf+4);
                }
 
                ftpcmd("TYPE I", NULL, sfp, buf);
@@ -414,24 +409,31 @@ read_response:
                /*
                 * Entering passive mode
                 */
-               if (ftpcmd("PASV", NULL, sfp, buf) !=  227)
-                       bb_error_msg_and_die("PASV: %s", buf+4);
+               if (ftpcmd("PASV", NULL, sfp, buf) != 227) {
+ pasv_error:
+                       bb_error_msg_and_die("bad response to %s: %s", "PASV", buf);
+               }
+               // Response is "227 garbageN1,N2,N3,N4,P1,P2
+               // Server's IP is N1.N2.N3.N4 (we ignore it)
+               // Server's port for data connection is P1*256+P2
                s = strrchr(buf, ',');
-               *s = 0;
-               port = atoi(s+1);
+               if (!s) goto pasv_error;
+               port = xatol_range(s+1, 0, 255);
+               *s = '\0';
                s = strrchr(buf, ',');
-               port += atoi(s+1) * 256;
+               if (!s) goto pasv_error;
+               port += xatol_range(s+1, 0, 255) * 256;
                s_in.sin_port = htons(port);
                dfp = open_socket(&s_in);
 
                if (beg_range) {
-                       sprintf(buf, "REST "FILEOFF_FMT, beg_range);
+                       sprintf(buf, "REST %"OFF_FMT, beg_range);
                        if (ftpcmd(buf, NULL, sfp, buf) == 350)
                                content_len -= beg_range;
                }
 
                if (ftpcmd("RETR ", target.path, sfp, buf) > 150)
-                       bb_error_msg_and_die("RETR: %s", buf+4);
+                       bb_error_msg_and_die("bad response to %s: %s", "RETR", buf);
        }
 
 
@@ -447,7 +449,7 @@ read_response:
        /* Do it before progressmeter (want to have nice error message) */
        if (output_fd < 0)
                output_fd = xopen3(fname_out,
-                       O_WRONLY|O_CREAT|O_EXCL|O_TRUNC|O_LARGEFILE, 0666);
+                       O_WRONLY|O_CREAT|O_EXCL|O_TRUNC, 0666);
 
        if (!(opt & WGET_OPT_QUIET))
                progressmeter(-1);
@@ -499,9 +501,11 @@ read_response:
 }
 
 
-static void parse_url(char *url, struct host_info *h)
+static void parse_url(char *src_url, struct host_info *h)
 {
-       char *p, *cp, *sp, *up, *pp;
+       char *url, *p, *cp, *sp, *up, *pp;
+
+       /* h->allocated = */ url = xstrdup(src_url);
 
        if (strncmp(url, "http://", 7) == 0) {
                h->port = bb_lookup_port("http", "tcp", 80);
@@ -517,10 +521,10 @@ static void parse_url(char *url, struct host_info *h)
        // FYI:
        // "Real" wget 'http://busybox.net?var=a/b' sends this request:
        //   'GET /?var=a/b HTTP 1.0'
-       //   and saves 'index.html?var=a%2Fb'
+       //   and saves 'index.html?var=a%2Fb' (we save 'b')
        // wget 'http://busybox.net?login=john@doe':
        //   request: 'GET /?login=john@doe HTTP/1.0'
-       //   saves: 'index.html?login=john@doe' (we save ?login=john@doe)
+       //   saves: 'index.html?login=john@doe' (we save '?login=john@doe')
        // wget 'http://busybox.net#test/test':
        //   request: 'GET / HTTP/1.0'
        //   saves: 'index.html' (we save 'test')
@@ -572,7 +576,7 @@ static void parse_url(char *url, struct host_info *h)
        cp = strchr(pp, ':');
        if (cp != NULL) {
                *cp++ = '\0';
-               h->port = htons(atoi(cp));
+               h->port = htons(xatou16(cp));
        }
 }
 
@@ -581,7 +585,7 @@ static FILE *open_socket(struct sockaddr_in *s_in)
 {
        FILE *fp;
 
-       fp = fdopen(xconnect(s_in), "r+");
+       fp = fdopen(xconnect_tcp_v4(s_in), "r+");
        if (fp == NULL)
                bb_perror_msg_and_die("fdopen");
 
@@ -638,8 +642,9 @@ static char *gethdr(char *buf, size_t bufsiz, FILE *fp, int *istrunc)
 
 static int ftpcmd(char *s1, char *s2, FILE *fp, char *buf)
 {
+       int result;
        if (s1) {
-               if (!s2) s2="";
+               if (!s2) s2 = "";
                fprintf(fp, "%s%s\r\n", s1, s2);
                fflush(fp);
        }
@@ -648,7 +653,7 @@ static int ftpcmd(char *s1, char *s2, FILE *fp, char *buf)
                char *buf_ptr;
 
                if (fgets(buf, 510, fp) == NULL) {
-                       bb_perror_msg_and_die("fgets");
+                       bb_perror_msg_and_die("error getting response");
                }
                buf_ptr = strstr(buf, "\r\n");
                if (buf_ptr) {
@@ -656,7 +661,10 @@ static int ftpcmd(char *s1, char *s2, FILE *fp, char *buf)
                }
        } while (!isdigit(buf[0]) || buf[3] != ' ');
 
-       return atoi(buf);
+       buf[3] = '\0';
+       result = xatoi_u(buf);
+       buf[3] = ' ';
+       return result;
 }
 
 #ifdef CONFIG_FEATURE_WGET_STATUSBAR
@@ -668,7 +676,7 @@ getttywidth(void)
 {
        int width=0;
        get_terminal_width_height(0, &width, NULL);
-       return (width);
+       return width;
 }
 
 static void
@@ -695,10 +703,10 @@ static void
 progressmeter(int flag)
 {
        static struct timeval lastupdate;
-       static FILEOFF_TYPE lastsize, totalsize;
+       static off_t lastsize, totalsize;
 
        struct timeval now, td, tvwait;
-       FILEOFF_TYPE abbrevsize;
+       off_t abbrevsize;
        int elapsed, ratio, barlength, i;
        char buf[256];
 
@@ -749,7 +757,7 @@ progressmeter(int flag)
        if (tvwait.tv_sec >= STALLTIME) {
                fprintf(stderr, " - stalled -");
        } else {
-               FILEOFF_TYPE to_download = totalsize - beg_range;
+               off_t to_download = totalsize - beg_range;
                if (transferred <= 0 || elapsed <= 0 || transferred > to_download || chunked) {
                        fprintf(stderr, "--:--:-- ETA");
                } else {