u_short, ulong exterminated
[oweals/busybox.git] / networking / tftp.c
index 466851c1b33748b88f8b604f6c6171e3edccfdf7..2d28973dc6ed52419bc7bd997f8d36aff8ad6ef4 100644 (file)
@@ -1,84 +1,46 @@
-/* ------------------------------------------------------------------------- */
-/* tftp.c                                                                    */
-/*                                                                           */
-/* A simple tftp client for busybox.                                         */
-/* Tries to follow RFC1350.                                                  */
-/* Only "octet" mode and 512-byte data blocks are supported.                 */
-/*                                                                           */
-/* Copyright (C) 2001 Magnus Damm <damm@opensource.se>                       */
-/*                                                                           */
-/* Parts of the code based on:                                               */
-/*                                                                           */
-/* atftp:  Copyright (C) 2000 Jean-Pierre Lefebvre <helix@step.polymtl.ca>   */
-/*                        and Remi Lefebvre <remi@debian.org>                */
-/*                                                                           */
-/* utftp:  Copyright (C) 1999 Uwe Ohse <uwe@ohse.de>                         */
-/*                                                                           */
-/* This program is free software; you can redistribute it and/or modify      */
-/* it under the terms of the GNU General Public License as published by      */
-/* the Free Software Foundation; either version 2 of the License, or         */
-/* (at your option) any later version.                                       */
-/*                                                                           */
-/* This program is distributed in the hope that it will be useful,           */
-/* but WITHOUT ANY WARRANTY; without even the implied warranty of            */
-/* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU          */
-/* General Public License for more details.                                  */
-/*                                                                           */
-/* You should have received a copy of the GNU General Public License         */
-/* along with this program; if not, write to the Free Software               */
-/* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA   */
-/*                                                                           */
-/* ------------------------------------------------------------------------- */
-
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#include <sys/types.h>
-#include <sys/socket.h>
-#include <sys/time.h>
-#include <sys/stat.h>
-#include <netdb.h>
-#include <netinet/in.h>
-#include <arpa/inet.h>
-#include <unistd.h>
-#include <fcntl.h>
+/* vi: set sw=4 ts=4: */
+/* -------------------------------------------------------------------------
+ * tftp.c
+ *
+ * A simple tftp client for busybox.
+ * Tries to follow RFC1350.
+ * Only "octet" mode supported.
+ * Optional blocksize negotiation (RFC2347 + RFC2348)
+ *
+ * Copyright (C) 2001 Magnus Damm <damm@opensource.se>
+ *
+ * Parts of the code based on:
+ *
+ * atftp:  Copyright (C) 2000 Jean-Pierre Lefebvre <helix@step.polymtl.ca>
+ *                        and Remi Lefebvre <remi@debian.org>
+ *
+ * utftp:  Copyright (C) 1999 Uwe Ohse <uwe@ohse.de>
+ *
+ * Licensed under GPLv2 or later, see file LICENSE in this tarball for details.
+ * ------------------------------------------------------------------------- */
 
 #include "busybox.h"
 
-//#define BB_FEATURE_TFTP_DEBUG
 
-/* we don't need #ifdefs with these constants and optimization... */
+#define TFTP_BLOCKSIZE_DEFAULT 512     /* according to RFC 1350, don't change */
+#define TFTP_TIMEOUT 5 /* seconds */
+#define TFTP_NUM_RETRIES 5 /* number of retries */
 
-#ifdef BB_FEATURE_TFTP_GET
-#define BB_TFTP_GET (1 << 0)
-#else
-#define BB_TFTP_GET 0
-#endif
-
-#ifdef BB_FEATURE_TFTP_PUT
-#define BB_TFTP_PUT (1 << 1)
-#else
-#define BB_TFTP_PUT 0
-#endif
+static const char * const MODE_OCTET = "octet";
+#define MODE_OCTET_LEN 6 /* sizeof(MODE_OCTET)*/
 
-#ifdef BB_FEATURE_TFTP_DEBUG
-#define BB_TFTP_DEBUG 1
-#else
-#define BB_TFTP_DEBUG 0
-#endif
-
-#define BB_TFTP_NO_RETRIES 5
-#define BB_TFTP_TIMEOUT    5   /* seconds */
+static const char * const OPTION_BLOCKSIZE = "blksize";
+#define OPTION_BLOCKSIZE_LEN 8 /* sizeof(OPTION_BLOCKSIZE) */
 
-#define        RRQ     1                       /* read request */
-#define        WRQ     2                       /* write request */
-#define        DATA    3               /* data packet */
-#define        ACK     4                       /* acknowledgement */
-#define        ERROR   5               /* error code */
+/* opcodes we support */
+#define TFTP_RRQ   1
+#define TFTP_WRQ   2
+#define TFTP_DATA  3
+#define TFTP_ACK   4
+#define TFTP_ERROR 5
+#define TFTP_OACK  6
 
-#define BUFSIZE (512+4)
-
-static const char *tftp_error_msg[] = {
+static const char *const tftp_bb_error_msg[] = {
        "Undefined error",
        "File not found",
        "Access violation",
@@ -89,86 +51,187 @@ static const char *tftp_error_msg[] = {
        "No such user"
 };
 
-static inline int tftp(int cmd, struct hostent *host,
-                                          char *serverfile, int localfd, int port)
+#define tftp_cmd_get ENABLE_FEATURE_TFTP_GET
+
+#if ENABLE_FEATURE_TFTP_PUT
+# define tftp_cmd_put (tftp_cmd_get+ENABLE_FEATURE_TFTP_PUT)
+#else
+# define tftp_cmd_put 0
+#endif
+
+
+#if ENABLE_FEATURE_TFTP_BLOCKSIZE
+
+static int tftp_blocksize_check(int blocksize, int bufsize)
+{
+       /* Check if the blocksize is valid:
+        * RFC2348 says between 8 and 65464,
+        * but our implementation makes it impossible
+        * to use blocksizes smaller than 22 octets.
+        */
+
+       if ((bufsize && (blocksize > bufsize)) ||
+               (blocksize < 8) || (blocksize > 65564)) {
+               bb_error_msg("bad blocksize");
+               return 0;
+       }
+
+       return blocksize;
+}
+
+static char *tftp_option_get(char *buf, int len, const char * const option)
+{
+       int opt_val = 0;
+       int opt_found = 0;
+       int k;
+
+       while (len > 0) {
+
+               /* Make sure the options are terminated correctly */
+
+               for (k = 0; k < len; k++) {
+                       if (buf[k] == '\0') {
+                               break;
+                       }
+               }
+
+               if (k >= len) {
+                       break;
+               }
+
+               if (opt_val == 0) {
+                       if (strcasecmp(buf, option) == 0) {
+                               opt_found = 1;
+                       }
+               } else {
+                       if (opt_found) {
+                               return buf;
+                       }
+               }
+
+               k++;
+
+               buf += k;
+               len -= k;
+
+               opt_val ^= 1;
+       }
+
+       return NULL;
+}
+
+#endif
+
+static int tftp(const int cmd, const struct hostent *host,
+                  const char *remotefile, const int localfd,
+                  const unsigned short port, int tftp_bufsize)
 {
        struct sockaddr_in sa;
-       int socketfd;
-       struct timeval tv;
-       fd_set rfds;
        struct sockaddr_in from;
+       struct timeval tv;
        socklen_t fromlen;
-       char *cp;
+       fd_set rfds;
+       int socketfd;
+       int len;
+       int opcode = 0;
+       int finished = 0;
+       int timeout = TFTP_NUM_RETRIES;
+       unsigned short block_nr = 1;
        unsigned short tmp;
-       int len, opcode, finished;
-       int timeout, block_nr;
+       char *cp;
 
-       RESERVE_BB_BUFFER(buf, BUFSIZE);
+       USE_FEATURE_TFTP_BLOCKSIZE(int want_option_ack = 0;)
 
-       opcode = finished = timeout = 0;
-       block_nr = 1;
+       /* Can't use RESERVE_CONFIG_BUFFER here since the allocation
+        * size varies meaning BUFFERS_GO_ON_STACK would fail */
+       /* We must keep the transmit and receive buffers seperate */
+       /* In case we rcv a garbage pkt and we need to rexmit the last pkt */
+       char *xbuf = xmalloc(tftp_bufsize += 4);
+       char *rbuf = xmalloc(tftp_bufsize);
 
        if ((socketfd = socket(PF_INET, SOCK_DGRAM, 0)) < 0) {
-               perror_msg("socket");
+               /* need to unlink the localfile, so don't use xsocket here. */
+               bb_perror_msg("socket");
                return EXIT_FAILURE;
        }
 
        len = sizeof(sa);
 
        memset(&sa, 0, len);
-       bind(socketfd, (struct sockaddr *)&sa, len);
+       xbind(socketfd, (struct sockaddr *)&sa, len);
 
        sa.sin_family = host->h_addrtype;
-       sa.sin_port = htons(port);
+       sa.sin_port = port;
        memcpy(&sa.sin_addr, (struct in_addr *) host->h_addr,
                   sizeof(sa.sin_addr));
 
        /* build opcode */
-
-       if (cmd & BB_TFTP_GET) {
-               opcode = RRQ;
+       if (cmd & tftp_cmd_get) {
+               opcode = TFTP_RRQ;
        }
-
-       if (cmd & BB_TFTP_PUT) {
-               opcode = WRQ;
+       if (cmd & tftp_cmd_put) {
+               opcode = TFTP_WRQ;
        }
 
        while (1) {
 
+               cp = xbuf;
 
-               /* build packet of type "opcode" */
+               /* first create the opcode part */
+               *((unsigned short *) cp) = htons(opcode);
+               cp += 2;
 
+               /* add filename and mode */
+               if (((cmd & tftp_cmd_get) && (opcode == TFTP_RRQ)) ||
+                       ((cmd & tftp_cmd_put) && (opcode == TFTP_WRQ)))
+               {
+                       int too_long = 0;
+
+                       /* see if the filename fits into xbuf
+                        * and fill in packet.  */
+                       len = strlen(remotefile) + 1;
+
+                       if ((cp + len) >= &xbuf[tftp_bufsize - 1]) {
+                               too_long = 1;
+                       } else {
+                               safe_strncpy(cp, remotefile, len);
+                               cp += len;
+                       }
 
-               cp = buf;
+                       if (too_long || ((&xbuf[tftp_bufsize - 1] - cp) < MODE_OCTET_LEN)) {
+                               bb_error_msg("remote filename too long");
+                               break;
+                       }
 
-               *((unsigned short *) cp) = htons(opcode);
+                       /* add "mode" part of the package */
+                       memcpy(cp, MODE_OCTET, MODE_OCTET_LEN);
+                       cp += MODE_OCTET_LEN;
 
-               cp += 2;
+#if ENABLE_FEATURE_TFTP_BLOCKSIZE
 
-               /* add filename and mode */
+                       len = tftp_bufsize - 4; /* data block size */
 
-               if ((BB_TFTP_GET && (opcode == RRQ)) ||
-                       (BB_TFTP_PUT && (opcode == WRQ))) {
+                       if (len != TFTP_BLOCKSIZE_DEFAULT) {
 
-                       while (cp != &buf[BUFSIZE - 1]) {
-                               if ((*cp = *serverfile++) == '\0')
+                               if ((&xbuf[tftp_bufsize - 1] - cp) < 15) {
+                                       bb_error_msg("remote filename too long");
                                        break;
-                               cp++;
-                       }
+                               }
 
-                       if ((*cp != '\0') || (&buf[BUFSIZE - 1] - cp) < 7) {
-                               error_msg("too long server-filename");
-                               break;
-                       }
+                               /* add "blksize" + number of blocks  */
+                               memcpy(cp, OPTION_BLOCKSIZE, OPTION_BLOCKSIZE_LEN);
+                               cp += OPTION_BLOCKSIZE_LEN;
+                               cp += snprintf(cp, 6, "%d", len) + 1;
 
-                       memcpy(cp + 1, "octet", 6);
-                       cp += 7;
+                               want_option_ack = 1;
+                       }
+#endif
                }
 
                /* add ack and data */
 
-               if ((BB_TFTP_GET && (opcode == ACK)) ||
-                       (BB_TFTP_PUT && (opcode == DATA))) {
+               if (((cmd & tftp_cmd_get) && (opcode == TFTP_ACK)) ||
+                       ((cmd & tftp_cmd_put) && (opcode == TFTP_DATA))) {
 
                        *((unsigned short *) cp) = htons(block_nr);
 
@@ -176,21 +239,19 @@ static inline int tftp(int cmd, struct hostent *host,
 
                        block_nr++;
 
-                       if (BB_TFTP_PUT && (opcode == DATA)) {
-                               len = read(localfd, cp, BUFSIZE - 4);
+                       if ((cmd & tftp_cmd_put) && (opcode == TFTP_DATA)) {
+                               len = full_read(localfd, cp, tftp_bufsize - 4);
 
                                if (len < 0) {
-                                       perror_msg("read");
+                                       bb_perror_msg(bb_msg_read_error);
                                        break;
                                }
 
-                               if (len != (BUFSIZE - 4)) {
+                               if (len != (tftp_bufsize - 4)) {
                                        finished++;
                                }
 
                                cp += len;
-                       } else if (finished) {
-                               break;
                        }
                }
 
@@ -198,222 +259,307 @@ static inline int tftp(int cmd, struct hostent *host,
                /* send packet */
 
 
+               timeout = TFTP_NUM_RETRIES;     /* re-initialize */
                do {
 
-                       len = cp - buf;
+                       len = cp - xbuf;
 
-                       if (BB_TFTP_DEBUG) {
-                               printf("sending %u bytes\n", len);
-
-                               for (cp = buf; cp < &buf[len]; cp++)
-                                       printf("%02x ", *cp);
-                               printf("\n");
-                       }
-
-                       if (sendto(socketfd, buf, len, 0,
+#if ENABLE_DEBUG_TFTP
+                       fprintf(stderr, "sending %u bytes\n", len);
+                       for (cp = xbuf; cp < &xbuf[len]; cp++)
+                               fprintf(stderr, "%02x ", (unsigned char) *cp);
+                       fprintf(stderr, "\n");
+#endif
+                       if (sendto(socketfd, xbuf, len, 0,
                                           (struct sockaddr *) &sa, sizeof(sa)) < 0) {
-                               perror_msg("send");
+                               bb_perror_msg("send");
                                len = -1;
                                break;
                        }
 
 
-                       /* receive packet */
+                       if (finished && (opcode == TFTP_ACK)) {
+                               break;
+                       }
 
+                       /* receive packet */
 
                        memset(&from, 0, sizeof(from));
                        fromlen = sizeof(from);
 
-                       tv.tv_sec = BB_TFTP_TIMEOUT;
+                       tv.tv_sec = TFTP_TIMEOUT;
                        tv.tv_usec = 0;
 
                        FD_ZERO(&rfds);
                        FD_SET(socketfd, &rfds);
 
-                       switch (select(FD_SETSIZE, &rfds, NULL, NULL, &tv)) {
+                       switch (select(socketfd + 1, &rfds, NULL, NULL, &tv)) {
                        case 1:
-                               len = recvfrom(socketfd, buf,
-                                                          BUFSIZE, 0,
+                               len = recvfrom(socketfd, rbuf, tftp_bufsize, 0,
                                                           (struct sockaddr *) &from, &fromlen);
 
                                if (len < 0) {
-                                       perror_msg("recvfrom");
+                                       bb_perror_msg("recvfrom");
                                        break;
                                }
 
                                timeout = 0;
 
-                               if (sa.sin_port == htons(port)) {
+                               if (sa.sin_port == port) {
                                        sa.sin_port = from.sin_port;
-                                       break;
                                }
-
                                if (sa.sin_port == from.sin_port) {
                                        break;
                                }
 
                                /* fall-through for bad packets! */
                                /* discard the packet - treat as timeout */
-
+                               timeout = TFTP_NUM_RETRIES;
                        case 0:
-                               error_msg("timeout");
+                               bb_error_msg("timeout");
 
-                               if (!timeout) {
-                                       timeout = BB_TFTP_NO_RETRIES;
-                               } else {
-                                       timeout--;
-                               }
-
-                               if (!timeout) {
+                               timeout--;
+                               if (timeout == 0) {
                                        len = -1;
-                                       error_msg("last timeout");
+                                       bb_error_msg("last timeout");
                                }
                                break;
-
                        default:
-                               perror_msg("select");
+                               bb_perror_msg("select");
                                len = -1;
                        }
 
                } while (timeout && (len >= 0));
 
-               if (len < 0) {
+               if ((finished) || (len < 0)) {
                        break;
                }
 
                /* process received packet */
 
+               opcode = ntohs(*((unsigned short *) rbuf));
+               tmp = ntohs(*((unsigned short *) &rbuf[2]));
 
-               opcode = ntohs(*((unsigned short *) buf));
-               tmp = ntohs(*((unsigned short *) &buf[2]));
+#if ENABLE_DEBUG_TFTP
+               fprintf(stderr, "received %d bytes: %04x %04x\n", len, opcode, tmp);
+#endif
+
+               if (opcode == TFTP_ERROR) {
+                       const char *msg = NULL;
+
+                       if (rbuf[4] != '\0') {
+                               msg = &rbuf[4];
+                               rbuf[tftp_bufsize - 1] = '\0';
+                       } else if (tmp < (sizeof(tftp_bb_error_msg)
+                                                         / sizeof(char *))) {
+
+                               msg = tftp_bb_error_msg[tmp];
+                       }
 
-               if (BB_TFTP_DEBUG) {
-                       printf("received %d bytes: %04x %04x\n", len, opcode, tmp);
+                       if (msg) {
+                               bb_error_msg("server says: %s", msg);
+                       }
+
+                       break;
                }
+#if ENABLE_FEATURE_TFTP_BLOCKSIZE
+               if (want_option_ack) {
 
-               if (BB_TFTP_GET && (opcode == DATA)) {
+                       want_option_ack = 0;
+
+                       if (opcode == TFTP_OACK) {
+
+                               /* server seems to support options */
+
+                               char *res;
+
+                               res = tftp_option_get(&rbuf[2], len - 2, OPTION_BLOCKSIZE);
+
+                               if (res) {
+                                       int blksize = xatoi_u(res);
+
+                                       if (tftp_blocksize_check(blksize, tftp_bufsize - 4)) {
+
+                                               if (cmd & tftp_cmd_put) {
+                                                       opcode = TFTP_DATA;
+                                               } else {
+                                                       opcode = TFTP_ACK;
+                                               }
+#if ENABLE_DEBUG_TFTP
+                                               fprintf(stderr, "using %s %u\n", OPTION_BLOCKSIZE,
+                                                               blksize);
+#endif
+                                               tftp_bufsize = blksize + 4;
+                                               block_nr = 0;
+                                               continue;
+                                       }
+                               }
+                               /* FIXME:
+                                * we should send ERROR 8 */
+                               bb_error_msg("bad server option");
+                               break;
+                       }
+
+                       bb_error_msg("warning: blksize not supported by server"
+                                                " - reverting to 512");
+
+                       tftp_bufsize = TFTP_BLOCKSIZE_DEFAULT + 4;
+               }
+#endif
+
+               if ((cmd & tftp_cmd_get) && (opcode == TFTP_DATA)) {
 
                        if (tmp == block_nr) {
-                               len = write(localfd, &buf[4], len - 4);
+
+                               len = full_write(localfd, &rbuf[4], len - 4);
 
                                if (len < 0) {
-                                       perror_msg("write");
+                                       bb_perror_msg(bb_msg_write_error);
                                        break;
                                }
 
-                               if (len != (BUFSIZE - 4)) {
+                               if (len != (tftp_bufsize - 4)) {
                                        finished++;
                                }
 
-                               opcode = ACK;
+                               opcode = TFTP_ACK;
+                               continue;
+                       }
+                       /* in case the last ack disappeared into the ether */
+                       if (tmp == (block_nr - 1)) {
+                               --block_nr;
+                               opcode = TFTP_ACK;
+                               continue;
+                       } else if (tmp + 1 == block_nr) {
+                               /* Server lost our TFTP_ACK.  Resend it */
+                               block_nr = tmp;
+                               opcode = TFTP_ACK;
                                continue;
                        }
                }
 
-               if (BB_TFTP_PUT && (opcode == ACK)) {
+               if ((cmd & tftp_cmd_put) && (opcode == TFTP_ACK)) {
 
-                       if (tmp == (block_nr - 1)) {
+                       if (tmp == (unsigned short) (block_nr - 1)) {
                                if (finished) {
                                        break;
                                }
 
-                               opcode = DATA;
+                               opcode = TFTP_DATA;
                                continue;
                        }
                }
-
-               if (opcode == ERROR) {
-                       char *msg = NULL;
-
-                       if (buf[4] != '\0') {
-                               msg = &buf[4];
-                               buf[BUFSIZE - 1] = '\0';
-                       } else if (tmp < (sizeof(tftp_error_msg) / sizeof(char *))) {
-                               msg = (char *) tftp_error_msg[tmp];
-                       }
-
-                       if (msg) {
-                               error_msg("server says: %s", msg);
-                       }
-
-                       break;
-               }
        }
 
+#if ENABLE_FEATURE_CLEAN_UP
        close(socketfd);
+       free(xbuf);
+       free(rbuf);
+#endif
 
        return finished ? EXIT_SUCCESS : EXIT_FAILURE;
 }
 
 int tftp_main(int argc, char **argv)
 {
-       char *cp, *s;
-       char *serverstr;
-       struct hostent *host;
-       char *serverfile;
-       char *localfile;
-       int cmd, flags, fd, bad;
-
-       host = (void *) serverstr = serverfile = localfile = NULL;
-       flags = cmd = 0;
-       bad = 1;
-
-       if (argc > 3) {
-               if (BB_TFTP_GET && (strcmp(argv[1], "get") == 0)) {
-                       cmd = BB_TFTP_GET;
-                       flags = O_WRONLY | O_CREAT;
-                       serverstr = argv[2];
-                       localfile = argv[3];
-               }
-
-               if (BB_TFTP_PUT && (strcmp(argv[1], "put") == 0)) {
-                       cmd = BB_TFTP_PUT;
-                       flags = O_RDONLY;
-                       localfile = argv[2];
-                       serverstr = argv[3];
-               }
-
-       }
+       struct hostent *host = NULL;
+       const char *localfile = NULL;
+       const char *remotefile = NULL;
+       int port;
+       int cmd = 0;
+       int fd = -1;
+       int flags = 0;
+       int result;
+       int blocksize = TFTP_BLOCKSIZE_DEFAULT;
+
+       /* figure out what to pass to getopt */
+
+#if ENABLE_FEATURE_TFTP_BLOCKSIZE
+       char *sblocksize = NULL;
+
+#define BS "b:"
+#define BS_ARG , &sblocksize
+#else
+#define BS
+#define BS_ARG
+#endif
 
-       if (!(cmd & (BB_TFTP_GET | BB_TFTP_PUT))) {
-               show_usage();
-       }
+#if ENABLE_FEATURE_TFTP_GET
+#define GET "g"
+#define GET_COMPL ":g"
+#else
+#define GET
+#define GET_COMPL
+#endif
 
-       for (cp = serverstr; *cp != '\0'; cp++)
-               if (*cp == ':')
-                       break;
+#if ENABLE_FEATURE_TFTP_PUT
+#define PUT "p"
+#define PUT_COMPL ":p"
+#else
+#define PUT
+#define PUT_COMPL
+#endif
 
-       if (*cp == ':') {
+#if defined(CONFIG_FEATURE_TFTP_GET) && defined(CONFIG_FEATURE_TFTP_PUT)
+       opt_complementary = GET_COMPL PUT_COMPL ":?g--p:p--g";
+#elif defined(CONFIG_FEATURE_TFTP_GET) || defined(CONFIG_FEATURE_TFTP_PUT)
+       opt_complementary = GET_COMPL PUT_COMPL;
+#endif
 
-               serverfile = cp + 1;
+       cmd = getopt32(argc, argv, GET PUT "l:r:" BS, &localfile, &remotefile BS_ARG);
 
-               s = xstrdup(serverstr);
-               s[cp - serverstr] = '\0';
+       cmd &= (tftp_cmd_get | tftp_cmd_put);
+#if ENABLE_FEATURE_TFTP_GET
+       if (cmd == tftp_cmd_get)
+               flags = O_WRONLY | O_CREAT | O_TRUNC;
+#endif
+#if ENABLE_FEATURE_TFTP_PUT
+       if (cmd == tftp_cmd_put)
+               flags = O_RDONLY;
+#endif
 
-               if ((host = gethostbyname(s))) {
-                       bad = 0;
+#if ENABLE_FEATURE_TFTP_BLOCKSIZE
+       if (sblocksize) {
+               blocksize = xatoi_u(sblocksize);
+               if (!tftp_blocksize_check(blocksize, 0)) {
+                       return EXIT_FAILURE;
                }
-
-               free(s);
-       }
-       if (bad) {
-               error_msg_and_die("bad \"server:file\" combination");
        }
+#endif
 
-       if (BB_TFTP_DEBUG) {
-               printf("using server \"%s\", serverfile \"%s\","
-                          "localfile \"%s\".\n",
-                          inet_ntoa(*((struct in_addr *) host->h_addr)),
-                          serverfile, localfile);
+       if (localfile == NULL)
+               localfile = remotefile;
+       if (remotefile == NULL)
+               remotefile = localfile;
+       if ((localfile == NULL && remotefile == NULL) || (argv[optind] == NULL))
+               bb_show_usage();
+
+       if (localfile == NULL || LONE_DASH(localfile)) {
+               fd = (cmd == tftp_cmd_get) ? STDOUT_FILENO : STDIN_FILENO;
+       } else {
+               fd = open(localfile, flags, 0644); /* fail below */
        }
-
-       if ((fd = open(localfile, flags, 0644)) < 0) {
-               perror_msg_and_die("local file");
+       if (fd < 0) {
+               bb_perror_msg_and_die("local file");
        }
 
-       flags = tftp(cmd, host, serverfile, fd, 69);
+       host = xgethostbyname(argv[optind]);
+       port = bb_lookup_port(argv[optind + 1], "udp", 69);
+
+#if ENABLE_DEBUG_TFTP
+       fprintf(stderr, "using server \"%s\", remotefile \"%s\", "
+                       "localfile \"%s\".\n",
+                       inet_ntoa(*((struct in_addr *) host->h_addr)),
+                       remotefile, localfile);
+#endif
 
-       close(fd);
+       result = tftp(cmd, host, remotefile, fd, port, blocksize);
 
-       return flags;
+       if (!(fd == STDOUT_FILENO || fd == STDIN_FILENO)) {
+               if (ENABLE_FEATURE_CLEAN_UP)
+                       close(fd);
+               if (cmd == tftp_cmd_get && result != EXIT_SUCCESS)
+                       unlink(localfile);
+       }
+       return result;
 }