pscan: size optimization (Tito <farmatito@tiscali.it>)
[oweals/busybox.git] / networking / ping.c
index 9bf38130e025387df395722f201aafbf042a39ba..c4a498cd8e925b154864978d94f5dfad488ac29e 100644 (file)
@@ -27,7 +27,7 @@
 
 #include <net/if.h>
 #include <netinet/ip_icmp.h>
-#include "busybox.h"
+#include "libbb.h"
 
 #if ENABLE_PING6
 #include <netinet/icmp6.h>
@@ -101,15 +101,9 @@ static void ping4(len_and_sockaddr *lsa)
        pkt->icmp_type = ICMP_ECHO;
        pkt->icmp_cksum = in_cksum((unsigned short *) pkt, sizeof(packet));
 
-       c = sendto(pingsock, packet, DEFDATALEN + ICMP_MINLEN, 0,
+       c = xsendto(pingsock, packet, DEFDATALEN + ICMP_MINLEN,
                           (struct sockaddr *) &pingaddr, sizeof(pingaddr));
 
-       if (c < 0) {
-               if (ENABLE_FEATURE_CLEAN_UP)
-                       close(pingsock);
-               bb_perror_msg_and_die("sendto");
-       }
-
        /* listen for replies */
        while (1) {
                struct sockaddr_in from;
@@ -153,15 +147,9 @@ static void ping6(len_and_sockaddr *lsa)
        sockopt = offsetof(struct icmp6_hdr, icmp6_cksum);
        setsockopt(pingsock, SOL_RAW, IPV6_CHECKSUM, &sockopt, sizeof(sockopt));
 
-       c = sendto(pingsock, packet, DEFDATALEN + sizeof (struct icmp6_hdr), 0,
+       c = xsendto(pingsock, packet, DEFDATALEN + sizeof (struct icmp6_hdr),
                           (struct sockaddr *) &pingaddr, sizeof(pingaddr));
 
-       if (c < 0) {
-               if (ENABLE_FEATURE_CLEAN_UP)
-                       close(pingsock);
-               bb_perror_msg_and_die("sendto");
-       }
-
        /* listen for replies */
        while (1) {
                struct sockaddr_in6 from;
@@ -247,26 +235,51 @@ enum {
 };
 
 
-static union {
-       struct sockaddr sa;
-       struct sockaddr_in sin;
+struct globals {
+       int pingsock;
+       len_and_sockaddr *source_lsa;
+       unsigned datalen;
+       int if_index;
+       unsigned long ntransmitted, nreceived, nrepeats, pingcount;
+       uint16_t myid;
+       unsigned tmin, tmax; /* in us */
+       unsigned long long tsum; /* in us, sum of all times */
+       const char *hostname;
+       const char *dotted;
+       union {
+               struct sockaddr sa;
+               struct sockaddr_in sin;
 #if ENABLE_PING6
-       struct sockaddr_in6 sin6;
+               struct sockaddr_in6 sin6;
 #endif
-} pingaddr;
-static len_and_sockaddr *source_lsa;
-static int pingsock = -1;
-static unsigned datalen; /* intentionally uninitialized to work around gcc bug */
-
-static int if_index;
-
-static unsigned long ntransmitted, nreceived, nrepeats, pingcount;
-static int myid;
-static unsigned long tmin = ULONG_MAX, tmax, tsum;
-static char rcvd_tbl[MAX_DUP_CHK / 8];
+       } pingaddr;
+       char rcvd_tbl[MAX_DUP_CHK / 8];
+};
+#define G (*(struct globals*)&bb_common_bufsiz1)
+#define pingsock     (G.pingsock    )
+#define source_lsa   (G.source_lsa  )
+#define datalen      (G.datalen     )
+#define if_index     (G.if_index    )
+#define ntransmitted (G.ntransmitted)
+#define nreceived    (G.nreceived   )
+#define nrepeats     (G.nrepeats    )
+#define pingcount    (G.pingcount   )
+#define myid         (G.myid        )
+#define tmin         (G.tmin        )
+#define tmax         (G.tmax        )
+#define tsum         (G.tsum        )
+#define hostname     (G.hostname    )
+#define dotted       (G.dotted      )
+#define pingaddr     (G.pingaddr    )
+#define rcvd_tbl     (G.rcvd_tbl    )
+void BUG_ping_globals_too_big(void);
+#define INIT_G() do { \
+        if (sizeof(G) > COMMON_BUFSIZE) \
+                BUG_ping_globals_too_big(); \
+       pingsock = -1; \
+       tmin = UINT_MAX; \
+} while (0)
 
-static const char *hostname;
-static const char *dotted;
 
 #define        A(bit)          rcvd_tbl[(bit)>>3]      /* identify byte in array */
 #define        B(bit)          (1 << ((bit) & 0x07))   /* identify bit in byte */
@@ -278,8 +291,6 @@ static const char *dotted;
 
 static void pingstats(int junk ATTRIBUTE_UNUSED)
 {
-       int status;
-
        signal(SIGINT, SIG_IGN);
 
        printf("\n--- %s ping statistics ---\n", hostname);
@@ -290,28 +301,31 @@ static void pingstats(int junk ATTRIBUTE_UNUSED)
        if (ntransmitted)
                ntransmitted = (ntransmitted - nreceived) * 100 / ntransmitted;
        printf("%lu%% packet loss\n", ntransmitted);
-       if (nreceived)
-               printf("round-trip min/avg/max = %lu.%lu/%lu.%lu/%lu.%lu ms\n",
-                       tmin / 10, tmin % 10,
-                       (tsum / (nreceived + nrepeats)) / 10,
-                       (tsum / (nreceived + nrepeats)) % 10, tmax / 10, tmax % 10);
-       if (nreceived != 0)
-               status = EXIT_SUCCESS;
-       else
-               status = EXIT_FAILURE;
-       exit(status);
+       if (tmin != UINT_MAX) {
+               unsigned tavg = tsum / (nreceived + nrepeats);
+               printf("round-trip min/avg/max = %u.%03u/%u.%03u/%u.%03u ms\n",
+                       tmin / 1000, tmin % 1000,
+                       tavg / 1000, tavg % 1000,
+                       tmax / 1000, tmax % 1000);
+       }
+       exit(nreceived == 0); /* (nreceived == 0) is true (1) -- 'failure' */
 }
 
-static void sendping_tail(void (*sp)(int), int sz, int sizeof_packet)
+static void sendping_tail(void (*sp)(int), const void *pkt, int size_pkt)
 {
-       if (sz < 0)
-               bb_perror_msg_and_die("sendto");
-       if (sz != sizeof_packet)
-               bb_error_msg_and_die("ping wrote %d chars; %d expected", sz,
-                       sizeof_packet);
+       int sz;
+
+       CLR((uint16_t)ntransmitted % MAX_DUP_CHK);
+       ntransmitted++;
+
+       /* sizeof(pingaddr) can be larger than real sa size, but I think
+        * it doesn't matter */
+       sz = xsendto(pingsock, pkt, size_pkt, &pingaddr.sa, sizeof(pingaddr));
+       if (sz != size_pkt)
+               bb_error_msg_and_die(bb_msg_write_error);
 
        signal(SIGALRM, sp);
-       if (pingcount == 0 || ntransmitted < pingcount) {       /* schedule next in 1s */
+       if (pingcount == 0 || ntransmitted < pingcount) { /* schedule next in 1s */
                alarm(PINGINTERVAL);
        } else { /* done, wait for the last ping to come back */
                /* todo, don't necessarily need to wait so long... */
@@ -322,51 +336,39 @@ static void sendping_tail(void (*sp)(int), int sz, int sizeof_packet)
 
 static void sendping4(int junk ATTRIBUTE_UNUSED)
 {
-       struct icmp *pkt;
-       int i;
-       char packet[datalen + ICMP_MINLEN];
-
-       pkt = (struct icmp *) packet;
+       /* +4 reserves a place for timestamp, which may end up sitting
+        * *after* packet. Saves one if() */
+       struct icmp *pkt = alloca(datalen + ICMP_MINLEN + 4);
 
        pkt->icmp_type = ICMP_ECHO;
        pkt->icmp_code = 0;
        pkt->icmp_cksum = 0;
        pkt->icmp_seq = htons(ntransmitted); /* don't ++ here, it can be a macro */
        pkt->icmp_id = myid;
-       CLR((uint16_t)ntransmitted % MAX_DUP_CHK);
-       ntransmitted++;
 
-       gettimeofday((struct timeval *) &pkt->icmp_dun, NULL);
-       pkt->icmp_cksum = in_cksum((unsigned short *) pkt, sizeof(packet));
+       /* We don't do hton, because we will read it back on the same machine */
+       /*if (datalen >= 4)*/
+               *(uint32_t*)&pkt->icmp_dun = monotonic_us();
 
-       i = sendto(pingsock, packet, sizeof(packet), 0,
-                       &pingaddr.sa, sizeof(pingaddr.sin));
+       pkt->icmp_cksum = in_cksum((unsigned short *) pkt, datalen + ICMP_MINLEN);
 
-       sendping_tail(sendping4, i, sizeof(packet));
+       sendping_tail(sendping4, pkt, datalen + ICMP_MINLEN);
 }
 #if ENABLE_PING6
 static void sendping6(int junk ATTRIBUTE_UNUSED)
 {
-       struct icmp6_hdr *pkt;
-       int i;
-       char packet[datalen + sizeof (struct icmp6_hdr)];
-
-       pkt = (struct icmp6_hdr *) packet;
+       struct icmp6_hdr *pkt = alloca(datalen + sizeof(struct icmp6_hdr) + 4);
 
        pkt->icmp6_type = ICMP6_ECHO_REQUEST;
        pkt->icmp6_code = 0;
        pkt->icmp6_cksum = 0;
        pkt->icmp6_seq = htons(ntransmitted); /* don't ++ here, it can be a macro */
        pkt->icmp6_id = myid;
-       CLR((uint16_t)ntransmitted % MAX_DUP_CHK);
-       ntransmitted++;
-
-       gettimeofday((struct timeval *) &pkt->icmp6_data8[4], NULL);
 
-       i = sendto(pingsock, packet, sizeof(packet), 0,
-                       &pingaddr.sa, sizeof(pingaddr.sin6));
+       /*if (datalen >= 4)*/
+               *(uint32_t*)(&pkt->icmp6_data8[4]) = monotonic_us();
 
-       sendping_tail(sendping6, i, sizeof(packet));
+       sendping_tail(sendping6, pkt, datalen + sizeof(struct icmp6_hdr));
 }
 #endif
 
@@ -418,15 +420,49 @@ static const char *icmp6_type_name(int id)
 }
 #endif
 
+static void unpack_tail(int sz, uint32_t *tp,
+               const char *from_str,
+               uint16_t recv_seq, int ttl)
+{
+       const char *dupmsg = " (DUP!)";
+       unsigned triptime = triptime; /* for gcc */
+
+       ++nreceived;
+
+       if (tp) {
+               /* (int32_t) cast is for hypothetical 64-bit unsigned */
+               /* (doesn't hurt 32-bit real-world anyway) */
+               triptime = (int32_t) ((uint32_t)monotonic_us() - *tp);
+               tsum += triptime;
+               if (triptime < tmin)
+                       tmin = triptime;
+               if (triptime > tmax)
+                       tmax = triptime;
+       }
+
+       if (TST(recv_seq % MAX_DUP_CHK)) {
+               ++nrepeats;
+               --nreceived;
+       } else {
+               SET(recv_seq % MAX_DUP_CHK);
+               dupmsg += 7;
+       }
+
+       if (option_mask32 & OPT_QUIET)
+               return;
+
+       printf("%d bytes from %s: seq=%u ttl=%d", sz,
+               from_str, recv_seq, ttl);
+       if (tp)
+               printf(" time=%u.%03u ms", triptime / 1000, triptime % 1000);
+       puts(dupmsg);
+       fflush(stdout);
+}
 static void unpack4(char *buf, int sz, struct sockaddr_in *from)
 {
        struct icmp *icmppkt;
        struct iphdr *iphdr;
-       struct timeval tv, *tp;
-       int hlen, dupflag;
-       unsigned long triptime;
-
-       gettimeofday(&tv, NULL);
+       int hlen;
 
        /* discard if too short */
        if (sz < (datalen + ICMP_MINLEN))
@@ -442,61 +478,25 @@ static void unpack4(char *buf, int sz, struct sockaddr_in *from)
 
        if (icmppkt->icmp_type == ICMP_ECHOREPLY) {
                uint16_t recv_seq = ntohs(icmppkt->icmp_seq);
-               ++nreceived;
-               tp = (struct timeval *) icmppkt->icmp_data;
-
-               if ((tv.tv_usec -= tp->tv_usec) < 0) {
-                       --tv.tv_sec;
-                       tv.tv_usec += 1000000;
-               }
-               tv.tv_sec -= tp->tv_sec;
-
-               triptime = tv.tv_sec * 10000 + (tv.tv_usec / 100);
-               tsum += triptime;
-               if (triptime < tmin)
-                       tmin = triptime;
-               if (triptime > tmax)
-                       tmax = triptime;
-
-               if (TST(recv_seq % MAX_DUP_CHK)) {
-                       ++nrepeats;
-                       --nreceived;
-                       dupflag = 1;
-               } else {
-                       SET(recv_seq % MAX_DUP_CHK);
-                       dupflag = 0;
-               }
-
-               if (option_mask32 & OPT_QUIET)
-                       return;
-
-               printf("%d bytes from %s: icmp_seq=%u", sz,
-                          inet_ntoa(*(struct in_addr *) &from->sin_addr.s_addr),
-                          recv_seq);
-               printf(" ttl=%d", iphdr->ttl);
-               printf(" time=%lu.%lu ms", triptime / 10, triptime % 10);
-               if (dupflag)
-                       printf(" (DUP!)");
-               puts("");
-       } else {
-               if (icmppkt->icmp_type != ICMP_ECHO)
-                       bb_error_msg("warning: got ICMP %d (%s)",
-                                       icmppkt->icmp_type,
-                                       icmp_type_name(icmppkt->icmp_type));
+               uint32_t *tp = NULL;
+
+               if (sz >= ICMP_MINLEN + sizeof(uint32_t))
+                       tp = (uint32_t *) icmppkt->icmp_data;
+               unpack_tail(sz, tp,
+                       inet_ntoa(*(struct in_addr *) &from->sin_addr.s_addr),
+                       recv_seq, iphdr->ttl);
+       } else if (icmppkt->icmp_type != ICMP_ECHO) {
+               bb_error_msg("warning: got ICMP %d (%s)",
+                               icmppkt->icmp_type,
+                               icmp_type_name(icmppkt->icmp_type));
        }
-       fflush(stdout);
 }
 #if ENABLE_PING6
 static void unpack6(char *packet, int sz, struct sockaddr_in6 *from, int hoplimit)
 {
        struct icmp6_hdr *icmppkt;
-       struct timeval tv, *tp;
-       int dupflag;
-       unsigned long triptime;
        char buf[INET6_ADDRSTRLEN];
 
-       gettimeofday(&tv, NULL);
-
        /* discard if too short */
        if (sz < (datalen + sizeof(struct icmp6_hdr)))
                return;
@@ -507,50 +507,19 @@ static void unpack6(char *packet, int sz, struct sockaddr_in6 *from, int hoplimi
 
        if (icmppkt->icmp6_type == ICMP6_ECHO_REPLY) {
                uint16_t recv_seq = ntohs(icmppkt->icmp6_seq);
-               ++nreceived;
-               tp = (struct timeval *) &icmppkt->icmp6_data8[4];
-
-               if ((tv.tv_usec -= tp->tv_usec) < 0) {
-                       --tv.tv_sec;
-                       tv.tv_usec += 1000000;
-               }
-               tv.tv_sec -= tp->tv_sec;
-
-               triptime = tv.tv_sec * 10000 + (tv.tv_usec / 100);
-               tsum += triptime;
-               if (triptime < tmin)
-                       tmin = triptime;
-               if (triptime > tmax)
-                       tmax = triptime;
-
-               if (TST(recv_seq % MAX_DUP_CHK)) {
-                       ++nrepeats;
-                       --nreceived;
-                       dupflag = 1;
-               } else {
-                       SET(recv_seq % MAX_DUP_CHK);
-                       dupflag = 0;
-               }
-
-               if (option_mask32 & OPT_QUIET)
-                       return;
-
-               printf("%d bytes from %s: icmp6_seq=%u", sz,
-                          inet_ntop(AF_INET6, &pingaddr.sin6.sin6_addr,
-                                                buf, sizeof(buf)),
-                          recv_seq);
-               printf(" ttl=%d time=%lu.%lu ms", hoplimit,
-                          triptime / 10, triptime % 10);
-               if (dupflag)
-                       printf(" (DUP!)");
-               puts("");
-       } else {
-               if (icmppkt->icmp6_type != ICMP6_ECHO_REQUEST)
-                       bb_error_msg("warning: got ICMP %d (%s)",
-                                       icmppkt->icmp6_type,
-                                       icmp6_type_name(icmppkt->icmp6_type));
+               uint32_t *tp = NULL;
+
+               if (sz >= sizeof(struct icmp6_hdr) + sizeof(uint32_t))
+                       tp = (uint32_t *) &icmppkt->icmp6_data8[4];
+               unpack_tail(sz, tp,
+                       inet_ntop(AF_INET6, &pingaddr.sin6.sin6_addr,
+                                       buf, sizeof(buf)),
+                       recv_seq, hoplimit);
+       } else if (icmppkt->icmp6_type != ICMP6_ECHO_REQUEST) {
+               bb_error_msg("warning: got ICMP %d (%s)",
+                               icmppkt->icmp6_type,
+                               icmp6_type_name(icmppkt->icmp6_type));
        }
-       fflush(stdout);
 }
 #endif
 
@@ -709,6 +678,8 @@ int ping_main(int argc, char **argv)
        char *opt_c, *opt_s, *opt_I;
        USE_PING6(sa_family_t af = AF_UNSPEC;)
 
+       INIT_G();
+
        datalen = DEFDATALEN; /* initialized here rather than in global scope to work around gcc bug */
 
        /* exactly one argument needed, -v and -q don't mix */
@@ -724,7 +695,7 @@ int ping_main(int argc, char **argv)
                        source_lsa = xdotted2sockaddr(opt_I, 0);
                }
        }
-       myid = (int16_t) getpid();
+       myid = (uint16_t) getpid();
        hostname = argv[optind];
 #if ENABLE_PING6
        if (option_mask32 & OPT_IPV4)