ash: fix for read $IFS splitting. Closes bug 235
[oweals/busybox.git] / networking / nc.c
index 2f8a36beef8673f35e5afe8a634c2a5b36379e9b..243c47976b9e6a0f5e1ad183840c5cb39f353314 100644 (file)
@@ -7,46 +7,58 @@
  *  Licensed under GPLv2 or later, see file LICENSE in this tarball for details.
  */
 
-#include "busybox.h"
+#include "libbb.h"
 
-static void timeout(int signum)
+#if ENABLE_DESKTOP
+#include "nc_bloaty.c"
+#else
+
+/* Lots of small differences in features
+ * when compared to "standard" nc
+ */
+
+static void timeout(int signum UNUSED_PARAM)
 {
        bb_error_msg_and_die("timed out");
 }
 
+int nc_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
 int nc_main(int argc, char **argv)
 {
-       int sfd = 0;
+       /* sfd sits _here_ only because of "repeat" option (-l -l). */
+       int sfd = sfd; /* for gcc */
        int cfd = 0;
-       SKIP_NC_SERVER(const) unsigned do_listen = 0;
-       SKIP_NC_SERVER(const) unsigned lport = 0;
-       SKIP_NC_EXTRA (const) unsigned wsecs = 0;
-       SKIP_NC_EXTRA (const) unsigned delay = 0;
-       SKIP_NC_EXTRA (const int execparam = 0;)
-       USE_NC_EXTRA  (char **execparam = NULL;)
-       struct sockaddr_in address;
+       unsigned lport = 0;
+       IF_NOT_NC_SERVER(const) unsigned do_listen = 0;
+       IF_NOT_NC_EXTRA (const) unsigned wsecs = 0;
+       IF_NOT_NC_EXTRA (const) unsigned delay = 0;
+       IF_NOT_NC_EXTRA (const int execparam = 0;)
+       IF_NC_EXTRA     (char **execparam = NULL;)
        fd_set readfds, testfds;
        int opt; /* must be signed (getopt returns -1) */
 
-       memset(&address, 0, sizeof(address));
-
        if (ENABLE_NC_SERVER || ENABLE_NC_EXTRA) {
                /* getopt32 is _almost_ usable:
                ** it cannot handle "... -e prog -prog-opt" */
                while ((opt = getopt(argc, argv,
-                       "" USE_NC_SERVER("lp:") USE_NC_EXTRA("w:i:f:e:") )) > 0
+                       "" IF_NC_SERVER("lp:") IF_NC_EXTRA("w:i:f:e:") )) > 0
                ) {
-                       if (ENABLE_NC_SERVER && opt=='l')      USE_NC_SERVER(do_listen++);
-                       else if (ENABLE_NC_SERVER && opt=='p') USE_NC_SERVER(lport = bb_lookup_port(optarg, "tcp", 0));
-                       else if (ENABLE_NC_EXTRA  && opt=='w') USE_NC_EXTRA( wsecs = xatou(optarg));
-                       else if (ENABLE_NC_EXTRA  && opt=='i') USE_NC_EXTRA( delay = xatou(optarg));
-                       else if (ENABLE_NC_EXTRA  && opt=='f') USE_NC_EXTRA( cfd = xopen(optarg, O_RDWR));
-                       else if (ENABLE_NC_EXTRA  && opt=='e' && optind<=argc) {
+                       if (ENABLE_NC_SERVER && opt == 'l')
+                               IF_NC_SERVER(do_listen++);
+                       else if (ENABLE_NC_SERVER && opt == 'p')
+                               IF_NC_SERVER(lport = bb_lookup_port(optarg, "tcp", 0));
+                       else if (ENABLE_NC_EXTRA && opt == 'w')
+                               IF_NC_EXTRA( wsecs = xatou(optarg));
+                       else if (ENABLE_NC_EXTRA && opt == 'i')
+                               IF_NC_EXTRA( delay = xatou(optarg));
+                       else if (ENABLE_NC_EXTRA && opt == 'f')
+                               IF_NC_EXTRA( cfd = xopen(optarg, O_RDWR));
+                       else if (ENABLE_NC_EXTRA && opt == 'e' && optind <= argc) {
                                /* We cannot just 'break'. We should let getopt finish.
                                ** Or else we won't be able to find where
                                ** 'host' and 'port' params are
                                ** (think "nc -w 60 host port -e prog"). */
-                               USE_NC_EXTRA(
+                               IF_NC_EXTRA(
                                        char **p;
                                        // +2: one for progname (optarg) and one for NULL
                                        execparam = xzalloc(sizeof(char*) * (argc - optind + 2));
@@ -67,10 +79,15 @@ int nc_main(int argc, char **argv)
                argc -= optind;
                // -l and -f don't mix
                if (do_listen && cfd) bb_show_usage();
-               // Listen or file modes need zero arguments, client mode needs 2
-               opt = ((do_listen || cfd) ? 0 : 2);
-               if (argc != opt)
-                       bb_show_usage();
+               // File mode needs need zero arguments, listen mode needs zero or one,
+               // client mode needs one or two
+               if (cfd) {
+                       if (argc) bb_show_usage();
+               } else if (do_listen) {
+                       if (argc > 1) bb_show_usage();
+               } else {
+                       if (!argc || argc > 2) bb_show_usage();
+               }
        } else {
                if (argc != 3) bb_show_usage();
                argc--;
@@ -83,84 +100,62 @@ int nc_main(int argc, char **argv)
        }
 
        if (!cfd) {
-               sfd = xsocket(AF_INET, SOCK_STREAM, 0);
-               fcntl(sfd, F_SETFD, FD_CLOEXEC);
-               opt = 1;
-               setsockopt(sfd, SOL_SOCKET, SO_REUSEADDR, &opt, sizeof(opt));
-               address.sin_family = AF_INET;
-
-               // Set local port.
-
-               if (lport != 0) {
-                       address.sin_port = lport;
-                       xbind(sfd, (struct sockaddr *) &address, sizeof(address));
-               }
-
                if (do_listen) {
-                       socklen_t addrlen = sizeof(address);
-
-                       xlisten(sfd, do_listen);
-
-                       // If we didn't specify a port number, query and print it to stderr.
-
+                       sfd = create_and_bind_stream_or_die(argv[0], lport);
+                       xlisten(sfd, do_listen); /* can be > 1 */
+#if 0  /* nc-1.10 does not do this (without -v) */
+                       /* If we didn't specify a port number,
+                        * query and print it after listen() */
                        if (!lport) {
-                               socklen_t len = sizeof(address);
-                               getsockname(sfd, &address, &len);
-                               fdprintf(2, "%d\n", SWAP_BE16(address.sin_port));
+                               len_and_sockaddr lsa;
+                               lsa.len = LSA_SIZEOF_SA;
+                               getsockname(sfd, &lsa.u.sa, &lsa.len);
+                               lport = get_nport(&lsa.u.sa);
+                               fdprintf(2, "%d\n", ntohs(lport));
                        }
- repeatyness:
-                       cfd = accept(sfd, (struct sockaddr *) &address, &addrlen);
+#endif
+                       close_on_exec_on(sfd);
+ accept_again:
+                       cfd = accept(sfd, NULL, 0);
                        if (cfd < 0)
                                bb_perror_msg_and_die("accept");
-
-                       if (!execparam) close(sfd);
+                       if (!execparam)
+                               close(sfd);
                } else {
-                       struct hostent *hostinfo;
-                       hostinfo = xgethostbyname(argv[0]);
-
-                       address.sin_addr = *(struct in_addr *) *hostinfo->h_addr_list;
-                       address.sin_port = bb_lookup_port(argv[1], "tcp", 0);
-
-                       if (connect(sfd, (struct sockaddr *) &address, sizeof(address)) < 0)
-                               bb_perror_msg_and_die("connect");
-                       cfd = sfd;
+                       cfd = create_and_connect_stream_or_die(argv[0],
+                               argv[1] ? bb_lookup_port(argv[1], "tcp", 0) : 0);
                }
        }
 
        if (wsecs) {
                alarm(0);
-               signal(SIGALRM, SIG_DFL);
+               /* Non-ignored signals revert to SIG_DFL on exec anyway */
+               /*signal(SIGALRM, SIG_DFL);*/
        }
 
        /* -e given? */
        if (execparam) {
-               if (cfd) {
+               pid_t pid;
+               /* With more than one -l, repeatedly act as server */
+               if (do_listen > 1 && (pid = vfork()) != 0) {
+                       /* parent or error */
+                       if (pid < 0)
+                               bb_perror_msg_and_die("vfork");
+                       /* prevent zombies */
                        signal(SIGCHLD, SIG_IGN);
-                       dup2(cfd, 0);
                        close(cfd);
+                       goto accept_again;
                }
-               dup2(0, 1);
-               dup2(0, 2);
-
-               // With more than one -l, repeatedly act as server.
-
-               if (do_listen > 1 && vfork()) {
-                       // This is a bit weird as cleanup goes, since we wind up with no
-                       // stdin/stdout/stderr.  But it's small and shouldn't hurt anything.
-                       // We check for cfd == 0 above.
-                       logmode = LOGMODE_NONE;
-                       close(0);
-                       close(1);
-                       close(2);
-
-                       goto repeatyness;
-               }
-               USE_NC_EXTRA(execvp(execparam[0], execparam);)
-               /* Don't print stuff or it will go over the wire.... */
+               /* child, or main thread if only one -l */
+               xmove_fd(cfd, 0);
+               xdup2(0, 1);
+               xdup2(0, 2);
+               IF_NC_EXTRA(BB_EXECVP(execparam[0], execparam);)
+               /* Don't print stuff or it will go over the wire... */
                _exit(127);
        }
 
-       // Select loop copying stdin to cfd, and cfd to stdout.
+       /* Select loop copying stdin to cfd, and cfd to stdout */
 
        FD_ZERO(&readfds);
        FD_SET(cfd, &readfds);
@@ -173,30 +168,35 @@ int nc_main(int argc, char **argv)
 
                testfds = readfds;
 
-               if (select(FD_SETSIZE, &testfds, NULL, NULL, NULL) < 0)
+               if (select(cfd + 1, &testfds, NULL, NULL, NULL) < 0)
                        bb_perror_msg_and_die("select");
 
-               for (fd = 0; fd < FD_SETSIZE; fd++) {
+#define iobuf bb_common_bufsiz1
+               fd = STDIN_FILENO;
+               while (1) {
                        if (FD_ISSET(fd, &testfds)) {
-                               nread = safe_read(fd, bb_common_bufsiz1,
-                                                       sizeof(bb_common_bufsiz1));
-
+                               nread = safe_read(fd, iobuf, sizeof(iobuf));
                                if (fd == cfd) {
-                                       if (nread<1) exit(0);
+                                       if (nread < 1)
+                                               exit(EXIT_SUCCESS);
                                        ofd = STDOUT_FILENO;
                                } else {
-                                       if (nread<1) {
-                                               // Close outgoing half-connection so they get EOF, but
-                                               // leave incoming alone so we can see response.
+                                       if (nread < 1) {
+                                               /* Close outgoing half-connection so they get EOF,
+                                                * but leave incoming alone so we can see response */
                                                shutdown(cfd, 1);
                                                FD_CLR(STDIN_FILENO, &readfds);
                                        }
                                        ofd = cfd;
                                }
-
-                               xwrite(ofd, bb_common_bufsiz1, nread);
-                               if (delay > 0) sleep(delay);
+                               xwrite(ofd, iobuf, nread);
+                               if (delay > 0)
+                                       sleep(delay);
                        }
+                       if (fd == cfd)
+                               break;
+                       fd = cfd;
                }
        }
 }
+#endif