wget: add TODO
[oweals/busybox.git] / networking / httpd.c
index d5cfd652c70079f5affd9840e34c9c8a5bb588fc..986703d2d5a34d76c7bee2eadb2c34888e5ac4e9 100644 (file)
@@ -256,7 +256,9 @@ static const HttpEnumString httpResponseNames[] = {
 
 
 static const char RFC1123FMT[] = "%a, %d %b %Y %H:%M:%S GMT";
-static const char Content_length[] = "Content-length:";
+
+
+#define STRNCASECMP(a, str) strncasecmp((a), (str), sizeof(str)-1)
 
 
 static int scan_ip(const char **ep, unsigned int *ip, unsigned char endc)
@@ -844,9 +846,11 @@ static int sendHeaders(HttpResponseNum responseNum)
        time_t timer = time(0);
        char timeStr[80];
        int len;
+       enum {
+               numNames = sizeof(httpResponseNames) / sizeof(httpResponseNames[0])
+       };
 
-       for (i = 0;
-               i < (sizeof(httpResponseNames)/sizeof(httpResponseNames[0])); i++) {
+       for (i = 0; i < numNames; i++) {
                if (httpResponseNames[i].type == responseNum) {
                        responseString = httpResponseNames[i].name;
                        infoString = httpResponseNames[i].info;
@@ -880,7 +884,7 @@ static int sendHeaders(HttpResponseNum responseNum)
        if (config->ContentLength != -1) {    /* file */
                strftime(timeStr, sizeof(timeStr), RFC1123FMT, gmtime(&config->last_mod));
                len += sprintf(buf+len, "Last-Modified: %s\r\n%s %"OFF_FMT"\r\n",
-                               timeStr, Content_length, (off_t) config->ContentLength);
+                               timeStr, "Content-length:", (off_t) config->ContentLength);
        }
        strcat(buf, "\r\n");
        len += 2;
@@ -891,9 +895,8 @@ static int sendHeaders(HttpResponseNum responseNum)
                                responseNum, responseString,
                                responseNum, responseString, infoString);
        }
-#if DEBUG
-       fprintf(stderr, "headers: '%s'\n", buf);
-#endif
+       if (DEBUG)
+               fprintf(stderr, "headers: '%s'\n", buf);
        return full_write(config->accepted_socket, buf, len);
 }
 
@@ -961,219 +964,214 @@ static int sendCgi(const char *url,
        int inFd;
        int outFd;
        int firstLine = 1;
+       int status;
+       size_t post_readed_size, post_readed_idx;
 
-       do {
-               if (pipe(fromCgi) != 0) {
-                       break;
-               }
-               if (pipe(toCgi) != 0) {
-                       break;
-               }
+       if (pipe(fromCgi) != 0)
+               return 0;
+       if (pipe(toCgi) != 0)
+               return 0;
 
-               pid = fork();
-               if (pid < 0) {
-                       pid = 0;
-                       break;
-               }
+       pid = fork();
+       if (pid < 0)
+               return 0;
+       
+       if (!pid) {
+               /* child process */
+               char *script;
+               char *purl = strdup(url);
+               char realpath_buff[MAXPATHLEN];
+
+               if (purl == NULL)
+                       _exit(242);
 
-               if (!pid) {
-                       /* child process */
-                       char *script;
-                       char *purl = strdup(url);
-                       char realpath_buff[MAXPATHLEN];
+               inFd = toCgi[0];
+               outFd = fromCgi[1];
 
-                       if (purl == NULL)
-                               _exit(242);
+               dup2(inFd, 0);  // replace stdin with the pipe
+               dup2(outFd, 1);  // replace stdout with the pipe
+               if (!DEBUG)
+                       dup2(outFd, 2);  // replace stderr with the pipe
 
-                       inFd  = toCgi[0];
-                       outFd = fromCgi[1];
+               close(toCgi[0]);
+               close(toCgi[1]);
+               close(fromCgi[0]);
+               close(fromCgi[1]);
 
-                       dup2(inFd, 0);  // replace stdin with the pipe
-                       dup2(outFd, 1);  // replace stdout with the pipe
-                       if (!DEBUG)
-                               dup2(outFd, 2);  // replace stderr with the pipe
-
-                       close(toCgi[0]);
-                       close(toCgi[1]);
-                       close(fromCgi[0]);
-                       close(fromCgi[1]);
-
-                       close(config->accepted_socket);
-                       close(config->server_socket);
-
-                       /*
-                        * Find PATH_INFO.
-                        */
-                       script = purl;
-                       while ((script = strchr(script + 1, '/')) != NULL) {
-                               /* have script.cgi/PATH_INFO or dirs/script.cgi[/PATH_INFO] */
-                               struct stat sb;
-
-                               *script = '\0';
-                               if (is_directory(purl + 1, 1, &sb) == 0) {
-                                       /* not directory, found script.cgi/PATH_INFO */
-                                       *script = '/';
-                                       break;
-                               }
-                               *script = '/';          /* is directory, find next '/' */
-                       }
-                       setenv1("PATH_INFO", script);   /* set /PATH_INFO or "" */
-                       /* setenv1("PATH", getenv("PATH")); redundant */
-                       setenv1("REQUEST_METHOD", request);
-                       if (config->query) {
-                               char *uri = alloca(strlen(purl) + 2 + strlen(config->query));
-                               if (uri)
-                                       sprintf(uri, "%s?%s", purl, config->query);
-                               setenv1("REQUEST_URI", uri);
-                       } else {
-                               setenv1("REQUEST_URI", purl);
+               close(config->accepted_socket);
+               close(config->server_socket);
+
+               /*
+                * Find PATH_INFO.
+                */
+               script = purl;
+               while ((script = strchr(script + 1, '/')) != NULL) {
+                       /* have script.cgi/PATH_INFO or dirs/script.cgi[/PATH_INFO] */
+                       struct stat sb;
+
+                       *script = '\0';
+                       if (is_directory(purl + 1, 1, &sb) == 0) {
+                               /* not directory, found script.cgi/PATH_INFO */
+                               *script = '/';
+                               break;
                        }
-                       if (script != NULL)
-                               *script = '\0';         /* reduce /PATH_INFO */
-                        /* SCRIPT_FILENAME required by PHP in CGI mode */
-                       if (realpath(purl + 1, realpath_buff))
-                               setenv1("SCRIPT_FILENAME", realpath_buff);
-                       else
-                               *realpath_buff = '\0';
-                       /* set SCRIPT_NAME as full path: /cgi-bin/dirs/script.cgi */
-                       setenv1("SCRIPT_NAME", purl);
-                       setenv1("QUERY_STRING", config->query);
-                       setenv1("SERVER_SOFTWARE", httpdVersion);
-                       putenv("SERVER_PROTOCOL=HTTP/1.0");
-                       putenv("GATEWAY_INTERFACE=CGI/1.1");
-                       setenv1("REMOTE_ADDR", config->rmt_ip_str);
+                       *script = '/';          /* is directory, find next '/' */
+               }
+               setenv1("PATH_INFO", script);   /* set /PATH_INFO or "" */
+               /* setenv1("PATH", getenv("PATH")); redundant */
+               setenv1("REQUEST_METHOD", request);
+               if (config->query) {
+                       char *uri = alloca(strlen(purl) + 2 + strlen(config->query));
+                       if (uri)
+                               sprintf(uri, "%s?%s", purl, config->query);
+                       setenv1("REQUEST_URI", uri);
+               } else {
+                       setenv1("REQUEST_URI", purl);
+               }
+               if (script != NULL)
+                       *script = '\0';         /* cut off /PATH_INFO */
+                /* SCRIPT_FILENAME required by PHP in CGI mode */
+               if (!realpath(purl + 1, realpath_buff))
+                       goto error_execing_cgi;
+               setenv1("SCRIPT_FILENAME", realpath_buff);
+               /* set SCRIPT_NAME as full path: /cgi-bin/dirs/script.cgi */
+               setenv1("SCRIPT_NAME", purl);
+               /* TODO: bug 996 says we need to decodeString(config->query)
+                * before placing it into env. Is this true? Add example
+                * in the comment please... */
+               setenv1("QUERY_STRING", config->query);
+               setenv1("SERVER_SOFTWARE", httpdVersion);
+               putenv("SERVER_PROTOCOL=HTTP/1.0");
+               putenv("GATEWAY_INTERFACE=CGI/1.1");
+               setenv1("REMOTE_ADDR", config->rmt_ip_str);
 #if ENABLE_FEATURE_HTTPD_SET_REMOTE_PORT_TO_ENV
-                       setenv_long("REMOTE_PORT", config->port);
+               setenv_long("REMOTE_PORT", config->port);
 #endif
-                       if (bodyLen) {
-                               setenv_long("CONTENT_LENGTH", bodyLen);
-                       }
-                       if (cookie)
-                               setenv1("HTTP_COOKIE", cookie);
-                       if (content_type)
-                               setenv1("CONTENT_TYPE", content_type);
+               if (bodyLen)
+                       setenv_long("CONTENT_LENGTH", bodyLen);
+               if (cookie)
+                       setenv1("HTTP_COOKIE", cookie);
+               if (content_type)
+                       setenv1("CONTENT_TYPE", content_type);
 #if ENABLE_FEATURE_HTTPD_BASIC_AUTH
-                       if (config->remoteuser) {
-                               setenv1("REMOTE_USER", config->remoteuser);
-                               putenv("AUTH_TYPE=Basic");
-                       }
-#endif
-                       if (config->referer)
-                               setenv1("HTTP_REFERER", config->referer);
-
-                       /* set execve argp[0] without path */
-                       argp[0] = strrchr(purl, '/') + 1;
-                       /* but script argp[0] must have absolute path and chdiring to this */
-                       if (*realpath_buff) {
-                               script = strrchr(realpath_buff, '/');
-                               if (script) {
-                                       *script = '\0';
-                                       if (chdir(realpath_buff) == 0) {
-                                               // now run the program.  If it fails,
-                                               // use _exit() so no destructors
-                                               // get called and make a mess.
-#if ENABLE_FEATURE_HTTPD_CONFIG_WITH_SCRIPT_INTERPR
-                                               char *interpr = NULL;
-                                               char *suffix = strrchr(purl, '.');
-
-                                               if (suffix) {
-                                                       Htaccess * cur;
-                                                       for (cur = config->script_i; cur; cur = cur->next)
-                                                               if (strcmp(cur->before_colon + 1, suffix) == 0) {
-                                                                       interpr = cur->after_colon;
-                                                                       break;
-                                                               }
-                                               }
+               if (config->remoteuser) {
+                       setenv1("REMOTE_USER", config->remoteuser);
+                       putenv("AUTH_TYPE=Basic");
+               }
 #endif
-                                               *script = '/';
+               if (config->referer)
+                       setenv1("HTTP_REFERER", config->referer);
+
+               /* set execve argp[0] without path */
+               argp[0] = strrchr(purl, '/') + 1;
+               /* but script argp[0] must have absolute path and chdiring to this */
+               script = strrchr(realpath_buff, '/');
+               if (!script)
+                       goto error_execing_cgi;
+               *script = '\0';
+               if (chdir(realpath_buff) == 0) {
+                       // now run the program.  If it fails,
+                       // use _exit() so no destructors
+                       // get called and make a mess.
 #if ENABLE_FEATURE_HTTPD_CONFIG_WITH_SCRIPT_INTERPR
-                                               if (interpr)
-                                                       execv(interpr, argp);
-                                               else
-#endif
-                                                       execv(realpath_buff, argp);
+                       char *interpr = NULL;
+                       char *suffix = strrchr(purl, '.');
+
+                       if (suffix) {
+                               Htaccess *cur;
+                               for (cur = config->script_i; cur; cur = cur->next) {
+                                       if (strcmp(cur->before_colon + 1, suffix) == 0) {
+                                               interpr = cur->after_colon;
+                                               break;
                                        }
                                }
                        }
-                       /* send to stdout (even if we are not from inetd) */
-                       config->accepted_socket = 1;
-                       sendHeaders(HTTP_NOT_FOUND);
-                       _exit(242);
-               } /* end child */
+#endif
+                       *script = '/';
+#if ENABLE_FEATURE_HTTPD_CONFIG_WITH_SCRIPT_INTERPR
+                       if (interpr)
+                               execv(interpr, argp);
+                       else
+#endif
+                               execv(realpath_buff, argp);
+               }
+ error_execing_cgi:
+               /* send to stdout (even if we are not from inetd) */
+               config->accepted_socket = 1;
+               sendHeaders(HTTP_NOT_FOUND);
+               _exit(242);
+       } /* end child */
 
-       } while (0);
+       /* parent process */
 
-       if (pid) {
-               /* parent process */
-               int status;
-               size_t post_readed_size = 0, post_readed_idx = 0;
+       post_readed_size = 0;
+       post_readed_idx = 0;
+       inFd = fromCgi[0];
+       outFd = toCgi[1];
+       close(fromCgi[1]);
+       close(toCgi[0]);
+       signal(SIGPIPE, SIG_IGN);
 
-               inFd  = fromCgi[0];
-               outFd = toCgi[1];
-               close(fromCgi[1]);
-               close(toCgi[0]);
-               signal(SIGPIPE, SIG_IGN);
-
-               while (1) {
-                       fd_set readSet;
-                       fd_set writeSet;
-                       char wbuf[128];
-                       int nfound;
-                       int count;
-
-                       FD_ZERO(&readSet);
-                       FD_ZERO(&writeSet);
-                       FD_SET(inFd, &readSet);
-                       if (bodyLen > 0 || post_readed_size > 0) {
-                               FD_SET(outFd, &writeSet);
-                               nfound = outFd > inFd ? outFd : inFd;
-                               if (post_readed_size == 0) {
-                                       FD_SET(config->accepted_socket, &readSet);
-                                       if (nfound < config->accepted_socket)
-                                               nfound = config->accepted_socket;
-                               }
-                               /* Now wait on the set of sockets! */
-                               nfound = select(nfound + 1, &readSet, &writeSet, 0, NULL);
-                       } else {
-                               if (!bodyLen) {
-                                       close(outFd);
-                                       bodyLen = -1;
-                               }
-                               nfound = select(inFd + 1, &readSet, 0, 0, NULL);
+       while (1) {
+               fd_set readSet;
+               fd_set writeSet;
+               char wbuf[128];
+               int nfound;
+               int count;
+
+               FD_ZERO(&readSet);
+               FD_ZERO(&writeSet);
+               FD_SET(inFd, &readSet);
+               if (bodyLen > 0 || post_readed_size > 0) {
+                       FD_SET(outFd, &writeSet);
+                       nfound = outFd > inFd ? outFd : inFd;
+                       if (post_readed_size == 0) {
+                               FD_SET(config->accepted_socket, &readSet);
+                               if (nfound < config->accepted_socket)
+                                       nfound = config->accepted_socket;
+                       }
+                       /* Now wait on the set of sockets! */
+                       nfound = select(nfound + 1, &readSet, &writeSet, 0, NULL);
+               } else {
+                       if (!bodyLen) {
+                               close(outFd);
+                               bodyLen = -1;
                        }
+                       nfound = select(inFd + 1, &readSet, 0, 0, NULL);
+               }
 
-                       if (nfound <= 0) {
-                               if (waitpid(pid, &status, WNOHANG) > 0) {
-                                       close(inFd);
-                                       if (DEBUG && WIFEXITED(status))
-                                               bb_error_msg("piped has exited with status=%d", WEXITSTATUS(status));
-                                       if (DEBUG && WIFSIGNALED(status))
-                                               bb_error_msg("piped has exited with signal=%d", WTERMSIG(status));
-                                       break;
-                               }
-                       } else if (post_readed_size > 0 && FD_ISSET(outFd, &writeSet)) {
-                               count = full_write(outFd, wbuf + post_readed_idx, post_readed_size);
-                               if (count > 0) {
-                                       post_readed_size -= count;
-                                       post_readed_idx += count;
-                                       if (post_readed_size == 0)
-                                               post_readed_idx = 0;
-                               } else {
-                                       post_readed_size = post_readed_idx = bodyLen = 0; /* broken pipe to CGI */
-                               }
-                       } else if (bodyLen > 0 && post_readed_size == 0 && FD_ISSET(config->accepted_socket, &readSet)) {
-                               count = bodyLen > (int)sizeof(wbuf) ? (int)sizeof(wbuf) : bodyLen;
-                               count = safe_read(config->accepted_socket, wbuf, count);
-                               if (count > 0) {
-                                       post_readed_size += count;
-                                       bodyLen -= count;
-                               } else {
-                                       bodyLen = 0;    /* closed */
-                               }
+               if (nfound <= 0) {
+                       if (waitpid(pid, &status, WNOHANG) > 0) {
+                               close(inFd);
+                               if (DEBUG && WIFEXITED(status))
+                                       bb_error_msg("piped has exited with status=%d", WEXITSTATUS(status));
+                               if (DEBUG && WIFSIGNALED(status))
+                                       bb_error_msg("piped has exited with signal=%d", WTERMSIG(status));
+                               break;
+                       }
+               } else if (post_readed_size > 0 && FD_ISSET(outFd, &writeSet)) {
+                       count = full_write(outFd, wbuf + post_readed_idx, post_readed_size);
+                       if (count > 0) {
+                               post_readed_size -= count;
+                               post_readed_idx += count;
+                               if (post_readed_size == 0)
+                                       post_readed_idx = 0;
+                       } else {
+                               post_readed_size = post_readed_idx = bodyLen = 0; /* broken pipe to CGI */
                        }
-                       if (FD_ISSET(inFd, &readSet)) {
-                               int s = config->accepted_socket;
-                               char *rbuf = config->buf;
+               } else if (bodyLen > 0 && post_readed_size == 0 && FD_ISSET(config->accepted_socket, &readSet)) {
+                       count = bodyLen > (int)sizeof(wbuf) ? (int)sizeof(wbuf) : bodyLen;
+                       count = safe_read(config->accepted_socket, wbuf, count);
+                       if (count > 0) {
+                               post_readed_size += count;
+                               bodyLen -= count;
+                       } else {
+                               bodyLen = 0;    /* closed */
+                       }
+               }
+               if (FD_ISSET(inFd, &readSet)) {
+                       int s = config->accepted_socket;
+                       char *rbuf = config->buf;
 
 #ifndef PIPE_BUF
 # define PIPESIZE 4096          /* amount of buffering in a pipe */
@@ -1184,28 +1182,31 @@ static int sendCgi(const char *url,
 # error "PIPESIZE >= MAX_MEMORY_BUFF"
 #endif
 
-                               // There is something to read
-                               count = safe_read(inFd, rbuf, PIPESIZE);
-                               if (count == 0)
-                                       break;  /* closed */
-                               if (count > 0) {
-                                       if (firstLine) {
-                                               rbuf[count] = 0;
-                                               /* check to see if the user script added headers */
-                                               if (strncmp(rbuf, "HTTP/1.0 200 OK\r\n", 4) != 0) {
-                                                       full_write(s, "HTTP/1.0 200 OK\r\n", 17);
-                                               }
-                                               if (strstr(rbuf, "ontent-") == 0) {
-                                                       full_write(s, "Content-type: text/plain\r\n\r\n", 28);
-                                               }
-                                               firstLine = 0;
+                       /* There is something to read */
+                       count = safe_read(inFd, rbuf, PIPESIZE);
+                       if (count == 0)
+                               break;  /* closed */
+                       if (count > 0) {
+                               if (firstLine) {
+                                       rbuf[count] = 0;
+                                       /* check to see if the user script added headers */
+                                       if (strncmp(rbuf, "HTTP/1.0 200 OK\r\n", 4) != 0) {
+                                               full_write(s, "HTTP/1.0 200 OK\r\n", 17);
                                        }
-                                       if (full_write(s, rbuf, count) != count)
-                                               break;
-
-                                       if (DEBUG)
-                                               fprintf(stderr, "cgi read %d bytes\n", count);
+                                       /* Sometimes CGI is writing to pipe in small chunks
+                                        * and we don't see Content-type (because the read
+                                        * is too short) and we emit bogus "text/plain"!
+                                        * Is it a bug or CGI *has to* write it in one piece? */
+                                       if (strstr(rbuf, "ontent-") == 0) {
+                                               full_write(s, "Content-type: text/plain\r\n\r\n", 28);
+                                       }
+                                       firstLine = 0;
                                }
+                               if (full_write(s, rbuf, count) != count)
+                                       break;
+
+                               if (DEBUG)
+                                       fprintf(stderr, "cgi read %d bytes: '%.*s'\n", count, count, rbuf);
                        }
                }
        }
@@ -1425,7 +1426,7 @@ static void handleIncoming(void)
        int ip_allowed;
 #if ENABLE_FEATURE_HTTPD_CGI
        const char *prequest = request_GET;
-       long length = 0;
+       unsigned long length = 0;
        char *cookie = 0;
        char *content_type = 0;
 #endif
@@ -1452,11 +1453,11 @@ static void handleIncoming(void)
 
                purl = strpbrk(buf, " \t");
                if (purl == NULL) {
-BAD_REQUEST:
+ BAD_REQUEST:
                        sendHeaders(HTTP_BAD_REQUEST);
                        break;
                }
-               *purl = 0;
+               *purl = '\0';
 #if ENABLE_FEATURE_HTTPD_CGI
                if (strcasecmp(buf, prequest) != 0) {
                        prequest = "POST";
@@ -1486,30 +1487,37 @@ BAD_REQUEST:
                strcpy(url, buf);
                /* extract url args if present */
                test = strchr(url, '?');
+               config->query = NULL;
                if (test) {
-                       *test++ = 0;
+                       *test++ = '\0';
                        config->query = test;
                }
 
                test = decodeString(url, 0);
                if (test == NULL)
                        goto BAD_REQUEST;
+               /* FIXME: bug? should be "url+1"? */
                if (test == (buf+1)) {
                        sendHeaders(HTTP_NOT_FOUND);
                        break;
                }
+
                /* algorithm stolen from libbb bb_simplify_path(),
                         but don't strdup and reducing trailing slash and protect out root */
                purl = test = url;
-
                do {
                        if (*purl == '/') {
-                               if (*test == '/') {        /* skip duplicate (or initial) slash */
+                               /* skip duplicate (or initial) slash */
+                               if (*test == '/') {
                                        continue;
-                               } else if (*test == '.') {
-                                       if (test[1] == '/' || test[1] == 0) { /* skip extra '.' */
+                               }
+                               if (*test == '.') {
+                                       /* skip extra '.' */
+                                       if (test[1] == '/' || test[1] == 0) {
                                                continue;
-                                       } else if ((test[1] == '.') && (test[2] == '/' || test[2] == 0)) {
+                                       } else
+                                       /* '..': be careful */
+                                       if (test[1] == '.' && (test[2] == '/' || test[2] == 0)) {
                                                ++test;
                                                if (purl == url) {
                                                        /* protect out root */
@@ -1522,9 +1530,8 @@ BAD_REQUEST:
                        }
                        *++purl = *test;
                } while (*++test);
-
-               *++purl = 0;        /* so keep last character */
-               test = purl;        /* end ptr */
+               *++purl = '\0';       /* so keep last character */
+               test = purl;          /* end ptr */
 
                /* If URL is directory, adding '/' */
                if (test[-1] != '/') {
@@ -1548,7 +1555,7 @@ BAD_REQUEST:
                        *test = '/';
                }
                if (blank >= 0) {
-                       // read until blank line for HTTP version specified, else parse immediate
+                       /* read until blank line for HTTP version specified, else parse immediate */
                        while (1) {
                                alarm(TIMEOUT);
                                count = getLine();
@@ -1560,36 +1567,40 @@ BAD_REQUEST:
 
 #if ENABLE_FEATURE_HTTPD_CGI
                                /* try and do our best to parse more lines */
-                               if ((strncasecmp(buf, Content_length, 15) == 0)) {
-                                       if (prequest != request_GET)
-                                               length = strtol(buf + 15, 0, 0); // extra read only for POST
-                               } else if ((strncasecmp(buf, "Cookie:", 7) == 0)) {
-                                       for (test = buf + 7; isspace(*test); test++)
-                                                 ;
-                                       cookie = strdup(test);
-                               } else if ((strncasecmp(buf, "Content-Type:", 13) == 0)) {
-                                       for (test = buf + 13; isspace(*test); test++)
-                                                 ;
-                                       content_type = strdup(test);
-                               } else if ((strncasecmp(buf, "Referer:", 8) == 0)) {
-                                       for (test = buf + 8; isspace(*test); test++)
-                                                 ;
-                                       config->referer = strdup(test);
+                               if ((STRNCASECMP(buf, "Content-length:") == 0)) {
+                                       /* extra read only for POST */
+                                       if (prequest != request_GET) {
+                                               test = buf + sizeof("Content-length:")-1;
+                                               if (!test[0]) goto bail_out;
+                                               errno = 0;
+                                               /* not using strtoul: it ignores leading munis! */
+                                               length = strtol(test, &test, 10);
+                                               /* length is "ulong", but we need to pass it to int later */
+                                               /* so we check for negative or too large values in one go: */
+                                               /* (long -> ulong conv caused negatives to be seen as > INT_MAX) */
+                                               if (test[0] || errno || length > INT_MAX)
+                                                       goto bail_out;
+                                       }
+                               } else if ((STRNCASECMP(buf, "Cookie:") == 0)) {
+                                       cookie = strdup(skip_whitespace(buf + sizeof("Cookie:")-1));
+                               } else if ((STRNCASECMP(buf, "Content-Type:") == 0)) {
+                                       content_type = strdup(skip_whitespace(buf + sizeof("Content-Type:")-1));
+                               } else if ((STRNCASECMP(buf, "Referer:") == 0)) {
+                                       config->referer = strdup(skip_whitespace(buf + sizeof("Referer:")-1));
                                }
 #endif
 
 #if ENABLE_FEATURE_HTTPD_BASIC_AUTH
-                               if (strncasecmp(buf, "Authorization:", 14) == 0) {
+                               if (STRNCASECMP(buf, "Authorization:") == 0) {
                                        /* We only allow Basic credentials.
                                         * It shows up as "Authorization: Basic <userid:password>" where
                                         * the userid:password is base64 encoded.
                                         */
-                                       for (test = buf + 14; isspace(*test); test++)
-                                               ;
-                                       if (strncasecmp(test, "Basic", 5) != 0)
+                                       test = skip_whitespace(buf + sizeof("Authorization:")-1);
+                                       if (STRNCASECMP(test, "Basic") != 0)
                                                continue;
-
-                                       test += 5;  /* decodeBase64() skiping space self */
+                                       test += sizeof("Basic")-1;
+                                       /* decodeBase64() skips whitespace itself */
                                        decodeBase64(test);
                                        credentials = checkPerm(url, test);
                                }
@@ -1597,14 +1608,14 @@ BAD_REQUEST:
 
                        } /* while extra header reading */
                }
-               (void) alarm(0);
+               alarm(0);
                if (config->alarm_signaled)
                        break;
 
                if (strcmp(strrchr(url, '/') + 1, httpd_conf) == 0 || ip_allowed == 0) {
                        /* protect listing [/path]/httpd_conf or IP deny */
 #if ENABLE_FEATURE_HTTPD_CGI
-FORBIDDEN:             /* protect listing /cgi-bin */
+ FORBIDDEN:            /* protect listing /cgi-bin */
 #endif
                        sendHeaders(HTTP_FORBIDDEN);
                        break;
@@ -1627,33 +1638,42 @@ FORBIDDEN:              /* protect listing /cgi-bin */
                test = url + 1;      /* skip first '/' */
 
 #if ENABLE_FEATURE_HTTPD_CGI
-               /* if strange Content-Length */
-               if (length < 0)
-                       break;
-
                if (strncmp(test, "cgi-bin", 7) == 0) {
                        if (test[7] == '/' && test[8] == 0)
-                               goto FORBIDDEN;     // protect listing cgi-bin/
+                               goto FORBIDDEN;     /* protect listing cgi-bin/ */
                        sendCgi(url, prequest, length, cookie, content_type);
-               } else {
-                       if (prequest != request_GET)
-                               sendHeaders(HTTP_NOT_IMPLEMENTED);
-                       else {
+                       break;
+               }
+               if (prequest != request_GET) {
+                       sendHeaders(HTTP_NOT_IMPLEMENTED);
+                       break;
+               }
 #endif  /* FEATURE_HTTPD_CGI */
-                               if (purl[-1] == '/')
-                                       strcpy(purl, "index.html");
-                               if (stat(test, &sb) == 0) {
-                                       config->ContentLength = sb.st_size;
-                                       config->last_mod = sb.st_mtime;
-                               }
-                               sendFile(test);
-                               config->ContentLength = -1;
+               if (purl[-1] == '/')
+                       strcpy(purl, "index.html");
+               if (stat(test, &sb) == 0) {
+                       /* It's a dir URL and there is index.html */
+                       config->ContentLength = sb.st_size;
+                       config->last_mod = sb.st_mtime;
+               }
 #if ENABLE_FEATURE_HTTPD_CGI
+               else if (purl[-1] == '/') {
+                       /* It's a dir URL and there is no index.html
+                        * Try cgi-bin/index.cgi */
+                       if (access("/cgi-bin/index.cgi"+1, X_OK) == 0) {
+                               purl[0] = '\0';
+                               config->query = url;
+                               sendCgi("/cgi-bin/index.cgi", prequest, length, cookie, content_type);
+                               break;
                        }
                }
-#endif
+#endif  /* FEATURE_HTTPD_CGI */
+               sendFile(test);
+               config->ContentLength = -1;
        } while (0);
 
+ bail_out:
+
        if (DEBUG)
                fprintf(stderr, "closing socket\n\n");
 #if ENABLE_FEATURE_HTTPD_CGI
@@ -1739,22 +1759,19 @@ static int miniHttpd(int server)
                /* set the KEEPALIVE option to cull dead connections */
                on = 1;
                setsockopt(s, SOL_SOCKET, SO_KEEPALIVE, (void *)&on, sizeof(on));
-#if !DEBUG
-               if (fork() == 0)
-#endif
-               {
-                       /* This is the spawned thread */
+
+               if (DEBUG || fork() == 0) {
+                       /* child */
 #if ENABLE_FEATURE_HTTPD_RELOAD_CONFIG_SIGHUP
                        /* protect reload config, may be confuse checking */
                        signal(SIGHUP, SIG_IGN);
 #endif
                        handleIncoming();
-#if !DEBUG
-                       exit(0);
-#endif
+                       if (!DEBUG)
+                               exit(0);
                }
                close(s);
-       } // while (1)
+       } /* while (1) */
        return 0;
 }
 
@@ -1834,6 +1851,11 @@ int httpd_main(int argc, char *argv[])
        USE_FEATURE_HTTPD_SETUID(struct bb_uidgid_t ugid;)
        USE_FEATURE_HTTPD_AUTH_MD5(const char *pass;)
 
+#if ENABLE_LOCALE_SUPPORT
+       /* Undo busybox.c: we want to speak English in http (dates etc) */
+       setlocale(LC_TIME, "C");
+#endif
+
        config = xzalloc(sizeof(*config));
 #if ENABLE_FEATURE_HTTPD_BASIC_AUTH
        config->realm = "Web Server Authentication";