wget: -O FILE is allowed to overwrite existing file (compat)
[oweals/busybox.git] / networking / httpd.c
index 560d1f8ee70d9b058dbead9881ff5a22fcc1f96e..92a07107dc12742de776bb7f72141780e43a4285 100644 (file)
@@ -42,6 +42,7 @@
  * A:10.0.0.0/255.255.255.128  # Allow any address that previous set
  * A:127.0.0.1       # Allow local loopback connections
  * D:*               # Deny from other IP connections
+ * E404:/path/e404.html # /path/e404.html is the 404 (not found) error page
  * /cgi-bin:foo:bar  # Require user foo, pwd bar on urls starting with /cgi-bin/
  * /adm:admin:setup  # Require user admin, pwd setup on urls starting with /adm/
  * /adm:toor:PaSsWd  # or user toor, pwd PaSsWd on urls starting with /adm/
  * subdir http request, any merge is discarded when the process exits.  As a
  * result, the subdir settings only have a lifetime of a single request.
  *
+ * Custom error pages can contain an absolute path or be relative to
+ * 'home_httpd'. Error pages are to be static files (no CGI or script). Error
+ * page can only be defined in the root configuration file and are not taken
+ * into account in local (directories) config files.
  *
  * If -c is not set, an attempt will be made to open the default
  * root configuration file.  If -c is set and the file is not found, the
 //#define DEBUG 1
 #define DEBUG 0
 
+#define IOBUF_SIZE 8192    /* IO buffer */
+
 /* amount of buffering in a pipe */
 #ifndef PIPE_BUF
 # define PIPE_BUF 4096
 #endif
-
-#define MAX_MEMORY_BUF 8192    /* IO buffer */
+#if PIPE_BUF >= IOBUF_SIZE
+# error "PIPE_BUF >= IOBUF_SIZE"
+#endif
 
 #define HEADER_READ_TIMEOUT 60
 
@@ -131,13 +139,98 @@ typedef struct Htaccess_IP {
        int allow_deny;
 } Htaccess_IP;
 
+enum {
+       HTTP_OK = 200,
+       HTTP_PARTIAL_CONTENT = 206,
+       HTTP_MOVED_TEMPORARILY = 302,
+       HTTP_BAD_REQUEST = 400,       /* malformed syntax */
+       HTTP_UNAUTHORIZED = 401, /* authentication needed, respond with auth hdr */
+       HTTP_NOT_FOUND = 404,
+       HTTP_FORBIDDEN = 403,
+       HTTP_REQUEST_TIMEOUT = 408,
+       HTTP_NOT_IMPLEMENTED = 501,   /* used for unrecognized requests */
+       HTTP_INTERNAL_SERVER_ERROR = 500,
+       HTTP_CONTINUE = 100,
+#if 0   /* future use */
+       HTTP_SWITCHING_PROTOCOLS = 101,
+       HTTP_CREATED = 201,
+       HTTP_ACCEPTED = 202,
+       HTTP_NON_AUTHORITATIVE_INFO = 203,
+       HTTP_NO_CONTENT = 204,
+       HTTP_MULTIPLE_CHOICES = 300,
+       HTTP_MOVED_PERMANENTLY = 301,
+       HTTP_NOT_MODIFIED = 304,
+       HTTP_PAYMENT_REQUIRED = 402,
+       HTTP_BAD_GATEWAY = 502,
+       HTTP_SERVICE_UNAVAILABLE = 503, /* overload, maintenance */
+       HTTP_RESPONSE_SETSIZE = 0xffffffff
+#endif
+};
+
+static const uint16_t http_response_type[] ALIGN2 = {
+       HTTP_OK,
+#if ENABLE_FEATURE_HTTPD_RANGES
+       HTTP_PARTIAL_CONTENT,
+#endif
+       HTTP_MOVED_TEMPORARILY,
+       HTTP_REQUEST_TIMEOUT,
+       HTTP_NOT_IMPLEMENTED,
+#if ENABLE_FEATURE_HTTPD_BASIC_AUTH 
+       HTTP_UNAUTHORIZED,
+#endif
+       HTTP_NOT_FOUND,
+       HTTP_BAD_REQUEST,
+       HTTP_FORBIDDEN,
+       HTTP_INTERNAL_SERVER_ERROR,
+#if 0   /* not implemented */
+       HTTP_CREATED,
+       HTTP_ACCEPTED,
+       HTTP_NO_CONTENT,
+       HTTP_MULTIPLE_CHOICES,
+       HTTP_MOVED_PERMANENTLY,
+       HTTP_NOT_MODIFIED,
+       HTTP_BAD_GATEWAY,
+       HTTP_SERVICE_UNAVAILABLE,
+#endif
+};
+
+static const struct {
+       const char *name;
+       const char *info;
+} http_response[ARRAY_SIZE(http_response_type)] = {
+       { "OK", NULL },
+#if ENABLE_FEATURE_HTTPD_RANGES
+       { "Partial Content", NULL },
+#endif
+       { "Found", NULL },
+       { "Request Timeout", "No request appeared within 60 seconds" },
+       { "Not Implemented", "The requested method is not recognized" },
+#if ENABLE_FEATURE_HTTPD_BASIC_AUTH
+       { "Unauthorized", "" },
+#endif
+       { "Not Found", "The requested URL was not found" },
+       { "Bad Request", "Unsupported method" },
+       { "Forbidden", ""  },
+       { "Internal Server Error", "Internal Server Error" },
+#if 0   /* not implemented */
+       { "Created" },
+       { "Accepted" },
+       { "No Content" },
+       { "Multiple Choices" },
+       { "Moved Permanently" },
+       { "Not Modified" },
+       { "Bad Gateway", "" },
+       { "Service Unavailable", "" },
+#endif
+};
+
+
 struct globals {
        int verbose;            /* must be int (used by getopt32) */
        smallint flg_deny_all;
 
        unsigned rmt_ip;        /* used for IP-based allow/deny rules */
        time_t last_mod;
-       off_t ContentLength;    /* -1 - unknown */
        char *rmt_ip_str;       /* for $REMOTE_ADDR and $REMOTE_PORT */
        const char *bind_addr_or_port;
 
@@ -154,6 +247,13 @@ struct globals {
        USE_FEATURE_HTTPD_CGI(char *referer;)
        USE_FEATURE_HTTPD_CGI(char *user_agent;)
 
+       off_t file_size;        /* -1 - unknown */
+#if ENABLE_FEATURE_HTTPD_RANGES
+       off_t range_start;
+       off_t range_end;
+       off_t range_len;
+#endif
+
 #if ENABLE_FEATURE_HTTPD_BASIC_AUTH
        Htaccess *g_auth;       /* config user:password lines */
 #endif
@@ -163,10 +263,13 @@ struct globals {
 #if ENABLE_FEATURE_HTTPD_CONFIG_WITH_SCRIPT_INTERPR
        Htaccess *script_i;     /* config script interpreters */
 #endif
-       char *iobuf;            /* [MAX_MEMORY_BUF] */
+       char *iobuf;            /* [IOBUF_SIZE] */
 #define hdr_buf bb_common_bufsiz1
        char *hdr_ptr;
        int hdr_cnt;
+#if ENABLE_FEATURE_HTTPD_ERROR_PAGES
+       const char *http_error_page[ARRAY_SIZE(http_response_type)];
+#endif
 };
 #define G (*ptr_to_globals)
 #define verbose           (G.verbose          )
@@ -178,13 +281,18 @@ struct globals {
 #define home_httpd        (G.home_httpd       )
 #define found_mime_type   (G.found_mime_type  )
 #define found_moved_temporarily (G.found_moved_temporarily)
-#define ContentLength     (G.ContentLength    )
 #define last_mod          (G.last_mod         )
 #define ip_a_d            (G.ip_a_d           )
 #define g_realm           (G.g_realm          )
 #define remoteuser        (G.remoteuser       )
 #define referer           (G.referer          )
 #define user_agent        (G.user_agent       )
+#define file_size         (G.file_size        )
+#if ENABLE_FEATURE_HTTPD_RANGES
+#define range_start       (G.range_start      )
+#define range_end         (G.range_end        )
+#define range_len         (G.range_len        )
+#endif
 #define rmt_ip_str        (G.rmt_ip_str       )
 #define g_auth            (G.g_auth           )
 #define mime_a            (G.mime_a           )
@@ -192,78 +300,28 @@ struct globals {
 #define iobuf             (G.iobuf            )
 #define hdr_ptr           (G.hdr_ptr          )
 #define hdr_cnt           (G.hdr_cnt          )
+#define http_error_page   (G.http_error_page  )
 #define INIT_G() do { \
        PTR_TO_GLOBALS = xzalloc(sizeof(G)); \
        USE_FEATURE_HTTPD_BASIC_AUTH(g_realm = "Web Server Authentication";) \
        bind_addr_or_port = "80"; \
-       ContentLength = -1; \
+       file_size = -1; \
 } while (0)
 
-
-typedef enum {
-       HTTP_OK = 200,
-       HTTP_MOVED_TEMPORARILY = 302,
-       HTTP_BAD_REQUEST = 400,       /* malformed syntax */
-       HTTP_UNAUTHORIZED = 401, /* authentication needed, respond with auth hdr */
-       HTTP_NOT_FOUND = 404,
-       HTTP_FORBIDDEN = 403,
-       HTTP_REQUEST_TIMEOUT = 408,
-       HTTP_NOT_IMPLEMENTED = 501,   /* used for unrecognized requests */
-       HTTP_INTERNAL_SERVER_ERROR = 500,
-#if 0 /* future use */
-       HTTP_CONTINUE = 100,
-       HTTP_SWITCHING_PROTOCOLS = 101,
-       HTTP_CREATED = 201,
-       HTTP_ACCEPTED = 202,
-       HTTP_NON_AUTHORITATIVE_INFO = 203,
-       HTTP_NO_CONTENT = 204,
-       HTTP_MULTIPLE_CHOICES = 300,
-       HTTP_MOVED_PERMANENTLY = 301,
-       HTTP_NOT_MODIFIED = 304,
-       HTTP_PAYMENT_REQUIRED = 402,
-       HTTP_BAD_GATEWAY = 502,
-       HTTP_SERVICE_UNAVAILABLE = 503, /* overload, maintenance */
-       HTTP_RESPONSE_SETSIZE = 0xffffffff
-#endif
-} HttpResponseNum;
-
-typedef struct {
-       HttpResponseNum type;
-       const char *name;
-       const char *info;
-} HttpEnumString;
-
-static const HttpEnumString httpResponseNames[] = {
-       { HTTP_OK, "OK", NULL },
-       { HTTP_MOVED_TEMPORARILY, "Found", "Directories must end with a slash." },
-       { HTTP_REQUEST_TIMEOUT, "Request Timeout",
-               "No request appeared within a reasonable time period." },
-       { HTTP_NOT_IMPLEMENTED, "Not Implemented",
-               "The requested method is not recognized by this server." },
-#if ENABLE_FEATURE_HTTPD_BASIC_AUTH
-       { HTTP_UNAUTHORIZED, "Unauthorized", "" },
-#endif
-       { HTTP_NOT_FOUND, "Not Found",
-               "The requested URL was not found on this server." },
-       { HTTP_BAD_REQUEST, "Bad Request", "Unsupported method." },
-       { HTTP_FORBIDDEN, "Forbidden", "" },
-       { HTTP_INTERNAL_SERVER_ERROR, "Internal Server Error",
-               "Internal Server Error" },
-#if 0                               /* not implemented */
-       { HTTP_CREATED, "Created" },
-       { HTTP_ACCEPTED, "Accepted" },
-       { HTTP_NO_CONTENT, "No Content" },
-       { HTTP_MULTIPLE_CHOICES, "Multiple Choices" },
-       { HTTP_MOVED_PERMANENTLY, "Moved Permanently" },
-       { HTTP_NOT_MODIFIED, "Not Modified" },
-       { HTTP_BAD_GATEWAY, "Bad Gateway", "" },
-       { HTTP_SERVICE_UNAVAILABLE, "Service Unavailable", "" },
-#endif
+#if !ENABLE_FEATURE_HTTPD_RANGES
+enum {
+       range_start = 0,
+       range_end = MAXINT(off_t) - 1,
+       range_len = MAXINT(off_t),
 };
+#endif
 
 
 #define STRNCASECMP(a, str) strncasecmp((a), (str), sizeof(str)-1)
 
+/* Prototypes */
+static void send_file_and_exit(const char *url, int headers) ATTRIBUTE_NORETURN;
+
 static void free_llist(has_next_ptr **pptr)
 {
        has_next_ptr *cur = *pptr;
@@ -289,17 +347,22 @@ static ALWAYS_INLINE void free_Htaccess_IP_list(Htaccess_IP **pptr)
        free_llist((has_next_ptr**)pptr);
 }
 
-static int scan_ip(const char **ep, unsigned *ip, unsigned char endc)
+/* Returns presumed mask width in bits or < 0 on error.
+ * Updates strp, stores IP at provided pointer */
+static int scan_ip(const char **strp, unsigned *ipp, unsigned char endc)
 {
-       const char *p = *ep;
+       const char *p = *strp;
        int auto_mask = 8;
+       unsigned ip = 0;
        int j;
 
-       *ip = 0;
+       if (*p == '/')
+               return -auto_mask;
+
        for (j = 0; j < 4; j++) {
                unsigned octet;
 
-               if ((*p < '0' || *p > '9') && (*p != '/' || j == 0) && *p != '\0')
+               if ((*p < '0' || *p > '9') && *p != '/' && *p)
                        return -auto_mask;
                octet = 0;
                while (*p >= '0' && *p <= '9') {
@@ -311,55 +374,61 @@ static int scan_ip(const char **ep, unsigned *ip, unsigned char endc)
                }
                if (*p == '.')
                        p++;
-               if (*p != '/' && *p != '\0')
+               if (*p != '/' && *p)
                        auto_mask += 8;
-               *ip = ((*ip) << 8) | octet;
+               ip = (ip << 8) | octet;
        }
-       if (*p != '\0') {
+       if (*p) {
                if (*p != endc)
                        return -auto_mask;
                p++;
                if (*p == '\0')
                        return -auto_mask;
        }
-       *ep = p;
+       *ipp = ip;
+       *strp = p;
        return auto_mask;
 }
 
-static int scan_ip_mask(const char *ipm, unsigned *ip, unsigned *mask)
+/* Returns 0 on success. Stores IP and mask at provided pointers */
+static int scan_ip_mask(const char *str, unsigned *ipp, unsigned *maskp)
 {
        int i;
-       unsigned msk;
+       unsigned mask;
+       char *p;
 
-       i = scan_ip(&ipm, ip, '/');
+       i = scan_ip(&str, ipp, '/');
        if (i < 0)
                return i;
-       if (*ipm) {
-               const char *p = ipm;
-
-               i = 0;
-               while (*p) {
-                       if (*p < '0' || *p > '9') {
-                               if (*p == '.') {
-                                       i = scan_ip(&ipm, mask, 0);
-                                       return i != 32;
-                               }
-                               return -1;
-                       }
-                       i *= 10;
-                       i += *p - '0';
-                       p++;
+
+       if (*str) {
+               /* there is /xxx after dotted-IP address */
+               i = bb_strtou(str, &p, 10);
+               if (*p == '.') {
+                       /* 'xxx' itself is dotted-IP mask, parse it */
+                       /* (return 0 (success) only if it has N.N.N.N form) */
+                       return scan_ip(&str, maskp, '\0') - 32;
                }
+               if (*p)
+                       return -1;
        }
-       if (i > 32 || i < 0)
+
+       if (i > 32)
                return -1;
-       msk = 0x80000000;
-       *mask = 0;
-       while (i > 0) {
-               *mask |= msk;
-               msk >>= 1;
-               i--;
+
+       if (sizeof(unsigned) == 4 && i == 32) {
+               /* mask >>= 32 below may not work */
+               mask = 0;
+       } else {
+               mask = 0xffffffff;
+               mask >>= i;
        }
+       /* i == 0 -> *maskp = 0x00000000
+        * i == 1 -> *maskp = 0x80000000
+        * i == 4 -> *maskp = 0xf0000000
+        * i == 31 -> *maskp = 0xfffffffe
+        * i == 32 -> *maskp = 0xffffffff */
+       *maskp = (uint32_t)(~mask);
        return 0;
 }
 
@@ -371,11 +440,13 @@ static int scan_ip_mask(const char *ipm, unsigned *ip, unsigned *mask)
  *    .ext:mime/type   # new mime type not compiled into httpd
  *    [adAD]:from      # ip address allow/deny, * for wildcard
  *    /path:user:pass  # username/password
+ *    Ennn:error.html  # error page for status nnn
  *
  * Any previous IP rules are discarded.
  * If the flag argument is not SUBDIR_PARSE then all /path and mime rules
  * are also discarded.  That is, previous settings are retained if flag is
  * SUBDIR_PARSE.
+ * Error pages are only parsed on the main config file.
  *
  * path   Path where to look for httpd.conf (without filename).
  * flag   Type of the parse request.
@@ -424,11 +495,6 @@ static void parse_conf(const char *path, int flag)
 
        if (flag == SUBDIR_PARSE || cf == NULL) {
                cf = alloca(strlen(path) + sizeof(httpd_conf) + 2);
-               if (cf == NULL) {
-                       if (flag == FIRST_PARSE)
-                               bb_error_msg_and_die(bb_msg_memory_exhausted);
-                       return;
-               }
                sprintf((char *)cf, "%s/%s", path, httpd_conf);
        }
 
@@ -475,18 +541,6 @@ static void parse_conf(const char *path, int flag)
 
                if (*p0 == 'a')
                        *p0 = 'A';
-               else if (*p0 != 'D' && *p0 != 'A'
-#if ENABLE_FEATURE_HTTPD_BASIC_AUTH
-                        && *p0 != '/'
-#endif
-#if ENABLE_FEATURE_HTTPD_CONFIG_WITH_MIME_TYPES
-                        && *p0 != '.'
-#endif
-#if ENABLE_FEATURE_HTTPD_CONFIG_WITH_SCRIPT_INTERPR
-                        && *p0 != '*'
-#endif
-                       )
-                        continue;
                if (*p0 == 'A' || *p0 == 'D') {
                        /* storing current config IP line */
                        pip = xzalloc(sizeof(Htaccess_IP));
@@ -516,13 +570,35 @@ static void parse_conf(const char *path, int flag)
                        }
                        continue;
                }
+
+#if ENABLE_FEATURE_HTTPD_ERROR_PAGES
+               if (flag == FIRST_PARSE && *p0 == 'E') {
+                       int i;
+                       /* error status code */
+                       int status = atoi(++p0);
+                       /* c already points at the character following ':' in parse loop */
+                       /* c = strchr(p0, ':'); c++; */
+                       if (status < HTTP_CONTINUE) {
+                               bb_error_msg("config error '%s' in '%s'", buf, cf);
+                               continue;
+                       }
+
+                       /* then error page; find matching status */
+                       for (i = 0; i < ARRAY_SIZE(http_response_type); i++) {
+                               if (http_response_type[i] == status) {
+                                       http_error_page[i] = concat_path_file((*c == '/') ? NULL : home_httpd, c);
+                                       break;
+                               }
+                       }
+                       continue;
+               }
+#endif
+
 #if ENABLE_FEATURE_HTTPD_BASIC_AUTH
                if (*p0 == '/') {
                        /* make full path from httpd root / current_path / config_line_path */
                        cf = (flag == SUBDIR_PARSE ? path : "");
-                       p0 = malloc(strlen(cf) + (c - buf) + 2 + strlen(c));
-                       if (p0 == NULL)
-                               continue;
+                       p0 = xmalloc(strlen(cf) + (c - buf) + 2 + strlen(c));
                        c[-1] = '\0';
                        sprintf(p0, "/%s%s", cf, buf);
 
@@ -552,7 +628,7 @@ static void parse_conf(const char *path, int flag)
                                ++p;                             /* so keep last character */
                        }
                        *p = '\0';
-                       sprintf(p0, "%s:%s", p0, c);
+                       sprintf(p0 + strlen(p0), ":%s", c);
                }
 #endif
 
@@ -639,9 +715,11 @@ static char *encodeString(const char *string)
        char ch;
 
        while ((ch = *string++)) {
-               // very simple check for what to encode
-               if (isalnum(ch)) *p++ = ch;
-               else p += sprintf(p, "&#%d;", (unsigned char) ch);
+               /* very simple check for what to encode */
+               if (isalnum(ch))
+                       *p++ = ch;
+               else
+                       p += sprintf(p, "&#%d;", (unsigned char) ch);
        }
        *p = '\0';
        return out;
@@ -662,18 +740,21 @@ static char *encodeString(const char *string)
  */
 static unsigned hex_to_bin(unsigned char c)
 {
-       unsigned v = c | 0x20; /* lowercase */
-       v = v - '0';
+       unsigned v;
+
+       v = c - '0';
        if (v <= 9)
                return v;
-       v = v + ('0' - 'a');
+       /* c | 0x20: letters to lower case, non-letters
+        * to (potentially different) non-letters */
+       v = (unsigned)(c | 0x20) - 'a';
        if (v <= 5)
                return v + 10;
        return ~0;
 }
 /* For testing:
-void t(char c) { printf("'%c' %u\n", c, hex_to_bin(c)); }
-int main() { t('0'); t('9'); t('A'); t('F'); t('a'); t('f');
+void t(char c) { printf("'%c'(%u) %u\n", c, c, hex_to_bin(c)); }
+int main() { t(0x10); t(0x20); t('0'); t('9'); t('A'); t('F'); t('a'); t('f');
 t('0'-1); t('9'+1); t('A'-1); t('F'+1); t('a'-1); t('f'+1); return 0; }
 */
 static char *decodeString(char *orig, int option_d)
@@ -717,19 +798,6 @@ static char *decodeString(char *orig, int option_d)
        return orig;
 }
 
-
-#if ENABLE_FEATURE_HTTPD_CGI
-/*
- * setenv helpers
- */
-static void setenv1(const char *name, const char *value)
-{
-       if (!value)
-               value = "";
-       setenv(name, value, 1);
-}
-#endif
-
 #if ENABLE_FEATURE_HTTPD_BASIC_AUTH
 /*
  * Decode a base64 data stream as per rfc1521.
@@ -797,6 +865,13 @@ static int openServer(void)
 static void log_and_exit(void) ATTRIBUTE_NORETURN;
 static void log_and_exit(void)
 {
+       /* Paranoia. IE said to be buggy. It may send some extra data
+        * or be confused by us just exiting without SHUT_WR. Oh well. */
+       shutdown(1, SHUT_WR);
+       ndelay_on(0);
+       while (read(0, iobuf, IOBUF_SIZE) > 0)
+               continue;
+
        if (verbose > 2)
                bb_error_msg("closed");
        _exit(xfunc_error_retval);
@@ -808,24 +883,29 @@ static void log_and_exit(void)
  * IE will puke big-time if the headers are not sent in one packet and the
  * second packet is delayed for any reason.
  * responseNum - the result code to send.
- * Return result of write().
  */
-static void send_headers(HttpResponseNum responseNum)
+static void send_headers(int responseNum)
 {
        static const char RFC1123FMT[] ALIGN1 = "%a, %d %b %Y %H:%M:%S GMT";
 
        const char *responseString = "";
        const char *infoString = NULL;
        const char *mime_type;
+#if ENABLE_FEATURE_HTTPD_ERROR_PAGES
+       const char *error_page = 0;
+#endif
        unsigned i;
        time_t timer = time(0);
        char tmp_str[80];
        int len;
 
-       for (i = 0; i < ARRAY_SIZE(httpResponseNames); i++) {
-               if (httpResponseNames[i].type == responseNum) {
-                       responseString = httpResponseNames[i].name;
-                       infoString = httpResponseNames[i].info;
+       for (i = 0; i < ARRAY_SIZE(http_response_type); i++) {
+               if (http_response_type[i] == responseNum) {
+                       responseString = http_response[i].name;
+                       infoString = http_response[i].info;
+#if ENABLE_FEATURE_HTTPD_ERROR_PAGES
+                       error_page = http_error_page[i];
+#endif
                        break;
                }
        }
@@ -857,10 +937,40 @@ static void send_headers(HttpResponseNum responseNum)
                                (g_query ? g_query : ""));
        }
 
-       if (ContentLength != -1) {    /* file */
+#if ENABLE_FEATURE_HTTPD_ERROR_PAGES
+       if (error_page && !access(error_page, R_OK)) {
+               strcat(iobuf, "\r\n");
+               len += 2;
+
+               if (DEBUG)
+                       fprintf(stderr, "headers: '%s'\n", iobuf);
+               full_write(1, iobuf, len);
+               if (DEBUG)
+                       fprintf(stderr, "writing error page: '%s'\n", error_page);
+               return send_file_and_exit(error_page, FALSE);
+       }
+#endif
+
+       if (file_size != -1) {    /* file */
                strftime(tmp_str, sizeof(tmp_str), RFC1123FMT, gmtime(&last_mod));
-               len += sprintf(iobuf + len, "Last-Modified: %s\r\n%s %"OFF_FMT"d\r\n",
-                       tmp_str, "Content-length:", ContentLength);
+#if ENABLE_FEATURE_HTTPD_RANGES
+               if (responseNum == HTTP_PARTIAL_CONTENT) {
+                       len += sprintf(iobuf + len, "Content-Range: bytes %"OFF_FMT"d-%"OFF_FMT"d/%"OFF_FMT"d\r\n",
+                                       range_start,
+                                       range_end,
+                                       file_size);
+                       file_size = range_end - range_start + 1;
+               }
+#endif
+               len += sprintf(iobuf + len,
+#if ENABLE_FEATURE_HTTPD_RANGES
+                       "Accept-Ranges: bytes\r\n"
+#endif
+                       "Last-Modified: %s\r\n%s %"OFF_FMT"d\r\n",
+                               tmp_str,
+                               "Content-length:",
+                               file_size
+               );
        }
        iobuf[len++] = '\r';
        iobuf[len++] = '\n';
@@ -880,8 +990,8 @@ static void send_headers(HttpResponseNum responseNum)
        }
 }
 
-static void send_headers_and_exit(HttpResponseNum responseNum) ATTRIBUTE_NORETURN;
-static void send_headers_and_exit(HttpResponseNum responseNum)
+static void send_headers_and_exit(int responseNum) ATTRIBUTE_NORETURN;
+static void send_headers_and_exit(int responseNum)
 {
        send_headers(responseNum);
        log_and_exit();
@@ -915,36 +1025,204 @@ static int get_line(void)
                        iobuf[count] = '\0';
                        return count;
                }
-               if (count < (MAX_MEMORY_BUF - 1))      /* check overflow */
+               if (count < (IOBUF_SIZE - 1))      /* check overflow */
                        count++;
        }
        return count;
 }
 
 #if ENABLE_FEATURE_HTTPD_CGI
+
+/* gcc 4.2.1 fares better with NOINLINE */
+static NOINLINE void cgi_io_loop_and_exit(int fromCgi_rd, int toCgi_wr, int post_len) ATTRIBUTE_NORETURN;
+static NOINLINE void cgi_io_loop_and_exit(int fromCgi_rd, int toCgi_wr, int post_len)
+{
+       enum { FROM_CGI = 1, TO_CGI = 2 }; /* indexes in pfd[] */
+       struct pollfd pfd[3];
+       int out_cnt; /* we buffer a bit of initial CGI output */
+       int count;
+
+       /* iobuf is used for CGI -> network data,
+        * hdr_buf is for network -> CGI data (POSTDATA) */
+
+       /* If CGI dies, we still want to correctly finish reading its output
+        * and send it to the peer. So please no SIGPIPEs! */
+       signal(SIGPIPE, SIG_IGN);
+
+       /* NB: breaking out of this loop jumps to log_and_exit() */
+       out_cnt = 0;
+       while (1) {
+               memset(pfd, 0, sizeof(pfd));
+
+               pfd[FROM_CGI].fd = fromCgi_rd;
+               pfd[FROM_CGI].events = POLLIN;
+
+               if (toCgi_wr) {
+                       pfd[TO_CGI].fd = toCgi_wr;
+                       if (hdr_cnt > 0) {
+                               pfd[TO_CGI].events = POLLOUT;
+                       } else if (post_len > 0) {
+                               pfd[0].events = POLLIN;
+                       } else {
+                               /* post_len <= 0 && hdr_cnt <= 0:
+                                * no more POST data to CGI,
+                                * let CGI see EOF on CGI's stdin */
+                               close(toCgi_wr);
+                               toCgi_wr = 0;
+                       }
+               }
+
+               /* Now wait on the set of sockets */
+               count = safe_poll(pfd, 3, -1);
+               if (count <= 0) {
+#if 0
+                       if (waitpid(pid, &status, WNOHANG) <= 0) {
+                               /* Weird. CGI didn't exit and no fd's
+                                * are ready, yet poll returned?! */
+                               continue;
+                       }
+                       if (DEBUG && WIFEXITED(status))
+                               bb_error_msg("CGI exited, status=%d", WEXITSTATUS(status));
+                       if (DEBUG && WIFSIGNALED(status))
+                               bb_error_msg("CGI killed, signal=%d", WTERMSIG(status));
+#endif
+                       break;
+               }
+
+               if (pfd[TO_CGI].revents) {
+                       /* hdr_cnt > 0 here due to the way pfd[TO_CGI].events set */
+                       /* Have data from peer and can write to CGI */
+                       count = safe_write(toCgi_wr, hdr_ptr, hdr_cnt);
+                       /* Doesn't happen, we dont use nonblocking IO here
+                        *if (count < 0 && errno == EAGAIN) {
+                        *      ...
+                        *} else */
+                       if (count > 0) {
+                               hdr_ptr += count;
+                               hdr_cnt -= count;
+                       } else {
+                               /* EOF/broken pipe to CGI, stop piping POST data */
+                               hdr_cnt = post_len = 0;
+                       }
+               }
+
+               if (pfd[0].revents) {
+                       /* post_len > 0 && hdr_cnt == 0 here */
+                       /* We expect data, prev data portion is eaten by CGI
+                        * and there *is* data to read from the peer
+                        * (POSTDATA) */
+                       //count = post_len > (int)sizeof(hdr_buf) ? (int)sizeof(hdr_buf) : post_len;
+                       //count = safe_read(0, hdr_buf, count);
+                       count = safe_read(0, hdr_buf, sizeof(hdr_buf));
+                       if (count > 0) {
+                               hdr_cnt = count;
+                               hdr_ptr = hdr_buf;
+                               post_len -= count;
+                       } else {
+                               /* no more POST data can be read */
+                               post_len = 0;
+                       }
+               }
+
+               if (pfd[FROM_CGI].revents) {
+                       /* There is something to read from CGI */
+                       char *rbuf = iobuf;
+
+                       /* Are we still buffering CGI output? */
+                       if (out_cnt >= 0) {
+                               /* HTTP_200[] has single "\r\n" at the end.
+                                * According to http://hoohoo.ncsa.uiuc.edu/cgi/out.html,
+                                * CGI scripts MUST send their own header terminated by
+                                * empty line, then data. That's why we have only one
+                                * <cr><lf> pair here. We will output "200 OK" line
+                                * if needed, but CGI still has to provide blank line
+                                * between header and body */
+
+                               /* Must use safe_read, not full_read, because
+                                * CGI may output a few first bytes and then wait
+                                * for POSTDATA without closing stdout.
+                                * With full_read we may wait here forever. */
+                               count = safe_read(fromCgi_rd, rbuf + out_cnt, PIPE_BUF - 8);
+                               if (count <= 0) {
+                                       /* eof (or error) and there was no "HTTP",
+                                        * so write it, then write received data */
+                                       if (out_cnt) {
+                                               full_write(1, HTTP_200, sizeof(HTTP_200)-1);
+                                               full_write(1, rbuf, out_cnt);
+                                       }
+                                       break; /* CGI stdout is closed, exiting */
+                               }
+                               out_cnt += count;
+                               count = 0;
+                               /* "Status" header format is: "Status: 302 Redirected\r\n" */
+                               if (out_cnt >= 8 && memcmp(rbuf, "Status: ", 8) == 0) {
+                                       /* send "HTTP/1.0 " */
+                                       if (full_write(1, HTTP_200, 9) != 9)
+                                               break;
+                                       rbuf += 8; /* skip "Status: " */
+                                       count = out_cnt - 8;
+                                       out_cnt = -1; /* buffering off */
+                               } else if (out_cnt >= 4) {
+                                       /* Did CGI add "HTTP"? */
+                                       if (memcmp(rbuf, HTTP_200, 4) != 0) {
+                                               /* there is no "HTTP", do it ourself */
+                                               if (full_write(1, HTTP_200, sizeof(HTTP_200)-1) != sizeof(HTTP_200)-1)
+                                                       break;
+                                       }
+                                       /* Commented out:
+                                       if (!strstr(rbuf, "ontent-")) {
+                                               full_write(s, "Content-type: text/plain\r\n\r\n", 28);
+                                       }
+                                        * Counter-example of valid CGI without Content-type:
+                                        * echo -en "HTTP/1.0 302 Found\r\n"
+                                        * echo -en "Location: http://www.busybox.net\r\n"
+                                        * echo -en "\r\n"
+                                        */
+                                       count = out_cnt;
+                                       out_cnt = -1; /* buffering off */
+                               }
+                       } else {
+                               count = safe_read(fromCgi_rd, rbuf, PIPE_BUF);
+                               if (count <= 0)
+                                       break;  /* eof (or error) */
+                       }
+                       if (full_write(1, rbuf, count) != count)
+                               break;
+                       if (DEBUG)
+                               fprintf(stderr, "cgi read %d bytes: '%.*s'\n", count, count, rbuf);
+               } /* if (pfd[FROM_CGI].revents) */
+       } /* while (1) */
+       log_and_exit();
+}
+
+static void setenv1(const char *name, const char *value)
+{
+       setenv(name, value ? value : "", 1);
+}
+
 /*
  * Spawn CGI script, forward CGI's stdin/out <=> network
  *
  * Environment variables are set up and the script is invoked with pipes
- * for stdin/stdout.  If a post is being done the script is fed the POST
+ * for stdin/stdout.  If a POST is being done the script is fed the POST
  * data in addition to setting the QUERY_STRING variable (for GETs or POSTs).
  *
  * Parameters:
  * const char *url              The requested URL (with leading /).
- * int bodyLen                  Length of the post body.
+ * int post_len                 Length of the POST body.
  * const char *cookie           For set HTTP_COOKIE.
  * const char *content_type     For set CONTENT_TYPE.
  */
 static void send_cgi_and_exit(
                const char *url,
                const char *request,
-               int bodyLen,
+               int post_len,
                const char *cookie,
                const char *content_type) ATTRIBUTE_NORETURN;
 static void send_cgi_and_exit(
                const char *url,
                const char *request,
-               int bodyLen,
+               int post_len,
                const char *cookie,
                const char *content_type)
 {
@@ -953,9 +1231,7 @@ static void send_cgi_and_exit(
        char *fullpath;
        char *script;
        char *purl;
-       int buf_count;
-       int status;
-       int pid = 0;
+       int pid;
 
        /*
         * We are mucking with environment _first_ and then vfork/exec,
@@ -1026,8 +1302,8 @@ static void send_cgi_and_exit(
                }
        }
        setenv1("HTTP_USER_AGENT", user_agent);
-       if (bodyLen)
-               putenv(xasprintf("CONTENT_LENGTH=%d", bodyLen));
+       if (post_len)
+               putenv(xasprintf("CONTENT_LENGTH=%d", post_len));
        if (cookie)
                setenv1("HTTP_COOKIE", cookie);
        if (content_type)
@@ -1103,175 +1379,25 @@ static void send_cgi_and_exit(
 
        /* Parent process */
 
-       /* First, restore variables possibly changed by child */
+       /* Restore variables possibly changed by child */
        xfunc_error_retval = 0;
 
-       /* Prepare for pumping data.
-        * iobuf is used for CGI -> network data,
-        * hdr_buf is for network -> CGI data (POSTDATA) */
-       buf_count = 0;
+       /* Pump data */
        close(fromCgi.wr);
        close(toCgi.rd);
-
-       /* If CGI dies, we still want to correctly finish reading its output
-        * and send it to the peer. So please no SIGPIPEs! */
-       signal(SIGPIPE, SIG_IGN);
-
-       /* This loop still looks messy. What is an exit criteria?
-        * "CGI's output closed"? Or "CGI has exited"?
-        * What to do if CGI has closed both input and output, but
-        * didn't exit? etc... */
-
-       /* NB: breaking out of this loop jumps to log_and_exit() */
-       while (1) {
-               fd_set readSet;
-               fd_set writeSet;
-               int nfound;
-               int count;
-
-               FD_ZERO(&readSet);
-               FD_ZERO(&writeSet);
-               FD_SET(fromCgi.rd, &readSet);
-               if (bodyLen > 0 || hdr_cnt > 0) {
-                       FD_SET(toCgi.wr, &writeSet);
-                       nfound = toCgi.wr > fromCgi.rd ? toCgi.wr : fromCgi.rd;
-                       if (hdr_cnt <= 0)
-                               FD_SET(0, &readSet);
-                       /* Now wait on the set of sockets! */
-                       nfound = select(nfound + 1, &readSet, &writeSet, NULL, NULL);
-               } else {
-                       if (!bodyLen) {
-                               close(toCgi.wr); /* no more POST data to CGI */
-                               bodyLen = -1;
-                       }
-                       nfound = select(fromCgi.rd + 1, &readSet, NULL, NULL, NULL);
-               }
-
-               if (nfound <= 0) {
-                       if (waitpid(pid, &status, WNOHANG) <= 0) {
-                               /* Weird. CGI didn't exit and no fd's
-                                * are ready, yet select returned?! */
-                               continue;
-                       }
-                       close(fromCgi.rd);
-                       if (DEBUG && WIFEXITED(status))
-                               bb_error_msg("CGI exited, status=%d", WEXITSTATUS(status));
-                       if (DEBUG && WIFSIGNALED(status))
-                               bb_error_msg("CGI killed, signal=%d", WTERMSIG(status));
-                       break;
-               }
-
-               if (hdr_cnt > 0 && FD_ISSET(toCgi.wr, &writeSet)) {
-                       /* Have data from peer and can write to CGI */
-                       count = safe_write(toCgi.wr, hdr_ptr, hdr_cnt);
-                       /* Doesn't happen, we dont use nonblocking IO here
-                        *if (count < 0 && errno == EAGAIN) {
-                        *      ...
-                        *} else */
-                       if (count > 0) {
-                               hdr_ptr += count;
-                               hdr_cnt -= count;
-                       } else {
-                               hdr_cnt = bodyLen = 0; /* EOF/broken pipe to CGI */
-                       }
-               } else if (bodyLen > 0 && hdr_cnt == 0
-                && FD_ISSET(0, &readSet)
-               ) {
-                       /* We expect data, prev data portion is eaten by CGI
-                        * and there *is* data to read from the peer
-                        * (POSTDATA?) */
-                       count = bodyLen > (int)sizeof(hdr_buf) ? (int)sizeof(hdr_buf) : bodyLen;
-                       count = safe_read(0, hdr_buf, count);
-                       if (count > 0) {
-                               hdr_cnt = count;
-                               hdr_ptr = hdr_buf;
-                               bodyLen -= count;
-                       } else {
-                               bodyLen = 0; /* closed */
-                       }
-               }
-
-#define PIPESIZE PIPE_BUF
-#if PIPESIZE >= MAX_MEMORY_BUF
-# error "PIPESIZE >= MAX_MEMORY_BUF"
-#endif
-               if (FD_ISSET(fromCgi.rd, &readSet)) {
-                       /* There is something to read from CGI */
-                       char *rbuf = iobuf;
-
-                       /* Are we still buffering CGI output? */
-                       if (buf_count >= 0) {
-                               /* HTTP_200[] has single "\r\n" at the end.
-                                * According to http://hoohoo.ncsa.uiuc.edu/cgi/out.html,
-                                * CGI scripts MUST send their own header terminated by
-                                * empty line, then data. That's why we have only one
-                                * <cr><lf> pair here. We will output "200 OK" line
-                                * if needed, but CGI still has to provide blank line
-                                * between header and body */
-
-                               /* Must use safe_read, not full_read, because
-                                * CGI may output a few first bytes and then wait
-                                * for POSTDATA without closing stdout.
-                                * With full_read we may wait here forever. */
-                               count = safe_read(fromCgi.rd, rbuf + buf_count, PIPESIZE - 8);
-                               if (count <= 0) {
-                                       /* eof (or error) and there was no "HTTP",
-                                        * so write it, then write received data */
-                                       if (buf_count) {
-                                               full_write(1, HTTP_200, sizeof(HTTP_200)-1);
-                                               full_write(1, rbuf, buf_count);
-                                       }
-                                       break; /* CGI stdout is closed, exiting */
-                               }
-                               buf_count += count;
-                               count = 0;
-                               /* "Status" header format is: "Status: 302 Redirected\r\n" */
-                               if (buf_count >= 8 && memcmp(rbuf, "Status: ", 8) == 0) {
-                                       /* send "HTTP/1.0 " */
-                                       if (full_write(1, HTTP_200, 9) != 9)
-                                               break;
-                                       rbuf += 8; /* skip "Status: " */
-                                       count = buf_count - 8;
-                                       buf_count = -1; /* buffering off */
-                               } else if (buf_count >= 4) {
-                                       /* Did CGI add "HTTP"? */
-                                       if (memcmp(rbuf, HTTP_200, 4) != 0) {
-                                               /* there is no "HTTP", do it ourself */
-                                               if (full_write(1, HTTP_200, sizeof(HTTP_200)-1) != sizeof(HTTP_200)-1)
-                                                       break;
-                                       }
-                                       /* Commented out:
-                                       if (!strstr(rbuf, "ontent-")) {
-                                               full_write(s, "Content-type: text/plain\r\n\r\n", 28);
-                                       }
-                                        * Counter-example of valid CGI without Content-type:
-                                        * echo -en "HTTP/1.0 302 Found\r\n"
-                                        * echo -en "Location: http://www.busybox.net\r\n"
-                                        * echo -en "\r\n"
-                                        */
-                                       count = buf_count;
-                                       buf_count = -1; /* buffering off */
-                               }
-                       } else {
-                               count = safe_read(fromCgi.rd, rbuf, PIPESIZE);
-                               if (count <= 0)
-                                       break;  /* eof (or error) */
-                       }
-                       if (full_write(1, rbuf, count) != count)
-                               break;
-                       if (DEBUG)
-                               fprintf(stderr, "cgi read %d bytes: '%.*s'\n", count, count, rbuf);
-               } /* if (FD_ISSET(fromCgi.rd)) */
-       } /* while (1) */
-       log_and_exit();
+       cgi_io_loop_and_exit(fromCgi.rd, toCgi.wr, post_len);
 }
+
 #endif          /* FEATURE_HTTPD_CGI */
 
 /*
  * Send a file response to a HTTP request, and exit
+ * 
+ * Parameters:
+ * const char *url    The requested URL (with leading /).
+ * headers            Don't send headers before if FALSE.
  */
-static void send_file_and_exit(const char *url) ATTRIBUTE_NORETURN;
-static void send_file_and_exit(const char *url)
+static void send_file_and_exit(const char *url, int headers)
 {
        static const char *const suffixTable[] = {
        /* Warning: shorter equivalent suffix in one line must be first */
@@ -1301,7 +1427,7 @@ static void send_file_and_exit(const char *url)
        const char *try_suffix;
        ssize_t count;
 #if ENABLE_FEATURE_HTTPD_USE_SENDFILE
-       off_t offset = 0;
+       off_t offset;
 #endif
 
        suffix = strrchr(url, '.');
@@ -1340,34 +1466,64 @@ static void send_file_and_exit(const char *url)
        if (f < 0) {
                if (DEBUG)
                        bb_perror_msg("cannot open '%s'", url);
-               send_headers_and_exit(HTTP_NOT_FOUND);
+               if (headers)
+                       send_headers_and_exit(HTTP_NOT_FOUND);
+       }
+#if ENABLE_FEATURE_HTTPD_RANGES
+       if (!headers)
+               range_start = 0; /* err pages and ranges don't mix */
+       range_len = MAXINT(off_t);
+       if (range_start) {
+               if (!range_end) {
+                       range_end = file_size - 1;
+               }
+               if (range_end < range_start
+                || lseek(f, range_start, SEEK_SET) != range_start
+               ) {
+                       lseek(f, 0, SEEK_SET);
+                       range_start = 0;
+               } else {
+                       range_len = range_end - range_start + 1;
+                       send_headers(HTTP_PARTIAL_CONTENT);
+                       headers = 0;
+               }
        }
+#endif
 
-       send_headers(HTTP_OK);
+       if (headers)
+               send_headers(HTTP_OK);
 
        /* If you want to know about EPIPE below
         * (happens if you abort downloads from local httpd): */
        signal(SIGPIPE, SIG_IGN);
 
 #if ENABLE_FEATURE_HTTPD_USE_SENDFILE
+       offset = range_start;
        do {
-               /* byte count (3rd arg) is rounded down to 64k */
-               count = sendfile(1, f, &offset, MAXINT(ssize_t) - 0xffff);
+               /* sz is rounded down to 64k */
+               ssize_t sz = MAXINT(ssize_t) - 0xffff;
+               USE_FEATURE_HTTPD_RANGES(if (sz > range_len) sz = range_len;)
+               count = sendfile(1, f, &offset, sz);
                if (count < 0) {
-                       if (offset == 0)
+                       if (offset == range_start)
                                goto fallback;
                        goto fin;
                }
-       } while (count > 0);
+               USE_FEATURE_HTTPD_RANGES(range_len -= sz;)
+       } while (count > 0 && range_len);
        log_and_exit();
 
  fallback:
 #endif
-       while ((count = safe_read(f, iobuf, MAX_MEMORY_BUF)) > 0) {
-               ssize_t n = count;
-               count = full_write(1, iobuf, count);
+       while ((count = safe_read(f, iobuf, IOBUF_SIZE)) > 0) {
+               ssize_t n;
+               USE_FEATURE_HTTPD_RANGES(if (count > range_len) count = range_len;)
+               n = full_write(1, iobuf, count);
                if (count != n)
                        break;
+               USE_FEATURE_HTTPD_RANGES(range_len -= count;)
+               if (!range_len)
+                       break;
        }
 #if ENABLE_FEATURE_HTTPD_USE_SENDFILE
  fin:
@@ -1455,12 +1611,13 @@ static int checkPerm(const char *path, const char *request)
                                char *pp;
 
                                if (strncmp(p, request, u - request) != 0) {
-                                       /* user uncompared */
+                                       /* user doesn't match */
                                        continue;
                                }
                                pp = strchr(p, ':');
-                               if (pp && pp[1] == '$' && pp[2] == '1' &&
-                                               pp[3] == '$' && pp[4]) {
+                               if (pp && pp[1] == '$' && pp[2] == '1'
+                                && pp[3] == '$' && pp[4]
+                               ) {
                                        pp++;
                                        cipher = pw_encrypt(u+1, pp);
                                        if (strcmp(cipher, pp) == 0)
@@ -1474,7 +1631,7 @@ static int checkPerm(const char *path, const char *request)
  set_remoteuser_var:
                                remoteuser = strdup(request);
                                if (remoteuser)
-                                       remoteuser[(u - request)] = '\0';
+                                       remoteuser[u - request] = '\0';
                                return 1;   /* Ok */
                        }
                        /* unauthorized */
@@ -1521,12 +1678,19 @@ static void handle_incoming_and_exit(const len_and_sockaddr *fromAddr)
 
        /* Allocation of iobuf is postponed until now
         * (IOW, server process doesn't need to waste 8k) */
-       iobuf = xmalloc(MAX_MEMORY_BUF);
+       iobuf = xmalloc(IOBUF_SIZE);
 
        rmt_ip = 0;
        if (fromAddr->sa.sa_family == AF_INET) {
                rmt_ip = ntohl(fromAddr->sin.sin_addr.s_addr);
        }
+#if ENABLE_FEATURE_IPV6
+       if (fromAddr->sa.sa_family == AF_INET6
+        && fromAddr->sin6.sin6_addr.s6_addr32[0] == 0
+        && fromAddr->sin6.sin6_addr.s6_addr32[1] == 0
+        && ntohl(fromAddr->sin6.sin6_addr.s6_addr32[2]) == 0xffff)
+               rmt_ip = ntohl(fromAddr->sin6.sin6_addr.s6_addr32[3]);
+#endif
        if (ENABLE_FEATURE_HTTPD_CGI || DEBUG || verbose) {
                rmt_ip_str = xmalloc_sockaddr2dotted(&fromAddr->sa);
        }
@@ -1706,6 +1870,23 @@ static void handle_incoming_and_exit(const len_and_sockaddr *fromAddr)
                                credentials = checkPerm(urlcopy, tptr);
                        }
 #endif          /* FEATURE_HTTPD_BASIC_AUTH */
+#if ENABLE_FEATURE_HTTPD_RANGES
+                       if (STRNCASECMP(iobuf, "Range:") == 0) {
+                               // We know only bytes=NNN-[MMM]
+                               char *s = skip_whitespace(iobuf + sizeof("Range:")-1);
+                               if (strncmp(s, "bytes=", 6) == 0) {
+                                       s += sizeof("bytes=")-1;
+                                       range_start = BB_STRTOOFF(s, &s, 10);
+                                       if (s[0] != '-' || range_start < 0) {
+                                               range_start = 0;
+                                       } else if (s[1]) {
+                                               range_end = BB_STRTOOFF(s+1, NULL, 10);
+                                               if (errno || range_end < range_start)
+                                                       range_start = 0;
+                                       }
+                               }
+                       }
+#endif
                } /* while extra header reading */
        }
 
@@ -1758,8 +1939,7 @@ static void handle_incoming_and_exit(const len_and_sockaddr *fromAddr)
        if (urlp[-1] == '/')
                strcpy(urlp, "index.html");
        if (stat(tptr, &sb) == 0) {
-               /* It's a dir URL and there is index.html */
-               ContentLength = sb.st_size;
+               file_size = sb.st_size;
                last_mod = sb.st_mtime;
        }
 #if ENABLE_FEATURE_HTTPD_CGI
@@ -1778,36 +1958,7 @@ static void handle_incoming_and_exit(const len_and_sockaddr *fromAddr)
         * }
         */
 
-       send_file_and_exit(tptr);
-
-#if 0 /* Is this needed? Why? */
-       if (DEBUG)
-               fprintf(stderr, "closing socket\n");
-#if ENABLE_FEATURE_HTTPD_CGI
-       free(cookie);
-       free(content_type);
-       free(referer);
-       referer = NULL;
-#if ENABLE_FEATURE_HTTPD_BASIC_AUTH
-       free(remoteuser);
-       remoteuser = NULL;
-#endif
-#endif
-       /* Properly wait for remote to closed */
-       int retval;
-       shutdown(1, SHUT_WR);
-       do {
-               fd_set s_fd;
-               struct timeval tv;
-               FD_ZERO(&s_fd);
-               FD_SET(0, &s_fd);
-               tv.tv_sec = 2;
-               tv.tv_usec = 0;
-               retval = select(1, &s_fd, NULL, NULL, &tv);
-       } while (retval > 0 && read(0, iobuf, sizeof(iobuf) > 0));
-       shutdown(0, SHUT_RD);
-       log_and_exit();
-#endif
+       send_file_and_exit(tptr, TRUE);
 }
 
 /*
@@ -1896,7 +2047,7 @@ static void mini_httpd_nommu(int server_socket, int argc, char **argv)
                        /* Run a copy of ourself in inetd mode */
                        re_exec(argv_copy);
                }
-               /* parent, or fork failed */
+               /* parent, or vfork failed */
                close(n);
        } /* while (1) */
        /* never reached */
@@ -2043,7 +2194,13 @@ int httpd_main(int argc, char **argv)
 #endif
        }
 
-#if ENABLE_FEATURE_HTTPD_CGI
+#if 0 /*was #if ENABLE_FEATURE_HTTPD_CGI*/
+       /* User can do it himself: 'env - PATH="$PATH" httpd'
+        * We don't do it because we don't want to screw users
+        * which want to do
+        * 'env - VAR1=val1 VAR2=val2 https'
+        * and have VAR1 and VAR2 values visible in their CGIs.
+        * Besides, it is also smaller. */
        {
                char *p = getenv("PATH");
                /* env strings themself are not freed, no need to strdup(p): */