- don't automatically select run-parts but point out that this is a system-utility...
[oweals/busybox.git] / networking / httpd.c
index 3b948b98d63dc88bfc80c6051060958ac4bcff58..72b03de792b0671fd5619485caa0ae11fad18541 100644 (file)
@@ -24,6 +24,9 @@
  * server changes directory to the location of the script and executes it
  * after setting QUERY_STRING and other environment variables.
  *
+ * Doc:
+ * "CGI Environment Variables": http://hoohoo.ncsa.uiuc.edu/cgi/env.html
+ *
  * The server can also be invoked as a url arg decoder and html text encoder
  * as follows:
  *  foo=`httpd -d $foo`           # decode "Hello%20World" as "Hello World"
  *
 */
 
-
 #include "busybox.h"
 
+/* amount of buffering in a pipe */
+#ifndef PIPE_BUF
+# define PIPE_BUF 4096
+#endif
 
 static const char httpdVersion[] = "busybox httpd/1.35 6-Oct-2004";
 static const char default_path_httpd_conf[] = "/etc";
@@ -105,10 +111,7 @@ static const char home[] = "./";
 //       is checked rigorously
 
 //#define DEBUG 1
-
-#ifndef DEBUG
-# define DEBUG 0
-#endif
+#define DEBUG 0
 
 #define MAX_MEMORY_BUFF 8192    /* IO buffer */
 
@@ -139,7 +142,7 @@ typedef struct {
 
        unsigned int rmt_ip;
 #if ENABLE_FEATURE_HTTPD_CGI || DEBUG
-       char rmt_ip_str[16];     /* for set env REMOTE_ADDR */
+       char *rmt_ip_str;        /* for set env REMOTE_ADDR */
 #endif
        unsigned port;           /* server initial port and for
                                                      set env REMOTE_PORT */
@@ -335,7 +338,9 @@ static int scan_ip_mask(const char *ipm, unsigned int *ip, unsigned int *mask)
        return 0;
 }
 
-#if ENABLE_FEATURE_HTTPD_BASIC_AUTH || ENABLE_FEATURE_HTTPD_CONFIG_WITH_MIME_TYPES
+#if ENABLE_FEATURE_HTTPD_BASIC_AUTH \
+ || ENABLE_FEATURE_HTTPD_CONFIG_WITH_MIME_TYPES \
+ || ENABLE_FEATURE_HTTPD_CONFIG_WITH_SCRIPT_INTERPR
 static void free_config_lines(Htaccess **pprev)
 {
        Htaccess *prev = *pprev;
@@ -384,8 +389,11 @@ static void parse_conf(const char *path, int flag)
 {
        FILE *f;
 #if ENABLE_FEATURE_HTTPD_BASIC_AUTH
-       Htaccess *prev, *cur;
-#elif ENABLE_FEATURE_HTTPD_CONFIG_WITH_MIME_TYPES
+       Htaccess *prev;
+#endif
+#if ENABLE_FEATURE_HTTPD_BASIC_AUTH \
+ || ENABLE_FEATURE_HTTPD_CONFIG_WITH_MIME_TYPES \
+ || ENABLE_FEATURE_HTTPD_CONFIG_WITH_SCRIPT_INTERPR
        Htaccess *cur;
 #endif
 
@@ -407,7 +415,9 @@ static void parse_conf(const char *path, int flag)
 
        config->flg_deny_all = 0;
 
-#if ENABLE_FEATURE_HTTPD_BASIC_AUTH || ENABLE_FEATURE_HTTPD_CONFIG_WITH_MIME_TYPES || ENABLE_FEATURE_HTTPD_CONFIG_WITH_SCRIPT_INTERPR
+#if ENABLE_FEATURE_HTTPD_BASIC_AUTH \
+ || ENABLE_FEATURE_HTTPD_CONFIG_WITH_MIME_TYPES \
+ || ENABLE_FEATURE_HTTPD_CONFIG_WITH_SCRIPT_INTERPR
        /* retain previous auth and mime config only for subdir parse */
        if (flag != SUBDIR_PARSE) {
 #if ENABLE_FEATURE_HTTPD_BASIC_AUTH
@@ -489,7 +499,7 @@ static void parse_conf(const char *path, int flag)
                         continue;
                if (*p0 == 'A' || *p0 == 'D') {
                        /* storing current config IP line */
-                       pip = calloc(1, sizeof(Htaccess_IP));
+                       pip = xzalloc(sizeof(Htaccess_IP));
                        if (pip) {
                                if (scan_ip_mask(c, &(pip->ip), &(pip->mask))) {
                                        /* syntax IP{/mask} error detected, protect all */
@@ -556,9 +566,11 @@ static void parse_conf(const char *path, int flag)
                }
 #endif
 
-#if ENABLE_FEATURE_HTTPD_BASIC_AUTH || ENABLE_FEATURE_HTTPD_CONFIG_WITH_MIME_TYPES || ENABLE_FEATURE_HTTPD_CONFIG_WITH_SCRIPT_INTERPR
+#if ENABLE_FEATURE_HTTPD_BASIC_AUTH \
+ || ENABLE_FEATURE_HTTPD_CONFIG_WITH_MIME_TYPES \
+ || ENABLE_FEATURE_HTTPD_CONFIG_WITH_SCRIPT_INTERPR
                /* storing current config line */
-               cur = calloc(1, sizeof(Htaccess) + strlen(p0));
+               cur = xzalloc(sizeof(Htaccess) + strlen(p0));
                if (cur) {
                        cf = strcpy(cur->before_colon, p0);
                        c = strchr(cf, ':');
@@ -641,17 +653,16 @@ static char *encodeString(const char *string)
        /* take the simple route and encode everything */
        /* could possibly scan once to get length.     */
        int len = strlen(string);
-       char *out = malloc(len * 6 + 1);
+       char *out = xmalloc(len * 6 + 1);
        char *p = out;
        char ch;
 
-       if (!out) return "";
        while ((ch = *string++)) {
                // very simple check for what to encode
                if (isalnum(ch)) *p++ = ch;
                else p += sprintf(p, "&#%d;", (unsigned char) ch);
        }
-       *p = 0;
+       *p = '\0';
        return out;
 }
 #endif          /* FEATURE_HTTPD_ENCODE_URL_STR */
@@ -668,39 +679,47 @@ static char *encodeString(const char *string)
  *
  * $Parameters:
  *      (char *) string . . . The first string to decode.
- *      (int)    flag   . . . 1 if require decode '+' as ' ' for CGI
+ *      (int)    option_d . . 1 if called for httpd -d
  *
  * $Return: (char *)  . . . . A pointer to the decoded string (same as input).
  *
  * $Errors: None
  *
  ****************************************************************************/
-static char *decodeString(char *orig, int flag_plus_to_space)
+static char *decodeString(char *orig, int option_d)
 {
        /* note that decoded string is always shorter than original */
        char *string = orig;
        char *ptr = string;
+       char c;
 
-       while (*ptr) {
-               if (*ptr == '+' && flag_plus_to_space) { *string++ = ' '; ptr++; }
-               else if (*ptr != '%') *string++ = *ptr++;
-               else {
-                       unsigned int value1, value2;
-
-                       ptr++;
-                       if (sscanf(ptr, "%1X", &value1) != 1 ||
-                                                   sscanf(ptr+1, "%1X", &value2) != 1) {
-                               if (!flag_plus_to_space)
-                                       return NULL;
-                               *string++ = '%';
-                       } else {
-                               value1 = value1 * 16 + value2;
-                               if (value1 == '/' || value1 == 0)
-                                       return orig+1;
-                               *string++ = value1;
-                               ptr += 2;
-                       }
+       while ((c = *ptr++) != '\0') {
+               unsigned value1, value2;
+
+               if (option_d && c == '+') {
+                       *string++ = ' ';
+                       continue;
                }
+               if (c != '%') {
+                       *string++ = c;
+                       continue;
+               }
+               if (sscanf(ptr, "%1X", &value1) != 1
+                || sscanf(ptr+1, "%1X", &value2) != 1
+               ) {
+                       if (!option_d)
+                               return NULL;
+                       *string++ = '%';
+                       continue;
+               }
+               value1 = value1 * 16 + value2;
+               if (!option_d && (value1 == '/' || value1 == '\0')) {
+                       /* caller takes it as indication of invalid
+                        * (dangerous wrt exploits) chars */
+                       return orig + 1;
+               }
+               *string++ = value1;
+               ptr += 2;
        }
        *string = '\0';
        return orig;
@@ -797,27 +816,11 @@ static void decodeBase64(char *Data)
  ****************************************************************************/
 static int openServer(void)
 {
-       struct sockaddr_in lsocket;
        int fd;
-       int on = 1;
 
        /* create the socket right now */
-       /* inet_addr() returns a value that is already in network order */
-       memset(&lsocket, 0, sizeof(lsocket));
-       lsocket.sin_family = AF_INET;
-       lsocket.sin_addr.s_addr = INADDR_ANY;
-       lsocket.sin_port = htons(config->port);
-       fd = xsocket(AF_INET, SOCK_STREAM, 0);
-       /* tell the OS it's OK to reuse a previous address even though */
-       /* it may still be in a close down state.  Allows bind to succeed. */
-#ifdef SO_REUSEPORT
-       setsockopt(fd, SOL_SOCKET, SO_REUSEPORT, (void *)&on, sizeof(on));
-#else
-       setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, (void *)&on, sizeof(on));
-#endif
-       xbind(fd, (struct sockaddr *)&lsocket, sizeof(lsocket));
+       fd = create_and_bind_stream_or_die(NULL, config->port);
        xlisten(fd, 9);
-       signal(SIGCHLD, SIG_IGN);   /* prevent zombie (defunct) processes */
        return fd;
 }
 
@@ -842,7 +845,7 @@ static int sendHeaders(HttpResponseNum responseNum)
        const char *responseString = "";
        const char *infoString = 0;
        const char *mime_type;
-       unsigned int i;
+       unsigned i;
        time_t timer = time(0);
        char timeStr[80];
        int len;
@@ -864,14 +867,15 @@ static int sendHeaders(HttpResponseNum responseNum)
        /* emit the current date */
        strftime(timeStr, sizeof(timeStr), RFC1123FMT, gmtime(&timer));
        len = sprintf(buf,
-               "HTTP/1.0 %d %s\r\nContent-type: %s\r\n"
-               "Date: %s\r\nConnection: close\r\n",
+                       "HTTP/1.0 %d %s\r\nContent-type: %s\r\n"
+                       "Date: %s\r\nConnection: close\r\n",
                        responseNum, responseString, mime_type, timeStr);
 
 #if ENABLE_FEATURE_HTTPD_BASIC_AUTH
        if (responseNum == HTTP_UNAUTHORIZED) {
-               len += sprintf(buf+len, "WWW-Authenticate: Basic realm=\"%s\"\r\n",
-                                                                   config->realm);
+               len += sprintf(buf+len,
+                               "WWW-Authenticate: Basic realm=\"%s\"\r\n",
+                               config->realm);
        }
 #endif
        if (responseNum == HTTP_MOVED_TEMPORARILY) {
@@ -883,8 +887,8 @@ static int sendHeaders(HttpResponseNum responseNum)
 
        if (config->ContentLength != -1) {    /* file */
                strftime(timeStr, sizeof(timeStr), RFC1123FMT, gmtime(&config->last_mod));
-               len += sprintf(buf+len, "Last-Modified: %s\r\n%s %"OFF_FMT"\r\n",
-                               timeStr, "Content-length:", (off_t) config->ContentLength);
+               len += sprintf(buf+len, "Last-Modified: %s\r\n%s %"OFF_FMT"d\r\n",
+                       timeStr, "Content-length:", config->ContentLength);
        }
        strcat(buf, "\r\n");
        len += 2;
@@ -897,7 +901,9 @@ static int sendHeaders(HttpResponseNum responseNum)
        }
        if (DEBUG)
                fprintf(stderr, "headers: '%s'\n", buf);
-       return full_write(config->accepted_socket, buf, len);
+       i = config->accepted_socket;
+       if (i == 0) i++; /* write to fd# 1 in inetd mode */
+       return full_write(i, buf, len);
 }
 
 /****************************************************************************
@@ -945,7 +951,6 @@ static int getLine(void)
  *      (int bodyLen)  . . . . . . . . Length of the post body.
  *      (const char *cookie) . . . . . For set HTTP_COOKIE.
  *      (const char *content_type) . . For set CONTENT_TYPE.
-
  *
  * $Return: (char *)  . . . . A pointer to the decoded string (same as input).
  *
@@ -963,47 +968,61 @@ static int sendCgi(const char *url,
        int pid = 0;
        int inFd;
        int outFd;
-       int firstLine = 1;
+       int buf_count;
        int status;
-       size_t post_readed_size, post_readed_idx;
+       size_t post_read_size, post_read_idx;
 
        if (pipe(fromCgi) != 0)
                return 0;
        if (pipe(toCgi) != 0)
                return 0;
 
+/*
+ * Note: We can use vfork() here in the no-mmu case, although
+ * the child modifies the parent's variables, due to:
+ * 1) The parent does not use the child-modified variables.
+ * 2) The allocated memory (in the child) is freed when the process
+ *    exits. This happens instantly after the child finishes,
+ *    since httpd is run from inetd (and it can't run standalone
+ *    in uClinux).
+ */
+#ifdef BB_NOMMU
+       pid = vfork();
+#else
        pid = fork();
+#endif
        if (pid < 0)
                return 0;
-       
+
        if (!pid) {
                /* child process */
                char *script;
-               char *purl = strdup(url);
+               char *purl;
                char realpath_buff[MAXPATHLEN];
 
-               if (purl == NULL)
-                       _exit(242);
+               if (config->accepted_socket > 1)
+                       close(config->accepted_socket);
+               if (config->server_socket > 1)
+                       close(config->server_socket);
 
-               inFd = toCgi[0];
-               outFd = fromCgi[1];
-
-               dup2(inFd, 0);  // replace stdin with the pipe
-               dup2(outFd, 1);  // replace stdout with the pipe
+               dup2(toCgi[0], 0);  // replace stdin with the pipe
+               dup2(fromCgi[1], 1);  // replace stdout with the pipe
+               /* Huh? User seeing stderr can be a security problem...
+                * and if CGI really wants that, it can always dup2(1,2)...
                if (!DEBUG)
-                       dup2(outFd, 2);  // replace stderr with the pipe
-
+                       dup2(fromCgi[1], 2);  // replace stderr with the pipe
+               */
+               /* I think we cannot inadvertently close 0, 1 here... */
                close(toCgi[0]);
                close(toCgi[1]);
                close(fromCgi[0]);
                close(fromCgi[1]);
 
-               close(config->accepted_socket);
-               close(config->server_socket);
-
                /*
                 * Find PATH_INFO.
                 */
+               xfunc_error_retval = 242;
+               purl = xstrdup(url);
                script = purl;
                while ((script = strchr(script + 1, '/')) != NULL) {
                        /* have script.cgi/PATH_INFO or dirs/script.cgi[/PATH_INFO] */
@@ -1036,11 +1055,30 @@ static int sendCgi(const char *url,
                setenv1("SCRIPT_FILENAME", realpath_buff);
                /* set SCRIPT_NAME as full path: /cgi-bin/dirs/script.cgi */
                setenv1("SCRIPT_NAME", purl);
+               /* http://hoohoo.ncsa.uiuc.edu/cgi/env.html:
+                * QUERY_STRING: The information which follows the ? in the URL
+                * which referenced this script. This is the query information.
+                * It should not be decoded in any fashion. This variable
+                * should always be set when there is query information,
+                * regardless of command line decoding. */
+               /* (Older versions of bbox seem to do some decoding) */
                setenv1("QUERY_STRING", config->query);
                setenv1("SERVER_SOFTWARE", httpdVersion);
-               putenv("SERVER_PROTOCOL=HTTP/1.0");
-               putenv("GATEWAY_INTERFACE=CGI/1.1");
-               setenv1("REMOTE_ADDR", config->rmt_ip_str);
+               putenv((char*)"SERVER_PROTOCOL=HTTP/1.0");
+               putenv((char*)"GATEWAY_INTERFACE=CGI/1.1");
+               /* Having _separate_ variables for IP and port defeats
+                * the purpose of having socket abstraction. Which "port"
+                * are you using on Unix domain socket?
+                * IOW - REMOTE_PEER="1.2.3.4:56" makes much more sense.
+                * Oh well... */
+               {
+                       char *p = config->rmt_ip_str ? : (char*)"";
+                       char *cp = strrchr(p, ':');
+                       if (ENABLE_FEATURE_IPV6 && cp && strchr(cp, ']'))
+                               cp = NULL;
+                       if (cp) *cp = '\0'; /* delete :PORT */
+                       setenv1("REMOTE_ADDR", p);
+               }
 #if ENABLE_FEATURE_HTTPD_SET_REMOTE_PORT_TO_ENV
                setenv_long("REMOTE_PORT", config->port);
 #endif
@@ -1053,7 +1091,7 @@ static int sendCgi(const char *url,
 #if ENABLE_FEATURE_HTTPD_BASIC_AUTH
                if (config->remoteuser) {
                        setenv1("REMOTE_USER", config->remoteuser);
-                       putenv("AUTH_TYPE=Basic");
+                       putenv((char*)"AUTH_TYPE=Basic");
                }
 #endif
                if (config->referer)
@@ -1067,7 +1105,7 @@ static int sendCgi(const char *url,
                        goto error_execing_cgi;
                *script = '\0';
                if (chdir(realpath_buff) == 0) {
-                       // now run the program.  If it fails,
+                       // Now run the program.  If it fails,
                        // use _exit() so no destructors
                        // get called and make a mess.
 #if ENABLE_FEATURE_HTTPD_CONFIG_WITH_SCRIPT_INTERPR
@@ -1101,8 +1139,9 @@ static int sendCgi(const char *url,
 
        /* parent process */
 
-       post_readed_size = 0;
-       post_readed_idx = 0;
+       buf_count = 0;
+       post_read_size = 0;
+       post_read_idx = 0; /* for gcc */
        inFd = fromCgi[0];
        outFd = toCgi[1];
        close(fromCgi[1]);
@@ -1119,94 +1158,123 @@ static int sendCgi(const char *url,
                FD_ZERO(&readSet);
                FD_ZERO(&writeSet);
                FD_SET(inFd, &readSet);
-               if (bodyLen > 0 || post_readed_size > 0) {
+               if (bodyLen > 0 || post_read_size > 0) {
                        FD_SET(outFd, &writeSet);
                        nfound = outFd > inFd ? outFd : inFd;
-                       if (post_readed_size == 0) {
+                       if (post_read_size == 0) {
                                FD_SET(config->accepted_socket, &readSet);
                                if (nfound < config->accepted_socket)
                                        nfound = config->accepted_socket;
                        }
                        /* Now wait on the set of sockets! */
-                       nfound = select(nfound + 1, &readSet, &writeSet, 0, NULL);
+                       nfound = select(nfound + 1, &readSet, &writeSet, NULL, NULL);
                } else {
                        if (!bodyLen) {
-                               close(outFd);
+                               close(outFd); /* no more POST data to CGI */
                                bodyLen = -1;
                        }
-                       nfound = select(inFd + 1, &readSet, 0, 0, NULL);
+                       nfound = select(inFd + 1, &readSet, NULL, NULL, NULL);
                }
 
                if (nfound <= 0) {
-                       if (waitpid(pid, &status, WNOHANG) > 0) {
-                               close(inFd);
-                               if (DEBUG && WIFEXITED(status))
-                                       bb_error_msg("piped has exited with status=%d", WEXITSTATUS(status));
-                               if (DEBUG && WIFSIGNALED(status))
-                                       bb_error_msg("piped has exited with signal=%d", WTERMSIG(status));
-                               break;
+                       if (waitpid(pid, &status, WNOHANG) <= 0) {
+                               /* Weird. CGI didn't exit and no fd's
+                                * are ready, yet select returned?! */
+                               continue;
                        }
-               } else if (post_readed_size > 0 && FD_ISSET(outFd, &writeSet)) {
-                       count = full_write(outFd, wbuf + post_readed_idx, post_readed_size);
+                       close(inFd);
+                       if (DEBUG && WIFEXITED(status))
+                               bb_error_msg("piped has exited with status=%d", WEXITSTATUS(status));
+                       if (DEBUG && WIFSIGNALED(status))
+                               bb_error_msg("piped has exited with signal=%d", WTERMSIG(status));
+                       break;
+               }
+
+               if (post_read_size > 0 && FD_ISSET(outFd, &writeSet)) {
+                       /* Have data from peer and can write to CGI */
+               // huh? why full_write? what if we will block?
+               // (imagine that CGI does not read its stdin...)
+                       count = full_write(outFd, wbuf + post_read_idx, post_read_size);
                        if (count > 0) {
-                               post_readed_size -= count;
-                               post_readed_idx += count;
-                               if (post_readed_size == 0)
-                                       post_readed_idx = 0;
+                               post_read_idx += count;
+                               post_read_size -= count;
                        } else {
-                               post_readed_size = post_readed_idx = bodyLen = 0; /* broken pipe to CGI */
+                               post_read_size = bodyLen = 0; /* broken pipe to CGI */
                        }
-               } else if (bodyLen > 0 && post_readed_size == 0 && FD_ISSET(config->accepted_socket, &readSet)) {
+               } else if (bodyLen > 0 && post_read_size == 0
+                && FD_ISSET(config->accepted_socket, &readSet)
+               ) {
+                       /* We expect data, prev data portion is eaten by CGI
+                        * and there *is* data to read from the peer
+                        * (POSTDATA?) */
                        count = bodyLen > (int)sizeof(wbuf) ? (int)sizeof(wbuf) : bodyLen;
                        count = safe_read(config->accepted_socket, wbuf, count);
                        if (count > 0) {
-                               post_readed_size += count;
+                               post_read_size = count;
+                               post_read_idx = 0;
                                bodyLen -= count;
                        } else {
                                bodyLen = 0;    /* closed */
                        }
                }
-               if (FD_ISSET(inFd, &readSet)) {
-                       int s = config->accepted_socket;
-                       char *rbuf = config->buf;
 
-#ifndef PIPE_BUF
-# define PIPESIZE 4096          /* amount of buffering in a pipe */
-#else
-# define PIPESIZE PIPE_BUF
-#endif
+#define PIPESIZE PIPE_BUF
 #if PIPESIZE >= MAX_MEMORY_BUFF
 # error "PIPESIZE >= MAX_MEMORY_BUFF"
 #endif
+               if (FD_ISSET(inFd, &readSet)) {
+                       /* There is something to read from CGI */
+                       int s = config->accepted_socket;
+                       char *rbuf = config->buf;
 
-                       /* There is something to read */
-                       count = safe_read(inFd, rbuf, PIPESIZE);
-                       if (count == 0)
-                               break;  /* closed */
-                       if (count > 0) {
-                               if (firstLine) {
-                                       rbuf[count] = 0;
-                                       /* check to see if the user script added headers */
-                                       if (strncmp(rbuf, "HTTP/1.0 200 OK\r\n", 4) != 0) {
-                                               full_write(s, "HTTP/1.0 200 OK\r\n", 17);
+                       /* Are we still buffering CGI output? */
+                       if (buf_count >= 0) {
+                               static const char HTTP_200[] = "HTTP/1.0 200 OK\r\n";
+                               /* Must use safe_read, not full_read, because
+                                * CGI may output a few first bytes and then wait
+                                * for POSTDATA without closing stdout.
+                                * With full_read we may wait here forever. */
+                               count = safe_read(inFd, rbuf + buf_count, PIPESIZE - 4);
+                               if (count <= 0) {
+                                       /* eof (or error) and there was no "HTTP",
+                                        * so add one and write out the received data */
+                                       if (buf_count) {
+                                               full_write(s, HTTP_200, sizeof(HTTP_200)-1);
+                                               full_write(s, rbuf, buf_count);
+                                       }
+                                       break;  /* closed */
+                               }
+                               buf_count += count;
+                               count = 0;
+                               if (buf_count >= 4) {
+                                       /* check to see if CGI added "HTTP" */
+                                       if (memcmp(rbuf, HTTP_200, 4) != 0) {
+                                               /* there is no "HTTP", do it ourself */
+                                               if (full_write(s, HTTP_200, sizeof(HTTP_200)-1) != sizeof(HTTP_200)-1)
+                                                       break;
                                        }
-                                       /* Sometimes CGI is writing to pipe in small chunks
-                                        * and we don't see Content-type (because the read
-                                        * is too short) and we emit bogus "text/plain"!
-                                        * Is it a bug or CGI *has to* write it in one piece? */
-                                       if (strstr(rbuf, "ontent-") == 0) {
+                                       /* example of valid CGI without "Content-type:"
+                                        * echo -en "HTTP/1.0 302 Found\r\n"
+                                        * echo -en "Location: http://www.busybox.net\r\n"
+                                        * echo -en "\r\n"
+                                       if (!strstr(rbuf, "ontent-")) {
                                                full_write(s, "Content-type: text/plain\r\n\r\n", 28);
                                        }
-                                       firstLine = 0;
+                                        */
+                                       count = buf_count;
+                                       buf_count = -1; /* buffering off */
                                }
-                               if (full_write(s, rbuf, count) != count)
-                                       break;
-
-                               if (DEBUG)
-                                       fprintf(stderr, "cgi read %d bytes: '%.*s'\n", count, count, rbuf);
+                       } else {
+                               count = safe_read(inFd, rbuf, PIPESIZE);
+                               if (count <= 0)
+                                       break;  /* eof (or error) */
                        }
-               }
-       }
+                       if (full_write(s, rbuf, count) != count)
+                               break;
+                       if (DEBUG)
+                               fprintf(stderr, "cgi read %d bytes: '%.*s'\n", count, count, rbuf);
+               } /* if (FD_ISSET(inFd)) */
+       } /* while (1) */
        return 0;
 }
 #endif          /* FEATURE_HTTPD_CGI */
@@ -1265,7 +1333,9 @@ static int sendFile(const char *url)
                sendHeaders(HTTP_OK);
                /* TODO: sendfile() */
                while ((count = full_read(f, buf, MAX_MEMORY_BUFF)) > 0) {
-                       if (full_write(config->accepted_socket, buf, count) != count)
+                       int fd = config->accepted_socket;
+                       if (fd == 0) fd++; /* write to fd# 1 in inetd mode */
+                       if (full_write(fd, buf, count) != count)
                                break;
                }
                close(f);
@@ -1284,18 +1354,21 @@ static int checkPermIP(void)
 
        /* This could stand some work */
        for (cur = config->ip_a_d; cur; cur = cur->next) {
-               if (DEBUG)
-                       fprintf(stderr, "checkPermIP: '%s' ? ", config->rmt_ip_str);
-               if (DEBUG)
-                       fprintf(stderr, "'%u.%u.%u.%u/%u.%u.%u.%u'\n",
-                               (unsigned char)(cur->ip >> 24),
-                               (unsigned char)(cur->ip >> 16),
-                               (unsigned char)(cur->ip >> 8),
-                                               cur->ip & 0xff,
-                               (unsigned char)(cur->mask >> 24),
-                               (unsigned char)(cur->mask >> 16),
-                               (unsigned char)(cur->mask >> 8),
-                                               cur->mask & 0xff);
+#if ENABLE_FEATURE_HTTPD_CGI && DEBUG
+               fprintf(stderr, "checkPermIP: '%s' ? ", config->rmt_ip_str);
+#endif
+#if DEBUG
+               fprintf(stderr, "'%u.%u.%u.%u/%u.%u.%u.%u'\n",
+                       (unsigned char)(cur->ip >> 24),
+                       (unsigned char)(cur->ip >> 16),
+                       (unsigned char)(cur->ip >> 8),
+                       (unsigned char)(cur->ip),
+                       (unsigned char)(cur->mask >> 24),
+                       (unsigned char)(cur->mask >> 16),
+                       (unsigned char)(cur->mask >> 8),
+                       (unsigned char)(cur->mask)
+               );
+#endif
                if ((config->rmt_ip & cur->mask) == cur->ip)
                        return cur->allow_deny == 'A';   /* Allow/Deny */
        }
@@ -1493,8 +1566,8 @@ static void handleIncoming(void)
                test = decodeString(url, 0);
                if (test == NULL)
                        goto BAD_REQUEST;
-               /* FIXME: bug? should be "url+1"? */
-               if (test == (buf+1)) {
+               if (test == url+1) {
+                       /* '/' or NUL is encoded */
                        sendHeaders(HTTP_NOT_FOUND);
                        break;
                }
@@ -1568,7 +1641,8 @@ static void handleIncoming(void)
                                        /* extra read only for POST */
                                        if (prequest != request_GET) {
                                                test = buf + sizeof("Content-length:")-1;
-                                               if (!test[0]) goto bail_out;
+                                               if (!test[0])
+                                                       goto bail_out;
                                                errno = 0;
                                                /* not using strtoul: it ignores leading munis! */
                                                length = strtol(test, &test, 10);
@@ -1641,6 +1715,20 @@ static void handleIncoming(void)
                        sendCgi(url, prequest, length, cookie, content_type);
                        break;
                }
+#if ENABLE_FEATURE_HTTPD_CONFIG_WITH_SCRIPT_INTERPR
+               {
+                       char *suffix = strrchr(test, '.');
+                       if (suffix) {
+                               Htaccess *cur;
+                               for (cur = config->script_i; cur; cur = cur->next) {
+                                       if (strcmp(cur->before_colon + 1, suffix) == 0) {
+                                               sendCgi(url, prequest, length, cookie, content_type);
+                                               goto bail_out;
+                                       }
+                               }
+                       }
+               }
+#endif
                if (prequest != request_GET) {
                        sendHeaders(HTTP_NOT_IMPLEMENTED);
                        break;
@@ -1669,7 +1757,9 @@ static void handleIncoming(void)
                config->ContentLength = -1;
        } while (0);
 
+#if ENABLE_FEATURE_HTTPD_CGI
  bail_out:
+#endif
 
        if (DEBUG)
                fprintf(stderr, "closing socket\n\n");
@@ -1724,9 +1814,13 @@ static int miniHttpd(int server)
 
        /* copy the ports we are watching to the readfd set */
        while (1) {
-               int on, s;
-               socklen_t fromAddrLen;
-               struct sockaddr_in fromAddr;
+               int s;
+               union {
+                       struct sockaddr sa;
+                       struct sockaddr_in sin;
+                       USE_FEATURE_IPV6(struct sockaddr_in6 sin6;)
+               } fromAddr;
+               socklen_t fromAddrLen = sizeof(fromAddr);
 
                /* Now wait INDEFINITELY on the set of sockets! */
                readfd = portfd;
@@ -1734,28 +1828,32 @@ static int miniHttpd(int server)
                        continue;
                if (!FD_ISSET(server, &readfd))
                        continue;
-               fromAddrLen = sizeof(fromAddr);
-               s = accept(server, (struct sockaddr *)&fromAddr, &fromAddrLen);
+               s = accept(server, &fromAddr.sa, &fromAddrLen);
                if (s < 0)
                        continue;
                config->accepted_socket = s;
-               config->rmt_ip = ntohl(fromAddr.sin_addr.s_addr);
+               config->rmt_ip = 0;
+               config->port = 0;
 #if ENABLE_FEATURE_HTTPD_CGI || DEBUG
-               sprintf(config->rmt_ip_str, "%u.%u.%u.%u",
-                               (unsigned char)(config->rmt_ip >> 24),
-                               (unsigned char)(config->rmt_ip >> 16),
-                               (unsigned char)(config->rmt_ip >> 8),
-                               config->rmt_ip & 0xff);
-               config->port = ntohs(fromAddr.sin_port);
+               free(config->rmt_ip_str);
+               config->rmt_ip_str = xmalloc_sockaddr2dotted(&fromAddr.sa, fromAddrLen);
 #if DEBUG
-               bb_error_msg("connection from IP=%s, port %u",
-                               config->rmt_ip_str, config->port);
+               bb_error_msg("connection from '%s'", config->rmt_ip_str);
 #endif
 #endif /* FEATURE_HTTPD_CGI */
+               if (fromAddr.sa.sa_family == AF_INET) {
+                       config->rmt_ip = ntohl(fromAddr.sin.sin_addr.s_addr);
+                       config->port = ntohs(fromAddr.sin.sin_port);
+               }
+#if ENABLE_FEATURE_IPV6
+               if (fromAddr.sa.sa_family == AF_INET6) {
+                       //config->rmt_ip = ntohl(fromAddr.sin.sin_addr.s_addr);
+                       config->port = ntohs(fromAddr.sin6.sin6_port);
+               }
+#endif
 
                /* set the KEEPALIVE option to cull dead connections */
-               on = 1;
-               setsockopt(s, SOL_SOCKET, SO_KEEPALIVE, (void *)&on, sizeof(on));
+               setsockopt(s, SOL_SOCKET, SO_KEEPALIVE, &const_int_1, sizeof(const_int_1));
 
                if (DEBUG || fork() == 0) {
                        /* child */
@@ -1775,19 +1873,30 @@ static int miniHttpd(int server)
 /* from inetd */
 static int miniHttpd_inetd(void)
 {
-       struct sockaddr_in fromAddrLen;
-       socklen_t sinlen = sizeof(struct sockaddr_in);
-
-       getpeername(0, (struct sockaddr *)&fromAddrLen, &sinlen);
-       config->rmt_ip = ntohl(fromAddrLen.sin_addr.s_addr);
-#if ENABLE_FEATURE_HTTPD_CGI
-       sprintf(config->rmt_ip_str, "%u.%u.%u.%u",
-                               (unsigned char)(config->rmt_ip >> 24),
-                               (unsigned char)(config->rmt_ip >> 16),
-                               (unsigned char)(config->rmt_ip >> 8),
-                                               config->rmt_ip & 0xff);
+       union {
+               struct sockaddr sa;
+               struct sockaddr_in sin;
+               USE_FEATURE_IPV6(struct sockaddr_in6 sin6;)
+       } fromAddr;
+       socklen_t fromAddrLen = sizeof(fromAddr);
+
+       getpeername(0, &fromAddr.sa, &fromAddrLen);
+       config->rmt_ip = 0;
+       config->port = 0;
+#if ENABLE_FEATURE_HTTPD_CGI || DEBUG
+       free(config->rmt_ip_str);
+       config->rmt_ip_str = xmalloc_sockaddr2dotted(&fromAddr.sa, fromAddrLen);
+#endif
+       if (fromAddr.sa.sa_family == AF_INET) {
+               config->rmt_ip = ntohl(fromAddr.sin.sin_addr.s_addr);
+               config->port = ntohs(fromAddr.sin.sin_port);
+       }
+#if ENABLE_FEATURE_IPV6
+       if (fromAddr.sa.sa_family == AF_INET6) {
+               //config->rmt_ip = ntohl(fromAddr.sin.sin_addr.s_addr);
+               config->port = ntohs(fromAddr.sin6.sin6_port);
+       }
 #endif
-       config->port = ntohs(fromAddrLen.sin_port);
        handleIncoming();
        return 0;
 }
@@ -1837,6 +1946,7 @@ static const char httpd_opts[] = "c:d:h:"
        "p:if";
 
 
+int httpd_main(int argc, char *argv[]);
 int httpd_main(int argc, char *argv[])
 {
        unsigned opt;
@@ -1889,32 +1999,22 @@ int httpd_main(int argc, char *argv[])
 
 #if ENABLE_FEATURE_HTTPD_SETUID
        if (opt & OPT_SETUID) {
-               char *e;
-               // FIXME: what the default group should be?
-               ugid.gid = -1;
-               ugid.uid = strtoul(s_ugid, &e, 0);
-               if (*e == ':') {
-                       e++;
-                       ugid.gid = strtoul(e, &e, 0);
-               }
-               if (*e != '\0') {
-                       /* not integer */
-                       if (!uidgid_get(&ugid, s_ugid))
-                               bb_error_msg_and_die("unrecognized user[:group] "
+               if (!get_uidgid(&ugid, s_ugid, 1))
+                       bb_error_msg_and_die("unrecognized user[:group] "
                                                "name '%s'", s_ugid);
-               }
        }
 #endif
 
        xchdir(home_httpd);
        if (!(opt & OPT_INETD)) {
+               signal(SIGCHLD, SIG_IGN);
                config->server_socket = openServer();
 #if ENABLE_FEATURE_HTTPD_SETUID
                /* drop privileges */
                if (opt & OPT_SETUID) {
                        if (ugid.gid != (gid_t)-1) {
                                if (setgroups(1, &ugid.gid) == -1)
-                                       bb_perror_msg_and_die("setgroups");
+                                       bb_perror_msg_and_die("setgroups");
                                xsetgid(ugid.gid);
                        }
                        xsetuid(ugid.uid);
@@ -1925,9 +2025,7 @@ int httpd_main(int argc, char *argv[])
 #if ENABLE_FEATURE_HTTPD_CGI
        {
                char *p = getenv("PATH");
-               if (p) {
-                       p = xstrdup(p);
-               }
+               p = xstrdup(p); /* if gets NULL, returns NULL */
                clearenv();
                if (p)
                        setenv1("PATH", p);